[PATCH 05/12] drm/dp: fix link probing for devices supporting DP 1.4+

2018-07-04 Thread Damian Kos
From: Quentin Schulz DP 1.4 introduced a DP_EXTENDED_RCVR_CAPA_FIELD_PRESENT bit in DP_TRAINING_AUX_RD_INTERVAL register. If set, DPCD registers from DP_DPCD_REV to DP_ADAPTER_CAP should be retrieved starting from DP_DPCD_REV_EXTENDED. All registers are copied except DP_DPCD_REV, DP_MAX_LINK_RATE

[PATCH 06/12] drm/dp: fix drm_dp_link_power_* for DP 1.2+

2018-07-04 Thread Damian Kos
From: Quentin Schulz In DP 1.1, DP_SET_POWER had only two bits for the power state (D0 or D3 and two other reserved values), thus DP_SET_POWER_MASK being 0x3. However, since DP 1.2, DP_SET_POWER has 3 bits (same values for D0 and D3, a mixed D3 which leaves only AUX powered and five other reserv

[PATCH 12/12] drm/rockchip: add support for CDNS MHDP IP controller.

2018-07-04 Thread Damian Kos
Signed-off-by: Damian Kos --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 953 +++- drivers/gpu/drm/rockchip/cdn-dp-core.h | 25 + drivers/gpu/drm/rockchip/cdn-dp-reg.c |2 +- drivers/gpu/drm/rockchip/cdn-dp-reg.h |4 + 4 files changed, 960 insertions(+), 24

[PATCH 11/12] drm/rockchip: added implementation for a few FW commands.

2018-07-04 Thread Damian Kos
Added support for a register read, register write and register field write commands. Added support for adjust link training command. Updated cdn_dp_get_event function, so it reads all SW event registers. Added definitions mostly for Framer and Streamer. Signed-off-by: Damian Kos --- drivers/gpu/

Re: [PATCHv2] lib/ratelimit: Lockless ratelimiting

2018-07-04 Thread Dmitry Safonov
On Tue, 2018-06-26 at 21:41 +0300, Andy Shevchenko wrote: > > > > @@ -42,9 +41,10 @@ static inline void > > > > ratelimit_state_init(struct > > > > ratelimit_state *rs, > > > > { > > > > memset(rs, 0, sizeof(*rs)); > > > > > > > > - raw_spin_lock_init(&rs->lock); > > > > rs-

Re: [PATCH] gpu: drm: v3d: use new return type vm_fault_t

2018-07-04 Thread Matthew Wilcox
On Tue, Jul 03, 2018 at 09:40:43PM +0530, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. For > now, this is just documenting that the function returns > a VM_FAULT value rather than an errno. Once all instances > are converted, vm_fault_t will become a distinct type. >

[PATCH] drm/amd/display/dc/dce: Fix multiple potential integer overflows

2018-07-04 Thread Gustavo A. R. Silva
Add suffix ULL to constant 5 and cast variables target_pix_clk_khz and feedback_divider to uint64_t in order to avoid multiple potential integer overflows and give the compiler complete information about the proper arithmetic to use. Notice that such constant and variables are used in contexts tha

Re: [PATCH] gpu: drm: v3d: use new return type vm_fault_t

2018-07-04 Thread Souptick Joarder
On 03-Jul-2018 11:12 PM, "Matthew Wilcox" wrote: > > On Tue, Jul 03, 2018 at 09:40:43PM +0530, Souptick Joarder wrote: > > Use new return type vm_fault_t for fault handler. For > > now, this is just documenting that the function returns > > a VM_FAULT value rather than an errno. Once all instances

[PATCH 01/12] HACK: increase timeout for drm_atomic_helper_wait_for_vblanks

2018-07-04 Thread Damian Kos
From: Quentin Schulz Due to the DP IP being simulated in a different and way slower way than the rest of the hardware, increase the timeout in drm_atomic_helper_wait_for_vblanks so that we don't miss the vblank event. Signed-off-by: Quentin Schulz Signed-off-by: Damian Kos --- drivers/gpu/drm

Re: [PATCH v2 1/2] efi/bgrt: Drop __initdata from bgrt_image_size

2018-07-04 Thread Ard Biesheuvel
On 3 July 2018 at 17:24, Bartlomiej Zolnierkiewicz wrote: > On Monday, July 02, 2018 02:02:47 PM Ard Biesheuvel wrote: >> On 2 July 2018 at 13:57, Bartlomiej Zolnierkiewicz >> wrote: >> > On Monday, July 02, 2018 01:46:09 PM Ard Biesheuvel wrote: >> >> On 2 July 2018 at 13:26, Hans de Goede wrot

[PATCH 00/12] drm: add support for Cadence MHDP DPI/DP bridge.

2018-07-04 Thread Damian Kos
Damian Kos (3): dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings drm/rockchip: added implementation for a few FW commands. drm/rockchip: add support for CDNS MHDP IP controller. Quentin Schulz (9): HACK: increase timeout for drm_atomic_helper_wait_for_vblanks drm/dp: make d

[PATCHv3] lib/ratelimit: Lockless ratelimiting

2018-07-04 Thread Dmitry Safonov
Currently ratelimit_state is protected with spin_lock. If the .lock is taken at the moment of ___ratelimit() call, the message is suppressed to make ratelimiting robust. That results in the following issue issue: CPU0 CPU1 -- ---

RE: [PATCH 12/12] drm/rockchip: add support for CDNS MHDP IP controller.

2018-07-04 Thread Damian Kos
Hi Heiko, Thank you for your feedback! Initially, MHDP driver was developed as a DRM bridge driver and was planned to be placed in drivers/gpu/drm/bridge/cadence/mhdp.c. However, there was already a driver for Cadence's DP controller developed by RockChip, but that driver uses different DRM f

[PATCH] drm/pl111: Use 64-bit arithmetic instead of 32-bit

2018-07-04 Thread Gustavo A. R. Silva
Add suffix UL to constant 1000 in order to give the compiler complete information about the proper arithmetic to use. Notice that such constant is used in a context that expects an expression of type u64 (64 bits, unsigned) and the following expression is currently being evaluated using 32-bit ari

[PATCH v2] gpu: drm: virtio: code cleanup

2018-07-04 Thread Souptick Joarder
The fault handler code is commented since v4.2. If there is no plan to enable the fault handler code in future, we can remove this dead code. Signed-off-by: Souptick Joarder --- v2: corrected subject line drivers/gpu/drm/virtio/virtgpu_ttm.c | 36 +--- 1 file cha

Re: [PATCH] drm/etnaviv: bring back progress check in job timeout handler

2018-07-04 Thread Russell King - ARM Linux
On Wed, Jun 27, 2018 at 04:34:27PM +0200, Lucas Stach wrote: > When the hangcheck handler was replaced by the DRM scheduler timeout > handling we dropped the forward progress check, as this might allow > clients to hog the GPU for a long time with a big job. > > It turns out that even reasonably w

[PATCH] gpu: drm: v3d: use new return type vm_fault_t

2018-07-04 Thread Souptick Joarder
Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. see commit 1c8f422059ae ("mm: change return type to vm_fault_t") for refere

[PATCH 07/12] drm/dp: fix drm_dp_link_train_clock_recovery_delay for DP 1.4

2018-07-04 Thread Damian Kos
From: Quentin Schulz In DP 1.4, interval between link status and adjust request read for the clock recovery phase is fixed to 100us whatever the value of the register is. Signed-off-by: Quentin Schulz Signed-off-by: Damian Kos --- drivers/gpu/drm/drm_dp_helper.c |5 + 1 files changed,

[PATCH 04/12] drm/dp: fix training interval formula for DP 1.3+

2018-07-04 Thread Damian Kos
From: Quentin Schulz In DP standard v1.2, DP_TRAINING_AUX_RD_INTERVAL DPCD "register" only has 0x0 to 0x4 values that are valid, the rest is reserved. In DP standard v1.3+, DP_TRAINING_AUX_RD_INTERVAL DPCD "register" has the same 0x0 to 0x4 valid values but there is an additional bit (bit 7) tha

[PATCH 09/12] drm/dp: add pixel encoding and colorimetry format indicator field in MISC1

2018-07-04 Thread Damian Kos
From: Quentin Schulz If DP_TEST_COLOR_FORMAT_RAW_Y_ONLY is set, if MISC0 color format is DP_COLOR_FORMAT_RGB and all other bits are 0, then color format is actually Y-Only. If DP_TEST_COLOR_FORMAT_RAW_Y_ONLY is set, if MISC0 color format is DP_COLOR_FORMAT_YCbCr422, DP_TEST_DYNAMIC_RANGE_CEA is

[PATCH 08/12] drm/dp: add max number of lanes supported

2018-07-04 Thread Damian Kos
From: Quentin Schulz Currently, a maximum of 4 lanes is supported in DP. It can be useful to add this maximum so that we can e.g. create arrays in drivers that can store data for several lanes (e.g. DP_TRAINING_LANEx_SET). Signed-off-by: Quentin Schulz Signed-off-by: Damian Kos --- include/d

[PATCH 10/12] dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings

2018-07-04 Thread Damian Kos
Document the bindings used for the Cadence MHDP DPI/DP bridge. Signed-off-by: Damian Kos --- .../bindings/display/bridge/cdns,mhdp.txt | 39 1 files changed, 39 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/cdn

[PATCH 02/12] drm/dp: make dp_link_status and dp_get_lane_status usable from outside of the core

2018-07-04 Thread Damian Kos
From: Quentin Schulz dp_link_status and dp_get_lane_status are pretty generic and can be used for other means, so let's make it "public". This adds drm_dp_link_status and drm_dp_get_lane_status to the header file and add the appropriate EXPORT_SYMBOL for it so that it can be used by other driver

[PATCH 03/12] drm/dp: add helpers for drm_dp_set_adjust_request_pre_emphasis and drm_dp_set_adjust_request_voltage

2018-07-04 Thread Damian Kos
From: Quentin Schulz We already have functions to get the adjust request voltage and pre-emphasis for a lane so it makes also sense to be able to set them so that we can then easily update them via a DPCD write. Add helpers for drm_dp_set_adjust_request_pre_emphasis and drm_dp_set_adjust_request

DRM COLOR_RANGE property

2018-07-04 Thread Russell King - ARM Linux
Can someone provide a deeper explanation about exactly what this property represents please? Does this represent the range of YCbCr values _into_ a YCbCr-to-RGB conversion (in other words, the range of values in the framebuffer), or the expected output range from the conversion? This matters, bec

Re: [PATCH 2/5] drm/amdgpu: update amd_pcie.h to include gen4 speeds

2018-07-04 Thread Alex Deucher
On Mon, Jun 25, 2018 at 5:06 PM, Alex Deucher wrote: > Internal header used by the driver to specify pcie gen > speeds of the asic and chipset. > > Signed-off-by: Alex Deucher Anyone care to review patches 2,3,4? > --- > drivers/gpu/drm/amd/include/amd_pcie.h | 2 ++ > 1 file changed, 2 insert

Re: [PATCH v6] Add udmabuf misc device

2018-07-04 Thread Tomeu Vizoso
On 07/04/2018 07:53 AM, Gerd Hoffmann wrote: On Tue, Jul 03, 2018 at 10:37:57AM +0200, Daniel Vetter wrote: On Tue, Jul 03, 2018 at 09:53:58AM +0200, Gerd Hoffmann wrote: A driver to let userspace turn memfd regions into dma-bufs. Use case: Allows qemu create dmabufs for the vga framebuffer o

Re: [PATCH] drm/amd/display/dc/dce: Fix multiple potential integer overflows

2018-07-04 Thread Michel Dänzer
On 2018-07-04 03:13 AM, Gustavo A. R. Silva wrote: > Add suffix ULL to constant 5 and cast variables target_pix_clk_khz and > feedback_divider to uint64_t in order to avoid multiple potential integer > overflows and give the compiler complete information about the proper > arithmetic to use. > > N

Re: [PATCH v7 5/6] mfd: cros_ec_dev: Add CEC sub-device registration

2018-07-04 Thread Lee Jones
On Fri, 01 Jun 2018, Neil Armstrong wrote: > The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device > when the CEC feature bit is present. > > Signed-off-by: Neil Armstrong > Reviewed-by: Enric Balletbo i Serra > Acked-by: Hans Verkuil > --- > drivers/mfd/cros_ec_dev.c | 16

[Bug 106928] When starting a match Rocket League crashes on "Go"

2018-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106928 --- Comment #18 from Miroslav Šustek --- (In reply to Roland Scheidegger from comment #12) > (In reply to ubizjak from comment #11) > > The (effectively the same patch as yours) proposed patch would be: > > > > diff --git a/src/gallium/drivers/

Re: [PATCH v6] Add udmabuf misc device

2018-07-04 Thread Gerd Hoffmann
On Wed, Jul 04, 2018 at 09:26:39AM +0200, Tomeu Vizoso wrote: > On 07/04/2018 07:53 AM, Gerd Hoffmann wrote: > > On Tue, Jul 03, 2018 at 10:37:57AM +0200, Daniel Vetter wrote: > > > On Tue, Jul 03, 2018 at 09:53:58AM +0200, Gerd Hoffmann wrote: > > > > A driver to let userspace turn memfd regions i

[Bug 200387] amdgpu uses unusually high memory

2018-07-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200387 --- Comment #26 from Michel Dänzer (mic...@daenzer.net) --- (In reply to phoenix from comment #25) > Ok, I've tested the issue using Kernel 4.15.0-24-generic (Shipped with > Ubuntu Mate) using the amdgpu driver and a 4.9.111 Kernel using the > amd

Re: [PATCH 00/21] USB DisplayLink patches

2018-07-04 Thread Daniel Vetter
On Mon, Jun 04, 2018 at 10:14:02AM -0400, Mikulas Patocka wrote: > > > On Mon, 4 Jun 2018, Dave Airlie wrote: > > > On 4 June 2018 at 00:40, Mikulas Patocka wrote: > > > Hi > > > > > > Here I'm sending bug fixes and performance improvements for the USB > > > DisplayLink framebuffer and modesett

Re: [PATCH v6] Add udmabuf misc device

2018-07-04 Thread Daniel Vetter
On Wed, Jul 04, 2018 at 07:53:38AM +0200, Gerd Hoffmann wrote: > On Tue, Jul 03, 2018 at 10:37:57AM +0200, Daniel Vetter wrote: > > On Tue, Jul 03, 2018 at 09:53:58AM +0200, Gerd Hoffmann wrote: > > > A driver to let userspace turn memfd regions into dma-bufs. > > > > > > Use case: Allows qemu cr

Re: [PATCH 03/12] drm/dp: add helpers for drm_dp_set_adjust_request_pre_emphasis and drm_dp_set_adjust_request_voltage

2018-07-04 Thread Daniel Vetter
On Tue, Jul 03, 2018 at 11:02:14AM +0100, Damian Kos wrote: > From: Quentin Schulz > > We already have functions to get the adjust request voltage and > pre-emphasis for a lane so it makes also sense to be able to set them so > that we can then easily update them via a DPCD write. > > Add helper

Re: [Intel-gfx] [PATCH v5 0/8] drm: Add generic fbdev emulation

2018-07-04 Thread Daniel Vetter
On Tue, Jul 03, 2018 at 06:03:46PM +0200, Noralf Trønnes wrote: > This patchset adds generic fbdev emulation for drivers that supports GEM > based dumb buffers which support .gem_prime_vmap and gem_prime_mmap. An > API is begun to support in-kernel clients in general. > > I've squashed the client

Re: DRM COLOR_RANGE property

2018-07-04 Thread Daniel Vetter
On Tue, Jul 03, 2018 at 05:18:57PM +0100, Russell King - ARM Linux wrote: > Can someone provide a deeper explanation about exactly what this > property represents please? > > Does this represent the range of YCbCr values _into_ a YCbCr-to-RGB > conversion (in other words, the range of values in th

Re: [PATCH 1/4] drm/v3d: Delay the scheduler timeout if we're still making progress.

2018-07-04 Thread Daniel Vetter
On Tue, Jul 03, 2018 at 10:05:12AM -0700, Eric Anholt wrote: > GTF-GLES2.gtf.GL.acos.acos_float_vert_xvary submits jobs that take 4 > seconds at maximum resolution, but we still want to reset quickly if a > job is really hung. Sample the CL's current address and the return > address (since we call

Re: [PATCH] drm/writeback: Fix the "overview" section of the doc

2018-07-04 Thread Daniel Vetter
On Tue, Jul 03, 2018 at 09:45:24PM +0200, Boris Brezillon wrote: > On Tue, 3 Jul 2018 19:44:00 +0200 > Boris Brezillon wrote: > > > On Tue, 3 Jul 2018 19:40:46 +0200 > > Boris Brezillon wrote: > > > > > Fix the bullet list declaration in the overview section. > > > > > > Signed-off-by: Boris

Re: [PATCH] dma-buf: Move BUG_ON from _add_shared_fence to _add_shared_inplace

2018-07-04 Thread Christian König
Am 26.06.2018 um 16:31 schrieb Michel Dänzer: From: Michel Dänzer Fixes the BUG_ON spuriously triggering under the following circumstances: * ttm_eu_reserve_buffers processes a list containing multiple BOs using the same reservation object, so it calls reservation_object_reserve_shared w

Re: [PATCH -next 05/15] drm/vmwgfx: Fix atomic mode set check

2018-07-04 Thread Daniel Vetter
On Tue, Jul 03, 2018 at 09:14:50PM +0200, Thomas Hellstrom wrote: > From: Sinclair Yeh > > vmw_kms_atomic_check_modeset() is currently checking config using the > legacy state, which is updated after a commit has happened. > > This means vmw_kms_atomic_check_modeset() will reject an invalid conf

Re: [PATCH 0/5] drm: use core pcie functionality for pcie gen/width

2018-07-04 Thread Christian König
Whole series is Acked-by: Christian König . BTW: With patch #2 you created quite some noise in the news: https://www.tomshardware.com/news/amd-vega-20-pcie-4.0,37389.html Cheers, Christian. Am 25.06.2018 um 23:06 schrieb Alex Deucher: This series exports some pcie helper functions for use by

[Bug 200387] amdgpu uses unusually high memory

2018-07-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200387 --- Comment #27 from Christian König (christian.koe...@amd.com) --- (In reply to Michel Dänzer from comment #26) > BTW, ideally you should only test with the kernel's own amdgpu driver, not > with amdgpu-pro, because the later uses its own copies

Re: [PATCH] fb: fix lost console when the user unplugs a USB adapter

2018-07-04 Thread Daniel Vetter
On Sun, Jun 03, 2018 at 11:46:29AM -0400, Mikulas Patocka wrote: > I have a USB display adapter using the udlfb driver and I use it on an ARM > board that doesn't have any graphics card. When I plug the adapter in, the > console is properly displayed, however when I unplug and re-plug the > adapter

Re: [PATCH] drm/amdgpu/acp: Fix slab-out-of-bounds in mfd_add_device in acp_hw_init

2018-07-04 Thread Mukunda,Vijendar
On Tuesday 03 July 2018 09:50 PM, Alex Deucher wrote: On Mon, Jul 2, 2018 at 5:48 PM, Daniel Kurtz wrote: Hi Alex, On Sun, Apr 15, 2018 at 9:48 PM Agrawal, Akshu wrote: On 4/13/2018 9:45 PM, Daniel Kurtz wrote: Commit 51f7415039d4 ("drm/amd/amdgpu: creating two I2S instances for stoney

Re: [PATCH v6] Add udmabuf misc device

2018-07-04 Thread Gerd Hoffmann
Hi, > > Hmm, does MAINTAINERS need an update then? Maintainer and mailing lists > > listed in the "DMA BUFFER SHARING FRAMEWORK" entry are on Cc. > > Yeah, maintainers entry with you as maintainer plus dri-devel as mailing > list plus drm-misc as repo would be good. Just grep for drm-misc.git

Re: [PATCH] dma-buf: Move BUG_ON from _add_shared_fence to _add_shared_inplace

2018-07-04 Thread Michel Dänzer
On 2018-07-04 10:31 AM, Christian König wrote: > Am 26.06.2018 um 16:31 schrieb Michel Dänzer: >> From: Michel Dänzer >> >> Fixes the BUG_ON spuriously triggering under the following >> circumstances: >> >> * ttm_eu_reserve_buffers processes a list containing multiple BOs using >>    the same rese

Re: [PATCH] backlight: remove obsolete comment for ->state

2018-07-04 Thread Daniel Vetter
On Thu, May 03, 2018 at 03:32:38PM +0100, Daniel Thompson wrote: > On Thu, May 03, 2018 at 04:15:17PM +0200, Daniel Vetter wrote: > > Jani spotted this when reviewing my earlier patch to remove the driver > > internal usage of this field in > > > > commit 3cf91adaa594e8933af1727942ac560e5c7bc70e >

Re: [PATCH v6] Add udmabuf misc device

2018-07-04 Thread Daniel Vetter
On Wed, Jul 04, 2018 at 10:58:25AM +0200, Gerd Hoffmann wrote: > Hi, > > > > Hmm, does MAINTAINERS need an update then? Maintainer and mailing lists > > > listed in the "DMA BUFFER SHARING FRAMEWORK" entry are on Cc. > > > > Yeah, maintainers entry with you as maintainer plus dri-devel as mail

Re: DRM COLOR_RANGE property

2018-07-04 Thread Daniel Vetter
On Wed, Jul 04, 2018 at 10:05:41AM +0100, Russell King - ARM Linux wrote: > On Wed, Jul 04, 2018 at 10:26:04AM +0200, Daniel Vetter wrote: > > On Tue, Jul 03, 2018 at 05:18:57PM +0100, Russell King - ARM Linux wrote: > > > Can someone provide a deeper explanation about exactly what this > > > prope

[PATCH 1/5] drm/i915: Remove unecessary dma_fence_ops

2018-07-04 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. v2: Also remove the relase hook, dma_fence_free is the default. Signed-off-by: Daniel Vetter Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Chris Wilson Cc: Tvrtko Ursulin Cc: Colin Ia

[PATCH 0/5] RESEND: dma-buf cleanup

2018-07-04 Thread Daniel Vetter
Hi all, This is a resend of my dma-buf cleanup with the patches that didn't yet get and ack/r-b. Feedback very much welcome. Thanks, Daniel Daniel Vetter (5): drm/i915: Remove unecessary dma_fence_ops drm/msm: Remove unecessary dma_fence_ops drm/nouveau: Remove unecessary dma_fence_ops d

[PATCH 2/5] drm/msm: Remove unecessary dma_fence_ops

2018-07-04 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. v2: Also remove the relase hook, dma_fence_free is the default. Signed-off-by: Daniel Vetter Cc: Rob Clark Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org --- drivers/gpu/drm/

[PATCH 3/5] drm/nouveau: Remove unecessary dma_fence_ops

2018-07-04 Thread Daniel Vetter
dma_fence_default_wait is the default now. Signed-off-by: Daniel Vetter Cc: Ben Skeggs Cc: nouv...@lists.freedesktop.org --- drivers/gpu/drm/nouveau/nouveau_fence.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fenc

[PATCH 4/5] drm/vgem: Remove unecessary dma_fence_ops

2018-07-04 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. Also remove the ->signaled callback, vgem can't peek ahead with a fastpath, returning false is the default implementation. Signed-off-by: Daniel Vetter Cc: Kees Cook Cc: Cihangir Akturk Cc: Sean Pa

[PATCH 5/5] dma-fence: Polish kernel-doc for dma-fence.c

2018-07-04 Thread Daniel Vetter
- Intro section that links to how this is exposed to userspace. - Lots more hyperlinks. - Minor clarifications and style polish v2: Add misplaced hunk of kerneldoc from a different patch. Signed-off-by: Daniel Vetter Cc: Sumit Semwal Cc: Gustavo Padovan Cc: linux-me...@vger.kernel.org Cc: lina

Re: [PATCH] dma-buf: Move BUG_ON from _add_shared_fence to _add_shared_inplace

2018-07-04 Thread Christian König
Am 04.07.2018 um 11:09 schrieb Michel Dänzer: On 2018-07-04 10:31 AM, Christian König wrote: Am 26.06.2018 um 16:31 schrieb Michel Dänzer: From: Michel Dänzer Fixes the BUG_ON spuriously triggering under the following circumstances: * ttm_eu_reserve_buffers processes a list containing multip

Re: [PATCH] drm: Limite blob creation to drm master

2018-07-04 Thread Daniel Vetter
On Mon, Jul 02, 2018 at 01:24:40PM +0300, Ville Syrjälä wrote: > On Mon, Jul 02, 2018 at 10:12:21AM +0200, Daniel Vetter wrote: > > This interface allows pretty much unlimited kernel memory allocations, > > which isn't all that great. But we allow that anyway for any drm > > master client (through

Re: [PATCH] backlight: remove obsolete comment for ->state

2018-07-04 Thread Lee Jones
> Jani spotted this when reviewing my earlier patch to remove the driver > internal usage of this field in > > commit 3cf91adaa594e8933af1727942ac560e5c7bc70e > Author: Daniel Vetter > Date: Wed Apr 25 19:42:52 2018 +0200 > > backlight: Nuke BL_CORE_DRIVER1 FYI, sending patches like this

Re: [PATCH -next 05/15] drm/vmwgfx: Fix atomic mode set check

2018-07-04 Thread Thomas Hellstrom
Hi, On 07/04/2018 10:35 AM, Daniel Vetter wrote: On Tue, Jul 03, 2018 at 09:14:50PM +0200, Thomas Hellstrom wrote: From: Sinclair Yeh vmw_kms_atomic_check_modeset() is currently checking config using the legacy state, which is updated after a commit has happened. This means vmw_kms_atomic_ch

Re: [PATCH 5/5] dma-fence: Polish kernel-doc for dma-fence.c

2018-07-04 Thread Christian König
Am 04.07.2018 um 11:29 schrieb Daniel Vetter: - Intro section that links to how this is exposed to userspace. - Lots more hyperlinks. - Minor clarifications and style polish v2: Add misplaced hunk of kerneldoc from a different patch. Signed-off-by: Daniel Vetter Cc: Sumit Semwal Cc: Gustavo P

[PATCH] drm/panel: type promotion bug in s6e8aa0_read_mtp_id()

2018-07-04 Thread Dan Carpenter
The ARRAY_SIZE() macro is type size_t. If s6e8aa0_dcs_read() returns a negative error code, then "ret < ARRAY_SIZE(id)" is false because the negative error code is type promoted to a high positive value. Fixes: 02051ca06371 ("drm/panel: add S6E8AA0 driver") Signed-off-by: Dan Carpenter diff --g

Re: [PATCH] backlight: remove obsolete comment for ->state

2018-07-04 Thread Lee Jones
On Wed, 04 Jul 2018, Lee Jones wrote: > > Jani spotted this when reviewing my earlier patch to remove the driver > > internal usage of this field in > > > > commit 3cf91adaa594e8933af1727942ac560e5c7bc70e > > Author: Daniel Vetter > > Date: Wed Apr 25 19:42:52 2018 +0200 > > > > backlight

[PATCH] drm/virtio: fix bounds check in virtio_gpu_cmd_get_capset()

2018-07-04 Thread Dan Carpenter
This doesn't affect runtime because in the current code "idx" is always valid. First, we read from "vgdev->capsets[idx].max_size" before checking whether "idx" is within bounds. And secondly the bounds check is off by one so we could end up reading one element beyond the end of the vgdev->capsets

[PATCH] drm/amd/display: off by one in find_irq_source_info()

2018-07-04 Thread Dan Carpenter
The ->info[] array has DAL_IRQ_SOURCES_NUMBER elements so this condition should be >= instead of > or we could read one element beyond the end of the array. Fixes: 4562236b3bc0 ("drm/amd/dc: Add dc display driver (v2)") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/amd/display/dc/irq

[PATCH] drm/savage: off by one in savage_bci_cmdbuf()

2018-07-04 Thread Dan Carpenter
The > should be >= here so that we don't read beyond the end of the dma->buflist[] array. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/savage/savage_state.c b/drivers/gpu/drm/savage/savage_state.c index 2db89bed52e8..7559a820bd43 100644 --- a/drivers/gpu/drm/savage/savage_state.c +

[Bug 200387] amdgpu uses unusually high memory

2018-07-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200387 --- Comment #28 from phoenix (fe...@feldspaten.org) --- Hi Michel, Hi Christian, that makes sense, I test it on a clean environment. Sorry, that I should have done that in the first place :-/ -- You are receiving this mail because: You are watc

Re: [PATCH] backlight: remove obsolete comment for ->state

2018-07-04 Thread Daniel Vetter
On Wed, Jul 04, 2018 at 10:38:16AM +0100, Lee Jones wrote: > On Wed, 04 Jul 2018, Lee Jones wrote: > > > > Jani spotted this when reviewing my earlier patch to remove the driver > > > internal usage of this field in > > > > > > commit 3cf91adaa594e8933af1727942ac560e5c7bc70e > > > Author: Daniel

Re: [PATCH] backlight: remove obsolete comment for ->state

2018-07-04 Thread Lee Jones
On Wed, 04 Jul 2018, Daniel Vetter wrote: > On Wed, Jul 04, 2018 at 10:38:16AM +0100, Lee Jones wrote: > > On Wed, 04 Jul 2018, Lee Jones wrote: > > > > > > Jani spotted this when reviewing my earlier patch to remove the driver > > > > internal usage of this field in > > > > > > > > commit 3cf91a

Re: [PATCH v2 3/8] drm/bridge/synopsys: dsi: defer probing if panel not available in bridge-attach

2018-07-04 Thread Heiko Stuebner
Am Dienstag, 3. Juli 2018, 14:42:49 CEST schrieb Andrzej Hajda: > On 18.06.2018 12:28, Heiko Stuebner wrote: > > When the panel-driver is build as a module it currently fails hard as the > > panel cannot be probed directly: > > > > dw_mipi_dsi_bind() > > __dw_mipi_dsi_probe() > > creates dsi

Re: [PATCH v2 6/8] drm/dsi: add helper function to find the second host in a dual-dsi setup

2018-07-04 Thread Heiko Stuebner
Am Dienstag, 3. Juli 2018, 17:06:48 CEST schrieb Andrzej Hajda: > On 18.06.2018 12:28, Heiko Stuebner wrote: > > >From a specified output port of one dsi controller this function allows to > > iterate over the list of registered dsi controllers trying to find a second > > instance connected to the

Re: DRM COLOR_RANGE property

2018-07-04 Thread Daniel Vetter
On Wed, Jul 4, 2018 at 11:58 AM, Russell King - ARM Linux wrote: > On Wed, Jul 04, 2018 at 11:24:10AM +0200, Daniel Vetter wrote: >> On Wed, Jul 04, 2018 at 10:05:41AM +0100, Russell King - ARM Linux wrote: >> > On Wed, Jul 04, 2018 at 10:26:04AM +0200, Daniel Vetter wrote: >> > > On Tue, Jul 03,

Re: DRM COLOR_RANGE property

2018-07-04 Thread Ville Syrjälä
On Tue, Jul 03, 2018 at 05:18:57PM +0100, Russell King - ARM Linux wrote: > Can someone provide a deeper explanation about exactly what this > property represents please? > > Does this represent the range of YCbCr values _into_ a YCbCr-to-RGB > conversion (in other words, the range of values in th

Re: DRM COLOR_RANGE property

2018-07-04 Thread Jyri Sarha
On 04/07/18 12:58, Russell King - ARM Linux wrote: >> Hm maybe I misunderstood, but I thought the COLOR_RANGE is on the input >> side. > If that's the case, I should force it to only indicate support for > limited range, while programming the CSC to produce full range RGB > on its output (see below

Re: DRM COLOR_RANGE property

2018-07-04 Thread Jyri Sarha
On 03/07/18 19:18, Russell King - ARM Linux wrote: > Can someone provide a deeper explanation about exactly what this > property represents please? > > Does this represent the range of YCbCr values _into_ a YCbCr-to-RGB > conversion (in other words, the range of values in the framebuffer), > or th

Re: [PATCH] backlight: remove obsolete comment for ->state

2018-07-04 Thread Daniel Vetter
Hi Lee, On Wed, Jul 4, 2018 at 12:34 PM, Lee Jones wrote: > On Wed, 04 Jul 2018, Daniel Vetter wrote: >> On Wed, Jul 04, 2018 at 10:38:16AM +0100, Lee Jones wrote: >> > On Wed, 04 Jul 2018, Lee Jones wrote: >> > >> > > > Jani spotted this when reviewing my earlier patch to remove the driver >> >

Re: [PATCH 1/5] drm/i915: Remove unecessary dma_fence_ops

2018-07-04 Thread Emil Velikov
Hi Daniel, On 4 July 2018 at 10:29, Daniel Vetter wrote: > dma_fence_default_wait is the default now, same for the trivial > enable_signaling implementation. > > v2: Also remove the relase hook, dma_fence_free is the default. > > Signed-off-by: Daniel Vetter > Cc: Jani Nikula > Cc: Joonas Lahti

Re: [PATCH v4 1/2] devicetree/bindings: display: Add document for rockchip RGB output

2018-07-04 Thread Sandy Huang
Hi Rob Herring, Thanks for your review. 在 2018/7/4 2:25, Rob Herring 写道: On Tue, Jun 26, 2018 at 03:15:39PM +0800, Sandy Huang wrote: This path add support rv1108 and px30 rgb output interface driver. Bindings are for h/w, not drivers. I will update at next version as following: This patch

Re: [PATCH] backlight: remove obsolete comment for ->state

2018-07-04 Thread Lee Jones
On Wed, 04 Jul 2018, Daniel Vetter wrote: > Hi Lee, > > On Wed, Jul 4, 2018 at 12:34 PM, Lee Jones wrote: > > On Wed, 04 Jul 2018, Daniel Vetter wrote: > >> On Wed, Jul 04, 2018 at 10:38:16AM +0100, Lee Jones wrote: > >> > On Wed, 04 Jul 2018, Lee Jones wrote: > >> > > >> > > > Jani spotted this

Re: [PATCH v2 2/8] drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind

2018-07-04 Thread Heiko Stuebner
Am Dienstag, 3. Juli 2018, 14:16:28 CEST schrieb Andrzej Hajda: > On 18.06.2018 12:28, Heiko Stuebner wrote: > > __dw_mipi_dsi_probe() does all the grabbing of resources and does it using > > devm-helpers. So this is happening on each try of master bringup possibly > > slowing down things a lot. >

Re: [PATCH] drm/savage: off by one in savage_bci_cmdbuf()

2018-07-04 Thread Daniel Vetter
On Wed, Jul 04, 2018 at 12:48:10PM +0300, Dan Carpenter wrote: > The > should be >= here so that we don't read beyond the end of the > dma->buflist[] array. > > Signed-off-by: Dan Carpenter Uh, another root-hole driver ... Applied, thanks for the patch. -Daniel > > diff --git a/drivers/gpu/drm

[Bug 105819] Window system hang due to GPU Fault

2018-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105819 --- Comment #7 from AmirAli Akbari --- Same problem on RX 460 card when running imagemagick's "mogrify" command. I'm using Arch linux with latest stable version of kernel, mesa, and X. $ mogrify -resize 400x300 piv.jpg [ 3091.155960] amdgpu 000

Re: [PATCH 1/5] drm/i915: Remove unecessary dma_fence_ops

2018-07-04 Thread Daniel Vetter
On Wed, Jul 04, 2018 at 01:03:18PM +0100, Emil Velikov wrote: > Hi Daniel, > > On 4 July 2018 at 10:29, Daniel Vetter wrote: > > dma_fence_default_wait is the default now, same for the trivial > > enable_signaling implementation. > > > > v2: Also remove the relase hook, dma_fence_free is the defa

Re: [PATCH v7 5/6] mfd: cros_ec_dev: Add CEC sub-device registration

2018-07-04 Thread Neil Armstrong
Hi Lee, On 04/07/2018 09:47, Lee Jones wrote: > On Fri, 01 Jun 2018, Neil Armstrong wrote: > >> The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device >> when the CEC feature bit is present. >> >> Signed-off-by: Neil Armstrong >> Reviewed-by: Enric Balletbo i Serra >> Acked-by: Ha

Re: [PATCH v7 5/6] mfd: cros_ec_dev: Add CEC sub-device registration

2018-07-04 Thread Lee Jones
On Wed, 04 Jul 2018, Neil Armstrong wrote: > Hi Lee, > > On 04/07/2018 09:47, Lee Jones wrote: > > On Fri, 01 Jun 2018, Neil Armstrong wrote: > > > >> The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device > >> when the CEC feature bit is present. > >> > >> Signed-off-by: Neil Arms

Re: [PATCH] drm/bridge: adv7511: Reset registers on hotplug

2018-07-04 Thread Archit Taneja
On Wednesday 04 July 2018 12:28 AM, Rob Clark wrote: On Tue, Jul 3, 2018 at 12:56 PM, Sean Paul wrote: The bridge loses its hw state when the cable is unplugged. If we detect this case in the hpd handler, reset its state. Reported-by: Rob Clark Signed-off-by: Sean Paul Tested-by: Rob Cla

Re: [PATCH] drm/bridge: adv7511: Reset registers on hotplug

2018-07-04 Thread Rob Clark
On Wed, Jul 4, 2018 at 9:23 AM, Archit Taneja wrote: > > > On Wednesday 04 July 2018 12:28 AM, Rob Clark wrote: >> >> On Tue, Jul 3, 2018 at 12:56 PM, Sean Paul wrote: >>> >>> The bridge loses its hw state when the cable is unplugged. If we detect >>> this case in the hpd handler, reset its state

Re: [PATCH] drm/bridge: adv7511: Reset registers on hotplug

2018-07-04 Thread Daniel Vetter
On Wed, Jul 4, 2018 at 4:06 PM, Rob Clark wrote: > On Wed, Jul 4, 2018 at 9:23 AM, Archit Taneja wrote: >> >> >> On Wednesday 04 July 2018 12:28 AM, Rob Clark wrote: >>> >>> On Tue, Jul 3, 2018 at 12:56 PM, Sean Paul wrote: The bridge loses its hw state when the cable is unplugged. If

Re: [PATCH 3/3] drm/bridge/sii8620: Fix link mode selection

2018-07-04 Thread Andrzej Hajda
On 28.06.2018 18:44, Maciej Purski wrote: > Current link mode values do not allow to enable packed pixel modes. > > Select packed pixel clock mode, if needed, every time the link mode > register gets updated. > > Signed-off-by: Maciej Purski Queued all three patches to drm-misc-fixes. Regards An

Re: [PATCH] drm/amd/display: off by one in find_irq_source_info()

2018-07-04 Thread Harry Wentland
On 2018-07-04 05:46 AM, Dan Carpenter wrote: > The ->info[] array has DAL_IRQ_SOURCES_NUMBER elements so this condition > should be >= instead of > or we could read one element beyond the end of > the array. > > Fixes: 4562236b3bc0 ("drm/amd/dc: Add dc display driver (v2)") > Signed-off-by: Dan Ca

Re: [PATCH] fb: fix lost console when the user unplugs a USB adapter

2018-07-04 Thread Mikulas Patocka
On Wed, 4 Jul 2018, Daniel Vetter wrote: > On Sun, Jun 03, 2018 at 11:46:29AM -0400, Mikulas Patocka wrote: > > I have a USB display adapter using the udlfb driver and I use it on an ARM > > board that doesn't have any graphics card. When I plug the adapter in, the > > console is properly displa

[Bug 106168] kernel NULL pointer dereference

2018-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106168 gr...@sub.red changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH] drm/bridge: adv7511: Reset registers on hotplug

2018-07-04 Thread Rob Clark
On Wed, Jul 4, 2018 at 10:15 AM, Daniel Vetter wrote: > On Wed, Jul 4, 2018 at 4:06 PM, Rob Clark wrote: >> On Wed, Jul 4, 2018 at 9:23 AM, Archit Taneja wrote: >>> >>> >>> On Wednesday 04 July 2018 12:28 AM, Rob Clark wrote: On Tue, Jul 3, 2018 at 12:56 PM, Sean Paul wrote: > >>>

[Bug 106306] amdgpu CIK power management issues (overdrive and wattman)

2018-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106306 --- Comment #4 from gr...@sub.red --- > wattman functionality doesn't work at all; > pp_od_clk_voltage prints nothing and doesn't accept anything. Is wattman > even implemented for CI? @Alex Deucher: Currently on 4.17.3 w/ dpm and the situation

Re: [PATCH] fb: fix lost console when the user unplugs a USB adapter

2018-07-04 Thread Bartlomiej Zolnierkiewicz
On Tuesday, July 03, 2018 01:18:57 PM Mikulas Patocka wrote: > > On Tue, 3 Jul 2018, Bartlomiej Zolnierkiewicz wrote: > > > > > Hi, > > > > On Sunday, June 03, 2018 11:46:29 AM Mikulas Patocka wrote: > > > I have a USB display adapter using the udlfb driver and I use it on an ARM > > > board th

[PATCH v8 2/6] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-07-04 Thread Neil Armstrong
This patchs adds the cec_notifier feature to the intel_hdmi part of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate between each HDMI ports. The changes will allow the i915 HDMI code to notify EDID and HPD changes to an eventual CEC adapter. Signed-off-by: Neil Armstrong

[PATCH v8 1/6] media: cec-notifier: Get notifier by device and connector name

2018-07-04 Thread Neil Armstrong
In non device-tree world, we can need to get the notifier by the driver name directly and eventually defer probe if not yet created. This patch adds a variant of the get function by using the device name instead and will not create a notifier if not yet created. But the i915 driver exposes at lea

[PATCH v8 0/6] Add ChromeOS EC CEC Support

2018-07-04 Thread Neil Armstrong
Hi All, The new Google "Fizz" Intel-based ChromeOS device is gaining CEC support through it's Embedded Controller, to enable the Linux CEC Core to communicate with it and get the CEC Physical Address from the correct HDMI Connector, the following must be added/changed: - Add the CEC sub-device reg

[PATCH v8 4/6] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-07-04 Thread Neil Armstrong
The EC can expose a CEC bus, this patch adds the CEC related definitions needed by the cros-ec-cec driver. Signed-off-by: Neil Armstrong Tested-by: Enric Balletbo i Serra Reviewed-by: Hans Verkuil Acked-for-MFD-by: Lee Jones --- include/linux/mfd/cros_ec_commands.h | 81 ++

[PATCH v8 3/6] mfd: cros-ec: Increase maximum mkbp event size

2018-07-04 Thread Neil Armstrong
Having a 16 byte mkbp event size makes it possible to send CEC messages from the EC to the AP directly inside the mkbp event instead of first doing a notification and then a read. Signed-off-by: Stefan Adolfsson Signed-off-by: Neil Armstrong Tested-by: Enric Balletbo i Serra Acked-by: Hans Verk

  1   2   >