[PATCH v4 0/4] Add support rockchip RGB output interface

2017-11-01 Thread Sandy Huang
This patches add support rockchip RGB output, Some Rockchip CRTCs, like rv1108, can directly output parallel and serial RGB data to panel or to conversion chip. So we add this driver to probe encoder and connector to support this case. Sandy Huang (4): devicetree/bindings: display: Add doucument

[PATCH v4 1/4] devicetree/bindings: display: Add doucument for RGB panels

2017-11-01 Thread Sandy Huang
Describe the panel property rgb-mode for parallel and serial RGB output interface, include the connection relations for each mode. Signed-off-by: Sandy Huang --- Changes: .../bindings/display/panel/panel-rgb.txt | 116 + 1 file changed, 116 insertions(+) create mod

[PATCH v4 2/4] devicetree/bindings: display: Add document for rockchip RGB output

2017-11-01 Thread Sandy Huang
This path add support rv1108 rgb output interface driver. Signed-off-by: Sandy Huang --- Changes in v4: None Changes in v3: move rgb-mode to panel node which describe at: Documentation/devicetree/bindings/display/panel/panel-rgb.txt Changes in v2: 1. rename rockchip,rgb-mode to rgb-mode; 2.

[PATCH v4 4/4] drm/rockchip: vop: Add more RGB output interface type

2017-11-01 Thread Sandy Huang
This patch add serial RGB output interface for rockchip vop, the more info about serial RGB output interface described at the following file: Documentation/devicetree/bindings/display/panel/panel-rgb.txt Signed-off-by: Sandy Huang Reviewed-by: Sean Paul --- Changes in v4: None Changes in v3: No

[PATCH v4 3/4] drm/rockchip: Add support for Rockchip Soc RGB output interface

2017-11-01 Thread Sandy Huang
Some Rockchip CRTCs, like rv1108, can directly output parallel and serial RGB data to panel or conversion chip, so we add this driver to probe encoder and connector. Signed-off-by: Sandy Huang Reviewed-by: Sean Paul Reviewed-by: Mark Yao --- Changes in v4: 1. add ROCKCHIP_RGB depend on DRM_RO

[Bug 91666] build fail with cunit - OK on amd64 - KO for i386

2017-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91666 Fabio Pedretti changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED

Re: [PATCH] drm: gma500: Convert timers to use timer_setup()

2017-11-01 Thread Kees Cook
On Tue, Oct 31, 2017 at 3:18 AM, Daniel Vetter wrote: > On Mon, Oct 30, 2017 at 03:05:29PM -0700, Kees Cook wrote: >> On Mon, Oct 30, 2017 at 3:08 AM, Daniel Vetter wrote: >> > On Tue, Oct 24, 2017 at 08:16:09AM -0700, Kees Cook wrote: >> >> In preparation for unconditionally passing the struct t

Re: [PATCH] PM / QoS: Fix default runtime_pm device resume latency

2017-11-01 Thread Ulf Hansson
On 31 October 2017 at 14:55, Geert Uytterhoeven wrote: > Hi Rafael, Tero, > > CC pinchartl, dri-devel > > On Tue, Oct 31, 2017 at 2:10 PM, Geert Uytterhoeven > wrote: >> CC linux-renesas-soc >> >> On Tue, Oct 31, 2017 at 2:09 PM, Geert Uytterhoeven >> wrote: >>> On Tue, Oct 31, 2017 at 12:27 AM,

Re: [PATCH] PM / QoS: Fix default runtime_pm device resume latency

2017-11-01 Thread Rafael J. Wysocki
On Tue, Oct 31, 2017 at 3:04 PM, Ulf Hansson wrote: > On 31 October 2017 at 14:55, Geert Uytterhoeven wrote: >> Hi Rafael, Tero, >> >> CC pinchartl, dri-devel >> >> On Tue, Oct 31, 2017 at 2:10 PM, Geert Uytterhoeven >> wrote: >>> CC linux-renesas-soc >>> >>> On Tue, Oct 31, 2017 at 2:09 PM, Gee

Re: [PATCH v4 07/11] drm/arc: Use drm_gem_cma_print_info()

2017-11-01 Thread Alexey Brodkin
Hi Noralf, On Mon, 2017-10-30 at 17:29 +0100, Noralf Trønnes wrote: > There is a new core debugfs file that prints fb/gem info: > /dri//framebuffer > > Use drm_gem_cma_print_info() to provide info to that output instead > of using drm_fb_cma_debugfs_show(). > > Cc: Alexey Brodkin > Signed-off-b

[PATCH v1 08/15] drm/i2c: tda998x: Remove duplicate NULL check

2017-11-01 Thread Andy Shevchenko
Since i2c_unregister_device() became NULL-aware we may remove duplicate NULL check. Cc: Russell King Cc: David Airlie Cc: dri-devel@lists.freedesktop.org Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i2c/tda998x_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/d

Re: [PATCH] PM / QoS: Fix default runtime_pm device resume latency

2017-11-01 Thread Rafael J. Wysocki
On Tue, Oct 31, 2017 at 7:07 PM, Geert Uytterhoeven wrote: > Hi Rafael, > > On Tue, Oct 31, 2017 at 6:22 PM, Rafael J. Wysocki wrote: >> On Tue, Oct 31, 2017 at 2:55 PM, Geert Uytterhoeven >> wrote: >>> Hi Rafael, Tero, >>> >>> CC pinchartl, dri-devel >>> >>> On Tue, Oct 31, 2017 at 2:10 PM, Gee

Re: [PATCH v5 2/2] drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset()

2017-11-01 Thread Ingo Molnar
* Hans de Goede wrote: > intel_uncore_forcewake_reset() does forcewake puts and gets as such > we need to make sure that no-one tries to access the PUNIT->PMIC bus > (on systems where this bus is shared) while it runs, otherwise bad > things happen. > > Normally this is taken care of by the i91

[PATCH v1 07/15] drm/i2c/sil164: Remove duplicate NULL check

2017-11-01 Thread Andy Shevchenko
Since i2c_unregister_device() became NULL-aware we may remove duplicate NULL check. Cc: David Airlie Cc: dri-devel@lists.freedesktop.org Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i2c/sil164_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i2c/

[PATCH v1 06/15] drm/bridge: analogix-anx78xx: Remove duplicate NULL check

2017-11-01 Thread Andy Shevchenko
Since i2c_unregister_device() became NULL-aware we may remove duplicate NULL check. Cc: Archit Taneja Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: David Airlie Cc: dri-devel@lists.freedesktop.org Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/bridge/analogix-anx78xx.c | 3 +-- 1 file chang

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset()

2017-11-01 Thread Ingo Molnar
* Daniel Vetter wrote: > On Tue, Oct 31, 2017 at 10:50:06AM +0100, Ingo Molnar wrote: > > > > * Hans de Goede wrote: > > > > > intel_uncore_forcewake_reset() does forcewake puts and gets as such > > > we need to make sure that no-one tries to access the PUNIT->PMIC bus > > > (on systems where

Re: [PATCH v1 08/15] drm/i2c: tda998x: Remove duplicate NULL check

2017-11-01 Thread Russell King - ARM Linux
On Tue, Oct 31, 2017 at 04:21:42PM +0200, Andy Shevchenko wrote: > Since i2c_unregister_device() became NULL-aware we may remove duplicate > NULL check. > > Cc: Russell King Acked-by: Russell King Thanks. > Cc: David Airlie > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Andy Shevchen

Re: WARNING in drm_modeset_lock_all

2017-11-01 Thread Dmitry Vyukov
On Tue, Oct 31, 2017 at 3:45 PM, Chris Wilson wrote: > Quoting syzbot (2017-10-27 09:09:50) >> This bug is generated by a dumb bot. It may contain errors. >> See https://goo.gl/tpsmEJ for details. >> Direct all questions to syzkal...@googlegroups.com. >> >> syzbot will keep track of this bug repor

Re: [PATCH] PM / QoS: Fix default runtime_pm device resume latency

2017-11-01 Thread Rafael J. Wysocki
On Tue, Oct 31, 2017 at 2:55 PM, Geert Uytterhoeven wrote: > Hi Rafael, Tero, > > CC pinchartl, dri-devel > > On Tue, Oct 31, 2017 at 2:10 PM, Geert Uytterhoeven > wrote: >> CC linux-renesas-soc >> >> On Tue, Oct 31, 2017 at 2:09 PM, Geert Uytterhoeven >> wrote: >>> On Tue, Oct 31, 2017 at 12:27

Re: [PATCH v2 05/15] drm/armada: Use drm_fb_helper_lastclose() and _poll_changed()

2017-11-01 Thread Russell King - ARM Linux
On Mon, Oct 30, 2017 at 04:39:41PM +0100, Noralf Trønnes wrote: > -static void armada_output_poll_changed(struct drm_device *dev) > -{ > - struct armada_private *priv = dev->dev_private; > - struct drm_fb_helper *fbh = priv->fbdev; > - > - if (fbh) > - drm_fb_helper_hotplug_

[PATCH 1/2] drm/i915: Reject unknown syncobj flags

2017-11-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We have to reject unknown flags for uAPI considerations, and also because the curent implementation limits their i915 storage space to two bits. v2: (Chris Wilson) * Fix fail in ABI check. * Added unknown flags and BUILD_BUG_ON. v3: * Use ARCH_KMALLOC_MINALIGN instead of

Re: RFC: Add drm_dev_suspend/resume() ?

2017-11-01 Thread Daniel Vetter
On Tue, Oct 31, 2017 at 05:37:23PM +0100, Noralf Trønnes wrote: > > Den 30.10.2017 10.34, skrev Daniel Vetter: > > Hi Noralf, > > > > On Sun, Oct 22, 2017 at 06:52:41PM +0200, Noralf Trønnes wrote: > > > Hi, > > > > > > I've spent some time in the fbdev emulation code and discovered a > > > recu

Re: [Intel-gfx] [PATCH v2 2/2] Test case for drm_vblank_cleanup refcount validation patch

2017-11-01 Thread Daniel Vetter
On Wed, Nov 01, 2017 at 09:48:28AM +0530, PrasannaKumar Muralidharan wrote: > Hi Daniel, > > On 31 October 2017 at 21:57, Daniel Vetter wrote: > > On Tue, Oct 31, 2017 at 08:37:21PM +0530, PrasannaKumar Muralidharan wrote: > >> My patch is supposed to catch problem with drivers. It warns when > >

Re: [PATCH v2 hwc] drm_hwcomposer: provide a common gralloc handle definition

2017-11-01 Thread Daniel Vetter
On Tue, Oct 31, 2017 at 04:10:52PM -0500, Rob Herring wrote: > On Tue, Oct 31, 2017 at 11:44 AM, Daniel Vetter wrote: > > On Tue, Oct 31, 2017 at 09:59:20AM -0500, Rob Herring wrote: > >> EGL, gralloc, and HWC must all have a common definition of fd's and int's > >> in native_handle_t to share the

[Bug 103486] Tonga DC vblank_mode=0 not working as expected fullscreen

2017-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103486 --- Comment #7 from Michel Dänzer --- FWIW, I've been testing with glxgears, either glxgears -fullscreen or making the window fullscreen manually. This may not work depending on the window manager, I'm using xfwm4 with compositing disabled fo

Re: [PATCH] drm: gma500: Convert timers to use timer_setup()

2017-11-01 Thread Daniel Vetter
On Tue, Oct 31, 2017 at 08:08:14AM -0700, Kees Cook wrote: > On Tue, Oct 31, 2017 at 3:18 AM, Daniel Vetter wrote: > > On Mon, Oct 30, 2017 at 03:05:29PM -0700, Kees Cook wrote: > >> On Mon, Oct 30, 2017 at 3:08 AM, Daniel Vetter wrote: > >> > On Tue, Oct 24, 2017 at 08:16:09AM -0700, Kees Cook w

[PATCH] drm/vc4: Fix wrong printk format in vc4_bo_stats_debugfs()

2017-11-01 Thread Boris Brezillon
vc4->purgeable.size and vc4->purgeable.purged_size are size_t fields and should be printed with a %zd specifier. Fixes: b9f19259b84d ("drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl") Signed-off-by: Boris Brezillon --- drivers/gpu/drm/vc4/vc4_bo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 d

Re: [Intel-gfx] [maintainer-tools PATCH] dim: Sign commits in addition to tags

2017-11-01 Thread Gustavo Padovan
2017-10-31 Sean Paul : > On Tue, Oct 31, 2017 at 1:31 PM, Daniel Vetter wrote: > > On Tue, Oct 31, 2017 at 5:14 PM, Sean Paul wrote: > >> On Tue, Oct 31, 2017 at 4:27 AM, Jani Nikula > >> wrote: > >>> > >>> Reminder, we have this new list dim-to...@lists.freedesktop.org for > >>> maintainer too

Re: [PATCH 6/6] drm/msm/mdp5: Don't use async plane update path if plane visibility changes

2017-11-01 Thread Gustavo Padovan
Hi Archit, 2017-10-27 Archit Taneja : > When a plane moves out of bounds (i.e, outside the crtc clip region), the > plane state's "visible" parameter changes to false. When this happens, we > (a) release the hwpipe resources away from it, and > (b) unstage the corresponding hwpipe(s) from the Lay

Re: [PATCH] drm/stm: dsi: Rename driver name

2017-11-01 Thread Gustavo Padovan
Hi Philippe, 2017-10-26 Philippe Cornu : > Rename the driver name from "dw_mipi_dsi-stm" to > "stm32-display-dsi" for a better readability > in /sys/bus/platform/drivers entries. > > Signed-off-by: Philippe Cornu > --- > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 2 +- > 1 file changed, 1 inserti

Re: [PATCH] drm/stm: checkpatch strict minor updates

2017-11-01 Thread Gustavo Padovan
2017-10-26 Philippe Cornu : > Minor fixes detected with "scripts/checkpatch.pl --strict" > > Signed-off-by: Philippe Cornu > --- > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 ++-- > drivers/gpu/drm/stm/ltdc.c| 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a

Re: [PATCH] drm/vc4: Fix wrong printk format in vc4_bo_stats_debugfs()

2017-11-01 Thread Gustavo Padovan
Hi Boris, 2017-11-01 Boris Brezillon : > vc4->purgeable.size and vc4->purgeable.purged_size are size_t fields > and should be printed with a %zd specifier. > > Fixes: b9f19259b84d ("drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl") > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/

Re: [Intel-gfx] [maintainer-tools PATCH] dim: Sign commits in addition to tags

2017-11-01 Thread Sean Paul
On Wed, Nov 1, 2017 at 7:12 AM, Gustavo Padovan wrote: > 2017-10-31 Sean Paul : > >> On Tue, Oct 31, 2017 at 1:31 PM, Daniel Vetter wrote: >> > On Tue, Oct 31, 2017 at 5:14 PM, Sean Paul wrote: >> >> On Tue, Oct 31, 2017 at 4:27 AM, Jani Nikula >> >> wrote: >> >>> >> >>> Reminder, we have this

Re: RFC: Add drm_dev_suspend/resume() ?

2017-11-01 Thread Noralf Trønnes
Den 01.11.2017 09.47, skrev Daniel Vetter: On Tue, Oct 31, 2017 at 05:37:23PM +0100, Noralf Trønnes wrote: Den 30.10.2017 10.34, skrev Daniel Vetter: Hi Noralf, On Sun, Oct 22, 2017 at 06:52:41PM +0200, Noralf Trønnes wrote: Hi, I've spent some time in the fbdev emulation code and discovere

[Bug 103404] HDMI Audio with RX Vega not working on drm-next-4.15-dc (device listed as unconnected)

2017-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103404 Leo Li changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [PATCH] drm: Require __GFP_NOFAIL for the legacy drm_modeset_lock_all

2017-11-01 Thread Chris Wilson
Quoting Daniel Vetter (2017-10-31 16:38:26) > On Tue, Oct 31, 2017 at 03:28:01PM +0200, Ville Syrjälä wrote: > > On Tue, Oct 31, 2017 at 11:55:35AM +, Chris Wilson wrote: > > > To acquire all modeset locks requires a ww_ctx to be allocated. As this > > > is the legacy path and the allocation sm

[PATCH] drm/drm_mm.h: Fix the name of the referenced function in comment

2017-11-01 Thread Liviu Dudau
drm_mm_insert_node_generic() is a simplified version of drm_mm_insert_node_in_range(), update comment to reflect correct function name. Signed-off-by: Liviu Dudau --- include/drm/drm_mm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_mm.h b/include/drm/drm_m

[PATCH] dma-buf: Cleanup comments on dma_buf_map_attachment()

2017-11-01 Thread Liviu Dudau
Mappings need to be unmapped by calling dma_buf_unmap_attachment() and not by calling again dma_buf_map_attachment(). Also fix some spelling mistakes. Signed-off-by: Liviu Dudau --- drivers/dma-buf/dma-buf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma-bu

[PATCH] drm/drm_vma_manager.c: Remove useless goto statement

2017-11-01 Thread Liviu Dudau
Commit db2395eccf08i ("drm: Convert drm_vma_manager to embedded interval-tree in drm_mm") removed a line in drm_vma_offset_add() function that makes checking the result of calling drm_mm_insert_node() and the goto call redundant. Remove them. Fixes: db2395eccf08i ("drm: Convert drm_vma_manager to

[PATCH] drm: Spelling fixes

2017-11-01 Thread Liviu Dudau
Minor spelling fix for 'monster' and replace 'on' with 'own' in comments. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/drm_atomic.c | 2 +- drivers/gpu/drm/drm_mm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_ato

Re: [PATCH] drm/drm_vma_manager.c: Remove useless goto statement

2017-11-01 Thread Chris Wilson
Quoting Liviu Dudau (2017-11-01 14:04:24) > Commit db2395eccf08i ("drm: Convert drm_vma_manager to embedded > interval-tree in drm_mm") removed a line in drm_vma_offset_add() function > that makes checking the result of calling drm_mm_insert_node() and the > goto call redundant. Remove them. > > F

[PATCH] drm: mali-dp: Separate static internal data into a read-only structure.

2017-11-01 Thread Liviu Dudau
The malidp_hw_device structure that the driver uses to handle the differences between versions of the IP contains both non-changeable data and fields that get updated at probe time. Previously we were copying the read-only part into allocated memory, but that can be completely avoided by splitting

[PATCH] drm: mali-dp: Disable planes when their CRTC gets disabled.

2017-11-01 Thread Liviu Dudau
Make sure only the planes on the active CRTCs get committed and that all planes on the disabled CRTCs get turned off. Reviewed-by: Brian Starkey Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_crtc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/arm/malidp_crt

[PATCH] drm: gem_cma_helper.c: Allow importing of contiguous scatterlists with nents > 1

2017-11-01 Thread Liviu Dudau
drm_gem_cma_prime_import_sg_table() will fail if the number of entries in the sg_table > 1. However, you can have a device that uses an IOMMU engine and can map a discontiguous buffer with multiple entries that have consecutive sg_dma_addresses, effectively making it contiguous. Allow for that scen

[PATCH] drm: hdlcd: Skip checking the clock provider when CRTC is disabled.

2017-11-01 Thread Liviu Dudau
Some clock providers (clk-vexpress-osc) trigger a WARN() when the requested rate falls outside its capabilities, as is the case when a CRTC gets disabled. Check if the CRTC's new state is enabled and skip the clk_round_rate() call if it is not. Reported-by: Vladimir Murzin Signed-off-by: Liviu Du

Re: [PATCH v4 2/9] drm/exynos: ipp: Add IPP v2 framework

2017-11-01 Thread Tobias Jakobi
Dave Airlie wrote: > On 23 October 2017 at 17:54, Marek Szyprowski > wrote: >> This patch adds Exynos IPP v2 subsystem and userspace API. >> >> New userspace API is focused ONLY on memory-to-memory image processing. >> The two remainging IPP operation modes (framebuffer writeback and >> local-pat

Re: [PATCH] drm/drm_vma_manager.c: Remove useless goto statement

2017-11-01 Thread Liviu Dudau
On Wed, Nov 01, 2017 at 02:11:44PM +, Chris Wilson wrote: > Quoting Liviu Dudau (2017-11-01 14:04:24) > > Commit db2395eccf08i ("drm: Convert drm_vma_manager to embedded > > interval-tree in drm_mm") removed a line in drm_vma_offset_add() function > > that makes checking the result of calling d

[PATCH 1/7] drm/edid: use macros for ELD offsets and values

2017-11-01 Thread Jani Nikula
We have the macros, use them. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 00ddabfbf980..6229735ecc1

[PATCH 0/7] drm/edid and drivers: ELD refactoring

2017-11-01 Thread Jani Nikula
We were recently bitten by drm_edid_to_eld() clearing the connector type, and us failing to set it back for DP. Here's a few ELD related patches to try to unify ELD handling and make it a bit simpler for drivers to get it right. Apologies for the massive Cc list; it's the maintainers of all driver

[PATCH 2/7] drm/edid: set ELD connector type in drm_edid_to_eld()

2017-11-01 Thread Jani Nikula
Since drm_edid_to_eld() knows the connector type, we can set the type in ELD while at it. Most connectors this gets called on are not DP encoders, and with the HDMI type being 0, this does not change behaviour for non-DP. For i915 having this in place earlier would have saved a considerable amount

[PATCH 7/7] drm/edid: make drm_edid_to_eld() static

2017-11-01 Thread Jani Nikula
This is no longer needed outside of drm_edid.c. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 5 ++--- include/drm/drm_edid.h | 1 - include/drm/drm_modeset_helper_vtables.h | 3 --- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/driv

[PATCH 3/7] drm/i915: remove redundant ELD connector type update

2017-11-01 Thread Jani Nikula
drm_edid_to_eld() now sets ELD connector type, remove the redundant update. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_modes.c | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_modes.c b/drivers/gpu/drm/i915/intel_modes.c index 28a77

[PATCH 6/7] drm/drivers: drop redundant drm_edid_to_eld() calls

2017-11-01 Thread Jani Nikula
drm_add_edid_modes() now fills in the ELD automatically, so the calls to drm_edid_to_eld() are redundant. Remove them. All the other places are obvious, but nv50 has detached drm_edid_to_eld() from the drm_add_edid_modes() call. Cc: Alex Deucher Cc: Christian König Cc: Archit Taneja Cc: Andrze

[PATCH 5/7] drm/edid: build ELD in drm_add_edid_modes()

2017-11-01 Thread Jani Nikula
Call drm_edid_to_eld() from drm_add_edid_modes() to fill in the ELD automatically. There's no harm in doing this for connectors that do not support audio. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 4/7] drm/edid: abstract connector ELD clearing

2017-11-01 Thread Jani Nikula
Preparation for future work. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 3139c2e90e32..3162ea58e450 100644

Re: [PATCH] drm/drm_vma_manager.c: Remove useless goto statement

2017-11-01 Thread Liviu Dudau
On Wed, Nov 01, 2017 at 02:11:44PM +, Chris Wilson wrote: > Quoting Liviu Dudau (2017-11-01 14:04:24) > > Commit db2395eccf08i ("drm: Convert drm_vma_manager to embedded > > interval-tree in drm_mm") removed a line in drm_vma_offset_add() function > > that makes checking the result of calling d

Re: [PATCH] drm/drm_vma_manager.c: Remove useless goto statement

2017-11-01 Thread Chris Wilson
Quoting Liviu Dudau (2017-11-01 14:20:53) > On Wed, Nov 01, 2017 at 02:11:44PM +, Chris Wilson wrote: > > Quoting Liviu Dudau (2017-11-01 14:04:24) > > > Commit db2395eccf08i ("drm: Convert drm_vma_manager to embedded > > > interval-tree in drm_mm") removed a line in drm_vma_offset_add() functi

Re: [PATCH] drm: Spelling fixes

2017-11-01 Thread Alex Deucher
On Wed, Nov 1, 2017 at 10:04 AM, Liviu Dudau wrote: > Minor spelling fix for 'monster' and replace 'on' with 'own' in > comments. > > Signed-off-by: Liviu Dudau Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/drm_atomic.c | 2 +- > drivers/gpu/drm/drm_mm.c | 2 +- > 2 files changed, 2 i

Re: [PATCH 1/2] drm/i915: Reject unknown syncobj flags

2017-11-01 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-10-31 10:23:25) > From: Tvrtko Ursulin > > We have to reject unknown flags for uAPI considerations, and also > because the curent implementation limits their i915 storage space > to two bits. > > v2: (Chris Wilson) > * Fix fail in ABI check. > * Added unknown flags

Re: [PATCH] drm: hdlcd: Skip checking the clock provider when CRTC is disabled.

2017-11-01 Thread Brian Starkey
On Wed, Nov 01, 2017 at 02:16:25PM +, Liviu Dudau wrote: Some clock providers (clk-vexpress-osc) trigger a WARN() when the requested rate falls outside its capabilities, as is the case when a CRTC gets disabled. Check if the CRTC's new state is enabled and skip the clk_round_rate() call if it

[PATCH v2] drm/drm_vma_manager.c: Remove useless goto statement

2017-11-01 Thread Liviu Dudau
Commit db2395eccf08i ("drm: Convert drm_vma_manager to embedded interval-tree in drm_mm") removed a line in drm_vma_offset_add() function that makes checking the result of calling drm_mm_insert_node() and the goto call redundant. Rework the function (as suggested by Chris Wilson) to eliminate the n

Re: [PATCH v2] drm/drm_vma_manager.c: Remove useless goto statement

2017-11-01 Thread Chris Wilson
Quoting Liviu Dudau (2017-11-01 14:44:58) > Commit db2395eccf08i ("drm: Convert drm_vma_manager to embedded > interval-tree in drm_mm") removed a line in drm_vma_offset_add() function that > makes checking the result of calling drm_mm_insert_node() and the goto > call redundant. Rework the function

[Bug 97055] Black screens on A10-8780P (Carrizo) + R7 M260/M265 (Topaz) Combo

2017-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97055 --- Comment #19 from Josh --- (In reply to Thomas J. Moore from comment #17) > Is this the place for AMD-related kernel bugs to die? Yes. Unfortunately, the only solution is to get a computer that is already known to be supported. You won't get

Re: [Intel-gfx] [PATCH 0/7] drm/edid and drivers: ELD refactoring

2017-11-01 Thread Ville Syrjälä
On Wed, Nov 01, 2017 at 04:20:56PM +0200, Jani Nikula wrote: > We were recently bitten by drm_edid_to_eld() clearing the connector > type, and us failing to set it back for DP. Here's a few ELD related > patches to try to unify ELD handling and make it a bit simpler for > drivers to get it right. >

[PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.

2017-11-01 Thread Maarten Lankhorst
This introduces a slight behavioral change to rmfb. Instead of disabling a crtc when the primary plane is disabled, we try to preserve it. Apart from old versions of the vmwgfx xorg driver, there is nothing depending on rmfb disabling a crtc. Vmwgfx' and simple kms helper atomic implementation re

Re: [PATCH 6/7] drm/drivers: drop redundant drm_edid_to_eld() calls

2017-11-01 Thread Ville Syrjälä
On Wed, Nov 01, 2017 at 04:21:02PM +0200, Jani Nikula wrote: > diff --git a/drivers/gpu/drm/nouveau/nv50_display.c > b/drivers/gpu/drm/nouveau/nv50_display.c > index e4751f92b342..e0a190a0f029 100644 > --- a/drivers/gpu/drm/nouveau/nv50_display.c > +++ b/drivers/gpu/drm/nouveau/nv50_display.c > @@

[Bug 97055] Black screens on A10-8780P (Carrizo) + R7 M260/M265 (Topaz) Combo

2017-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97055 --- Comment #20 from Jan Vesely --- (In reply to James Payne from comment #18) > Would be good to get to the bottom of this one as it affects my wife's > laptop :( > > Currently stuck with Windows 10 which is sluggish to do anything... > > Runn

[Bug 99843] Geometry Shader - Incorrect Output

2017-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99843 --- Comment #11 from d...@jerber.co.uk --- Hi, Is it likely this will be looked into or are there no plans to look into issues for older cards? -- You are receiving this mail because: You are the assignee for the bug.___

Re: [Intel-gfx] [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.

2017-11-01 Thread Ville Syrjälä
On Wed, Nov 01, 2017 at 04:04:33PM +0100, Maarten Lankhorst wrote: > This introduces a slight behavioral change to rmfb. Instead of > disabling a crtc when the primary plane is disabled, we try to > preserve it. > > Apart from old versions of the vmwgfx xorg driver, there is > nothing depending on

[Bug 99843] Geometry Shader - Incorrect Output

2017-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99843 --- Comment #12 from Ilia Mirkin --- No one has been able to reproduce, tried on various hardware including a Radeon 6870 (BARTS). Without more information, it's unlikely that anything will happen. At the very least (a) recheck on mesa master an

[PATCH v2 0/2] R-Car Display Unit: Fine-tuning for some function implementations

2017-11-01 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 1 Nov 2017 16:23:45 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): drm/rcar-du: Use common error handling code in rcar_du_encoders_init() drm/rcar-du: Adjust 14 checks for null pointers --- v2: Advic

[PATCH v2 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init()

2017-11-01 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 1 Nov 2017 15:57:31 +0100 * Add a jump target so that a bit of exception handling can be better reused at the end of this function. * Increase the scope for the variable "ret". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elf

[PATCH v2 2/2] drm/rcar-du: Adjust 14 checks for null pointers

2017-11-01 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 1 Nov 2017 16:00:46 +0100 The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written !... Thus fix the affected source code places. Signed-off-by: Markus Elfring --- v2: The commit message was written only with A

[drm-intel:for-linux-next 3/4] drivers/gpu/drm/i915/intel_engine_cs.c:1620:30: error: 'dev_priv' undeclared

2017-11-01 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next head: 3265124a2d3744d789ede58452ab6f8a9b454be8 commit: 680273879d125d644831b8de42c66576e6290378 [3/4] drm/i915: Move parking-while-active warning to intel_engines_park() config: i386-randconfig-x003-201744 (attached as .config) compi

Re: [Intel-gfx] [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.

2017-11-01 Thread Maarten Lankhorst
Op 01-11-17 om 16:29 schreef Ville Syrjälä: > On Wed, Nov 01, 2017 at 04:04:33PM +0100, Maarten Lankhorst wrote: >> This introduces a slight behavioral change to rmfb. Instead of >> disabling a crtc when the primary plane is disabled, we try to >> preserve it. >> >> Apart from old versions of the v

Re: [Intel-gfx] [PATCH v2 2/2] Test case for drm_vblank_cleanup refcount validation patch

2017-11-01 Thread PrasannaKumar Muralidharan
Hi Daniel, On 1 November 2017 at 14:23, Daniel Vetter wrote: > On Wed, Nov 01, 2017 at 09:48:28AM +0530, PrasannaKumar Muralidharan wrote: >> Hi Daniel, >> >> On 31 October 2017 at 21:57, Daniel Vetter wrote: >> > On Tue, Oct 31, 2017 at 08:37:21PM +0530, PrasannaKumar Muralidharan wrote: >> >>

[PATCH] drm/ttm: Always and only destroy bo->ttm_resv in ttm_bo_release_list

2017-11-01 Thread Michel Dänzer
From: Michel Dänzer Fixes a use-after-free due to a race condition in ttm_bo_cleanup_refs_and_unlock, which allows one task to reserve a BO and destroy its ttm_resv while another task is waiting for it to signal in reservation_object_wait_timeout_rcu. Fixes: 0d2bd2ae045d "drm/ttm: fix memory lea

RE: [Intel-gfx] [maintainer-tools PATCH] dim: Sign commits in addition to tags

2017-11-01 Thread Deucher, Alexander
> -Original Message- > From: dim-tools [mailto:dim-tools-boun...@lists.freedesktop.org] On Behalf > Of Sean Paul > Sent: Wednesday, November 01, 2017 8:52 AM > To: Gustavo Padovan > Cc: Daniel Vetter; Intel Graphics Development; dim- > to...@lists.freedesktop.org; dri-devel; Daniel Vetter >

[PATCH hwc] drm_hwcomposer: correct handling of DRM_MODE_ROTATE_0

2017-11-01 Thread Rob Herring
If the rotation property is supported for a plane, then the rotation value must be non-zero. For the case of 0 degree rotation, DRM_MODE_ROTATE_0 needs to be set. Signed-off-by: Rob Herring --- drmdisplaycompositor.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drmdis

Re: [PATCH] drm/vc4: Fix wrong printk format in vc4_bo_stats_debugfs()

2017-11-01 Thread Eric Anholt
Boris Brezillon writes: > vc4->purgeable.size and vc4->purgeable.purged_size are size_t fields > and should be printed with a %zd specifier. > > Fixes: b9f19259b84d ("drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl") > Signed-off-by: Boris Brezillon Reviewed-by: Eric Anholt signature.asc De

Re: [PATCH 6/7] drm/drivers: drop redundant drm_edid_to_eld() calls

2017-11-01 Thread Eric Anholt
Jani Nikula writes: > drm_add_edid_modes() now fills in the ELD automatically, so the calls to > drm_edid_to_eld() are redundant. Remove them. > > All the other places are obvious, but nv50 has detached > drm_edid_to_eld() from the drm_add_edid_modes() call. Nice! For vc4, Acked-by: Eric Anhol

Re: [Intel-gfx] [maintainer-tools PATCH] dim: Sign commits in addition to tags

2017-11-01 Thread Eric Anholt
Sean Paul writes: > On Wed, Nov 1, 2017 at 7:12 AM, Gustavo Padovan wrote: >> 2017-10-31 Sean Paul : >> >>> On Tue, Oct 31, 2017 at 1:31 PM, Daniel Vetter wrote: >>> > On Tue, Oct 31, 2017 at 5:14 PM, Sean Paul wrote: >>> >> On Tue, Oct 31, 2017 at 4:27 AM, Jani Nikula >>> >> wrote: >>> >>> >

Re: [Intel-gfx] [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.

2017-11-01 Thread Ville Syrjälä
On Wed, Nov 01, 2017 at 04:55:06PM +0100, Maarten Lankhorst wrote: > Op 01-11-17 om 16:29 schreef Ville Syrjälä: > > On Wed, Nov 01, 2017 at 04:04:33PM +0100, Maarten Lankhorst wrote: > >> This introduces a slight behavioral change to rmfb. Instead of > >> disabling a crtc when the primary plane is

[Bug 103486] Tonga DC vblank_mode=0 not working as expected fullscreen

2017-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103486 Bhawan Lakha changed: What|Removed |Added CC||bhawanpreet.la...@amd.com --- Comment #8

[Bug 103486] Tonga DC vblank_mode=0 not working as expected fullscreen

2017-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103486 --- Comment #9 from Michel Dänzer --- (In reply to Bhawan Lakha from comment #8) > Created attachment 135202 [details] [review] > Patch to fix vblank_mode not working properly Tested-by: Michel Dänzer P.S. I had to convert the patch from DOS-

[Bug 103486] Tonga DC vblank_mode=0 not working as expected fullscreen

2017-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103486 Bhawan Lakha changed: What|Removed |Added Attachment #135202|0 |1 is obsolete|

Re: [Intel-gfx] [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.

2017-11-01 Thread Maarten Lankhorst
Op 01-11-17 om 18:00 schreef Ville Syrjälä: > On Wed, Nov 01, 2017 at 04:55:06PM +0100, Maarten Lankhorst wrote: >> Op 01-11-17 om 16:29 schreef Ville Syrjälä: >>> On Wed, Nov 01, 2017 at 04:04:33PM +0100, Maarten Lankhorst wrote: This introduces a slight behavioral change to rmfb. Instead of

Re: [Intel-gfx] [maintainer-tools PATCH] dim: Sign commits in addition to tags

2017-11-01 Thread Sean Paul
On Wed, Nov 1, 2017 at 1:00 PM, Eric Anholt wrote: > Sean Paul writes: > >> On Wed, Nov 1, 2017 at 7:12 AM, Gustavo Padovan wrote: >>> 2017-10-31 Sean Paul : >>> On Tue, Oct 31, 2017 at 1:31 PM, Daniel Vetter wrote: > On Tue, Oct 31, 2017 at 5:14 PM, Sean Paul wrote: >> On Tue,

[PATCH hwc] drm_hwcomposer: Add HDMI connector as a valid type

2017-11-01 Thread Rob Herring
From: Robert Foss Accept DRM_MODE_CONNECTOR_HDMIA connector type. Look for primary DrmConnector amongst external connectors after looking for primary amongst internal ones first. Signed-off-by: Robert Foss Signed-off-by: Rob Herring --- This is needed to get dev boards like DB410c to work.

Re: [PATCH hwc] drm_hwcomposer: correct handling of DRM_MODE_ROTATE_0

2017-11-01 Thread Rob Herring
On Wed, Nov 1, 2017 at 11:37 AM, Rob Herring wrote: > If the rotation property is supported for a plane, then the rotation > value must be non-zero. For the case of 0 degree rotation, > DRM_MODE_ROTATE_0 needs to be set. > > Signed-off-by: Rob Herring > --- > drmdisplaycompositor.cpp | 4 +++- >

Re: [PATCH hwc] drm_hwcomposer: correct handling of DRM_MODE_ROTATE_0

2017-11-01 Thread Robert Foss
Hi Rob, On Wed, 2017-11-01 at 12:50 -0500, Rob Herring wrote: > On Wed, Nov 1, 2017 at 11:37 AM, Rob Herring wrote: > > If the rotation property is supported for a plane, then the > > rotation > > value must be non-zero. For the case of 0 degree rotation, > > DRM_MODE_ROTATE_0 needs to be set. >

Re: [PATCH hwc] drm_hwcomposer: Add HDMI connector as a valid type

2017-11-01 Thread Robert Foss
Hi Rob, Pushed to master. Rob. On Wed, 2017-11-01 at 12:50 -0500, Rob Herring wrote: > From: Robert Foss > > Accept DRM_MODE_CONNECTOR_HDMIA connector type. > > Look for primary DrmConnector amongst external connectors > after looking for primary amongst internal ones first. > > Signed-off-

[PATCH 2/5] drm/vmwgfx: Use drm_plane_helper_check_state()

2017-11-01 Thread Ville Syrjala
From: Ville Syrjälä Atomic drivers have no reason to use drm_plane_helper_check_update() instead of drm_plane_helper_check_state(). So let's switch over. Cc: VMware Graphics Cc: Sinclair Yeh Cc: Thomas Hellstrom Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 17 +++--

[PATCH 0/5] drm: drm_plane_helper_check_state() related stuff

2017-11-01 Thread Ville Syrjala
From: Ville Syrjälä While trawling the tree I spotted some issues with the way vmwgfx uses drm_plane_helper_check_state(). Here's my attempt at fixing it. Do note that I haven't actually tested the resulting code at all, but it does build at least. And while touching that general area I took up

[PATCH 1/5] drm/vmwgfx: Remove bogus crtc coords vs fb size check

2017-11-01 Thread Ville Syrjala
From: Ville Syrjälä Throw away the bugs crtc coords vs. fb size check. Crtc coords don't define the viewport inside the fb, that's a job for the src coords, which have been checked by the core already. Cc: VMware Graphics Cc: Sinclair Yeh Cc: Thomas Hellstrom Signed-off-by: Ville Syrjälä ---

[PATCH 3/5] drm/vmwgfx: Try to fix plane clipping

2017-11-01 Thread Ville Syrjala
From: Ville Syrjälä Try to fix the code to actually clip the plane to the crtc bounds instead of the user provided crtc coordinates (which would be a no-op since those are exactly the coordinates before clipping). Cc: VMware Graphics Cc: Sinclair Yeh Cc: Thomas Hellstrom Signed-off-by: Ville

[PATCH 4/5] drm: Check crtc_state->enable rather than crtc->enabled in drm_plane_helper_check_state()

2017-11-01 Thread Ville Syrjala
From: Ville Syrjälä drm_plane_helper_check_state() is supposed to do things the atomic way, so it should not be inspecting crtc->enabled. Rather we should be looking at crtc_state->enable. We have a slight complication due to drm_plane_helper_check_update() reusing drm_plane_helper_check_state()

[PATCH 5/5] drm: Move drm_plane_helper_check_state() into drm_atomic_helper.c

2017-11-01 Thread Ville Syrjala
From: Ville Syrjälä drm_plane_helper_check_update() isn't a transitional helper, so let's rename it to drm_atomic_helper_check_plane_state() and move it into drm_atomic_helper.c. Cc: Daniel Vetter Suggested-by: Daniel Vetter Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/arm/hdlcd_crtc.c

[PATCH] drm: Print the fb dimensions when the src coord check fails

2017-11-01 Thread Ville Syrjala
From: Ville Syrjälä When debugging bad plane source coordinates it helps to have an idea of what the framebuffer dimensions are. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic.c | 5 +++-- drivers/gpu/drm/drm_framebuffer.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deleti

[pull] drm/msm: msm-next for 4.15 (take 2)

2017-11-01 Thread Rob Clark
Hi Dave, Updated pull request, which adds the patch I lost from Arnd to correct a warning on armv7. Original pull req description: Updates for 4.15.. highlights include: + preemption support for a5xx[1][2] + display fixes for 8x96 (snapdragon 820) including fixes for 4k scanout (hwpipe as

  1   2   >