Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-04-04 Thread Daniel Vetter
On Mon, Apr 03, 2017 at 03:50:33PM -0700, Keith Packard wrote: > Daniel Vetter writes: > > > Also if this confuses VR, then another reason why we want to make leases > > invariant and only allow pure revoke, not changing the list. > > I'm not sure why you want this to be asymmetrical, nor why yo

Re: [PATCH] drm/amdgpu: Fix a NULL deref in amdgpu_vm_add_prt_cb()

2017-04-04 Thread Christian König
Am 03.04.2017 um 22:36 schrieb Alex Deucher: On Mon, Apr 3, 2017 at 2:53 PM, Harry Wentland wrote: Reviewed-by: Harry Wentland Harry Applied. thanks! Nice catch, Reviewed-by: Christian König if Alex still wants to add that. Christian. Alex On 2017-04-03 02:41 PM, Dan Carpenter w

Re: GSOC(Xorg)

2017-04-04 Thread Martin Peres
On 04/04/17 01:17, Christian Lockley wrote: Hi all, I'm Christian Lockley I'm wondering if it's too late to apply for GSOC if so I understand and will apply next year. It not, is the DRM kernel janitor position still open? While I don't have kernel or graphics experience I do know C and Java. If

Re: [PATCH 1/8] sync_file: add type/flags to sync file object creation.

2017-04-04 Thread Daniel Vetter
On Tue, Apr 04, 2017 at 02:27:26PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This allows us to create sync files with different semantics, > and clearly define the interoperation between them it also > provides flags to allow for tweaks on those semantics. > > This provides a validation

Re: [PATCH 2/8] sync_file: export some interfaces needed by drm sync objects.

2017-04-04 Thread Daniel Vetter
On Tue, Apr 04, 2017 at 02:27:27PM +1000, Dave Airlie wrote: > From: Dave Airlie > > These are just alloc and fdget interfaces needed by the drm sync > objects code. > > Signed-off-by: Dave Airlie Reviewed-by: Daniel Vetter > --- > drivers/dma-buf/sync_file.c | 21 +++-- > i

Re: [PATCH 7/8] amdgpu/cs: split out fence dependency checking

2017-04-04 Thread Christian König
Am 04.04.2017 um 06:27 schrieb Dave Airlie: From: Dave Airlie This just splits out the fence depenency checking into it's own function to make it easier to add semaphore dependencies. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 86 +++-

Re: [PATCH 8/8] amdgpu: use sync file for shared semaphores (v2)

2017-04-04 Thread Christian König
Am 04.04.2017 um 06:27 schrieb Dave Airlie: From: Dave Airlie This creates a new interface for amdgpu with ioctls to create/destroy/import and export shared semaphores using sem object backed by the sync_file code. The semaphores are not installed as fd (except for export), but rather like othe

Re: [PATCH 3/8] drm: introduce sync objects as sync file objects with no fd

2017-04-04 Thread Daniel Vetter
On Tue, Apr 04, 2017 at 02:27:28PM +1000, Dave Airlie wrote: > From: Dave Airlie > > Sync objects are new toplevel drm object, that have the same > semantics as sync_file objects, but without requiring an fd > to be consumed to support them. > > This patch just enables the DRM interface to creat

Re: [PATCH 4/8] sync_file: add a mutex to protect fence and callback members. (v4)

2017-04-04 Thread Daniel Vetter
On Tue, Apr 04, 2017 at 02:27:29PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This patch allows the underlying fence in a sync_file to be changed > or set to NULL. This isn't currently required but for Vulkan > semaphores we need to be able to swap and reset the fence. > > In order to fac

Re: [PATCH 5/8] sync_file: add support for a semaphore object

2017-04-04 Thread Daniel Vetter
On Tue, Apr 04, 2017 at 02:27:30PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This object can be used to implement the Vulkan semaphores. > > The object behaviour differs from fence, in that you can > replace the underlying fence, and you cannot merge semaphores. > > Signed-off-by: Dave

[PATCH] MAINTAINERS: meson-drm: remove useless git repository

2017-04-04 Thread Neil Armstrong
Meson DRM is switching to drm-misc, so remove the freedesktop drm/meson-drm git repository from MAINTAINERS entry. Acked-by: Daniel Vetter Signed-off-by: Neil Armstrong --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d0d9ed8..8d3eb6e 100644 ---

Re: [PATCH 7/7 v2] drm/radeon: Refuse to migrate a prime BO to VRAM. (v2)

2017-04-04 Thread Christopher James Halse Rogers
I also haven't tested it on hardware (all my hardware seems to be supported by amdgpu), but the only times we touch prime_shared_count are: 1) It's set to 1 in radeon_gem_prime_import_sg_table. This shouldn't be called in the self-import case (and isn't, as far as I can tell), and 2) It's increment

Re: [RFC] DRM synchronisation objects

2017-04-04 Thread Christian König
Am 04.04.2017 um 06:27 schrieb Dave Airlie: This series enhances my previous semaphore work on for amdgpu, with a generic DRM sync object. (drm_syncobj). It first enhances sync_file to have a type/flags so we can have different semantics for different sync files, and a wait to retrieve the type

Re: [PATCH] MAINTAINERS: meson-drm: remove useless git repository

2017-04-04 Thread Neil Armstrong
On 04/04/2017 10:01 AM, Neil Armstrong wrote: > Meson DRM is switching to drm-misc, so remove the freedesktop drm/meson-drm > git repository from MAINTAINERS entry. > > Acked-by: Daniel Vetter > Signed-off-by: Neil Armstrong > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) > > diff -

Re: [PATCH 6/8] drm/syncobj: add semaphore support helpers.

2017-04-04 Thread Daniel Vetter
On Tue, Apr 04, 2017 at 02:27:31PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This just adds two helper interfaces to bridge the gap from > drivers to sync_file for the semaphore objects. > > These will be used by the amdgpu driver. > > Signed-off-by: Dave Airlie > --- > drivers/gpu/dr

Re: [PATCH v2 09/13] ARM64: dts: meson-gx: Add support for HDMI output

2017-04-04 Thread Neil Armstrong
On 03/21/2017 04:25 PM, Neil Armstrong wrote: > Add HDMI output and connector nodes. > > Signed-off-by: Neil Armstrong > --- > .../arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi | 39 > ++ > arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 32 ++ > .../bo

Re: [PATCH 8/8] amdgpu: use sync file for shared semaphores (v2)

2017-04-04 Thread Daniel Vetter
On Tue, Apr 04, 2017 at 09:40:57AM +0200, Christian König wrote: > Am 04.04.2017 um 06:27 schrieb Dave Airlie: > > From: Dave Airlie > > > > This creates a new interface for amdgpu with ioctls to > > create/destroy/import and export shared semaphores using > > sem object backed by the sync_file c

Re: [RFC] DRM synchronisation objects

2017-04-04 Thread Daniel Vetter
On Tue, Apr 04, 2017 at 02:27:25PM +1000, Dave Airlie wrote: > This series enhances my previous semaphore work on for amdgpu, > with a generic DRM sync object. (drm_syncobj). > > It first enhances sync_file to have a type/flags so we can have > different semantics for different sync files, and a w

[PATCH 2/2] drm/i915: support DRIVER_PRIME_SCANOUT.

2017-04-04 Thread raof
From: Christopher James Halse Rogers CC: intel-...@lists.freedesktop.org Signed-off-by: Christopher James Halse Rogers --- drivers/gpu/drm/i915/i915_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c inde

[PATCH] Tell userspace if scanning out of an imported PRIME buffer is safe.

2017-04-04 Thread raof
My past set of patches fix nouveau, radeon, and amdgpu breaking dma-buf sharing when trying to scanout of an imported PRIME buffer. Driver-agnostic userspace can't safely try to scanout of such a buffer, though, because the failure-mode is that subsequent rendering isn't shown on screen. This a

[PATCH 1/2] drm: Add DRM_CAP_PRIME_SCANOUT.

2017-04-04 Thread raof
From: Christopher James Halse Rogers Until recently, on (at least) nouveau, radeon, and amdgpu attempting to scanout of an imported dma-buf would silently result in the dma-buf sharing being broken. While the hardware is capable of scanning out of imported dma-bufs (at least in some circumstan

Re: imx-drm: vblank wait timed out

2017-04-04 Thread Philipp Zabel
Hi Christian, On Mon, 2017-04-03 at 17:16 +0200, Christian Gmeiner wrote: > 2017-03-31 14:57 GMT+02:00 Philipp Zabel : > > Hi Christian, > > > > On Fri, 2017-03-31 at 12:44 +0200, Christian Gmeiner wrote: > >> Hi > >> > >> I get this from time to time on a 4.9.17 kernel: > >> > >> [3.353387] -

Re: [PATCH 4/8] sync_file: add a mutex to protect fence and callback members. (v4)

2017-04-04 Thread Christian König
Am 04.04.2017 um 06:27 schrieb Dave Airlie: From: Dave Airlie This patch allows the underlying fence in a sync_file to be changed or set to NULL. This isn't currently required but for Vulkan semaphores we need to be able to swap and reset the fence. In order to faciliate this, it uses rcu to p

Re: [Intel-gfx] [PATCH] dim: Add apply-pull command

2017-04-04 Thread Jani Nikula
On Tue, 04 Apr 2017, Daniel Vetter wrote: > On Mon, Apr 03, 2017 at 06:17:51PM +0300, Jani Nikula wrote: >> On Thu, 30 Mar 2017, Daniel Vetter wrote: >> > I'm getting real lazy, let's start scripting this. Very rough draft, >> > but adds a Link: (patchwork tracks pull requests too, maybe we'll >>

Re: [PATCH 1/2] drm: Add DRM_CAP_PRIME_SCANOUT.

2017-04-04 Thread Daniel Vetter
On Tue, Apr 04, 2017 at 06:13:20PM +1000, r...@ubuntu.com wrote: > From: Christopher James Halse Rogers > > Until recently, on (at least) nouveau, radeon, and amdgpu attempting to > scanout of an > imported dma-buf would silently result in the dma-buf sharing being broken. > > While the hardwar

Re: [PATCH v2 08/13] ARM64: dts: meson-gx: Add shared CMA dma memory pool

2017-04-04 Thread Neil Armstrong
On 03/21/2017 04:25 PM, Neil Armstrong wrote: > The HDMI modes needs more CMA memory to be reserved at boot-time. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 8 > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meso

Re: [PATCH v2 01/13] drm/meson: Use crtc_state for hdisplay and fix atomic flush/enable sync for vsync commit

2017-04-04 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 04:25:38PM +0100, Neil Armstrong wrote: > Clean the crtc_enable by using the proper crtc_state instead of the state > of the primary plane state data. > > Also fix the dependency to commit the plane changes even if enable is called > after the flush. Would have done this a

Re: [PATCH v2 07/13] drm/meson: Add support for HDMI encoder and DW-HDMI bridge + PHY

2017-04-04 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 04:25:44PM +0100, Neil Armstrong wrote: > The Amlogic Meson GXBB/GXL/GXM SoCs embeds a Synopsys DesignWare HDMI TX > Controller with a custom Bridge + PHY around the Controller. > > This driver makes uses of all the custom PHY plat data callbacks and enables > the compatibl

Re: [PATCH v2 03/13] drm/meson: Add support for components

2017-04-04 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 04:25:40PM +0100, Neil Armstrong wrote: > This patch adds support for optional components connected through the > Device Tree endpoints scheme. > > Signed-off-by: Neil Armstrong > --- > drivers/gpu/drm/meson/meson_drv.c | 113 > +- > 1

Re: [PATCH v2 12/13] drm/meson: Add RST to bring together kerneldoc

2017-04-04 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 04:25:49PM +0100, Neil Armstrong wrote: > Signed-off-by: Neil Armstrong \o/ for kerneldoc! This is awesome, but I guess it's time to extract a drivers.rst sub-file within Doc/gpu and put all the various driver docs in there? Would be great if you could do the follow-up fo

Re: [PATCH v2 13/13] MAINTAINERS: update files for Amlogic DRM Driver

2017-04-04 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 04:25:50PM +0100, Neil Armstrong wrote: > This patch adds the dw-hdmi bindings and RST kerneldoc to maintained files. > > Signed-off-by: Neil Armstrong > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index e88154

Re: [PATCH v2 00/13] drm/meson: Initial support for HDMI Output

2017-04-04 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 04:25:37PM +0100, Neil Armstrong wrote: > The Amlogic GX SoCs implements a Synopsys DesignWare HDMI TX Controller > in combination with a very custom PHY. > > This patchset depends on Laurent Pinchart patchset merged in drm-misc-next > and my v4 patchset at [1] to permit PH

Re: [PATCH v2 03/13] drm/meson: Add support for components

2017-04-04 Thread Neil Armstrong
On 04/04/2017 10:59 AM, Daniel Vetter wrote: > On Tue, Mar 21, 2017 at 04:25:40PM +0100, Neil Armstrong wrote: >> This patch adds support for optional components connected through the >> Device Tree endpoints scheme. >> >> Signed-off-by: Neil Armstrong >> --- >> drivers/gpu/drm/meson/meson_drv.c

Re: [PATCH v2 03/13] drm/meson: Add support for components

2017-04-04 Thread Daniel Vetter
On Tue, Apr 04, 2017 at 11:08:26AM +0200, Neil Armstrong wrote: > On 04/04/2017 10:59 AM, Daniel Vetter wrote: > > On Tue, Mar 21, 2017 at 04:25:40PM +0100, Neil Armstrong wrote: > >> +static int meson_drv_probe(struct platform_device *pdev) > >> +{ > >> + struct component_match *match = NULL; > >

Re: [PATCH v6 2/6] media: uapi: Add RGB and YUV bus formats for Synopsys HDMI TX Controller

2017-04-04 Thread Laurent Pinchart
Hi Neil, Thank you for the patch. On Monday 03 Apr 2017 16:42:34 Neil Armstrong wrote: > In order to describe the RGB and YUV bus formats used to feed the > Synopsys DesignWare HDMI TX Controller, add missing formats to the > list of Bus Formats. > > Documentation for these formats is added in a

Re: [PATCH v2 07/13] drm/meson: Add support for HDMI encoder and DW-HDMI bridge + PHY

2017-04-04 Thread Neil Armstrong
On 04/04/2017 10:57 AM, Daniel Vetter wrote: > On Tue, Mar 21, 2017 at 04:25:44PM +0100, Neil Armstrong wrote: >> The Amlogic Meson GXBB/GXL/GXM SoCs embeds a Synopsys DesignWare HDMI TX >> Controller with a custom Bridge + PHY around the Controller. >> >> This driver makes uses of all the custom P

Re: [PATCH v2 12/13] drm/meson: Add RST to bring together kerneldoc

2017-04-04 Thread Neil Armstrong
On 04/04/2017 11:00 AM, Daniel Vetter wrote: > On Tue, Mar 21, 2017 at 04:25:49PM +0100, Neil Armstrong wrote: >> Signed-off-by: Neil Armstrong > > \o/ for kerneldoc! > > This is awesome, but I guess it's time to extract a drivers.rst sub-file > within Doc/gpu and put all the various driver docs

Re: [PATCH v6 3/6] documentation: media: Add documentation for new RGB and YUV bus formats

2017-04-04 Thread Laurent Pinchart
Hi Neil, Thank you for the patch. On Monday 03 Apr 2017 16:42:35 Neil Armstrong wrote: > Add documentation for added Bus Formats to describe RGB and YUV formats used > as input to the Synopsys DesignWare HDMI TX Controller. > > Acked-by: Hans Verkuil > Reviewed-by: Archit Taneja > Acked-by: Ma

Re: [PATCH v2 13/13] MAINTAINERS: update files for Amlogic DRM Driver

2017-04-04 Thread Neil Armstrong
On 04/04/2017 11:01 AM, Daniel Vetter wrote: > On Tue, Mar 21, 2017 at 04:25:50PM +0100, Neil Armstrong wrote: >> This patch adds the dw-hdmi bindings and RST kerneldoc to maintained files. >> >> Signed-off-by: Neil Armstrong >> --- >> MAINTAINERS | 2 ++ >> 1 file changed, 2 insertions(+) >> >>

[PATCH] gpu: ipu-v3: don't depend on DRM being enabled

2017-04-04 Thread Philipp Zabel
From: Lucas Stach The PRE/PRG drivers, which need the DRM infrastructure, are only used from the output path, so we skip building them into the ipu-v3 driver if CONFIG_DRM is not enabled. Signed-off-by: Lucas Stach Signed-off-by: Philipp Zabel --- drivers/gpu/ipu-v3/Makefile | 6 +- d

[PATCH] drm/imx: merge imx-drm-core and ipuv3-crtc in one module

2017-04-04 Thread Philipp Zabel
From: Lucas Stach While it is possible to hook other CRTC implementations into imx-drm in practice there are none yet and the option to disable ipuv3-crtc support has been hidden for a long time. Now that the imx-drm-core has learned to deal with some of the specifics of IPUv3 there is a cyclic

Re: [PATCH v2 00/13] drm/meson: Initial support for HDMI Output

2017-04-04 Thread Neil Armstrong
On 04/04/2017 11:04 AM, Daniel Vetter wrote: > On Tue, Mar 21, 2017 at 04:25:37PM +0100, Neil Armstrong wrote: >> The Amlogic GX SoCs implements a Synopsys DesignWare HDMI TX Controller >> in combination with a very custom PHY. >> >> This patchset depends on Laurent Pinchart patchset merged in drm-

Re: [PATCH v6 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

2017-04-04 Thread Laurent Pinchart
Hi Neil, Thank you for the patch. On Monday 03 Apr 2017 16:42:36 Neil Armstrong wrote: > Some display pipelines can only provide non-RBG input pixels to the HDMI TX > Controller, this patch takes the pixel format from the plat_data if > provided. The commit message doesn't seem to match the subj

Re: [PATCH v6 5/6] drm: bridge: dw-hdmi: Add Documentation on supported input formats

2017-04-04 Thread Laurent Pinchart
Hi Neil, Thank you for the patch. On Monday 03 Apr 2017 16:42:37 Neil Armstrong wrote: > This patch adds a new DRM documentation entry and links to the input > format table added in the dw_hdmi header. > > Reviewed-by: Archit Taneja > Signed-off-by: Neil Armstrong Acked-by: Laurent Pinchart

Re: [PATCH] kernel: drm/vmwgfx: limit the number of mip levels in vmw_gb_surface_define_ioctl()

2017-04-04 Thread Vladis Dronov
Hello, Sinclair! > Here, the check should be "> DRM_VMW_MAX_MIP_LEVELS" because req->mip_levels > is only for one layer. Got it, thanks! > Also, as long as we can doing a check, I would suggest we check for 0 as > well. Do you mean a check for "req->mip_levels > 0" or for "req->mip_levels >= 0"

Re: [PATCH v6 6/6] drm: bridge: dw-hdmi: Move HPD handling to PHY operations

2017-04-04 Thread Laurent Pinchart
Hi Neil, Thank you for the patch. On Monday 03 Apr 2017 16:42:38 Neil Armstrong wrote: > The HDMI TX controller support HPD and RXSENSE signaling from the PHY > via it's STAT0 PHY interface, but some vendor PHYs can manage these > signals independently from the controller, thus these STAT0 handli

[PATCH 03/11] drm: Extract drm_ioctl.h

2017-04-04 Thread Daniel Vetter
To match the drm_ioctl.c we already have. v2: Remove spurious space (Ville). Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Daniel Vetter --- include/drm/drmP.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index e1daa4f343cd..a5ddc28

[PATCH 01/11] drm: update todo.rst

2017-04-04 Thread Daniel Vetter
Just drive-by, but we have gsoc running so better to update it now. Great news is that two entries can be removed because essentially all done. v2: Keep a bunch of the todos, Gabriel is working on them. Cc: Gabriel Krisman Bertazi Signed-off-by: Daniel Vetter --- Documentation/gpu/todo.rst |

[PATCH 05/11] drm/vblank: Switch drm_driver->get_vblank_timestamp to return a bool

2017-04-04 Thread Daniel Vetter
There's really no reason for anything more: - Calling this while the crtc vblank stuff isn't set up is a driver bug. Those places arlready DRM_ERROR. - Calling this when the crtc is off is either a driver bug (callin drm_crtc_handle_vblank at the wrong time) or a core bug (for anything else).

[PATCH 04/11] drm: document drm_ioctl.[hc]

2017-04-04 Thread Daniel Vetter
Also unify/merge with the existing stuff. I was a bit torn where to put this, but in the end I decided to put all the ioctl/sysfs/debugfs stuff into drm-uapi.rst. That means we have a bit a split with the other uapi related stuff used internally, like drm_file.[hc], but I think overall this makes

[PATCH 06/11] drm/vblank: Switch to bool in_vblank_irq in get_vblank_timestamp

2017-04-04 Thread Daniel Vetter
It's overkill to have a flag parameter which is essentially used just as a boolean. This takes care of core + adjusting drivers. Adjusting the scanout position callback is a bit harder, since radeon also supplies it's own driver-private flags in there. Cc: Mario Kleiner Cc: Eric Anholt Cc: Rob

[PATCH 07/11] drm/vblank: Add FIXME comments about moving the vblank ts hooks

2017-04-04 Thread Daniel Vetter
This is going to be a bit too much, but good to have at least a small note about where this should all head towards. Signed-off-by: Daniel Vetter --- include/drm/drm_drv.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h index 9fe6301e

[PATCH 02/11] drm: Consolidate and document sysfs support

2017-04-04 Thread Daniel Vetter
- remove docs for internal func, doesn't add value - add short overview snippet instead explaining that drivers don't have to bother themselves with reg/unreg concerns - drop the ttm comment about drmP.h, drmP.h is disappearing ... Signed-off-by: Daniel Vetter --- Documentation/gpu/drm-uapi.rs

[PATCH 08/11] drm/vblank: drop the mode argument from drm_calc_vbltimestamp_from_scanoutpos

2017-04-04 Thread Daniel Vetter
If we restrict this helper to only kms drivers (which is the case) we can look up the correct mode easily ourselves. But it's a bit tricky: - All legacy drivers look at crtc->hwmode. But that is update already at the beginning of the modeset helper, which means when we disable a pipe. Hence th

[PATCH 10/11] drm/vblank: Lock down vblank->hwmode more

2017-04-04 Thread Daniel Vetter
In the previous patch we've implemented hwmode tracking a la i915 for the vblank timestamp calculations. But that was just the basic semantics, i915 has some nice sanity checks to make sure we keep getting this right. Move them over too. Cc: Ville Syrjälä Signed-off-by: Daniel Vetter --- driver

[PATCH 09/11] drm/vblank: Simplify the get_scanout_position helper hook

2017-04-04 Thread Daniel Vetter
- We can drop the different return value flags, the only caller only cares about whether the scanout position is valid or not. Also, it's entirely undefined what "accurate" means, if we'd really care we should probably wire the max_error through. But since we never even report this to users

Re: [Intel-gfx] [PATCH] drm/vblank: drop the mode argument from drm_calc_vbltimestamp_from_scanoutpos

2017-04-04 Thread Daniel Vetter
On Thu, Mar 30, 2017 at 08:27:40PM +0200, Daniel Vetter wrote: > On Thu, Mar 30, 2017 at 04:41:57PM +0300, Ville Syrjälä wrote: > > On Thu, Mar 30, 2017 at 03:27:57PM +0200, Daniel Vetter wrote: > > > On Thu, Mar 30, 2017 at 2:03 PM, Ville Syrjälä > > > wrote: > > > > On Wed, Mar 22, 2017 at 09:56

[PATCH 11/11] drm/doc: Small markup fixup

2017-04-04 Thread Daniel Vetter
Drive-by cleanup. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_probe_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c index 85005d57bde6..efb5e5e8ce62 100644 --- a/drivers/gpu/drm/drm_pro

[ANNOUNCE] libdrm 2.4.77

2017-04-04 Thread Marek Olšák
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bernd Kuhls (1): tests/etnaviv: link against libdrm Christian Gmeiner (1): etnaviv: remove struct etna_specs Emil Velikov (2): amdgpu: add amdgpu_bo_va_op_raw to the symbol check configure.ac: bring back pthread-stubs check

Re: [PATCH 1/2] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2017-04-04 Thread Daniel Stone
Hi, On 1 April 2017 at 19:47, Rob Clark wrote: > On Tue, Dec 20, 2016 at 7:12 PM, Kristian H. Kristensen > wrote: >> This new ioctl exctends DRM_IOCTL_MODE_GETPLANE, by returning >> information about the modifiers that will work with each format. > > So, just to toss out a completely different i

Re: [PATCH 1/2] drm: Add DRM_CAP_PRIME_SCANOUT.

2017-04-04 Thread Daniel Stone
Hi, On 4 April 2017 at 09:31, Daniel Vetter wrote: > On Tue, Apr 04, 2017 at 06:13:20PM +1000, r...@ubuntu.com wrote: >> Until recently, on (at least) nouveau, radeon, and amdgpu attempting to >> scanout of an >> imported dma-buf would silently result in the dma-buf sharing being broken. >> >> W

Re: [PATCH 1/2] drm: Add DRM_CAP_PRIME_SCANOUT.

2017-04-04 Thread Christopher James Halse Rogers
On 4 April 2017 6:31:12 pm AEST, Daniel Vetter wrote: >On Tue, Apr 04, 2017 at 06:13:20PM +1000, r...@ubuntu.com wrote: >> From: Christopher James Halse Rogers >> >> Until recently, on (at least) nouveau, radeon, and amdgpu attempting >to scanout of an >> imported dma-buf would silently result i

Re: [PATCH 1/2] drm: Add DRM_CAP_PRIME_SCANOUT.

2017-04-04 Thread Lucas Stach
Am Dienstag, den 04.04.2017, 20:27 +1000 schrieb Christopher James Halse Rogers: > On 4 April 2017 6:31:12 pm AEST, Daniel Vetter wrote: > >On Tue, Apr 04, 2017 at 06:13:20PM +1000, r...@ubuntu.com wrote: > >> From: Christopher James Halse Rogers > >> > >> Until recently, on (at least) nouveau,

Re: [PATCH 1/2] drm: Add DRM_CAP_PRIME_SCANOUT.

2017-04-04 Thread Daniel Stone
Hi, On 4 April 2017 at 11:27, Christopher James Halse Rogers wrote: > On 4 April 2017 6:31:12 pm AEST, Daniel Vetter wrote: >>This seems like an awful specific special case. Why can't you do the >>entire dance upfront, i.e. import buffer, addfb2? None of that has any >>visible effect, and it wil

Re: [PATCH 08/15] drm/i915: Nuke intel_atomic_legacy_gamma_set

2017-04-04 Thread Maarten Lankhorst
Op 03-04-17 om 10:32 schreef Daniel Vetter: > We do set DRIVER_ATOMIC now. > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/intel_display.c | 44 > +--- > 1 file changed, 1 insertion(+), 43 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_disp

[PATCH] drm/atomic: Acquire connection_mutex lock in drm_helper_probe_single_connector_modes, v2.

2017-04-04 Thread Maarten Lankhorst
mode_valid() called from drm_helper_probe_single_connector_modes() may need to look at connector->state because what a valid mode is may depend on connector properties being set. For example some HDMI modes might be rejected when a connector property forces the connector into DVI mode. Some implem

Re: [PATCH 8/8] amdgpu: use sync file for shared semaphores (v2)

2017-04-04 Thread Christian König
Am 04.04.2017 um 10:10 schrieb Daniel Vetter: On Tue, Apr 04, 2017 at 09:40:57AM +0200, Christian König wrote: Am 04.04.2017 um 06:27 schrieb Dave Airlie: From: Dave Airlie This creates a new interface for amdgpu with ioctls to create/destroy/import and export shared semaphores using sem obje

Re: [PATCH 1/2] drm: Add DRM_CAP_PRIME_SCANOUT.

2017-04-04 Thread Christian König
Am 04.04.2017 um 12:43 schrieb Daniel Stone: Hi, On 4 April 2017 at 11:27, Christopher James Halse Rogers wrote: On 4 April 2017 6:31:12 pm AEST, Daniel Vetter wrote: This seems like an awful specific special case. Why can't you do the entire dance upfront, i.e. import buffer, addfb2? None o

Re: [PATCH 6/6] drm/amdgpu: handle CPU access for split VRAM buffers

2017-04-04 Thread Christian König
Am 03.04.2017 um 18:25 schrieb Nicolai Hähnle: On 31.03.2017 11:47, Christian König wrote: From: Christian König [SNIP] mem->bus.offset = mem->start << PAGE_SHIFT; /* check if it's visible */ if ((mem->bus.offset + mem->bus.size) > adev->mc.visible_vram_size) I bel

Re: [PATCH 1/2] drm: Add DRM_CAP_PRIME_SCANOUT.

2017-04-04 Thread Daniel Stone
Hi, On 4 April 2017 at 12:15, Christian König wrote: > Am 04.04.2017 um 12:43 schrieb Daniel Stone: >> Yeah, the ABI is that AddFB2 should fail hard on something which can >> never be used as a framebuffer. The fact it didn't is a bug rather >> than a behavioural change per se ... > > I agree on

Re: [PATCH 5/6] drm/amdgpu: use TTM_PL_FLAG_CONTIGUOUS

2017-04-04 Thread Christian König
Am 03.04.2017 um 18:22 schrieb Nicolai Hähnle: On 31.03.2017 11:47, Christian König wrote: From: Christian König Implement AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS using TTM_PL_FLAG_CONTIGUOUS instead of a placement limit. That allows us to better handle CPU accessible placements. Signed-off-by: Chr

Re: [PATCH 1/2] drm: Add DRM_CAP_PRIME_SCANOUT.

2017-04-04 Thread Christian König
Am 04.04.2017 um 13:32 schrieb Daniel Stone: Hi, On 4 April 2017 at 12:15, Christian König wrote: Am 04.04.2017 um 12:43 schrieb Daniel Stone: Yeah, the ABI is that AddFB2 should fail hard on something which can never be used as a framebuffer. The fact it didn't is a bug rather than a behavio

Re: [PATCH 5/8] sync_file: add support for a semaphore object

2017-04-04 Thread Chris Wilson
On Tue, Apr 04, 2017 at 02:27:30PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This object can be used to implement the Vulkan semaphores. > > The object behaviour differs from fence, in that you can > replace the underlying fence, and you cannot merge semaphores. > > Signed-off-by: Dave

Re: [PATCH 1/2] drm: Add DRM_CAP_PRIME_SCANOUT.

2017-04-04 Thread Daniel Vetter
On Tue, Apr 4, 2017 at 12:43 PM, Lucas Stach wrote: >> If I could guarantee that I'd only ever run on 4.13-or-later kernels >> (I think that's when the previous patches will land?), then this would >> indeed be mostly unnecessary. It would save me a bunch of addfb calls >> that would predictably f

Re: [PATCH v2 08/13] ARM64: dts: meson-gx: Add shared CMA dma memory pool

2017-04-04 Thread Kevin Hilman
Neil Armstrong writes: > On 03/21/2017 04:25 PM, Neil Armstrong wrote: >> The HDMI modes needs more CMA memory to be reserved at boot-time. >> >> Signed-off-by: Neil Armstrong [...] > Hi Kevin, > > Please take this one for the amlogic arm-soc DT tree. > Applied to v4.12/dt64, Kevin

Re: [PATCH v2 09/13] ARM64: dts: meson-gx: Add support for HDMI output

2017-04-04 Thread Kevin Hilman
Neil Armstrong writes: > On 03/21/2017 04:25 PM, Neil Armstrong wrote: >> Add HDMI output and connector nodes. >> >> Signed-off-by: Neil Armstrong [...] > > Hi Kevin, > > Please take this one for the amlogic arm-soc DT tree. > Applied to v4.12/dt64, Kevin ___

Re: [PATCH 5/8] sync_file: add support for a semaphore object

2017-04-04 Thread Chris Wilson
On Tue, Apr 04, 2017 at 12:52:32PM +0100, Chris Wilson wrote: > On Tue, Apr 04, 2017 at 02:27:30PM +1000, Dave Airlie wrote: > > +struct dma_fence *sync_file_replace_fence(struct sync_file *sync_file, > > + struct dma_fence *fence) > > +{ > > + struct dma_fence

[Bug 193651] Amdgpu error messages at boot with Amd RX460

2017-04-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=193651 --- Comment #21 from Steven A. Falco (stevenfa...@gmail.com) --- As I previously reported, building a custom kernel as suggested in comment 8 allows me to use my video card. I do continue to get the powerplay error messages, but aside from slowin

[PATCH v3 01/11] drm/meson: Use crtc_state for hdisplay and fix atomic flush/enable sync for vsync commit

2017-04-04 Thread Neil Armstrong
Clean the crtc_enable by using the proper crtc_state instead of the state of the primary plane state data. Also fix the dependency to commit the plane changes even if enable is called after the flush. Acked-by: Daniel Vetter Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_crtc.c

[PATCH v3 00/11] drm/meson: Initial support for HDMI Output

2017-04-04 Thread Neil Armstrong
The Amlogic GX SoCs implements a Synopsys DesignWare HDMI TX Controller in combination with a very custom PHY. This patchset depends on Laurent Pinchart patchset merged in drm-misc-next and my v6 patchset at [1] to permit PHY control from outside the dw-hdmi driver. The Synopsys DesignWare HDMI T

[PATCH v3 06/11] drm/meson: Add support for HDMI venc modes and settings

2017-04-04 Thread Neil Armstrong
This patch adds support for the supported HDMI Venc modes and add the VPP mux value to switch to ENCP encoder. Acked-by: Daniel Vetter Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_venc.c | 1245 +++- drivers/gpu/drm/meson/meson_venc.h |7 + d

[PATCH v3 02/11] drm/meson: Add missing HDMI register

2017-04-04 Thread Neil Armstrong
Add missing VPU HDMI register. Acked-by: Daniel Vetter Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_registers.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/meson/meson_registers.h b/drivers/gpu/drm/meson/meson_registers.h index 6adf9c1..2847381 100644 -

[PATCH v3 03/11] drm/meson: Add support for components

2017-04-04 Thread Neil Armstrong
This patch adds support for optional components connected through the Device Tree endpoints scheme. Acked-by: Daniel Vetter Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_drv.c | 113 +- 1 file changed, 99 insertions(+), 14 deletions(-) diff -

[PATCH v3 04/11] drm/meson: venc_cvbs: no more return -ENODEV if CVBS is not available

2017-04-04 Thread Neil Armstrong
Since this is managed now by the components code, if CVBS is not available and HDMI neither, the drm driver won't bind anyway. Acked-by: Daniel Vetter Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_venc_cvbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH v3 08/11] dt-bindings: Add bindings for the Amlogic Meson dw-hdmi extension

2017-04-04 Thread Neil Armstrong
This binding describes the Amlogic Meson specific extension to the Synopsys Designware HDMI Controller. Acked-by: Rob Herring Signed-off-by: Neil Armstrong --- .../bindings/display/amlogic,meson-dw-hdmi.txt | 111 + 1 file changed, 111 insertions(+) create mode 100644

[PATCH v3 07/11] drm/meson: Add support for HDMI encoder and DW-HDMI bridge + PHY

2017-04-04 Thread Neil Armstrong
The Amlogic Meson GXBB/GXL/GXM SoCs embeds a Synopsys DesignWare HDMI TX Controller with a custom Bridge + PHY around the Controller. This driver makes uses of all the custom PHY plat data callbacks and enables the compatible HDMI modes to be configured as a drm_encoder instance. Acked-by: Daniel

[PATCH v3 09/11] drm/meson: Convert existing documentation to actual kerneldoc

2017-04-04 Thread Neil Armstrong
Acked-by: Daniel Vetter Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_canvas.c | 4 +++- drivers/gpu/drm/meson/meson_drv.c | 5 +++-- drivers/gpu/drm/meson/meson_dw_hdmi.c | 25 + drivers/gpu/drm/meson/meson_vclk.c| 22 +++--- dr

[PATCH v3 05/11] drm/meson: add support for HDMI clock support

2017-04-04 Thread Neil Armstrong
This patchs adds support for the supported HDMI modes clocks frequencies. Acked-by: Daniel Vetter Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_vclk.c | 624 +++- drivers/gpu/drm/meson/meson_vclk.h | 6 +- drivers/gpu/drm/meson/meson_venc_

[PATCH v3 11/11] MAINTAINERS: update files for Amlogic DRM Driver

2017-04-04 Thread Neil Armstrong
This patch adds the dw-hdmi bindings and RST kerneldoc to maintained files. Acked-by: Daniel Vetter Signed-off-by: Neil Armstrong --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8d3eb6e..8471ff1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[PATCH v3 10/11] drm/meson: Add RST to bring together kerneldoc

2017-04-04 Thread Neil Armstrong
Acked-by: Daniel Vetter Signed-off-by: Neil Armstrong --- Documentation/gpu/index.rst | 1 + Documentation/gpu/meson.rst | 61 + 2 files changed, 62 insertions(+) create mode 100644 Documentation/gpu/meson.rst diff --git a/Documentation/gpu/index.rs

[PATCH v6.1 1/4] drm: bridge: dw-hdmi: Extract PHY interrupt setup to a function

2017-04-04 Thread Neil Armstrong
From: Laurent Pinchart In preparation for adding PHY operations to handle RX SENSE and HPD, group all the PHY interrupt setup code in a single location and extract it to a separate function. Signed-off-by: Laurent Pinchart Reviewed-by: Jose Abreu [narmstrong: renamed dw_hdmi_fb_registered to d

[PATCH v6.1 4/4] drm: bridge: dw-hdmi: Move HPD handling to PHY operations

2017-04-04 Thread Neil Armstrong
The HDMI TX controller support HPD and RXSENSE signaling from the PHY via it's STAT0 PHY interface, but some vendor PHYs can manage these signals independently from the controller, thus these STAT0 handling should be moved to PHY specific operations and become optional. The existing STAT0 HPD and

[PATCH v6.1 0/4] drm: bridge: dw-hdmi: Add support for Custom PHYs

2017-04-04 Thread Neil Armstrong
The Amlogic GX SoCs implements a Synopsys DesignWare HDMI TX Controller in combination with a very custom PHY. Thanks to Laurent Pinchart's changes, the HW report the following : Detected HDMI TX controller v2.01a with HDCP (meson_dw_hdmi_phy) The following differs from common PHY integration as

[PATCH v6.1 2/4] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

2017-04-04 Thread Neil Armstrong
Switch code to use the newly introduced V4L bus formats IDs instead of custom defines. Also use the V4L encoding defines. Some display pipelines can only provide non-RBG input pixels to the HDMI TX Controller, this patch takes the pixel format from the plat_data if provided. Reviewed-by: Jose Abr

[PATCH v6.1 3/4] drm: bridge: dw-hdmi: Add Documentation on supported input formats

2017-04-04 Thread Neil Armstrong
This patch adds a new DRM documentation entry and links to the input format table added in the dw_hdmi header. Reviewed-by: Archit Taneja Acked-by: Laurent Pinchart Signed-off-by: Neil Armstrong --- Documentation/gpu/bridge/dw-hdmi.rst | 15 +++ Documentation/gpu/index.rst

Re: imx-drm: vblank wait timed out

2017-04-04 Thread Christian Gmeiner
2017-04-04 10:14 GMT+02:00 Philipp Zabel : > Hi Christian, > > On Mon, 2017-04-03 at 17:16 +0200, Christian Gmeiner wrote: >> 2017-03-31 14:57 GMT+02:00 Philipp Zabel : >> > Hi Christian, >> > >> > On Fri, 2017-03-31 at 12:44 +0200, Christian Gmeiner wrote: >> >> Hi >> >> >> >> I get this from time

Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property

2017-04-04 Thread John Keeping
Hi Sean, On Sun, 12 Mar 2017 07:06:59 -0500, Rob Herring wrote: > On Fri, Mar 03, 2017 at 11:39:45AM +, John Keeping wrote: > > This reset is required in order to fully reset the internal state of the > > MIPI controller. > > > > Signed-off-by: John Keeping > > --- > > On Thu, 2 Mar 2017 13

[Bug 193651] Amdgpu error messages at boot with Amd RX460

2017-04-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=193651 --- Comment #22 from Christian Lanig (christian.la...@gmail.com) --- Thanks for clarification. That means building the Kernel was not a possible fix for the messages but for getting the driver to start with Tonga. So the AVFS- issue and missing/w

Re: [PATCH 4/4] drm: zte: add VGA driver support

2017-04-04 Thread Shawn Guo
On Mon, Apr 03, 2017 at 11:23:51AM +0200, Daniel Vetter wrote: > > +static int zx_vga_ddc_register(struct zx_vga *vga) > > +{ > > + struct device *dev = vga->dev; > > + struct i2c_adapter *adap; > > + struct zx_vga_i2c *ddc; > > + int ret; > > + > > + ddc = devm_kzalloc(dev, sizeof(*ddc),

Re: [PATCH v2 07/13] drm/meson: Add support for HDMI encoder and DW-HDMI bridge + PHY

2017-04-04 Thread Daniel Vetter
On Tue, Apr 04, 2017 at 11:16:23AM +0200, Neil Armstrong wrote: > On 04/04/2017 10:57 AM, Daniel Vetter wrote: > > On Tue, Mar 21, 2017 at 04:25:44PM +0100, Neil Armstrong wrote: > >> The Amlogic Meson GXBB/GXL/GXM SoCs embeds a Synopsys DesignWare HDMI TX > >> Controller with a custom Bridge + PHY

  1   2   >