Fix hardware accelerated video playback with amdgpu on 32Bit system

2017-03-29 Thread Jan Burgmeier
Hi, on 32Bit systems hardware accelerated video playback with amdgpu always errors out with the following message: "[drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* IB va_start+ib_bytes is invalid." Attached you find a patch witch fixes the problem. The patch was made against the staging-next bra

[PATCH v3 08/11] drm/sun4i: tcon: add support for V3s TCON

2017-03-29 Thread Icenowy Zheng
From: Icenowy Zheng Allwinner V3s SoC features a TCON without channel 1. Add support for it. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/sun4i/sun4i_drv.c | 3 ++- drivers/gpu/drm/sun4i/sun4i_tcon.c | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH v3 00/11] Initial Allwinner Display Engine 2.0 Support

2017-03-29 Thread Icenowy Zheng
This patchset is the initial patchset for Allwinner DE2 support. It contains the support of clocks in DE2 and the mixers in DE2. The SoC used to develop this patchset is V3s, as V3s is the simplest one of the SoCs that have DE2. (Allwinner V3s features only one mixer, although its clock control u

[PATCH v3 05/11] drm/sun4i: abstract a mixer type

2017-03-29 Thread Icenowy Zheng
As we are going to add support for the Allwinner DE2 mixer in sun4i-drm driver, we will finally have two types of display mixers -- the DE1 backend and the DE2 mixer. They both do some display blending and feed graphics data to TCON, so I choose to call them both "mixer" here. Abstract the mixer t

[PATCH v3 04/11] drm/sun4i: abstract the layer type

2017-03-29 Thread Icenowy Zheng
As we are going to add support for the Allwinner DE2 Mixer in sun4i-drm driver, we will finally have two types of layer. Abstract the layer type to void * and a ops struct, which contains the only function used by crtc -- get the drm_plane struct of the layer. Signed-off-by: Icenowy Zheng --- Re

RE: [pull] radeon drm-fixes-4.11

2017-03-29 Thread Panariti, David
Hi, I'm still new to this stuff. Is this informational or some action items? thanks, davep > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Alex Deucher > Sent: Wednesday, March 29, 2017 12:55 PM > To: amd-...@lists.freedesktop.org; dri-d

Re: [linux-sunxi] [PATCH v3 06/11] drm/sun4i: add support for Allwinner DE2 mixers

2017-03-29 Thread Jernej Škrabec
Hi, Dne sreda, 29. marec 2017 ob 21:46:08 CEST je Icenowy Zheng napisal(a): > Allwinner have a new "Display Engine 2.0" in their new SoCs, which comes > with mixers to do graphic processing and feed data to TCON, like the old > backends and frontends. > > Add support for the mixer on Allwinner V3

[PATCH v3 07/11] drm/sun4i: Add compatible string for V3s display engine

2017-03-29 Thread Icenowy Zheng
Allwinner V3s features the new "Display Engine 2.0", which can now also be driven with our subdrivers in sun4i-drm. Add the compatible string for in sun4i_drv.c, in order to make the display engine and its components probed. Signed-off-by: Icenowy Zheng --- Patch splited in v3. drivers/gpu/drm

Re: [PATCH] drm/rockchip: fix Kconfig dependencies

2017-03-29 Thread jeffy
Hi Arnd, Tested-by: Jeffy Chen Thanx for fixing this :) On 03/29/2017 12:37 AM, Guenter Roeck wrote: On Tue, Mar 28, 2017 at 3:16 AM, Arnd Bergmann wrote: A bug that I had fixed earlier just came back, with CONFIG_EXTCON=m, the rockchip drm driver will fail to link: drivers/gpu/drm/rockchi

[PATCH v3 03/11] dt-bindings: add bindings for DE2 on V3s SoC

2017-03-29 Thread Icenowy Zheng
From: Icenowy Zheng Allwinner V3s SoC have a display engine which have a different pipeline with older SoCs. Add document for it (new compatibles and the new "mixer" part). The paragraph of TCON is also refactored, for furtherly add TCONs in A83T/H3/A64/H5 that have only a channel 1 (used for H

[PATCH v3 11/11] [DO NOT MERGE] ARM: dts: sun8i: enable LCD panel of Lichee Pi Zero

2017-03-29 Thread Icenowy Zheng
From: Icenowy Zheng A 480x272 QiaoDian QD43003C0-40-7LED panel is available from Lichee Pi. This commit connects this panel to Lichee Pi Zero. Lichee Pi also provides a 800x480 panel without accurate model number, so do not merge this patch. It will finally come as device tree overlay. Signed-

Re: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property

2017-03-29 Thread Alexey Brodkin
Hi Liviu, Rob, On Fri, 2017-03-03 at 18:21 +, liviu.du...@arm.com wrote: > On Fri, Mar 03, 2017 at 05:48:19PM +, Alexey Brodkin wrote: > > > > Hi Liviu, > > > > On Fri, 2017-03-03 at 16:28 +, Liviu Dudau wrote: > > > > > > On Fri, Mar 03, 2017 at 06:19:24PM +0300, Alexey Brodkin wro

[PATCH] Fix IB va_start+ib_bytes range check on 32Bit systems

2017-03-29 Thread Jan Burgmeier
Signed-off-by: Jan Burgmeier --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index 99424cb8020b..583d22974e14 100644 --- a/drivers/gpu/drm/amd/amdgpu/

[PATCH v3 10/11] ARM: dts: sun8i: add pinmux for LCD pins of V3s SoC

2017-03-29 Thread Icenowy Zheng
From: Icenowy Zheng Allwinner V3s SoC features a set of pins that have functionality of RGB LCD, the pins are at different pin ban than other SoCs. Add pinctrl node for them. Signed-off-by: Icenowy Zheng --- arch/arm/boot/dts/sun8i-v3s.dtsi | 9 + 1 file changed, 9 insertions(+) diff

[PATCH v3 02/11] clk: sunxi-ng: add support for DE2 CCU

2017-03-29 Thread Icenowy Zheng
From: Icenowy Zheng The "Display Engine 2.0" in Allwinner newer SoCs contains a clock management unit for its subunits, like the DE CCU in A80. Add a sunxi-ng style driver for it. Signed-off-by: Icenowy Zheng --- Changes in v2: - Rename sunxi-de2-ccu to sun8i-de2-ccu. drivers/clk/sunxi-ng/Kc

linux-next: manual merge of the drm tree with the drm-intel-fixes tree

2017-03-29 Thread Stephen Rothwell
Hi Dave, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/i915/intel_lrc.c between commit: dd68f2ba0720 ("drm/i915/execlists: Wrap tail pointer after reset tweaking") from the drm-intel-fixes tree and commit: 944a36d472be ("drm/i915: Assert that the request->t

linux-next: manual merge of the drm tree with the drm-intel-fixes tree

2017-03-29 Thread Stephen Rothwell
Hi Dave, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/i915/intel_ringbuffer.h between commit: dd68f2ba0720 ("drm/i915/execlists: Wrap tail pointer after reset tweaking") from the drm-intel-fixes tree and commit: 73dec95e6ba3 ("drm/i915: Emit to ringbuffer

Re: [drm] 4e64e5539d [ 1138.272031] NMI watchdog: BUG: soft lockup - CPU#0 stuck for 23s! [swapper:1]

2017-03-29 Thread Gabriel Krisman Bertazi
Fengguang Wu writes: > Hi Chris, > >>+--+++---+---+ >>| | 17aad8a340 | 4e64e5539d | >>v4.11-rc3 | next-20170320 | >>+--+---

Re: [PATCH] Fix IB va_start+ib_bytes range check on 32Bit systems

2017-03-29 Thread Michel Dänzer
On 30/03/17 12:18 AM, Christian König wrote: > Am 29.03.2017 um 16:54 schrieb Michel Dänzer: >> On 29/03/17 10:22 PM, Christian König wrote: >>> Am 29.03.2017 um 11:18 schrieb Jan Burgmeier: Signed-off-by: Jan Burgmeier --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 +++-

Re: [ANNOUNCE] libdrm 2.4.76

2017-03-29 Thread Jani Nikula
On Wed, 29 Mar 2017, Marek Olšák wrote: > libdrm 2.4.76 has been released. > > git tag: libdrm-2.4.76 Should the release tags be signed? For a couple of years that has been the practise until this release. Admittedly RELEASING doesn't even say anything about tagging, let alone signing the tag. B

Re: [PATCH 1/6] drm/ttm: cleanup and optimize ttm_bo_mem_compat

2017-03-29 Thread Michel Dänzer
On 29/03/17 09:55 PM, Christian König wrote: > From: Christian König > > No need to implement the same logic twice. Also check if the busy placements > are identical to the already scanned placements before checking them. > > Signed-off-by: Christian König [...] > @@ -1077,6 +1065,23 @@ bool

Re: [PATCH 4/6] drm/amdgpu: drop alpha support

2017-03-29 Thread Michel Dänzer
On 29/03/17 09:55 PM, Christian König wrote: > From: Christian König > > We will probably never see this combination. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 25 - > 1 file changed, 25 deletions(-) > > diff --git a/drivers/g

Re: [PATCH 3/6] drm/ttm: add TTM_PL_FLAG_CONTIGUOUS

2017-03-29 Thread Michel Dänzer
On 29/03/17 09:55 PM, Christian König wrote: > From: Christian König > > This allows drivers to specify if they need a contiguous allocation or not. > > Signed-off-by: Christian König [...] > diff --git a/include/drm/ttm/ttm_placement.h b/include/drm/ttm/ttm_placement.h > index 932be0c..40f94

Re: [PATCH 2/6] drm/ttm: add io_mem_pfn callback

2017-03-29 Thread Michel Dänzer
On 29/03/17 09:55 PM, Christian König wrote: > From: Christian König > > This allows the driver to handle io_mem mappings on their own. > > Signed-off-by: Christian König Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software e

Re: CPU mapping of split VRAM buffers

2017-03-29 Thread Michel Dänzer
On 29/03/17 09:55 PM, Christian König wrote: > Hi guys, > > this set implements CPU mapping of split VRAM buffers and could > help with some performance issues regarding this. > > Please review and/or comment, Patches 5 & 6 look mostly good to me, but I don't fully understand all changes in ther

Re: [PATCHv3 06/30] drm/omap: Add support for render nodes

2017-03-29 Thread David Herrmann
Hey On Wed, Mar 29, 2017 at 11:42 PM, Laurent Pinchart wrote: > Hi David, > > On Wednesday 29 Mar 2017 14:51:48 David Herrmann wrote: >> On Wed, Mar 29, 2017 at 2:20 PM, Laurent Pinchart wrote: >> > On Wednesday 29 Mar 2017 11:58:23 Tomi Valkeinen wrote: >> >> On 29/03/17 11:22, Laurent Pinchart

Re: [PATCH] drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE

2017-03-29 Thread Jani Nikula
On Wed, 29 Mar 2017, Tobias Regnery wrote: > With CONFIG_ACPI=n and CONFIG_BACKLIGHT_CLASS_DEVICE=n we see the following > link error in the i915 driver: > > drivers/built-in.o: In function 'intel_backlight_device_register': > (.text+0x2a921d): undefined reference to 'backlight_device_register' >

Re: [PATCH] drm/atomic: Introduce drm_atomic_helper_shutdown

2017-03-29 Thread Tomi Valkeinen
On 28/03/17 17:22, Daniel Vetter wrote: >> This is a bit related to the other annoyance, which is that we don't >> reset properties when a DRM app quits. I think the state of the HW >> should be restored to exactly the same state as it was (including >> turning off the crtcs). I'm planning to have

Re: [PATCH 1/2] drm/sun4i: Add display backend interrupt to device tree binding

2017-03-29 Thread Maxime Ripard
On Mon, Mar 27, 2017 at 10:38:46PM +0800, Chen-Yu Tsai wrote: > The display backend has an interrupt line. Add it to the device tree > binding. > > Signed-off-by: Chen-Yu Tsai The patches prefix for the binding documentation is usually dt-bindings: I've changed that and applied that patch, than

Re: [PATCH 2/2] ARM: dts: sun5i: Add interrupt for display backend

2017-03-29 Thread Maxime Ripard
On Mon, Mar 27, 2017 at 10:38:47PM +0800, Chen-Yu Tsai wrote: > The display backend on sun5i shares the same interrupt line as the > display frontend. Add it. > > Signed-off-by: Chen-Yu Tsai And ideally, patches prefix shouldn't have dts here too. I've dropped it and applied, thanks! > This won

Re: [PATCH 4/6] drm/amd/amdgpu: Pin bos from imported dma-bufs to GTT.

2017-03-29 Thread Christian König
Am 29.03.2017 um 02:27 schrieb r...@ubuntu.com: From: Christopher James Halse Rogers Attempting to migrate the bo will break the sharing of the buffer. Signed-off-by: Christopher James Halse Rogers CC: amd-...@lists.freedesktop.org NAK on this one and the radeon version. We can't migrate

Re: [PATCH v2] drm/radeon: Fail fb creation from imported dma-bufs.

2017-03-29 Thread Christian König
Am 29.03.2017 um 06:00 schrieb r...@ubuntu.com: From: Christopher James Halse Rogers Any use of the framebuffer will migrate it to VRAM, which is not sensible for an imported dma-buf. v2: Use DRM_DEBUG_KMS to prevent userspace accidentally spamming dmesg. Signed-off-by: Christopher James Hals

CTM and other color related properties

2017-03-29 Thread Jyri Sarha
Referring to this discussion: https://patchwork.kernel.org/patch/9546905/ Since the discussion, has there been any planning/work been done about the CTM2 API? We would need for omap drm (for DSS5 and DSS6) a similar matrix API for two purposes. However, neither of them is an exact match to the CT

[PATCH] drm-misc: Next phase in small drivers in drm-misc

2017-03-29 Thread Daniel Vetter
I think the initial experiment worked fairly well, and the kickstarting of a review (well, ack/best practices really) market seems to work ok-ish too. I think we can try to make it (slowly) scale to more drivers, with driver teams interested in being part of drm-misc. I do think we need to be caref

Re: [PATCH] drm-misc: Next phase in small drivers in drm-misc

2017-03-29 Thread Boris Brezillon
On Wed, 29 Mar 2017 09:38:15 +0200 Daniel Vetter wrote: > I think the initial experiment worked fairly well, and the > kickstarting of a review (well, ack/best practices really) market > seems to work ok-ish too. I think we can try to make it (slowly) scale > to more drivers, with driver teams in

Re: [PATCH v4 0/6] drm/omap: Remove CONFIG_DRM_OMAP_NUM_CRTCS, cleanup & CTM

2017-03-29 Thread Tomi Valkeinen
On 24/03/17 16:47, Jyri Sarha wrote: > The first patch removes CONFIG_DRM_OMAP_NUM_CRTCS config option. The > patches number 2-4 gets rid of annoying name collision between dss > backend and omapdrm. The second last patch cleans up the unnecessary > complexity from omap_modeset_init(). And finally

Re: [PATCHv3 01/30] drm/omap: work-around for errata i886

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:07:47 Tomi Valkeinen wrote: > DRA7 errata i886 (FPDLink PLL Unlocks With Certain SoC PLL M/N Values) > says that FPDLink is sensitive to jitter on the vout clock, and that low > PLL M and N values result in more jitter than high M and N

Re: [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-29 Thread Daniel Vetter
On Mon, Mar 27, 2017 at 10:31:51AM +0200, Thomas Hellstrom wrote: > On 03/27/2017 08:28 AM, Daniel Vetter wrote: > > We discussed this quickly on irc, transcribing. > > > > On Mon, Mar 27, 2017 at 5:01 AM, Michel Dänzer wrote: > >> Strictly speaking, the (virtual) hardware is too limited to suppor

Re: [PATCHv3 02/30] drm/omap: refactor CRTC HW property setup

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:07:48 Tomi Valkeinen wrote: > The current driver doesn't expose any of the CRTC HW properties like > background color or transparency key, and sets them at CRTC enable time. > > Refactor this into a separate function and call that funct

[Bug 100443] DMESG: [powerplay] Can't find requested voltage id in vdd_dep_on_sclk table!

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100443 Bug ID: 100443 Summary: DMESG: [powerplay] Can't find requested voltage id in vdd_dep_on_sclk table! Product: DRI Version: unspecified Hardware: x86-64 (AMD64)

Re: [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-29 Thread Thomas Hellstrom
On 03/29/2017 10:00 AM, Daniel Vetter wrote: > On Mon, Mar 27, 2017 at 10:31:51AM +0200, Thomas Hellstrom wrote: >> On 03/27/2017 08:28 AM, Daniel Vetter wrote: >>> We discussed this quickly on irc, transcribing. >>> >>> On Mon, Mar 27, 2017 at 5:01 AM, Michel Dänzer wrote: Strictly speaking,

[Bug 100437] IO_PAGE_FAULT is spammed in dmesg

2017-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100437 Christian Lanig changed: What|Removed |Added Summary|IO_PAGE_FAULT is spammed in |IO_PAGE_FAULT is spammed in

Re: [CRTC:24] vblank wait timed out

2017-03-29 Thread Philipp Zabel
On Tue, 2017-03-28 at 18:52 +0100, Martyn Welch wrote: > On Tue, Mar 28, 2017 at 06:44:50PM +0200, Philipp Zabel wrote: [...] > > It is the ipu1_di0_pre_sel and ipu2_di0_pre_sel setup that is important > > here (and you have to pin LVDS and HDMI to separate IPUs). The LDB > > driver will switch th

Re: [PATCHv3 03/30] drm/omap: remove divider constraint from hsdiv

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:07:49 Tomi Valkeinen wrote: > The driver only uses even dividers for hsdiv when pclk >= 100MHz, as odd > dividers can create uneven duty cycle. However, while this holds true > for some dividers like DISPC's LCK and PCK dividers, it is n

Re: [PATCHv3 04/30] drm/omap: decrease min width & height

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:07:50 Tomi Valkeinen wrote: > mode_config's min_width and min_height are both set to 32, which is > overly restrictive. > > The real limits depend on whether we're configuring a crtc or a plane, > but a limit of 8x2 is safe for both cas

Re: [PATCHv3 02/30] drm/omap: refactor CRTC HW property setup

2017-03-29 Thread Tomi Valkeinen
On 29/03/17 11:05, Laurent Pinchart wrote: >> +static void omap_crtc_write_crtc_properties(struct drm_crtc *crtc) >> +{ >> +struct omap_crtc *omap_crtc = to_omap_crtc(crtc); >> +struct omap_overlay_manager_info info; >> + >> +memset(&info, 0, sizeof(info)); >> + >> +info.default_co

Re: [PATCHv3 05/30] drm/omap: improve DPI clock selection on DRA7xx

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:07:51 Tomi Valkeinen wrote: > The clock source selection for the LCD outputs is too hardcoded at the > moment. For example, LCD3 is set to use PLL2_1, and PLL2 doesn't exist > on DRA72x SoCs. > > There are quite many ways to configure t

Re: [CRTC:24] vblank wait timed out

2017-03-29 Thread Martyn Welch
On Wed, Mar 29, 2017 at 10:07:45AM +0200, Philipp Zabel wrote: > On Tue, 2017-03-28 at 18:52 +0100, Martyn Welch wrote: > > On Tue, Mar 28, 2017 at 06:44:50PM +0200, Philipp Zabel wrote: > [...] > > > It is the ipu1_di0_pre_sel and ipu2_di0_pre_sel setup that is important > > > here (and you have

Re: [PATCHv3 06/30] drm/omap: Add support for render nodes

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:07:52 Tomi Valkeinen wrote: > From: Hemant Hariyani > > Add support for render nodes in omap driver and allow required > ioctls to be accessible via render nodes. But the OMAP DSS doesn't perform rendering... This seems an abuse of re

Re: [PATCHv3 04/30] drm/omap: decrease min width & height

2017-03-29 Thread Tomi Valkeinen
On 29/03/17 11:13, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tuesday 28 Mar 2017 16:07:50 Tomi Valkeinen wrote: >> mode_config's min_width and min_height are both set to 32, which is >> overly restrictive. >> >> The real limits depend on whether we're configuring a cr

Re: [PATCHv3 04/30] drm/omap: decrease min width & height

2017-03-29 Thread Laurent Pinchart
On Wednesday 29 Mar 2017 11:23:00 Tomi Valkeinen wrote: > On 29/03/17 11:13, Laurent Pinchart wrote: > > Hi Tomi, > > > > Thank you for the patch. > > > > On Tuesday 28 Mar 2017 16:07:50 Tomi Valkeinen wrote: > >> mode_config's min_width and min_height are both set to 32, which is > >> overly res

Re: [PATCHv3 07/30] drm/omap: fix HDMI sync polarities

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:07:53 Tomi Valkeinen wrote: > While implementing writeback support, odd behavior of WBDELAYCOUNT was > observed with the combination of WB capture and HDMI. The result of the > debugging was that the HDMI sync polarities are not set corr

Re: [PATCH] drm-misc: Next phase in small drivers in drm-misc

2017-03-29 Thread Shawn Guo
On Wed, Mar 29, 2017 at 09:38:15AM +0200, Daniel Vetter wrote: > I think the initial experiment worked fairly well, and the > kickstarting of a review (well, ack/best practices really) market > seems to work ok-ish too. I think we can try to make it (slowly) scale > to more drivers, with driver tea

Re: [PATCHv3 04/30] drm/omap: decrease min width & height

2017-03-29 Thread Tomi Valkeinen
On 29/03/17 11:24, Laurent Pinchart wrote: > On Wednesday 29 Mar 2017 11:23:00 Tomi Valkeinen wrote: >> On 29/03/17 11:13, Laurent Pinchart wrote: >>> Hi Tomi, >>> >>> Thank you for the patch. >>> >>> On Tuesday 28 Mar 2017 16:07:50 Tomi Valkeinen wrote: mode_config's min_width and min_heigh

Re: [PATCHv3 04/30] drm/omap: decrease min width & height

2017-03-29 Thread Laurent Pinchart
Hi Tomi, On Wednesday 29 Mar 2017 11:26:45 Tomi Valkeinen wrote: > On 29/03/17 11:24, Laurent Pinchart wrote: > > On Wednesday 29 Mar 2017 11:23:00 Tomi Valkeinen wrote: > >> On 29/03/17 11:13, Laurent Pinchart wrote: > >>> On Tuesday 28 Mar 2017 16:07:50 Tomi Valkeinen wrote: > mode_config's

Re: [PATCHv3 10/30] drm/omap: output: use dev_err instead of DSSERR

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:07:56 Tomi Valkeinen wrote: > We don't have omapdss's custom error printing functions in the common > omapdss-base module, to which we want to move output.c. > > This patch changes output.c to use dev_err instead of DSSERR so that it >

Re: [PATCHv3 05/30] drm/omap: improve DPI clock selection on DRA7xx

2017-03-29 Thread Tomi Valkeinen
On 29/03/17 11:19, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tuesday 28 Mar 2017 16:07:51 Tomi Valkeinen wrote: >> The clock source selection for the LCD outputs is too hardcoded at the >> moment. For example, LCD3 is set to use PLL2_1, and PLL2 doesn't exist >> on DR

Re: [PATCHv3 30/30] drm/omap: fix crash on module unload

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:08:16 Tomi Valkeinen wrote: > When unloading omapdrm we get a NULL pointer deref in > omap_drm_irq_uninstall(). This is caused by: > > 967dd48417874dd25491a4e933648f394a64f70f ("drm: remove > drm_vblank_no_hw_counter assignment from dri

[Bug 88861] [efi, i915, vgaswitcheroo, black screen, nouveau] Screen goes black when switching from dedicated nvidia graphics card (nouveau) to integrated

2017-03-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=88861 Jani Nikula (jani.nik...@intel.com) changed: What|Removed |Added Component|Video(DRI - Intel) |Video(Other) -- You

Re: [PATCHv3 04/30] drm/omap: decrease min width & height

2017-03-29 Thread Tomi Valkeinen
On 29/03/17 11:30, Laurent Pinchart wrote: > The mode setting min/max width and height are used by the core when creating > a > framebuffer to validate its size. It's thus only related to planes, not to > the > CRTC. It's also set to drm_mode_card_res, and fb's min & max are not necessarily t

Re: [PATCH 2/6] drm/nouveau: Pin bos from imported dma-bufs to GTT.

2017-03-29 Thread Maarten Lankhorst
Op 29-03-17 om 02:27 schreef r...@ubuntu.com: > From: Christopher James Halse Rogers > > Attempting to migrate the bo will break the sharing of the buffer. > > Signed-off-by: Christopher James Halse Rogers > > CC: nouv...@lists.freedesktop.org > --- > drivers/gpu/drm/nouveau/nouveau_prime.c | 2

Re: [PATCH 1/6] drm/nouveau: Fail fb creation from imported dma-bufs.

2017-03-29 Thread Maarten Lankhorst
Op 29-03-17 om 02:27 schreef r...@ubuntu.com: > From: Christopher James Halse Rogers > > Any use of the framebuffer will migrate it to VRAM, which is not sensible for > an imported dma-buf. > > Signed-off-by: Christopher James Halse Rogers > > CC: nouv...@lists.freedesktop.org > --- > drivers/g

Re: [RFC PATCHv2 02/21] cma: Introduce cma_for_each_area

2017-03-29 Thread Benjamin Gaignard
2017-03-18 1:54 GMT+01:00 Laura Abbott : > > Frameworks (e.g. Ion) may want to iterate over each possible CMA area to > allow for enumeration. Introduce a function to allow a callback. even outside ION rework that could be useful Reviewed-by: Benjamin Gaignard > > Signed-off-by: Laura Abbott >

Re: [PATCHv3 29/30] drm/omap: use drm_atomic_helper_shutdown()

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:08:15 Tomi Valkeinen wrote: > Use drm_atomic_helper_shutdown() to ensure that all crtcs are disabled > when unloading the driver. > > Signed-off-by: Tomi Valkeinen > Cc: Daniel Vetter > > --- > drivers/gpu/drm/omapdrm/omap_drv.c | 2

Re: [PATCHv3 28/30] drm/omap: fix display SYNC/DE flags

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:08:14 Tomi Valkeinen wrote: > At the moment VSYNC/HSYNC/DE high/low flags set by the panel/encoder > drivers get lost when the videotimings are translated to DRM's > videomode, as DRM's mode does not have corresponding flags. > > DRM ha

Re: [PATCHv3 06/30] drm/omap: Add support for render nodes

2017-03-29 Thread Tomi Valkeinen
On 29/03/17 11:22, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tuesday 28 Mar 2017 16:07:52 Tomi Valkeinen wrote: >> From: Hemant Hariyani >> >> Add support for render nodes in omap driver and allow required >> ioctls to be accessible via render nodes. > > But the OMA

Re: [PATCH] Revert "drm/radeon: Try evicting from CPU accessible to inaccessible VRAM first"

2017-03-29 Thread Michel Dänzer
On 28/03/17 08:00 PM, Julien Isorce wrote: > > On 28 March 2017 at 10:36, Michel Dänzer > wrote: > > On 28/03/17 05:24 PM, Julien Isorce wrote: > > Hi Michel, > > > > About the hard lockup, I noticed that I cannot have it with the > > following cond

Re: [PATCHv3 27/30] drm/omap: dispc: improve debug print of display flags

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:08:13 Tomi Valkeinen wrote: > Instead of printing 0/1 for display flags like vsync high/low, use a > tri-state print (-1/0/1) to indicate the "undefined" state. Even better would be to use high/low/unknown (or H/L/U or any similar set o

Re: [RFC PATCHv2 00/21] Ion clean in preparation for moving out of staging

2017-03-29 Thread Benjamin Gaignard
2017-03-18 1:54 GMT+01:00 Laura Abbott : > > Hi, > > This is v2 of the series to do some serious Ion clean up in preparation for > moving out of staging. I got good feedback last time so this series mostly > attempts to address that feedback and do more still more cleanup. Highlights: > > - All cal

Re: [PATCHv3 29/30] drm/omap: use drm_atomic_helper_shutdown()

2017-03-29 Thread Tomi Valkeinen
On 29/03/17 11:49, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tuesday 28 Mar 2017 16:08:15 Tomi Valkeinen wrote: >> Use drm_atomic_helper_shutdown() to ensure that all crtcs are disabled >> when unloading the driver. >> >> Signed-off-by: Tomi Valkeinen >> Cc: Daniel V

Re: [PATCH 4/6] drm/amd/amdgpu: Pin bos from imported dma-bufs to GTT.

2017-03-29 Thread Michel Dänzer
On 29/03/17 04:14 PM, Christian König wrote: > Am 29.03.2017 um 02:27 schrieb r...@ubuntu.com: >> From: Christopher James Halse Rogers >> >> >> Attempting to migrate the bo will break the sharing of the buffer. >> >> Signed-off-by: Christopher James Halse Rogers >> >> CC: amd-...@lists.freedeskto

Re: [PATCH] Revert "drm/radeon: Try evicting from CPU accessible to inaccessible VRAM first"

2017-03-29 Thread Christian König
Am 29.03.2017 um 10:59 schrieb Michel Dänzer: On 28/03/17 08:00 PM, Julien Isorce wrote: On 28 March 2017 at 10:36, Michel Dänzer mailto:mic...@daenzer.net>> wrote: On 28/03/17 05:24 PM, Julien Isorce wrote: > Hi Michel, > > About the hard lockup, I noticed that I cannot hav

Re: [PATCHv3 29/30] drm/omap: use drm_atomic_helper_shutdown()

2017-03-29 Thread Laurent Pinchart
Hi Tomi, On Wednesday 29 Mar 2017 12:08:19 Tomi Valkeinen wrote: > On 29/03/17 11:49, Laurent Pinchart wrote: > > On Tuesday 28 Mar 2017 16:08:15 Tomi Valkeinen wrote: > >> Use drm_atomic_helper_shutdown() to ensure that all crtcs are disabled > >> when unloading the driver. > >> > >> Signed-off-

[PATCH] drm/mm: Split up long running selftests with cond_resched()

2017-03-29 Thread Chris Wilson
Scatter a few cond_resched() in between phases of the drm_mm selftests to try and prevent us incurring the wrath of the NMI watchdog. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen --- drivers/gpu/drm/selftests/test-drm_mm.c | 28 1 file changed, 28 insertions(+)

Re: [PATCHv3 26/30] drm/omap: displays: panel-dpi: Support for handling backlight devices

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:08:12 Tomi Valkeinen wrote: > From: Peter Ujfalusi > > The associated backlight device can be configured via DT by providing the > phandle to the device. > > If the backlight device is configured, the driver can manage the backligt >

Re: [PATCH 4/6] drm/amd/amdgpu: Pin bos from imported dma-bufs to GTT.

2017-03-29 Thread Christian König
Am 29.03.2017 um 11:07 schrieb Michel Dänzer: On 29/03/17 04:14 PM, Christian König wrote: Am 29.03.2017 um 02:27 schrieb r...@ubuntu.com: From: Christopher James Halse Rogers Attempting to migrate the bo will break the sharing of the buffer. Signed-off-by: Christopher James Halse Rogers CC

Re: CTM and other color related properties

2017-03-29 Thread Ville Syrjälä
On Wed, Mar 29, 2017 at 10:23:54AM +0300, Jyri Sarha wrote: > Referring to this discussion: > https://patchwork.kernel.org/patch/9546905/ > > Since the discussion, has there been any planning/work been done about > the CTM2 API? > > We would need for omap drm (for DSS5 and DSS6) a similar matrix

Re: [PATCHv3 29/30] drm/omap: use drm_atomic_helper_shutdown()

2017-03-29 Thread Tomi Valkeinen
On 29/03/17 12:11, Laurent Pinchart wrote: >> The hw is disabled before drm_atomic_helper_shutdown() is called only if >> you have fbdev. And fbdev on all the connectors. If that's not the case, >> we need drm_atomic_helper_shutdown() to disable the hw. > > But if you have no fbdev, as userspace

Re: [PATCHv3 25/30] drm/omap: poll only connectors where the connect/disconnect can be checked

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:08:11 Tomi Valkeinen wrote: > From: Peter Ujfalusi > > When the connector associated detect callback is not provided, we can not > detect if the display is connected or disconnected. These displays does not s/does/do/ > support hot p

Re: [PATCH] Revert "drm/radeon: Try evicting from CPU accessible to inaccessible VRAM first"

2017-03-29 Thread Michel Dänzer
On 29/03/17 06:07 PM, Christian König wrote: > Am 29.03.2017 um 10:59 schrieb Michel Dänzer: >> On 28/03/17 08:00 PM, Julien Isorce wrote: >>> On 28 March 2017 at 10:36, Michel Dänzer >> > wrote: >>> >>> On 28/03/17 05:24 PM, Julien Isorce wrote: >>> > Hi Michel

Re: [PATCHv3 24/30] drm/omap: display: Add displays in sorted order to the panel_list

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:08:10 Tomi Valkeinen wrote: > From: Peter Ujfalusi > > Keep the panel_list ordered according to aliases. The DRM connectors will > be created following the panel_list. By keeping the list ordered the DRM > connectors will be created in

Re: [PATCHv3 28/30] drm/omap: fix display SYNC/DE flags

2017-03-29 Thread Tomi Valkeinen
On 29/03/17 11:58, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tuesday 28 Mar 2017 16:08:14 Tomi Valkeinen wrote: >> At the moment VSYNC/HSYNC/DE high/low flags set by the panel/encoder >> drivers get lost when the videotimings are translated to DRM's >> videomode, as D

[PATCH] drm/atomic: Acquire connection_mutex lock in drm_helper_probe_single_connector_modes.

2017-03-29 Thread Maarten Lankhorst
mode_valid() and get_modes() called from drm_helper_probe_single_connector_modes() may need to look at connector->state because what a valid mode is may depend on connector properties being set. For example some HDMI modes might be rejected when a connector property forces the connector into DVI mo

Re: [PATCHv3 27/30] drm/omap: dispc: improve debug print of display flags

2017-03-29 Thread Tomi Valkeinen
On 29/03/17 12:00, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tuesday 28 Mar 2017 16:08:13 Tomi Valkeinen wrote: >> Instead of printing 0/1 for display flags like vsync high/low, use a >> tri-state print (-1/0/1) to indicate the "undefined" state. > > Even better woul

Re: [PATCHv3 23/30] drm/omap: fix plane update warning when crtc is disabled

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:08:09 Tomi Valkeinen wrote: > If omap_plane_atomic_update() is called when the crtc is disabled, and > the timings are zero, we'll see the following warning: > > omapdss DISPC error: cannot calculate scaling settings: pclk is zero > oma

[PULL] drm-intel-fixes

2017-03-29 Thread Jani Nikula
Hi Dave, i915 fixes for -rc5, mostly gvt. BR, Jani. The following changes since commit c02ed2e75ef4c74e41e421acb4ef1494671585e8: Linux 4.11-rc4 (2017-03-26 14:15:16 -0700) are available in the git repository at: git://anongit.freedesktop.org/git/drm-intel tags/drm-intel-fixes-2017-03-29

Re: [PATCH v2] drm: Make the decision to keep vblank irq enabled earlier

2017-03-29 Thread Ville Syrjälä
On Fri, Mar 24, 2017 at 05:30:58PM +, Chris Wilson wrote: > We want to provide the vblank irq shadow for pageflip events as well as > vblank queries. Such events are completed within the vblank interrupt > handler, and so the current check for disabling the irq will disable it > from with the s

Re: [PATCH v2] drm: Refactor vblank sequence number comparison

2017-03-29 Thread Ville Syrjälä
On Thu, Mar 23, 2017 at 12:23:34PM +0900, Michel Dänzer wrote: > On 22/03/17 07:06 PM, Chris Wilson wrote: > > Move the repeated (a - b) <= (1 << 23) to its own function. > > > > v2: Catch the '1<<23' inside drm_handle_vblank() as well > > > > Signed-off-by: Chris Wilson > > Reviewed-by: Michel

Re: [PATCHv3 19/30] drm/omap: fix replication logic

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:08:05 Tomi Valkeinen wrote: > DSS uses "replication logic" to convert color components from smaller > bit widths to bigger bit widths. Without replication logic, the color > component would be shifted and the least significant bits would

Re: [PATCHv3 18/30] drm/omap: remove unused dispc_wb_enable & dispc_wb_is_enabled

2017-03-29 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:08:04 Tomi Valkeinen wrote: > Remove two unused WB functions. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/dss/dispc.c | 10 -- > drivers/gpu/drm/omapdrm/dss/dss.h | 2 -

Re: [PATCH v2 1/2] drm/exynos: mixer: simplify mixer_cfg_rgb_fmt()

2017-03-29 Thread Tobias Jakobi
Hello Daniel, I'm not getting any response from the Exynos DRM maintainer concerning this patch. Since this is just a simple cleanup, and Andrzej has already review, could you perhaps merge it through drm-misc? With best wishes, Tobias Tobias Jakobi wrote: > Convert if-statements to switch sta

Re: [PATCH v3] drm/exynos: mixer: document YCbCr magic numbers

2017-03-29 Thread Tobias Jakobi
Hello Daniel, same question here. Patch doesn't introduce any functional changes (just adds code documentation), so can you merge it through drm-misc? With best wishes, Tobias Tobias Jakobi wrote: > The output stage of the mixer uses YCbCr for the internal > computations, which is the reason th

<    1   2