[PATCH v15 1/3] drm: rockchip: Add basic drm driver

2016-03-17 Thread Tomeu Vizoso
On 16 March 2016 at 16:23, Tomeu Vizoso wrote: > On 15 March 2016 at 02:30, Mark yao wrote: >> On 2016年03月14日 21:35, Tomeu Vizoso wrote: >>> >>> On 2 December 2014 at 10:15, Mark Yao wrote: diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/r

[PATCH v15 1/3] drm: rockchip: Add basic drm driver

2016-03-16 Thread Tomeu Vizoso
On 15 March 2016 at 02:30, Mark yao wrote: > On 2016年03月14日 21:35, Tomeu Vizoso wrote: >> >> On 2 December 2014 at 10:15, Mark Yao wrote: >>> >>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >>> b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >>> new file mode 100644 >>> index 000

[PATCH v15 1/3] drm: rockchip: Add basic drm driver

2016-03-15 Thread Mark yao
On 2016年03月14日 21:35, Tomeu Vizoso wrote: > On 2 December 2014 at 10:15, Mark Yao wrote: >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> new file mode 100644 >> index 000..e7ca25b >> --- /dev/null >> +++ b/drivers/gpu/drm/r

[PATCH v15 1/3] drm: rockchip: Add basic drm driver

2016-03-14 Thread Tomeu Vizoso
On 2 December 2014 at 10:15, Mark Yao wrote: > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > new file mode 100644 > index 000..e7ca25b > --- /dev/null > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -0,0 +1,1455 @@ ... > +s

drm: rockchip: Add basic drm driver

2014-12-17 Thread Dan Carpenter
On Wed, Dec 17, 2014 at 08:56:25AM +0800, Mark yao wrote: > Hello Dan, > > Thanks for your review, I will fix it soon. > Do you use a script to find out these issues? I was interested in > this script. > Can you teach me how to find this script and use it? The first one is a smatch warning. http

drm: rockchip: Add basic drm driver

2014-12-17 Thread Mark yao
The patch 2048e3286f34: "drm: rockchip: Add basic drm driver" from > Aug 22, 2014, leads to the following static checker warning: > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1383 vop_bind() > warn: unsigned 'vop->irq' is never less than zero. > > dri

drm: rockchip: Add basic drm driver

2014-12-16 Thread Dan Carpenter
Hello Mark Yao, The patch 2048e3286f34: "drm: rockchip: Add basic drm driver" from Aug 22, 2014, leads to the following static checker warning: drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1383 vop_bind() warn: unsigned 'vop->irq' is never less than zero. d

[PATCH v15 1/3] drm: rockchip: Add basic drm driver

2014-12-02 Thread Mark Yao
This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark Yao Signed-off-by: Daniel Kurtz Acked-by: Daniel Vetter Reviewed-by: Rob Clark --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices have been probed. -

[PATCH v14 1/3] drm: rockchip: Add basic drm driver

2014-11-20 Thread Mark Yao
This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark Yao Signed-off-by: Daniel Kurtz Acked-by: Daniel Vetter Reviewed-by: Rob Clark --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices have been probed. -

[PATCH v12 1/3] drm: rockchip: Add basic drm driver

2014-11-19 Thread Daniel Vetter
On Wed, Nov 19, 2014 at 10:04:13AM +0100, Boris Brezillon wrote: > AFAIU, the suggestion was to split drm_connector_init and > drm_connector_register calls: > - drm_connector_init call should still be part of the load procedure >(this function adds the connector to the connector list which is

[PATCH v12 1/3] drm: rockchip: Add basic drm driver

2014-11-19 Thread Boris Brezillon
On Wed, 19 Nov 2014 10:02:53 +0800 Mark yao wrote: > On 2014年11月19日 09:09, Mark yao wrote: > > On 2014年11月18日 22:24, Daniel Vetter wrote: > >> On Tue, Nov 18, 2014 at 02:21:30PM +0100, Boris Brezillon wrote: > >>> Hi Daniel, > >>> > >>> On Tue, 18 Nov 2014 09:32:34 +0100 > >>> Daniel

[PATCH v12 1/3] drm: rockchip: Add basic drm driver

2014-11-19 Thread Mark yao
On 2014年11月19日 09:09, Mark yao wrote: > On 2014年11月18日 22:24, Daniel Vetter wrote: >> On Tue, Nov 18, 2014 at 02:21:30PM +0100, Boris Brezillon wrote: >>> Hi Daniel, >>> >>> On Tue, 18 Nov 2014 09:32:34 +0100 >>> Daniel Vetter wrote: >>> On Tue, Nov 18, 2014 at 04:00:29PM +0800, M

[PATCH v12 1/3] drm: rockchip: Add basic drm driver

2014-11-19 Thread Mark yao
On 2014年11月18日 22:24, Daniel Vetter wrote: > On Tue, Nov 18, 2014 at 02:21:30PM +0100, Boris Brezillon wrote: >> Hi Daniel, >> >> On Tue, 18 Nov 2014 09:32:34 +0100 >> Daniel Vetter wrote: >> >>> On Tue, Nov 18, 2014 at 04:00:29PM +0800, Mark Yao wrote: From: Mark yao This pa

[PATCH v13 1/3] drm: rockchip: Add basic drm driver

2014-11-18 Thread Mark Yao
This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark Yao Signed-off-by: Daniel Kurtz Acked-by: Daniel Vetter Reviewed-by: Rob Clark --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices have been probed. -

[PATCH v12 1/3] drm: rockchip: Add basic drm driver

2014-11-18 Thread Mark yao
On 2014年11月18日 16:32, Daniel Vetter wrote: > On Tue, Nov 18, 2014 at 04:00:29PM +0800, Mark Yao wrote: >> From: Mark yao >> >> This patch adds the basic structure of a DRM Driver for Rockchip Socs. >> >> Signed-off-by: Mark Yao >> Signed-off-by: Daniel Kurtz >> Acked-by: Daniel Vetter >>

[PATCH v12 1/3] drm: rockchip: Add basic drm driver

2014-11-18 Thread Mark Yao
From: Mark yao This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark Yao Signed-off-by: Daniel Kurtz Acked-by: Daniel Vetter Reviewed-by: Rob Clark --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices hav

[PATCH v12 1/3] drm: rockchip: Add basic drm driver

2014-11-18 Thread Daniel Vetter
On Tue, Nov 18, 2014 at 02:21:30PM +0100, Boris Brezillon wrote: > Hi Daniel, > > On Tue, 18 Nov 2014 09:32:34 +0100 > Daniel Vetter wrote: > > > On Tue, Nov 18, 2014 at 04:00:29PM +0800, Mark Yao wrote: > > > From: Mark yao > > > > > > This patch adds the basic structure of a DRM Driver for R

[PATCH v12 1/3] drm: rockchip: Add basic drm driver

2014-11-18 Thread Boris Brezillon
Hi Daniel, On Tue, 18 Nov 2014 09:32:34 +0100 Daniel Vetter wrote: > On Tue, Nov 18, 2014 at 04:00:29PM +0800, Mark Yao wrote: > > From: Mark yao > > > > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > > > Signed-off-by: Mark Yao > > Signed-off-by: Daniel Kurtz >

[PATCH v12 1/3] drm: rockchip: Add basic drm driver

2014-11-18 Thread Daniel Vetter
On Tue, Nov 18, 2014 at 04:00:29PM +0800, Mark Yao wrote: > From: Mark yao > > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark Yao > Signed-off-by: Daniel Kurtz > Acked-by: Daniel Vetter > Reviewed-by: Rob Clark > --- > Changes in v2: > - use th

[PATCH v11 1/3] drm: rockchip: Add basic drm driver

2014-10-08 Thread Mark Yao
From: Mark yao This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark Yao Signed-off-by: Daniel Kurtz Acked-by: Daniel Vetter Reviewed-by: Rob Clark --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices hav

[PATCH v10 1/3] drm: rockchip: Add basic drm driver

2014-10-08 Thread Mark yao
On 2014?10?08? 12:23, Mark Yao wrote: > From: Mark yao > > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark Yao > Signed-off-by: Daniel Kurtz > Acked-by: Daniel Vetter > Reviewed-by: Rob Clark > --- > Changes in v2: > - use the component framework

[PATCH v9 1/3] drm: rockchip: Add basic drm driver

2014-10-08 Thread Steven Newbury
On Wed, 2014-10-08 at 09:17 +0800, Mark yao wrote: > Hi Steven > I'm glad to see you to discuss about rk29xx. > > On 2014?10?08? 06:26, Steven Newbury wrote: > > I've just been discussing how this relates to rk29xx on #etnaviv. > > I > > looked through the patch and it's good to see it's no

[PATCH v10 1/3] drm: rockchip: Add basic drm driver

2014-10-08 Thread Mark Yao
From: Mark yao This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark Yao Signed-off-by: Daniel Kurtz Acked-by: Daniel Vetter Reviewed-by: Rob Clark --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices hav

[PATCH v9 1/3] drm: rockchip: Add basic drm driver

2014-10-08 Thread Mark yao
Hi Steven I'm glad to see you to discuss about rk29xx. On 2014?10?08? 06:26, Steven Newbury wrote: > I've just been discussing how this relates to rk29xx on #etnaviv. I > looked through the patch and it's good to see it's not limited to > supporting Mali GPUs. I see no reason this wouldn't

[PATCH v9 1/3] drm: rockchip: Add basic drm driver

2014-10-07 Thread Steven Newbury
I've just been discussing how this relates to rk29xx on #etnaviv. I looked through the patch and it's good to see it's not limited to supporting Mali GPUs. I see no reason this wouldn't be compatible with etna_viv for rk29xx (or future Rockchip designs with alternative GPUs) as long as the re

[PATCH v9 1/3] drm: rockchip: Add basic drm driver

2014-10-07 Thread Mark yao
On 2014?09?30? 21:31, Andrzej Hajda wrote: > Hi Mark, Hi Andrzej, Sorry for replying late, I have a vacation before. Thanks for your review. > On 09/30/2014 03:03 PM, Mark Yao wrote: >> From: Mark yao >> >> This patch adds the basic structure of a DRM Driver for Rockchip Socs. >> >> Sign

[PATCH v9 1/3] drm: rockchip: Add basic drm driver

2014-10-07 Thread Andrzej Hajda
On 10/07/2014 05:56 AM, Mark yao wrote: > On 2014?09?30? 21:31, Andrzej Hajda wrote: >> Hi Mark, > Hi Andrzej, > Sorry for replying late, I have a vacation before. > Thanks for your review. >> On 09/30/2014 03:03 PM, Mark Yao wrote: >>> From: Mark yao >>> (...) >>> +#ifdef CONFIG_PM_SLEEP

[PATCH v9 1/3] drm: rockchip: Add basic drm driver

2014-09-30 Thread Mark Yao
From: Mark yao This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark Yao Signed-off-by: Daniel Kurtz Acked-by: Daniel Vetter Reviewed-by: Rob Clark --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices hav

[PATCH v9 1/3] drm: rockchip: Add basic drm driver

2014-09-30 Thread Andrzej Hajda
Hi Mark, On 09/30/2014 03:03 PM, Mark Yao wrote: > From: Mark yao > > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark Yao > Signed-off-by: Daniel Kurtz > Acked-by: Daniel Vetter > Reviewed-by: Rob Clark > --- > Changes in v2: > - use the compon

[PATCH v8 1/3] drm: rockchip: Add basic drm driver

2014-09-30 Thread Mark Yao
From: Mark yao This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark Yao Signed-off-by: Daniel Kurtz Acked-by: Daniel Vetter Reviewed-by: Rob Clark --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices hav

[RESENT PATCH v7 1/3] drm: rockchip: Add basic drm driver

2014-09-30 Thread Mark yao
On 2014?09?29? 12:01, Daniel Kurtz wrote: > Hi Mark, > > More review comments inline... (sorry for the delay) Thanks for your review. > > On Fri, Sep 26, 2014 at 6:55 PM, Mark Yao wrote: >> From: Mark yao >> >> This patch adds the basic structure of a DRM Driver for Rockchip Socs. >> >> Signed-of

[RESENT PATCH v7 1/3] drm: rockchip: Add basic drm driver

2014-09-29 Thread Daniel Kurtz
Hi Mark, More review comments inline... (sorry for the delay) On Fri, Sep 26, 2014 at 6:55 PM, Mark Yao wrote: > From: Mark yao > > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark Yao > Signed-off-by: Daniel Kurtz > Acked-by: Daniel Vetter > Re

[RESENT PATCH v7 1/3] drm: rockchip: Add basic drm driver

2014-09-26 Thread Mark Yao
From: Mark yao This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark Yao Signed-off-by: Daniel Kurtz Acked-by: Daniel Vetter Reviewed-by: Rob Clark --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices hav

[PATCH 1/3] drm/rockchip: Add basic drm driver

2014-09-26 Thread Mark yao
This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark yao Signed-off-by: Daniel Kurtz Acked-by: Daniel Vetter Reviewed-by: Rob Clark --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices have been probed. -

[PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-26 Thread Mark yao
On 2014?09?25? 20:11, Mark yao wrote: > On 2014?09?25? 16:58, Mark yao wrote: >> On 2014?09?25? 00:20, Daniel Kurtz wrote: >>> Hi Mark, >>> >>> Please review comments inline... >>> >>> On Wed, Sep 24, 2014 at 10:12 AM, Mark yao >>> wrote: >>> To match the enum name, use ROCKCHIP_OUTPUT_TYPE_*. >>

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-25 Thread Daniel Vetter
On Thu, Sep 25, 2014 at 2:54 AM, Mark yao wrote: > Hi, Daniel > this version is old, newest is v5. and I remove uapi at v5. > you can see v5 patch at: > https://lkml.org/lkml/2014/9/23/1061 > thanks > > This version doesn't seem to be cc'ed to dri-devel, at least it didn't > yet show up. Can you p

[PATCH v6 1/3] drm/rockchip: Add basic drm driver

2014-09-25 Thread Mark yao
This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark yao --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices have been probed. - use dma-mapping API with ARM_DMA_USE_IOMMU, create dma mapping by master dev

[PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-25 Thread Mark yao
On 2014?09?25? 16:58, Mark yao wrote: > On 2014?09?25? 00:20, Daniel Kurtz wrote: >> Hi Mark, >> >> Please review comments inline... >> >> On Wed, Sep 24, 2014 at 10:12 AM, Mark yao >> wrote: >> To match the enum name, use ROCKCHIP_OUTPUT_TYPE_*. >> Also, no need to explicitly set the first one t

[PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-25 Thread Rob Clark
On Tue, Sep 23, 2014 at 10:12 PM, Mark yao wrote: > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark yao Looks like my comments are addressed, so: Reviewed-by: Rob Clark > --- > Changes in v2: > - use the component framework to defer main drm driv

[PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-25 Thread Mark yao
On 2014?09?25? 00:20, Daniel Kurtz wrote: > Hi Mark, > > Please review comments inline... > > On Wed, Sep 24, 2014 at 10:12 AM, Mark yao wrote: >> This patch adds the basic structure of a DRM Driver for Rockchip Socs. >> >> Signed-off-by: Mark yao >> --- >> Changes in v2: >> - use the component f

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-25 Thread Mark yao
On 2014?09?24? 19:20, Daniel Vetter wrote: > On Wed, Sep 24, 2014 at 11:31 AM, Mark yao wrote: >> On 2014?09?24? 16:20, Daniel Vetter wrote: >>> On Mon, Sep 22, 2014 at 06:48:54PM +0800, Mark yao wrote: This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-of

[PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-25 Thread Daniel Kurtz
Hi Mark, Please review comments inline... On Wed, Sep 24, 2014 at 10:12 AM, Mark yao wrote: > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark yao > --- > Changes in v2: > - use the component framework to defer main drm driver probe > until all VO

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-24 Thread Mark yao
On 2014?09?24? 16:20, Daniel Vetter wrote: > On Mon, Sep 22, 2014 at 06:48:54PM +0800, Mark yao wrote: >> This patch adds the basic structure of a DRM Driver for Rockchip Socs. >> >> Signed-off-by: Mark yao >> --- >> Changes in v2: >> - use the component framework to defer main drm driver probe >>

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-24 Thread Daniel Vetter
On Wed, Sep 24, 2014 at 11:31 AM, Mark yao wrote: > On 2014?09?24? 16:20, Daniel Vetter wrote: >> >> On Mon, Sep 22, 2014 at 06:48:54PM +0800, Mark yao wrote: >>> >>> This patch adds the basic structure of a DRM Driver for Rockchip Socs. >>> >>> Signed-off-by: Mark yao >>> --- >>> Changes in v2:

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-24 Thread Daniel Vetter
On Mon, Sep 22, 2014 at 06:48:54PM +0800, Mark yao wrote: > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark yao > --- > Changes in v2: > - use the component framework to defer main drm driver probe > until all VOP devices have been probed. > - use

[PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-24 Thread Mark yao
This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark yao --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices have been probed. - use dma-mapping API with ARM_DMA_USE_IOMMU, create dma mapping by master dev

[PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-23 Thread Mark yao
On 2014?09?23? 15:48, Daniel Vetter wrote: > On Mon, Sep 22, 2014 at 09:32:19AM +0800, Mark yao wrote: >> On 2014?09?20? 08:03, Rob Clark wrote: >>> On Fri, Sep 19, 2014 at 1:47 AM, Mark yao >>> wrote: diff --git a/include/uapi/drm/rockchip_drm.h b/include/uapi/drm/rockchip_drm.h

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-23 Thread Mark yao
On 2014?09?22? 23:54, Arnd Bergmann wrote: > On Monday 22 September 2014 17:15:06 Boris BREZILLON wrote: + + /* TODO(djkurtz): fetch the mapping start/size from somewhere */ + mapping = arm_iommu_create_mapping(&platform_bus_type, 0x1000, +

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-23 Thread Mark yao
On 2014?09?22? 22:43, Arnd Bergmann wrote: > On Monday 22 September 2014 18:48:54 Mark yao wrote: >> diff --git a/drivers/gpu/drm/rockchip/Kconfig >> b/drivers/gpu/drm/rockchip/Kconfig >> new file mode 100644 >> index 000..7146c80 >> --- /dev/null >> +++ b/drivers/gpu/drm/rockchip/Kconfig >> @

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-23 Thread Mark yao
On 2014?09?23? 03:10, Rob Clark wrote: > Ok, couple more small comments.. this time I actually had time to go > through the entire patch, not just the uapi > > > On Mon, Sep 22, 2014 at 6:48 AM, Mark yao wrote: >> This patch adds the basic structure of a DRM Driver for Rockchip Socs. >> >> Signed-

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-23 Thread Mark yao
On 2014?09?22? 21:24, Boris BREZILLON wrote: > Hi Mark, > > You'll find some comments inline. > Anyway, I wouldn't call it a review (your driver is using some concepts > I'm not used to, like IOMMUs) but rather a collection of nitpicks :-). > > I haven't been through the whole driver yet, but I'll

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-23 Thread Arnd Bergmann
On Tuesday 23 September 2014 15:09:37 Mark yao wrote: > On 2014?09?22? 23:54, Arnd Bergmann wrote: > > On Monday 22 September 2014 17:15:06 Boris BREZILLON wrote: > + > + /* TODO(djkurtz): fetch the mapping start/size from somewhere */ > + mapping = arm_iommu_create_mapping(&plat

[PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-23 Thread Daniel Vetter
On Mon, Sep 22, 2014 at 09:32:19AM +0800, Mark yao wrote: > On 2014?09?20? 08:03, Rob Clark wrote: > >On Fri, Sep 19, 2014 at 1:47 AM, Mark yao wrote: > >>diff --git a/include/uapi/drm/rockchip_drm.h > >>b/include/uapi/drm/rockchip_drm.h > >>new file mode 100644 > >>index 000..8f8e60e > >>---

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-22 Thread Mark yao
This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark yao --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices have been probed. - use dma-mapping API with ARM_DMA_USE_IOMMU, create dma mapping by master dev

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-22 Thread Arnd Bergmann
On Monday 22 September 2014 17:15:06 Boris BREZILLON wrote: > > > + > > > + /* TODO(djkurtz): fetch the mapping start/size from somewhere */ > > > + mapping = arm_iommu_create_mapping(&platform_bus_type, 0x1000, > > > + SZ_1G); > > > + if (IS_ERR(mappi

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-22 Thread Boris BREZILLON
On Mon, 22 Sep 2014 16:43:31 +0200 Arnd Bergmann wrote: > On Monday 22 September 2014 18:48:54 Mark yao wrote: > > diff --git a/drivers/gpu/drm/rockchip/Kconfig > > b/drivers/gpu/drm/rockchip/Kconfig > > new file mode 100644 > > index 000..7146c80 > > --- /dev/null > > +++ b/drivers/gpu/drm/

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-22 Thread Arnd Bergmann
On Monday 22 September 2014 18:48:54 Mark yao wrote: > diff --git a/drivers/gpu/drm/rockchip/Kconfig > b/drivers/gpu/drm/rockchip/Kconfig > new file mode 100644 > index 000..7146c80 > --- /dev/null > +++ b/drivers/gpu/drm/rockchip/Kconfig > @@ -0,0 +1,19 @@ > +config DRM_ROCKCHIP > + trist

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-22 Thread Boris BREZILLON
Hi Mark, You'll find some comments inline. Anyway, I wouldn't call it a review (your driver is using some concepts I'm not used to, like IOMMUs) but rather a collection of nitpicks :-). I haven't been through the whole driver yet, but I'll get back to it soon ;-). And remember this is a 2 way th

[PATCH v4 1/5] drm/rockchip: Add basic drm driver

2014-09-22 Thread Rob Clark
Ok, couple more small comments.. this time I actually had time to go through the entire patch, not just the uapi On Mon, Sep 22, 2014 at 6:48 AM, Mark yao wrote: > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark yao > --- > Changes in v2: > - use t

[PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-22 Thread Mark yao
On 2014?09?20? 08:03, Rob Clark wrote: > On Fri, Sep 19, 2014 at 1:47 AM, Mark yao wrote: >> diff --git a/include/uapi/drm/rockchip_drm.h >> b/include/uapi/drm/rockchip_drm.h >> new file mode 100644 >> index 000..8f8e60e >> --- /dev/null >> +++ b/include/uapi/drm/rockchip_drm.h >> @@ -0,0 +1,

[PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-22 Thread Mark yao
On 2014?09?19? 21:04, David Herrmann wrote: > Hi > > On Fri, Sep 19, 2014 at 7:47 AM, Mark yao wrote: > [snip] >> +static int rockchip_drm_bind(struct device *dev) >> +{ >> + return drm_platform_init(&rockchip_drm_driver, >> to_platform_device(dev)); > Please avoid drm_platform_*() usage. W

[PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-19 Thread Rob Clark
On Fri, Sep 19, 2014 at 1:47 AM, Mark yao wrote: > diff --git a/include/uapi/drm/rockchip_drm.h b/include/uapi/drm/rockchip_drm.h > new file mode 100644 > index 000..8f8e60e > --- /dev/null > +++ b/include/uapi/drm/rockchip_drm.h > @@ -0,0 +1,97 @@ > +/* > + * > + * Copyright (c) Fuzhou Rockch

[PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-19 Thread David Herrmann
Hi On Fri, Sep 19, 2014 at 7:47 AM, Mark yao wrote: [snip] > +static int rockchip_drm_bind(struct device *dev) > +{ > + return drm_platform_init(&rockchip_drm_driver, > to_platform_device(dev)); Please avoid drm_platform_*() usage. We're about to drop all the drm_bus midlayers. See the te

[PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-19 Thread Mark yao
This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark yao --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices have been probed. - use dma-mapping API with ARM_DMA_USE_IOMMU, create dma mapping by master dev

[PATCH v2 1/5] drm/rockchip: Add basic drm driver

2014-09-19 Thread yaozq
On 2014?09?18? 22:53, Daniel Vetter wrote: > On Thu, Sep 18, 2014 at 04:52:14PM +0200, Daniel Vetter wrote: >> On Thu, Sep 18, 2014 at 05:36:31PM +0800, Mark yao wrote: >>> This patch adds the basic structure of a DRM Driver for Rockchip Socs. >>> >>> Signed-off-by: Mark yao >>> --- >>> Changes in

[PATCH v2 1/5] drm/rockchip: Add basic drm driver

2014-09-18 Thread Mark yao
This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark yao --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices have been probed. - use dma-mapping API with ARM_DMA_USE_IOMMU, create dma mapping by master dev

[PATCH v2 1/5] drm/rockchip: Add basic drm driver

2014-09-18 Thread Daniel Vetter
On Thu, Sep 18, 2014 at 04:52:14PM +0200, Daniel Vetter wrote: > On Thu, Sep 18, 2014 at 05:36:31PM +0800, Mark yao wrote: > > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > > > Signed-off-by: Mark yao > > --- > > Changes in v2: > > - use the component framework to def

[PATCH v2 1/5] drm/rockchip: Add basic drm driver

2014-09-18 Thread Daniel Vetter
On Thu, Sep 18, 2014 at 05:36:31PM +0800, Mark yao wrote: > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark yao > --- > Changes in v2: > - use the component framework to defer main drm driver probe > until all VOP devices have been probed. > - use