From: Markus Elfring
Date: Wed, 1 Nov 2017 15:57:31 +0100
* Add a jump target so that a bit of exception handling can be better
reused at the end of this function.
* Increase the scope for the variable "ret".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elf
Hi Jani,
On Monday, 30 October 2017 11:52:07 EET Jani Nikula wrote:
> On Sun, 29 Oct 2017, Laurent Pinchart wrote:
> > On Friday, 27 October 2017 21:45:17 EET Jani Nikula wrote:
> >> On Tue, 24 Oct 2017, SF Markus Elfring wrote:
> >>> Add a jump target so that a bit of exception handling can be be
> In general, I'll pick up any patches that are good,
This is usual.
> but the current track record is that Markus' patches need extra scrutiny,
I find that this can be fine according to a safe review for presented
update suggestions.
> and many of the patches contain subjective changes that
On Sun, 29 Oct 2017, Laurent Pinchart wrote:
> Hi Jani,
>
> On Friday, 27 October 2017 21:45:17 EET Jani Nikula wrote:
>> On Tue, 24 Oct 2017, SF Markus Elfring wrote:
>> > Add a jump target so that a bit of exception handling can be better reused
>> > at the end of this function.
>> >
>> > This
> Just for the record, I've been bitten in the past by applying one of Markus'
> patches that seemed to make sense, only to discover later that it introduced
> a
> security hole.
How do you think about to take another look at the circumstances
under which a questionable commit happened in the r
Hi Jani,
On Friday, 27 October 2017 21:45:17 EET Jani Nikula wrote:
> On Tue, 24 Oct 2017, SF Markus Elfring wrote:
> > Add a jump target so that a bit of exception handling can be better reused
> > at the end of this function.
> >
> > This issue was detected by using the Coccinelle software.
>
On Fri, Oct 27, 2017 at 8:45 PM, Jani Nikula
wrote:
> On Tue, 24 Oct 2017, SF Markus Elfring wrote:
>> Add a jump target so that a bit of exception handling can be better reused
>> at the end of this function.
>>
>> This issue was detected by using the Coccinelle software.
>
> Please also look in
On Tue, 24 Oct 2017, SF Markus Elfring wrote:
> Add a jump target so that a bit of exception handling can be better reused
> at the end of this function.
>
> This issue was detected by using the Coccinelle software.
Please also look into the GCC software, which will detect that your
patch does no
Hi Markus,
[auto build test ERROR on drm/drm-next]
[also build test ERROR on v4.14-rc6 next-20171018]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/SF-Markus-Elfring/R-Car-Display-Unit-Fine-tun
This is a subtle thing but my preference on this type of thing is the
way the original code is written. I'm still slightly annoyed that
someone once made me rewrite a patch using the new style... But anyways
I guess other people sometimes disagree with me.
Unwinding is for when you allocate five
From: Markus Elfring
Date: Tue, 24 Oct 2017 17:16:09 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/rcar-du/rcar_du_kms.c
11 matches
Mail list logo
