[PATCH 07/12] drm/amdgpu: implement cgs gpu memory callbacks

2015-09-30 Thread Christian König
On 30.09.2015 08:54, Daniel Vetter wrote: > On Tue, Sep 29, 2015 at 04:28:13PM -0400, Alex Deucher wrote: >> On Tue, Sep 29, 2015 at 4:10 PM, Dave Airlie wrote: >>> On 30 September 2015 at 01:41, Alex Deucher >>> wrote: On Tue, Sep 29, 2015 at 11:20 AM, Daniel Vetter wrote: > On Tue, S

[PATCH 07/12] drm/amdgpu: implement cgs gpu memory callbacks

2015-09-30 Thread Daniel Vetter
On Tue, Sep 29, 2015 at 11:41:56AM -0400, Alex Deucher wrote: > On Tue, Sep 29, 2015 at 11:20 AM, Daniel Vetter wrote: > > On Tue, Sep 29, 2015 at 02:39:49PM +0200, Christian König wrote: > >> On 29.09.2015 13:40, Daniel Vetter wrote: > >> >On Thu, Jul 09, 2015 at 12:21:06PM -0400, Alex Deucher w

[PATCH 07/12] drm/amdgpu: implement cgs gpu memory callbacks

2015-09-30 Thread Daniel Vetter
On Tue, Sep 29, 2015 at 04:28:13PM -0400, Alex Deucher wrote: > On Tue, Sep 29, 2015 at 4:10 PM, Dave Airlie wrote: > > On 30 September 2015 at 01:41, Alex Deucher > > wrote: > >> On Tue, Sep 29, 2015 at 11:20 AM, Daniel Vetter wrote: > >>> On Tue, Sep 29, 2015 at 02:39:49PM +0200, Christian KÃ

[PATCH 07/12] drm/amdgpu: implement cgs gpu memory callbacks

2015-09-30 Thread Daniel Vetter
On Wed, Sep 30, 2015 at 06:10:52AM +1000, Dave Airlie wrote: > On 30 September 2015 at 01:41, Alex Deucher wrote: > > On Tue, Sep 29, 2015 at 11:20 AM, Daniel Vetter wrote: > >> On Tue, Sep 29, 2015 at 02:39:49PM +0200, Christian König wrote: > >>> On 29.09.2015 13:40, Daniel Vetter wrote: > >>>

[PATCH 07/12] drm/amdgpu: implement cgs gpu memory callbacks

2015-09-30 Thread Dave Airlie
On 30 September 2015 at 01:41, Alex Deucher wrote: > On Tue, Sep 29, 2015 at 11:20 AM, Daniel Vetter wrote: >> On Tue, Sep 29, 2015 at 02:39:49PM +0200, Christian König wrote: >>> On 29.09.2015 13:40, Daniel Vetter wrote: >>> >On Thu, Jul 09, 2015 at 12:21:06PM -0400, Alex Deucher wrote: >>> >>F

[PATCH 07/12] drm/amdgpu: implement cgs gpu memory callbacks

2015-09-29 Thread Daniel Vetter
On Tue, Sep 29, 2015 at 02:39:49PM +0200, Christian König wrote: > On 29.09.2015 13:40, Daniel Vetter wrote: > >On Thu, Jul 09, 2015 at 12:21:06PM -0400, Alex Deucher wrote: > >>From: Chunming Zhou > >> > >>This implements the cgs interface for allocating > >>GPU memory. > >> > >>Reviewed-by: Jam

[PATCH 07/12] drm/amdgpu: implement cgs gpu memory callbacks

2015-09-29 Thread Alex Deucher
On Tue, Sep 29, 2015 at 4:10 PM, Dave Airlie wrote: > On 30 September 2015 at 01:41, Alex Deucher wrote: >> On Tue, Sep 29, 2015 at 11:20 AM, Daniel Vetter wrote: >>> On Tue, Sep 29, 2015 at 02:39:49PM +0200, Christian König wrote: On 29.09.2015 13:40, Daniel Vetter wrote: >On Thu, Ju

[PATCH 07/12] drm/amdgpu: implement cgs gpu memory callbacks

2015-09-29 Thread Christian König
On 29.09.2015 13:40, Daniel Vetter wrote: > On Thu, Jul 09, 2015 at 12:21:06PM -0400, Alex Deucher wrote: >> From: Chunming Zhou >> >> This implements the cgs interface for allocating >> GPU memory. >> >> Reviewed-by: Jammy Zhou > I don't see that review anywhere on a m-l ... where is it? Jammy

[PATCH 07/12] drm/amdgpu: implement cgs gpu memory callbacks

2015-09-29 Thread Daniel Vetter
On Thu, Jul 09, 2015 at 12:21:06PM -0400, Alex Deucher wrote: > From: Chunming Zhou > > This implements the cgs interface for allocating > GPU memory. > > Reviewed-by: Jammy Zhou I don't see that review anywhere on a m-l ... where is it? I stumbled over this patch because it adds a new dev->s

[PATCH 07/12] drm/amdgpu: implement cgs gpu memory callbacks

2015-09-29 Thread Alex Deucher
On Tue, Sep 29, 2015 at 11:20 AM, Daniel Vetter wrote: > On Tue, Sep 29, 2015 at 02:39:49PM +0200, Christian König wrote: >> On 29.09.2015 13:40, Daniel Vetter wrote: >> >On Thu, Jul 09, 2015 at 12:21:06PM -0400, Alex Deucher wrote: >> >>From: Chunming Zhou >> >> >> >>This implements the cgs int

drm/amdgpu: implement cgs gpu memory callbacks

2015-08-25 Thread Dan Carpenter
On Tue, Aug 25, 2015 at 02:07:21AM +, Zhou, David(ChunMing) wrote: > >and can the shift actually > > wrap? > [DZ] of course, adding shift wrap is better. fpfn/lpfn is page number, so > <

drm/amdgpu: implement cgs gpu memory callbacks

2015-08-25 Thread Zhou, David(ChunMing)
> -Original Message- > From: Dan Carpenter [mailto:dan.carpenter at oracle.com] > Sent: Tuesday, August 25, 2015 1:51 PM > To: Zhou, David(ChunMing) > Cc: dri-devel at lists.freedesktop.org > Subject: Re: drm/amdgpu: implement cgs gpu memory callbacks > > On Tu

drm/amdgpu: implement cgs gpu memory callbacks

2015-08-25 Thread Zhou, David(ChunMing)
Inline...[DZ] > -Original Message- > From: Dan Carpenter [mailto:dan.carpenter at oracle.com] > Sent: Tuesday, August 25, 2015 3:51 AM > To: Zhou, David(ChunMing) > Cc: dri-devel at lists.freedesktop.org > Subject: Re: drm/amdgpu: implement cgs gpu memory callbacks &

drm/amdgpu: implement cgs gpu memory callbacks

2015-08-24 Thread Dan Carpenter
On Mon, Aug 24, 2015 at 07:09:15AM +, Zhou, David(ChunMing) wrote: > Hi Dan, > Thanks for figuring out that. > >274 min_offset = obj->placements[0].fpfn << PAGE_SHIFT; > >275 max_offset = obj->placements[0].lpfn << PAGE_SHIFT; > Maybe should be: > min_offset = o

drm/amdgpu: implement cgs gpu memory callbacks

2015-08-24 Thread Zhou, David(ChunMing)
> Cc: dri-devel at lists.freedesktop.org > Subject: re: drm/amdgpu: implement cgs gpu memory callbacks > > Hello Chunming Zhou, > > The patch 57ff96cf471a: "drm/amdgpu: implement cgs gpu memory callbacks" > from Apr 24, 2015, leads to the following static checker > w

drm/amdgpu: implement cgs gpu memory callbacks

2015-08-21 Thread Dan Carpenter
Hello Chunming Zhou, The patch 57ff96cf471a: "drm/amdgpu: implement cgs gpu memory callbacks" from Apr 24, 2015, leads to the following static checker warning: drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:274 amdgpu_cgs_gmap_gpu_mem() warn: should 'obj->placements[0]

[PATCH 07/12] drm/amdgpu: implement cgs gpu memory callbacks

2015-07-09 Thread Alex Deucher
From: Chunming Zhou This implements the cgs interface for allocating GPU memory. Reviewed-by: Jammy Zhou Signed-off-by: Chunming Zhou Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 238 ++-- 1 file changed, 226 insertions(+), 12 deletion