On Wed, Sep 30, 2015 at 06:10:52AM +1000, Dave Airlie wrote: > On 30 September 2015 at 01:41, Alex Deucher <alexdeucher at gmail.com> wrote: > > On Tue, Sep 29, 2015 at 11:20 AM, Daniel Vetter <daniel at ffwll.ch> wrote: > >> On Tue, Sep 29, 2015 at 02:39:49PM +0200, Christian König wrote: > >>> On 29.09.2015 13:40, Daniel Vetter wrote: > >>> >On Thu, Jul 09, 2015 at 12:21:06PM -0400, Alex Deucher wrote: > >>> >>From: Chunming Zhou <david1.zhou at amd.com> > >>> >> > >>> >>This implements the cgs interface for allocating > >>> >>GPU memory. > >>> >> > >>> >>Reviewed-by: Jammy Zhou <Jammy.Zhou at amd.com> > >>> >I don't see that review anywhere on a m-l ... where is it? > >>> > >>> Jammy reviewed the stuff internally before we made it public, that's why > >>> you > >>> can't find it. > > Can we get these reviews done publically? it's kinda hard to know how > well someone > reviewed things if we have no external copy. Like did Jammy a) read > the patch, and > slap Reviewed-by on it, or did he b) comment on some whitespace issues > and slap R-b > on it, or c) did he suggest a bunch of changes and those changes were > made and a new > version was produced and he r-b'ed that etc.
Yeah review in public is great. We can do that for almost everythingn since nowadays we have blanket approval for everything, except a short list of marketing relevant new features on new platforms. Occasionally the public review with mails don't work out though and then we have a big meeting, but even for those we try to summarize what we discussed and decided on the m-l. But without blanket approval this won't work I think. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
