Re: [PATCH v2 1/7] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs

2021-10-22 Thread Laurent Pinchart
Hi Sam, On Fri, Oct 22, 2021 at 09:32:08PM +0200, Sam Ravnborg wrote: > On Fri, Oct 22, 2021 at 09:42:37PM +0300, Laurent Pinchart wrote: > > On Fri, Oct 22, 2021 at 07:13:58PM +0200, Sam Ravnborg wrote: > > > Hi Laurent, > > > > > > > From a quick look only cadence/cdns-mhdp8546 subclass > > > >

Re: [PATCH v2 1/7] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs

2021-10-22 Thread Sam Ravnborg
Hi Laurent, On Fri, Oct 22, 2021 at 09:42:37PM +0300, Laurent Pinchart wrote: > Hi Sam, > > On Fri, Oct 22, 2021 at 07:13:58PM +0200, Sam Ravnborg wrote: > > Hi Laurent, > > > > > From a quick look only cadence/cdns-mhdp8546 subclass > > > drm_bridge_state and I wonder if the right thing to do w

Re: [PATCH v2 1/7] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs

2021-10-22 Thread Laurent Pinchart
Hi Sam, On Fri, Oct 22, 2021 at 07:13:58PM +0200, Sam Ravnborg wrote: > Hi Laurent, > > > From a quick look only cadence/cdns-mhdp8546 subclass > > drm_bridge_state and I wonder if the right thing to do would be to > > implement fallback to the helpers if the bridge driver do not set > > any of t

Re: [PATCH v2 1/7] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs

2021-10-22 Thread Sam Ravnborg
Hi Laurent, > > >From a quick look only cadence/cdns-mhdp8546 subclass > drm_bridge_state and I wonder if the right thing to do would be to > implement fallback to the helpers if the bridge driver do not set > any of the .atomic_duplicate_state(), .atomic_destroy_state(), or > .atomic_reset(). >

Re: [PATCH v2 1/7] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs

2021-10-22 Thread Sam Ravnborg
Hi Laurent, > > @@ -508,8 +510,8 @@ static const struct drm_bridge_funcs > > ps8640_bridge_funcs = { > > .attach = ps8640_bridge_attach, > > .detach = ps8640_bridge_detach, > > .get_edid = ps8640_bridge_get_edid, > > - .post_disable = ps8640_post_disable, > > - .pre_enable = ps864

Re: [PATCH v2 1/7] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs

2021-10-22 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Wed, Oct 20, 2021 at 08:18:55PM +0200, Sam Ravnborg wrote: > The atomic variants of enable/disable in drm_bridge_funcs are the > preferred operations - introduce these. > > The ps8640 driver used the non-atomic variants of the > drm_bridge_chain_pre_enable/ >