Re: [PATCH v1 01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get

2022-09-08 Thread Linus Walleij
On Mon, Sep 5, 2022 at 8:31 AM Dmitry Torokhov wrote: > I would like to limit (or maybe even remove) use of > [devm_]gpiod_get_from_of_node in drivers so that gpiolib can be cleaned > a bit, so let's switch to the generic device property API. It may even > help with handling secondary fwnodes whe

Re: [PATCH v1 01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 09:19:02AM +0200, Pali Rohár wrote: > On Sunday 04 September 2022 23:30:53 Dmitry Torokhov wrote: > > I would like to limit (or maybe even remove) use of > > [devm_]gpiod_get_from_of_node in drivers so that gpiolib can be cleaned > > a bit, so let's switch to the generic dev

Re: [PATCH v1 01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get

2022-09-05 Thread Andy Shevchenko
On Mon, Sep 5, 2022 at 1:53 PM Pali Rohár wrote: > On Monday 05 September 2022 13:49:21 Andy Shevchenko wrote: ... > > It's not the same dev and its node in this case. There is one reset > > for _all_ ports, here is the reset on _per port_ basis. > > aardvark is single port controller. So it is

Re: [PATCH v1 01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get

2022-09-05 Thread Andy Shevchenko
On Mon, Sep 5, 2022 at 1:49 PM Andy Shevchenko wrote: > > On Mon, Sep 5, 2022 at 10:23 AM Pali Rohár wrote: > > On Sunday 04 September 2022 23:30:53 Dmitry Torokhov wrote: > > ... > > > > - rp->reset_gpio = devm_gpiod_get_from_of_node(dev, port, > > > -

Re: [PATCH v1 01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get

2022-09-05 Thread Pali Rohár
On Monday 05 September 2022 13:49:21 Andy Shevchenko wrote: > On Mon, Sep 5, 2022 at 10:23 AM Pali Rohár wrote: > > On Sunday 04 September 2022 23:30:53 Dmitry Torokhov wrote: > > ... > > > > - rp->reset_gpio = devm_gpiod_get_from_of_node(dev, port, > > > -

Re: [PATCH v1 01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get

2022-09-05 Thread Andy Shevchenko
On Mon, Sep 5, 2022 at 10:23 AM Pali Rohár wrote: > On Sunday 04 September 2022 23:30:53 Dmitry Torokhov wrote: ... > > - rp->reset_gpio = devm_gpiod_get_from_of_node(dev, port, > > - "reset-gpios", 0, > > -

Re: [PATCH v1 01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get

2022-09-05 Thread Pali Rohár
On Sunday 04 September 2022 23:30:53 Dmitry Torokhov wrote: > I would like to limit (or maybe even remove) use of > [devm_]gpiod_get_from_of_node in drivers so that gpiolib can be cleaned > a bit, so let's switch to the generic device property API. It may even > help with handling secondary fwnodes