Re: [PATCH] drm/writeback: Delete drm_writeback_cleanup_job

Hi Brian, On Thu, Feb 21, 2019 at 09:34:10AM +, Brian Starkey wrote: > On Thu, Feb 21, 2019 at 10:19:35AM +0200, Laurent Pinchart wrote: > > Hi Daniel, > > > > Thank you for the patch. > > > > On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote: > >> No implementation, no callers.

Re: [PATCH] drm/writeback: Delete drm_writeback_cleanup_job

Hi Daniel, On Thu, Feb 21, 2019 at 10:30:24AM +0100, Daniel Vetter wrote: > On Thu, Feb 21, 2019 at 9:19 AM Laurent Pinchart > wrote: > > Hi Daniel, > > > > Thank you for the patch. > > > > On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote: > >> No implementation, no callers. > > > >

Re: [PATCH] drm/writeback: Delete drm_writeback_cleanup_job

On Thu, Feb 21, 2019 at 10:19:35AM +0200, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote: > > No implementation, no callers. > > The issue here isn't that the function is declared, but that it's not > defined. J

Re: [PATCH] drm/writeback: Delete drm_writeback_cleanup_job

On Thu, Feb 21, 2019 at 9:19 AM Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote: > > No implementation, no callers. > > The issue here isn't that the function is declared, but that it's not > defined. Jobs are leak

Re: [PATCH] drm/writeback: Delete drm_writeback_cleanup_job

Hi Daniel, Thank you for the patch. On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote: > No implementation, no callers. The issue here isn't that the function is declared, but that it's not defined. Jobs are leaked when atomic commit fails (or when using test commits). I'm working on