On Thu, Feb 21, 2019 at 9:19 AM Laurent Pinchart <laurent.pinch...@ideasonboard.com> wrote: > Hi Daniel, > > Thank you for the patch. > > On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote: > > No implementation, no callers. > > The issue here isn't that the function is declared, but that it's not > defined. Jobs are leaked when atomic commit fails (or when using test > commits). I'm working on a fix, please don't apply this patch in the > meantime.
Hm, can't I merge this one and give you a clean slate? Function in header but nowhere else kinda upsets my ocd :-) -Daniel > > Cc: Brian Starkey <brian.star...@arm.com> > > Cc: Liviu Dudau <liviu.du...@arm.com> > > Cc: Eric Anholt <e...@anholt.net> > > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> > > --- > > include/drm/drm_writeback.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h > > index 23df9d463003..f34895f7fcb1 100644 > > --- a/include/drm/drm_writeback.h > > +++ b/include/drm/drm_writeback.h > > @@ -125,8 +125,6 @@ int drm_writeback_connector_init(struct drm_device *dev, > > void drm_writeback_queue_job(struct drm_writeback_connector *wb_connector, > > struct drm_writeback_job *job); > > > > -void drm_writeback_cleanup_job(struct drm_writeback_job *job); > > - > > void > > drm_writeback_signal_completion(struct drm_writeback_connector > > *wb_connector, > > int status); > > -- > Regards, > > Laurent Pinchart -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
