Re: [PATCH] drm/meson: fix resource cleanup in meson_drv_bind_master() on error

2025-05-04 Thread Martin Blumenstingl
On Tue, Apr 22, 2025 at 9:23 AM Neil Armstrong wrote: > > On 22/04/2025 09:04, neil.armstr...@linaro.org wrote: > > On 19/04/2025 23:32, Martin Blumenstingl wrote: > >> Hi Martijn, Hi Neil, > >> > >> On Thu, Apr 10, 2025 at 8:46 PM wrote: > >>> > >>> Hi Martin, > >>> > >>> Thank you for the patch

Re: [PATCH] drm/meson: fix resource cleanup in meson_drv_bind_master() on error

2025-04-22 Thread Neil Armstrong
On 22/04/2025 09:04, neil.armstr...@linaro.org wrote: On 19/04/2025 23:32, Martin Blumenstingl wrote: Hi Martijn, Hi Neil, On Thu, Apr 10, 2025 at 8:46 PM wrote: Hi Martin, Thank you for the patch. I encountered this issue some time ago as well and had a possible fix in my tree (see below

Re: [PATCH] drm/meson: fix resource cleanup in meson_drv_bind_master() on error

2025-04-22 Thread neil . armstrong
On 19/04/2025 23:32, Martin Blumenstingl wrote: Hi Martijn, Hi Neil, On Thu, Apr 10, 2025 at 8:46 PM wrote: Hi Martin, Thank you for the patch. I encountered this issue some time ago as well and had a possible fix in my tree (see below). My apologies for not upstreaming it earlier. No wor

Re: [PATCH] drm/meson: fix resource cleanup in meson_drv_bind_master() on error

2025-04-20 Thread Fedor Pchelkin
Martin Blumenstingl wrote: > @@ -360,6 +360,16 @@ static int meson_drv_bind_master(struct device *dev, > bool has_components) > > uninstall_irq: > free_irq(priv->vsync_irq, drm); > +dsi_encoder_remove: > + if (meson_vpu_is_compatible(priv, VPU_COMPATIBLE_G12A)) > + meson_e

Re: [PATCH] drm/meson: fix resource cleanup in meson_drv_bind_master() on error

2025-04-19 Thread Martin Blumenstingl
Hi Martijn, Hi Neil, On Thu, Apr 10, 2025 at 8:46 PM wrote: > > Hi Martin, > > Thank you for the patch. > > I encountered this issue some time ago as well and had a possible fix in my > tree (see > below). > My apologies for not upstreaming it earlier. No worries, we're all busy with both, offli

Re: [PATCH] drm/meson: fix resource cleanup in meson_drv_bind_master() on error

2025-04-11 Thread Anand Moon
Hi Martin, On Thu, 10 Apr 2025 at 03:30, Martin Blumenstingl wrote: > > meson_drv_bind_master() does not free resources in the order they are > allocated. This can lead to crashes such as: > Unable to handle kernel NULL pointer dereference at virtual address > 00c8 > [...] >

RE: [PATCH] drm/meson: fix resource cleanup in meson_drv_bind_master() on error

2025-04-11 Thread linux
Hi Martin, Thank you for the patch. I encountered this issue some time ago as well and had a possible fix in my tree (see below). My apologies for not upstreaming it earlier. While my fix is not as symmetric as yours—I like symmetry—it is somewhat simpler. It did make the assumption that only