Re: [bug report] drm/msm: Add VM_BIND ioctl

2025-08-04 Thread Dan Carpenter
On Sat, Aug 02, 2025 at 06:12:56AM -0700, Rob Clark wrote: > On Sat, Aug 2, 2025 at 12:49 AM Dan Carpenter > wrote: > > > > Hello Rob Clark, > > > > Commit 2e6a8a1fe2b2 ("drm/msm: Add VM_BIND ioctl") from Jun 29, 2025 > > (linux-next), leads to the following Smatch static checker warning: > > > >

Re: [bug report] drm/msm: Add VM_BIND ioctl

2025-08-02 Thread Rob Clark
On Sat, Aug 2, 2025 at 12:49 AM Dan Carpenter wrote: > > Hello Rob Clark, > > Commit 2e6a8a1fe2b2 ("drm/msm: Add VM_BIND ioctl") from Jun 29, 2025 > (linux-next), leads to the following Smatch static checker warning: > > drivers/gpu/drm/msm/msm_gem_vma.c:596 msm_gem_vm_sm_step_remap() >

[bug report] drm/msm: Add VM_BIND ioctl

2025-08-02 Thread Dan Carpenter
Hello Rob Clark, Commit 2e6a8a1fe2b2 ("drm/msm: Add VM_BIND ioctl") from Jun 29, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/msm/msm_gem_vma.c:596 msm_gem_vm_sm_step_remap() error: we previously assumed 'vm_bo' could be null (see line 5

Re: [bug report] drm/ttm, drm_xe, Implement ttm_lru_walk_for_evict() using the guarded LRU iteration

2025-07-21 Thread Thomas Hellström
On Sat, 2025-06-28 at 22:51 -0500, Dan Carpenter wrote: > Hello Thomas Hellström, > > Commit bb8aa27eff6f ("drm/ttm, drm_xe, Implement > ttm_lru_walk_for_evict() using the guarded LRU iteration") from Jun > 23, 2025 (linux-next), leads to the following (unpublished) Smatch > static checker warning

Re: [bug report] drm/ttm, drm_xe, Implement ttm_lru_walk_for_evict() using the guarded LRU iteration

2025-07-21 Thread Thomas Hellström
Hi! On Tue, 2025-07-01 at 12:49 -0500, Dan Carpenter wrote: > Hello Thomas Hellström, > > Commit bb8aa27eff6f ("drm/ttm, drm_xe, Implement > ttm_lru_walk_for_evict() using the guarded LRU iteration") from Jun > 23, 2025 (linux-next), leads to the following Smatch static checker > warning: > >

Re: [bug report] drm/xe/uc: Disable GuC communication on hardware initialization error

2025-07-15 Thread Dong, Zhanjun
On 2025-07-15 6:59 p.m., Dan Carpenter wrote: Hello Zhanjun Dong, Commit b2c4ac219fa4 ("drm/xe/uc: Disable GuC communication on hardware initialization error") from Jul 7, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/xe/xe_uc.c:167 vf_uc_lo

[bug report] drm/xe/uc: Disable GuC communication on hardware initialization error

2025-07-15 Thread Dan Carpenter
Hello Zhanjun Dong, Commit b2c4ac219fa4 ("drm/xe/uc: Disable GuC communication on hardware initialization error") from Jul 7, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/xe/xe_uc.c:167 vf_uc_load_hw() warn: missing unwind goto? drivers

[bug report] drm/msm: bail out late_init_minor() if it is not a GPU device

2025-07-15 Thread Dan Carpenter
Hello Dmitry Baryshkov, This is a semi-automatic email about new static checker warnings. Commit 4f89cf40d01e ("drm/msm: bail out late_init_minor() if it is not a GPU device") from Jul 5, 2025, leads to the following Smatch complaint: drivers/gpu/drm/msm/msm_debugfs.c:332 late_init_minor()

[bug report] drm/msm: Fix submit error-path leaks

2025-07-15 Thread Dan Carpenter
Hello Rob Clark, Commit 68dc6c2d5eec ("drm/msm: Fix submit error-path leaks") from May 9, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/msm/msm_gem_submit.c:816 msm_ioctl_gem_submit() warn: fd used after fd_install() 'out_fence_fd' drivers/gpu/drm/msm/m

[bug report] drm/ttm, drm_xe, Implement ttm_lru_walk_for_evict() using the guarded LRU iteration

2025-07-01 Thread Dan Carpenter
Hello Thomas Hellström, Commit bb8aa27eff6f ("drm/ttm, drm_xe, Implement ttm_lru_walk_for_evict() using the guarded LRU iteration") from Jun 23, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/ttm/ttm_bo_util.c:899 ttm_lru_walk_for_evict()

[bug report] drm/ttm, drm_xe, Implement ttm_lru_walk_for_evict() using the guarded LRU iteration

2025-06-28 Thread Dan Carpenter
Hello Thomas Hellström, Commit bb8aa27eff6f ("drm/ttm, drm_xe, Implement ttm_lru_walk_for_evict() using the guarded LRU iteration") from Jun 23, 2025 (linux-next), leads to the following (unpublished) Smatch static checker warning: drivers/gpu/drm/ttm/ttm_bo_util.c:991 __ttm_bo_lru_cursor

[bug report] dma-buf: dma-buf: stop mapping sg_tables on attach v2

2025-06-04 Thread Dan Carpenter
Hello Christian König, Commit de68b17d5d07 ("dma-buf: dma-buf: stop mapping sg_tables on attach v2") from Feb 11, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/dma-buf/dma-buf.c:1123 dma_buf_map_attachment() warn: passing positive error code '16'

Re: [bug report] drm/xe/svm: Implement prefetch support for SVM ranges

2025-06-04 Thread Dan Carpenter
On Wed, Jun 04, 2025 at 11:56:57AM -0300, Jason Gunthorpe wrote: > > A WARN_ON would be reasonable Or we could add a WARN_ON(). That's also fine. regards, dan carpenter

Re: [bug report] drm/xe/svm: Implement prefetch support for SVM ranges

2025-06-04 Thread Dan Carpenter
On Wed, Jun 04, 2025 at 04:54:43PM +0200, Simona Vetter wrote: > On Tue, Jun 03, 2025 at 07:29:52PM -0300, Jason Gunthorpe wrote: > > On Mon, May 26, 2025 at 10:15:17PM +0530, Ghimiray, Himal Prasad wrote: > > > > > > > > > On 26-05-2025 20:36, Dan Carpenter wrote: > > > > Hello Himal Prasad Ghim

Re: [bug report] drm/xe/svm: Implement prefetch support for SVM ranges

2025-06-04 Thread Jason Gunthorpe
On Wed, Jun 04, 2025 at 04:54:43PM +0200, Simona Vetter wrote: > On Tue, Jun 03, 2025 at 07:29:52PM -0300, Jason Gunthorpe wrote: > > On Mon, May 26, 2025 at 10:15:17PM +0530, Ghimiray, Himal Prasad wrote: > > > > > > > > > On 26-05-2025 20:36, Dan Carpenter wrote: > > > > Hello Himal Prasad Ghim

Re: [bug report] drm/xe/svm: Implement prefetch support for SVM ranges

2025-06-04 Thread Simona Vetter
On Tue, Jun 03, 2025 at 07:29:52PM -0300, Jason Gunthorpe wrote: > On Mon, May 26, 2025 at 10:15:17PM +0530, Ghimiray, Himal Prasad wrote: > > > > > > On 26-05-2025 20:36, Dan Carpenter wrote: > > > Hello Himal Prasad Ghimiray, > > > > > > Commit 09ba0a8f06cd ("drm/xe/svm: Implement prefetch sup

Re: [bug report] drm/xe/svm: Implement prefetch support for SVM ranges

2025-06-03 Thread Jason Gunthorpe
On Mon, May 26, 2025 at 10:15:17PM +0530, Ghimiray, Himal Prasad wrote: > > > On 26-05-2025 20:36, Dan Carpenter wrote: > > Hello Himal Prasad Ghimiray, > > > > Commit 09ba0a8f06cd ("drm/xe/svm: Implement prefetch support for SVM > > ranges") from May 13, 2025 (linux-next), leads to the followin

Re: [bug report] drm/xe/svm: Implement prefetch support for SVM ranges

2025-05-26 Thread Ghimiray, Himal Prasad
On 26-05-2025 20:36, Dan Carpenter wrote: Hello Himal Prasad Ghimiray, Commit 09ba0a8f06cd ("drm/xe/svm: Implement prefetch support for SVM ranges") from May 13, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/xe/xe_vm.c:2922 prefetch_ranges()

[bug report] drm/xe/svm: Implement prefetch support for SVM ranges

2025-05-26 Thread Dan Carpenter
Hello Himal Prasad Ghimiray, Commit 09ba0a8f06cd ("drm/xe/svm: Implement prefetch support for SVM ranges") from May 13, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/xe/xe_vm.c:2922 prefetch_ranges() warn: passing positive error code 's3

[bug report] drm: panel: Add driver for Himax HX8279 DDIC panels

2025-04-22 Thread Dan Carpenter
Hello AngeloGioacchino Del Regno, Commit 38d42c261389 ("drm: panel: Add driver for Himax HX8279 DDIC panels") from Apr 14, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/panel/panel-himax-hx8279.c:593 hx8279_set_digital_gamma() warn: reus

Re: [bug report] drm/panthor: Call panthor_gpu_coherency_init() after PM resume()

2025-04-15 Thread Dan Carpenter
On Mon, Apr 14, 2025 at 09:34:48AM +0200, Boris Brezillon wrote: > > 235 /* If PM is disabled, we need to call > > panthor_device_resume() manually. */ > > 236 if (!IS_ENABLED(CONFIG_PM)) { > > 237 ret = panthor_device_resume(ptdev->base.dev); > > 23

Re: [bug report] drm/panthor: Call panthor_gpu_coherency_init() after PM resume()

2025-04-14 Thread Boris Brezillon
On Sat, 12 Apr 2025 17:39:58 +0300 Dan Carpenter wrote: > Hello Boris Brezillon, > > Commit 7d5a3b22f5b5 ("drm/panthor: Call panthor_gpu_coherency_init() > after PM resume()") from Apr 4, 2025 (linux-next), leads to the > following Smatch static checker warning: > > drivers/gpu/drm/pantho

[bug report] drm/panthor: Call panthor_gpu_coherency_init() after PM resume()

2025-04-12 Thread Dan Carpenter
Hello Boris Brezillon, Commit 7d5a3b22f5b5 ("drm/panthor: Call panthor_gpu_coherency_init() after PM resume()") from Apr 4, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/panthor/panthor_device.c:248 panthor_device_init() warn: missing unw

Re: [bug report] HACK: drm/panel: ltk050h3146w: read panel-id

2025-04-09 Thread Heiko Stübner
Hi Dan, Am Mittwoch, 9. April 2025, 12:59:39 Mitteleuropäische Sommerzeit schrieb Dan Carpenter: > Commit e09be2a6ab1a ("HACK: drm/panel: ltk050h3146w: read panel-id") that commit was accientially merged into my for-next branch but never applied to any actual kernel branch (and is already gone a

[bug report] HACK: drm/panel: ltk050h3146w: read panel-id

2025-04-09 Thread Dan Carpenter
Hello Heiko Stuebner, Commit e09be2a6ab1a ("HACK: drm/panel: ltk050h3146w: read panel-id") from Mar 26, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c:490 ltk050h314x_read_id() warn: inconsistent indenti

[bug report] drm/gpusvm: Add support for GPU Shared Virtual Memory

2025-03-08 Thread Dan Carpenter
Hello Matthew Brost, Commit 99624bdff867 ("drm/gpusvm: Add support for GPU Shared Virtual Memory") from Mar 5, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/drm_gpusvm.c:794 drm_gpusvm_range_alloc() error: 'range' dereferencing possible E

Re: [bug report] habanalabs/gaudi: fix a race condition causing DMAR error

2025-03-05 Thread Dan Carpenter
Yuri's email is bouncing. Another related warnings: drivers/accel/habanalabs/gaudi/gaudi.c:5344 gaudi_parse_cb_mmu() warn: potential user controlled sizeof overflow 'parser->user_cb_size + gaudi_get_patched_cb_extra_size(parser->user_cb_size)' '0-u32max + 0-u32max' regards, dan carpenter On Wed

[bug report] habanalabs/gaudi: fix a race condition causing DMAR error

2025-03-05 Thread Dan Carpenter
Hello Yuri Nudelman, Commit 17ab47d2d6d4 ("habanalabs/gaudi: fix a race condition causing DMAR error") from Jun 22, 2022 (linux-next), leads to the following Smatch static checker warning: drivers/accel/habanalabs/gaudi/gaudi.c:1422 gaudi_get_patched_cb_extra_size() warn: potenti

Re: [bug report] drm/panthor: Expose size of driver internal BO's over fdinfo

2025-02-17 Thread Adrián Larumbe
Hi Dan, thanks for the bug report. A fix is already being discussed at https://lore.kernel.org/dri-devel/20250215102807.7502e...@collabora.com/ On 17.02.2025 00:36, Dan Carpenter wrote: > Hello Adrián Larumbe, > > Commit 434e5ca5b5d7 ("drm/panthor: Expose size of driver intern

Re: [bug report] drm/panthor: Expose size of driver internal BO's over fdinfo

2025-02-16 Thread Dan Carpenter
Similar issue in panthor_fdinfo_gather_group_samples() drivers/gpu/drm/panthor/panthor_sched.c:2883 panthor_fdinfo_gather_group_samples() warn: sleeping in atomic context regards, dan carpenter

[bug report] drm/panthor: Expose size of driver internal BO's over fdinfo

2025-02-16 Thread Dan Carpenter
Hello Adrián Larumbe, Commit 434e5ca5b5d7 ("drm/panthor: Expose size of driver internal BO's over fdinfo") from Jan 30, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/panthor/panthor_mmu.c:1968 panthor_vm_heaps_sizes() warn: sleeping in at

Re: [bug report] accel/amdxdna: Enhance power management settings

2025-01-08 Thread Lizhi Hou
On 1/8/25 00:40, Dan Carpenter wrote: Hello Lizhi Hou, Commit f4d7b8a6bc8c ("accel/amdxdna: Enhance power management settings") from Dec 13, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/accel/amdxdna/aie2_smu.c:68 npu1_set_dpm() error: unini

Re: [bug report] accel/amdxdna: Enhance power management settings

2025-01-08 Thread Dan Carpenter
On Wed, Jan 08, 2025 at 10:14:47AM -0800, Lizhi Hou wrote: > > On 1/8/25 00:40, Dan Carpenter wrote: > > Hello Lizhi Hou, > > > > Commit f4d7b8a6bc8c ("accel/amdxdna: Enhance power management > > settings") from Dec 13, 2024 (linux-next), leads to the following > > Smatch static checker warning:

RE: [bug report] drm/bridge: it6505: fix HDCP CTS compare V matching

2025-01-08 Thread Hermes.Wu
Hi Dan Carpenter, > >-Original Message- >From: Dan Carpenter >Sent: Wednesday, January 8, 2025 5:14 PM >To: Hermes Wu (吳佳宏) >Cc: dri-devel@lists.freedesktop.org >Subject: [bug report] drm/bridge: it6505: fix HDCP CTS compare V matching > >Hello Hermes Wu, &

[bug report] drm/bridge: it6505: fix HDCP CTS compare V matching

2025-01-08 Thread Dan Carpenter
Hello Hermes Wu, Commit 0989c02c7a5c ("drm/bridge: it6505: fix HDCP CTS compare V matching") from Dec 30, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/bridge/ite-it6505.c:2253 it6505_hdcp_part2_ksvlist_check() warn: ignoring unreachable

[bug report] accel/amdxdna: Enhance power management settings

2025-01-08 Thread Dan Carpenter
Hello Lizhi Hou, Commit f4d7b8a6bc8c ("accel/amdxdna: Enhance power management settings") from Dec 13, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/accel/amdxdna/aie2_smu.c:68 npu1_set_dpm() error: uninitialized symbol 'freq'. drivers/accel/amd

[Bug Report] Warning from __flush_work() on next-20241126

2024-11-26 Thread Muhammad Usama Anjum
Hi, We are getting this warning on x86_64 and i386 targets: [8.677157] amdgpu :03:00.0: [drm:amdgpu_ib_ring_tests] *ERROR* IB test failed on sdma0 (-110). [8.698661] [ cut here ] [8.703310] WARNING: CPU: 1 PID: 49 at kernel/workqueue.c:4192 __flush_work+0

[bug report] drm/mediatek: Implement OF graphs support for display paths

2024-11-12 Thread Dan Carpenter
Hello AngeloGioacchino Del Regno, Commit 4c932840db1d ("drm/mediatek: Implement OF graphs support for display paths") from Oct 17, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/mediatek/mtk_drm_drv.c:913 mtk_drm_of_ddp_path_build_one() e

Re: [bug report] drm: add DRM_SET_CLIENT_NAME ioctl

2024-10-11 Thread Dan Carpenter
On Fri, Oct 11, 2024 at 10:20:03AM +0200, Pierre-Eric Pelloux-Prayer wrote: > > Hi, > > Le 10/10/2024 à 12:02, Dan Carpenter a écrit : > > Hello Pierre-Eric Pelloux-Prayer, > > > > Commit 56c594d8df64 ("drm: add DRM_SET_CLIENT_NAME ioctl") from Oct > > 3, 2024 (linux-next), leads to the followin

Re: [bug report] drm: add DRM_SET_CLIENT_NAME ioctl

2024-10-11 Thread Pierre-Eric Pelloux-Prayer
Hi, Le 10/10/2024 à 12:02, Dan Carpenter a écrit : Hello Pierre-Eric Pelloux-Prayer, Commit 56c594d8df64 ("drm: add DRM_SET_CLIENT_NAME ioctl") from Oct 3, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/drm_debugfs.c:104 drm_clients_info()

[bug report] drm: add DRM_SET_CLIENT_NAME ioctl

2024-10-10 Thread Dan Carpenter
Hello Pierre-Eric Pelloux-Prayer, Commit 56c594d8df64 ("drm: add DRM_SET_CLIENT_NAME ioctl") from Oct 3, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/drm_debugfs.c:104 drm_clients_info() warn: was precision intended? '64' drivers/gpu/dr

[bug report] drm/msm: add msm8998 hdmi phy/pll support

2024-09-03 Thread Dan Carpenter
Hello Arnaud Vrac, Commit caedbf17c48d ("drm/msm: add msm8998 hdmi phy/pll support") from Jul 24, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:634 hdmi_8998_pll_prepare() info: return a literal instead of 'ret' drivers/gpu/drm/

Re: [bug report] accel/ivpu: Add GEM buffer object management

2024-08-23 Thread Jacek Lawrynowicz
Thanks. I agree this check makes no sense. I will remove it. On 19.08.2024 20:58, Dan Carpenter wrote: > Hello Jacek Lawrynowicz, > > This is a semi-automatic email about new static checker warnings. > > Commit 647371a6609d ("accel/ivpu: Add GEM buffer object management") > from Jan 17, 2023, le

[bug report] accel/ivpu: Add GEM buffer object management

2024-08-19 Thread Dan Carpenter
Hello Jacek Lawrynowicz, This is a semi-automatic email about new static checker warnings. Commit 647371a6609d ("accel/ivpu: Add GEM buffer object management") from Jan 17, 2023, leads to the following Smatch complaint: ./drivers/accel/ivpu/ivpu_drv.c:119 ivpu_file_priv_put() warn: varia

Re: [bug report] drm/omap: gem: Replace struct_mutex usage with omap_obj private lock

2024-08-05 Thread Tomi Valkeinen
On 31/07/2024 15:26, Laurent Pinchart wrote: Hi Dan, (CC'ing Tomi) Thank for the report. It indeed seems that something is wrong. Tomi, could you handle this and send a fix ? On Tue, Jul 30, 2024 at 05:01:35PM -0500, Dan Carpenter wrote: Hello Laurent Pinchart, Commit 3cbd0c587b12 ("drm/

Re: [bug report] drm/omap: gem: Replace struct_mutex usage with omap_obj private lock

2024-07-31 Thread Laurent Pinchart
Hi Dan, (CC'ing Tomi) Thank for the report. It indeed seems that something is wrong. Tomi, could you handle this and send a fix ? On Tue, Jul 30, 2024 at 05:01:35PM -0500, Dan Carpenter wrote: > Hello Laurent Pinchart, > > Commit 3cbd0c587b12 ("drm/omap: gem: Replace struct_mutex usage with >

[bug report] drm/omap: gem: Replace struct_mutex usage with omap_obj private lock

2024-07-30 Thread Dan Carpenter
Hello Laurent Pinchart, Commit 3cbd0c587b12 ("drm/omap: gem: Replace struct_mutex usage with omap_obj private lock") from May 26, 2018 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/omapdrm/omap_gem.c:1435 omap_gem_new_dmabuf() warn: 'omap_obj'

Re: [bug report] accel/habanalabs: enforce release order of compute device and dma-buf

2024-07-26 Thread Dan Carpenter
On Fri, Jul 26, 2024 at 02:56:04PM +, Tomer Tayar wrote: > > Okay, no problem, I wont change the code. > > Unless you are against it, I think I can still add a short comment > before calling fput(), explaining why it is okay to access 'ctx' at > that point. Thanks, Tomer A comment would be g

Re: [bug report] accel/habanalabs: enforce release order of compute device and dma-buf

2024-07-26 Thread Tomer Tayar
On 26/07/2024 1:33, Dan Carpenter wrote: On Thu, Jul 25, 2024 at 08:21:51AM +, Tomer Tayar wrote: On 24/07/2024 19:08, Dan Carpenter wrote: Hello Tomer Tayar, Commit 09524eb8824e ("accel/habanalabs: enforce release order of compute device and dma-buf") from Jan 22, 2023 (linux-next), lead

Re: [bug report] accel/habanalabs: enforce release order of compute device and dma-buf

2024-07-25 Thread Dan Carpenter
On Thu, Jul 25, 2024 at 08:21:51AM +, Tomer Tayar wrote: > On 24/07/2024 19:08, Dan Carpenter wrote: > > Hello Tomer Tayar, > > > > Commit 09524eb8824e ("accel/habanalabs: enforce release order of > > compute device and dma-buf") from Jan 22, 2023 (linux-next), leads to > > the following Smatch

Re: [bug report] accel/habanalabs: enforce release order of compute device and dma-buf

2024-07-25 Thread Tomer Tayar
On 24/07/2024 19:08, Dan Carpenter wrote: > Hello Tomer Tayar, > > Commit 09524eb8824e ("accel/habanalabs: enforce release order of > compute device and dma-buf") from Jan 22, 2023 (linux-next), leads to > the following Smatch static checker warning: > > drivers/accel/habanalabs/common/memory

[bug report] accel/habanalabs: enforce release order of compute device and dma-buf

2024-07-24 Thread Dan Carpenter
Hello Tomer Tayar, Commit 09524eb8824e ("accel/habanalabs: enforce release order of compute device and dma-buf") from Jan 22, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/accel/habanalabs/common/memory.c:1844 hl_release_dmabuf() error: dereferen

[bug report] drm/v3d: Create a CPU job extension for the reset timestamp job

2024-07-23 Thread Dan Carpenter
[ The Smatch integer overflow are too garbage to publish. We're going to have a BoF about integer overflows at plumbers. - dan ] Hello Maíra Canal, Commit 34a101e64296 ("drm/v3d: Create a CPU job extension for the reset timestamp job") from Nov 30, 2023 (linux-next), leads to the following Sma

[bug report] drm/vc4: Add CTM support

2024-07-19 Thread Dan Carpenter
Hello Stefan Schake, Commit 766cc6b1f7fc ("drm/vc4: Add CTM support") from Apr 20, 2018 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/vc4/vc4_kms.c:555 vc4_ctm_atomic_check() warn: reusing outside iterator: 'i' drivers/gpu/drm/vc4/vc4_kms.c

[bug report] drm/vblank: Hard lockup in __disable_vblank()

2024-07-15 Thread Yu Liao
Hi, A hard lockup is happened when I do fuzz test with syzkaller. Kernel panic - not syncing: Hard LOCKUP CPU: 3 PID: 0 Comm: swapper/3 Not tainted 6.6.0+ #21 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014 Call Trace: hrtimer

Re: [bug report] drm: atmel-hlcdc: add driver ops to differentiate HLCDC and XLCDC IP

2024-06-20 Thread Manikandan.M
Hi Dan, Thank you for reporting the bug.I will prepare and send a fix-up patch soon. On 20/06/24 2:20 pm, Dan Carpenter wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hello Manikandan Muralidharan, > > Commit aa71584b323a ("drm: atmel-

[bug report] drm: atmel-hlcdc: add driver ops to differentiate HLCDC and XLCDC IP

2024-06-20 Thread Dan Carpenter
Hello Manikandan Muralidharan, Commit aa71584b323a ("drm: atmel-hlcdc: add driver ops to differentiate HLCDC and XLCDC IP") from Apr 24, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c:573 atmel_hlcdc_plane_update_b

Re: [bug report] drm/meson: fix unbind path if HDMI fails to bind

2024-06-10 Thread Neil Armstrong
Hi, On 08/06/2024 16:20, Dan Carpenter wrote: Hello Neil Armstrong, Commit 6a044642988b ("drm/meson: fix unbind path if HDMI fails to bind") from May 30, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/meson/meson_drv.c:377 meson_drv_bind_master

[bug report] drm/xe/bo: Simplify xe_bo_lock()

2024-06-08 Thread Dan Carpenter
Hello Thomas Hellström, Commit 08a4f00e62bc ("drm/xe/bo: Simplify xe_bo_lock()") from Sep 8, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/xe/xe_vm.c:2095 vm_bind_ioctl_ops_create() error: we previously assumed 'bo' could be null (see lin

[bug report] drm/xe: Introduce a new DRM driver for Intel GPUs

2024-06-08 Thread Dan Carpenter
Hello Matthew Brost, Commit dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs") from Mar 30, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/xe/xe_pt.c:671 xe_pt_stage_bind() error: we previously assumed 'bo' could be null (s

[bug report] drm/meson: fix unbind path if HDMI fails to bind

2024-06-08 Thread Dan Carpenter
Hello Neil Armstrong, Commit 6a044642988b ("drm/meson: fix unbind path if HDMI fails to bind") from May 30, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/meson/meson_drv.c:377 meson_drv_bind_master() error: we previously assumed 'priv' co

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-30 Thread Patrik Jakobsson
On Fri, Apr 19, 2024 at 5:34 PM Nam Cao wrote: > > On 2024-04-19 Patrik Jakobsson wrote: > > Neither cancel_delayed_work_sync() or flush_delayed_work() prevent new > > work from being scheduled after they return. > > flush_delayed_work() is called during device closing. And because no > writes are

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Harshit Mogalapalli
On 19/04/24 21:53, Nam Cao wrote: On 2024-04-19 Harshit Mogalapalli wrote: +CC stable( heads up as this is a regression affecting 5.15.y and probably others, Greg: this was reproducible upstream so reported everything w.r.t upstream code but initially found on 5.15.y) No worry about this, I wi

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Nam Cao
On 2024-04-19 Harshit Mogalapalli wrote: > +CC stable( heads up as this is a regression affecting 5.15.y and > probably others, Greg: this was reproducible upstream so reported > everything w.r.t upstream code but initially found on 5.15.y) No worry about this, I will add a "Cc: " tag to the pat

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Harshit Mogalapalli
Hi Nam, +CC stable( heads up as this is a regression affecting 5.15.y and probably others, Greg: this was reproducible upstream so reported everything w.r.t upstream code but initially found on 5.15.y) On 19/04/24 20:29, Nam Cao wrote: On 2024-04-18 Harshit Mogalapalli wrote: While fuzzing

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Nam Cao
On 2024-04-19 Patrik Jakobsson wrote: > Neither cancel_delayed_work_sync() or flush_delayed_work() prevent new > work from being scheduled after they return. flush_delayed_work() is called during device closing. And because no writes are performed after the device has been closed, no new work shou

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Nam Cao
On 2024-04-18 Patrik Jakobsson wrote: > On Thu, Apr 18, 2024 at 4:05 PM Nam Cao wrote: > > > > On 2024-04-18 Patrik Jakobsson wrote: > > > This sounds similar to the SUSE bug [1]. We fixed it by reverting [2] > > > in the SUSE kernel. The problem seems to be that flush_delayed_work() > > > kills

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Nam Cao
On 2024-04-18 Harshit Mogalapalli wrote: > While fuzzing 5.15.y kernel with Syzkaller, we noticed a INFO: task hung > bug in fb_deferred_io_work() I think the problem is because of improper offset address calculation. The kernel calculate address offset with: offset = vmf->address - vmf->

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Harshit Mogalapalli
Hi Takashi, On 19/04/24 13:15, Takashi Iwai wrote: On Fri, 19 Apr 2024 09:39:09 +0200, Then later on, the commit 33cd6ea9c067 changed cancel_*() to flush_delayed_work() blindly, and the known problem resurfaced again. I have reverted that commit, but still could see some other task hung messa

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Patrik Jakobsson
On Fri, Apr 19, 2024 at 9:45 AM Takashi Iwai wrote: > > On Fri, 19 Apr 2024 09:39:09 +0200, > Harshit Mogalapalli wrote: > > > > Hi Takashi, > > > > On 19/04/24 12:14, Takashi Iwai wrote: > > > On Thu, 18 Apr 2024 21:29:57 +0200, > > > Helge Deller wrote: > > >> > > >> On 4/18/24 16:26, Takashi Iw

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Takashi Iwai
On Fri, 19 Apr 2024 09:39:09 +0200, Harshit Mogalapalli wrote: > > Hi Takashi, > > On 19/04/24 12:14, Takashi Iwai wrote: > > On Thu, 18 Apr 2024 21:29:57 +0200, > > Helge Deller wrote: > >> > >> On 4/18/24 16:26, Takashi Iwai wrote: > >>> On Thu, 18 Apr 2024 16:06:52 +0200, > >>> Nam Cao wrote:

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Harshit Mogalapalli
Hi Takashi, On 19/04/24 12:14, Takashi Iwai wrote: On Thu, 18 Apr 2024 21:29:57 +0200, Helge Deller wrote: On 4/18/24 16:26, Takashi Iwai wrote: On Thu, 18 Apr 2024 16:06:52 +0200, Nam Cao wrote: On 2024-04-18 Harshit Mogalapalli wrote: While fuzzing 5.15.y kernel with Syzkaller, we notice

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Harshit Mogalapalli
Hi Nam, On 18/04/24 19:36, Nam Cao wrote: On 2024-04-18 Harshit Mogalapalli wrote: While fuzzing 5.15.y kernel with Syzkaller, we noticed a INFO: task hung bug in fb_deferred_io_work() Which framebuffer device are you using exactly? It is possible that the problem is with the device driver, n

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Harshit Mogalapalli
Hi Patrik, On 18/04/24 18:44, Patrik Jakobsson wrote: On Thu, Apr 18, 2024 at 2:40 PM Harshit Mogalapalli wrote: Hi, While fuzzing 5.15.y kernel with Syzkaller, we noticed a INFO: task hung bug in fb_deferred_io_work() This is in 5.15.149 tag, and this is introduced by a set of commits: 2

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-18 Thread Takashi Iwai
On Thu, 18 Apr 2024 21:29:57 +0200, Helge Deller wrote: > > On 4/18/24 16:26, Takashi Iwai wrote: > > On Thu, 18 Apr 2024 16:06:52 +0200, > > Nam Cao wrote: > >> > >> On 2024-04-18 Harshit Mogalapalli wrote: > >>> While fuzzing 5.15.y kernel with Syzkaller, we noticed a INFO: task hung > >>> bug

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-18 Thread Helge Deller
On 4/18/24 16:26, Takashi Iwai wrote: On Thu, 18 Apr 2024 16:06:52 +0200, Nam Cao wrote: On 2024-04-18 Harshit Mogalapalli wrote: While fuzzing 5.15.y kernel with Syzkaller, we noticed a INFO: task hung bug in fb_deferred_io_work() Which framebuffer device are you using exactly? It is possib

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-18 Thread Patrik Jakobsson
On Thu, Apr 18, 2024 at 4:05 PM Nam Cao wrote: > > On 2024-04-18 Patrik Jakobsson wrote: > > This sounds similar to the SUSE bug [1]. We fixed it by reverting [2] > > in the SUSE kernel. The problem seems to be that flush_delayed_work() > > kills the timer and re-queues the work but doesn't guaran

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-18 Thread Takashi Iwai
On Thu, 18 Apr 2024 16:06:52 +0200, Nam Cao wrote: > > On 2024-04-18 Harshit Mogalapalli wrote: > > While fuzzing 5.15.y kernel with Syzkaller, we noticed a INFO: task hung > > bug in fb_deferred_io_work() > > Which framebuffer device are you using exactly? It is possible that > the problem is w

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-18 Thread Nam Cao
On 2024-04-18 Harshit Mogalapalli wrote: > While fuzzing 5.15.y kernel with Syzkaller, we noticed a INFO: task hung > bug in fb_deferred_io_work() Which framebuffer device are you using exactly? It is possible that the problem is with the device driver, not core framebuffer. Best regards, Nam

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-18 Thread Nam Cao
On 2024-04-18 Patrik Jakobsson wrote: > This sounds similar to the SUSE bug [1]. We fixed it by reverting [2] > in the SUSE kernel. The problem seems to be that flush_delayed_work() > kills the timer and re-queues the work but doesn't guarantee that it > is finished when returning. So when the devi

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-18 Thread Patrik Jakobsson
On Thu, Apr 18, 2024 at 2:40 PM Harshit Mogalapalli wrote: > > Hi, > > While fuzzing 5.15.y kernel with Syzkaller, we noticed a INFO: task hung > bug in fb_deferred_io_work() > > > This is in 5.15.149 tag, and this is introduced by a set of commits: > > 2655757a3f10 fbdev: flush deferred IO before

[bug-report] task info hung problem in fb_deferred_io_work()

2024-04-18 Thread Harshit Mogalapalli
Hi, While fuzzing 5.15.y kernel with Syzkaller, we noticed a INFO: task hung bug in fb_deferred_io_work() This is in 5.15.149 tag, and this is introduced by a set of commits: 2655757a3f10 fbdev: flush deferred IO before closing 15492bab7393 fbdev: Fix incorrect page mapping clearance at fb_

[bug report] drm/nouveau/disp/r535: initial support

2024-04-15 Thread Dan Carpenter
Hello Nouveau Devs, Commit 9e999023 ("drm/nouveau/disp/r535: initial support") from Sep 19, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/nouveau/nvkm/engine/disp/r535.c:1482 r535_disp_oneinit() error: potential NULL/IS_ERR bug 'ctrl' drivers/gpu/dr

Re: [bug report] drm: bridge: cdns-mhdp8546: Fix possible null pointer dereference

2024-04-11 Thread Aleksandr Mishin
On 11.04.2024 16:39, Dan Carpenter wrote: Hello Aleksandr Mishin, Commit 935a92a1c400 ("drm: bridge: cdns-mhdp8546: Fix possible null pointer dereference") from Apr 8, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/bridge/cadence/cdns-mhdp854

[bug report] drm: bridge: cdns-mhdp8546: Fix possible null pointer dereference

2024-04-11 Thread Dan Carpenter
Hello Aleksandr Mishin, Commit 935a92a1c400 ("drm: bridge: cdns-mhdp8546: Fix possible null pointer dereference") from Apr 8, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:2074 cdns_mhdp_atomic_enable()

Re: [bug report] drm/panthor: Add the scheduler logical block

2024-04-10 Thread Steven Price
On 10/04/2024 15:34, Dan Carpenter wrote: > On Wed, Apr 10, 2024 at 03:11:52PM +0100, Steven Price wrote: >> On 08/04/2024 08:35, Dan Carpenter wrote: >>> Hello Boris Brezillon, >>> >>> Commit de8548813824 ("drm/panthor: Add the scheduler logical block") >>> from Feb 29, 2024 (linux-next), leads to

Re: [bug report] drm/panthor: Add the scheduler logical block

2024-04-10 Thread Dan Carpenter
On Wed, Apr 10, 2024 at 03:11:52PM +0100, Steven Price wrote: > On 08/04/2024 08:35, Dan Carpenter wrote: > > Hello Boris Brezillon, > > > > Commit de8548813824 ("drm/panthor: Add the scheduler logical block") > > from Feb 29, 2024 (linux-next), leads to the following Smatch static > > checker war

Re: [bug report] drm/panthor: Add the scheduler logical block

2024-04-10 Thread Steven Price
On 08/04/2024 08:35, Dan Carpenter wrote: > Hello Boris Brezillon, > > Commit de8548813824 ("drm/panthor: Add the scheduler logical block") > from Feb 29, 2024 (linux-next), leads to the following Smatch static > checker warning: > > drivers/gpu/drm/panthor/panthor_sched.c:1153 > csg_slot_

[bug report] drm/panthor: Add the scheduler logical block

2024-04-08 Thread Dan Carpenter
Hello Boris Brezillon, Commit de8548813824 ("drm/panthor: Add the scheduler logical block") from Feb 29, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/panthor/panthor_sched.c:1153 csg_slot_sync_state_locked() error: uninitialized symbol

[Bug 218617] Linux Kernel Bug Report: "Scheduling while atomic" Kernel Panic and System Freeze on NVIDIA RTX 2000 Ada Generation Laptop GPU

2024-03-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218617 --- Comment #2 from Sarah S. (sarah.salzst...@gmail.com) --- Thank you for letting me know! Sincerely, Sarah S. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

[Bug 218617] Linux Kernel Bug Report: "Scheduling while atomic" Kernel Panic and System Freeze on NVIDIA RTX 2000 Ada Generation Laptop GPU

2024-03-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218617 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

[Bug 218617] New: Linux Kernel Bug Report: "Scheduling while atomic" Kernel Panic and System Freeze on NVIDIA RTX 2000 Ada Generation Laptop GPU

2024-03-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218617 Bug ID: 218617 Summary: Linux Kernel Bug Report: "Scheduling while atomic" Kernel Panic and System Freeze on NVIDIA RTX 2000 Ada Generation Laptop GPU Produc

[bug report] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2024-02-07 Thread Dan Carpenter
Hello Lucas Stach, This is a semi-automatic email about new static checker warnings. drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c:81 imx8mp_hdmi_pvi_bridge_enable() warn: variable dereferenced before check 'bridge_state' (see line 54) drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c 53

Re: [bug report] drm/amdkfd: Export DMABufs from KFD using GEM handles

2024-01-23 Thread Felix Kuehling
On 2024-01-23 5:21, Dan Carpenter wrote: Hello Felix Kuehling, The patch 1819200166ce: "drm/amdkfd: Export DMABufs from KFD using GEM handles" from Aug 24, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/dma-buf/dma-buf.c:729 dma_buf_get() warn:

[bug report] drm/amdkfd: Export DMABufs from KFD using GEM handles

2024-01-23 Thread Dan Carpenter
Hello Felix Kuehling, The patch 1819200166ce: "drm/amdkfd: Export DMABufs from KFD using GEM handles" from Aug 24, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/dma-buf/dma-buf.c:729 dma_buf_get() warn: fd used after fd_install() 'fd' drivers/gp

[bug report] backlight: hx8357: Convert to agnostic GPIO API

2024-01-10 Thread Dan Carpenter
Hello Andy Shevchenko, The patch 7d84a63a39b7: "backlight: hx8357: Convert to agnostic GPIO API" from Dec 7, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/video/backlight/hx8357.c:612 hx8357_probe() error: potential NULL/IS_ERR bug 'lcd->im_pins'

Re: [bug report] drm/amdgpu/vpe: enable vpe dpm

2024-01-07 Thread SHANMUGAM, SRINIVASAN
ct: RE: [bug report] drm/amdgpu/vpe: enable vpe dpm Hi Dan Carpenter, This was fixed in https://patchwork.freedesktop.org/patch/573477/?series=128249&rev=1 Thank you! Regards, Srini -Original Message- From: amd-gfx On Behalf Of Dan Carpenter Sent: Friday, January 5, 2024 7:04 PM To: L

RE: [bug report] drm/amdgpu/vpe: enable vpe dpm

2024-01-05 Thread SHANMUGAM, SRINIVASAN
evel@lists.freedesktop.org; amd-...@lists.freedesktop.org Subject: [bug report] drm/amdgpu/vpe: enable vpe dpm Hello Peyton Lee, The patch 5f82a0c90cca: "drm/amdgpu/vpe: enable vpe dpm" from Dec 12, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/a

[bug report] drm/amdgpu/vpe: enable vpe dpm

2024-01-05 Thread Dan Carpenter
Hello Peyton Lee, The patch 5f82a0c90cca: "drm/amdgpu/vpe: enable vpe dpm" from Dec 12, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c:62 vpe_u1_8_from_fraction() warn: unsigned 'numerator' is never less than zero. drivers/gpu/drm

[bug report] drm/xe: Introduce a new DRM driver for Intel GPUs

2024-01-05 Thread Dan Carpenter
Hello Matthew Brost, The patch dd08ebf6c352: "drm/xe: Introduce a new DRM driver for Intel GPUs" from Mar 30, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/xe/xe_bo.c:2246 xe_bo_dumb_create() warn: potential integer overflow from user '((

  1   2   3   4   5   >