On Mon, Apr 14, 2025 at 09:34:48AM +0200, Boris Brezillon wrote:
> > 235 /* If PM is disabled, we need to call
> > panthor_device_resume() manually. */
> > 236 if (!IS_ENABLED(CONFIG_PM)) {
> > 237 ret = panthor_device_resume(ptdev->base.dev);
> > 238 if (ret)
> > 239 return ret;
> > 240 }
> > 241
> > 242 ret = panthor_gpu_init(ptdev);
> > 243 if (ret)
> > 244 goto err_rpm_put;
> > 245
> > 246 ret = panthor_gpu_coherency_init(ptdev);
> > 247 if (ret)
> > --> 248 return ret;
> > ^^^^^^^^^^^
> > Missing cleanup?
>
> Thanks for the report, it should definitely be
>
> goto err_unplug_gpu;
>
> Do you plan to send a patch, or should I do it?
>
I'm on vacation.
regards,
dan carpenter
