Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2023-02-14 Thread Janusz Krzysztofik
Hi Isabella, On Friday, 10 February 2023 17:55:34 CET Isabella Basso wrote: > Hi, Janusz, > > > Am 2023-02-10 um 11:56 AM schrieb Janusz Krzysztofik > > : > > > > Hi Isabella, > > > > On Monday, 19 September 2022 22:55:44 CET Isabella Basso wrote: > >> Hi, Janusz, > >> > >>> Am 09/09/2022 um

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2023-02-11 Thread Isabella Basso
Hi, Janusz, > Am 2023-02-10 um 11:56 AM schrieb Janusz Krzysztofik > : > > Hi Isabella, > > On Monday, 19 September 2022 22:55:44 CET Isabella Basso wrote: >> Hi, Janusz, >> >>> Am 09/09/2022 um 12:18 PM schrieb Janusz Krzysztofik >>> : >>> >>> ... >>> >>> Anyway, related to my comment abou

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2023-02-10 Thread Janusz Krzysztofik
Hi Isabella, On Monday, 19 September 2022 22:55:44 CET Isabella Basso wrote: > Hi, Janusz, > > > Am 09/09/2022 um 12:18 PM schrieb Janusz Krzysztofik > > : > > > > ... > > > > Anyway, related to my comment about naming that function a parser, I think > > the > > best approach would be for th

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-03 Thread Mauro Carvalho Chehab
On Thu, 3 Nov 2022 10:48:40 +0100 Mauro Carvalho Chehab wrote: > On Sun, 28 Aug 2022 21:09:19 -0300 > Isabella Basso wrote: > > > This adds functions for both executing the tests as well as parsing (K)TAP > > kmsg output, as per the KTAP spec [1]. > > > > [1] https://www.kernel.org/doc/html/la

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-03 Thread Petri Latvala
On Thu, Nov 03, 2022 at 12:40:59PM +0100, Mauro Carvalho Chehab wrote: > On Thu, 3 Nov 2022 10:48:40 +0100 > Mauro Carvalho Chehab wrote: > > > On Sun, 28 Aug 2022 21:09:19 -0300 > > Isabella Basso wrote: > > > > > This adds functions for both executing the tests as well as parsing (K)TAP > > >

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-03 Thread Mauro Carvalho Chehab
On Thu, 3 Nov 2022 10:48:40 +0100 Mauro Carvalho Chehab wrote: > On Sun, 28 Aug 2022 21:09:19 -0300 > Isabella Basso wrote: > > > This adds functions for both executing the tests as well as parsing (K)TAP > > kmsg output, as per the KTAP spec [1]. > > > > [1] https://www.kernel.org/doc/html/la

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-03 Thread Mauro Carvalho Chehab
On Sun, 28 Aug 2022 21:09:19 -0300 Isabella Basso wrote: > This adds functions for both executing the tests as well as parsing (K)TAP > kmsg output, as per the KTAP spec [1]. > > [1] https://www.kernel.org/doc/html/latest/dev-tools/ktap.html > > Signed-off-by: Isabella Basso Hi Isabella, I'm

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Tue, 1 Nov 2022 14:17:26 -0300 Isabella Basso wrote: > Hi, Mauro, > > > Am 01/11/2022 um 9:33 AM schrieb Mauro Carvalho Chehab > > : > > > > Hi Isabella, > > > > On Mon, 19 Sep 2022 17:43:19 -0300 > > Isabella Basso wrote: > > > >>> Do you want to _require_ KUnit be built as a module,

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Isabella Basso
Hi, Mauro, > Am 01/11/2022 um 9:33 AM schrieb Mauro Carvalho Chehab > : > > Hi Isabella, > > On Mon, 19 Sep 2022 17:43:19 -0300 > Isabella Basso wrote: > >>> Do you want to _require_ KUnit be built as a module, rather than built-in >>> here? >> >> I’ll change the comment and the warning i

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Mon, 19 Sep 2022 17:25:38 -0700 Daniel Latypov wrote: > On Mon, Sep 19, 2022 at 1:43 PM Isabella Basso wrote: > > >> +* "(K)TAP version XX" should be the first line on all > > >> (sub)tests as per > > >> +* > > >> https://www.kernel.org/doc/html/latest/dev-tools/ktap.html#ve

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Mauro Carvalho Chehab
Hi Isabella, On Mon, 19 Sep 2022 17:43:19 -0300 Isabella Basso wrote: > > Do you want to _require_ KUnit be built as a module, rather than built-in > > here? > > I’ll change the comment and the warning in v3 to clarify this. When do you intend to submit v3? Regards, Mauro

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Thu, 1 Sep 2022 14:37:06 +0800 David Gow wrote: > On Mon, Aug 29, 2022 at 8:10 AM Isabella Basso wrote: > > > > This adds functions for both executing the tests as well as parsing (K)TAP > > kmsg output, as per the KTAP spec [1]. > > > > [1] https://www.kernel.org/doc/html/latest/dev-tools/kt

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-09-19 Thread Isabella Basso
Hi, Janusz, > Am 09/09/2022 um 12:18 PM schrieb Janusz Krzysztofik > : > > Hi Isabella, > > On Monday, 29 August 2022 02:09:19 CEST Isabella Basso wrote: >> This adds functions for both executing the tests as well as parsing (K)TAP >> kmsg output, as per the KTAP spec [1]. >> >> [1] https://ww

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-09-09 Thread Janusz Krzysztofik
Hi Isabella, On Monday, 29 August 2022 02:09:19 CEST Isabella Basso wrote: > This adds functions for both executing the tests as well as parsing (K)TAP > kmsg output, as per the KTAP spec [1]. > > [1] https://www.kernel.org/doc/html/latest/dev-tools/ktap.html > > Signed-off-by: Isabella Basso >