RE: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-10-05 Thread Chrisanthus, Anitha
> -Original Message- > From: Daniel Vetter > Sent: Monday, October 5, 2020 6:49 AM > To: Chrisanthus, Anitha > Cc: Daniel Vetter ; dri-devel@lists.freedesktop.org; > Paauwe, Bob J ; Dea, Edmund J > ; Vetter, Daniel > Subject: Re: [PATCH v7 2/4] drm/kmb: Add sup

Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-10-05 Thread Daniel Vetter
> ; Dea, Edmund J ; > > Vetter, Daniel > > Subject: Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display > > > > On Thu, Oct 1, 2020 at 8:02 PM Chrisanthus, Anitha > > wrote: > > > > > > Hi Daniel, > > > I was finally able to te

RE: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-10-02 Thread Chrisanthus, Anitha
> -Original Message- > From: Daniel Vetter > Sent: Friday, October 2, 2020 2:19 AM > To: Chrisanthus, Anitha > Cc: dri-devel@lists.freedesktop.org; Paauwe, Bob J > ; Dea, Edmund J ; > Vetter, Daniel > Subject: Re: [PATCH v7 2/4] drm/kmb: Add support for Kee

Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-10-02 Thread Daniel Vetter
o: Chrisanthus, Anitha > > Cc: dri-devel@lists.freedesktop.org; Paauwe, Bob J > > ; Dea, Edmund J ; > > Vetter, Daniel > > Subject: Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display > > > > On Mon, Aug 31, 2020 at 01:02:50PM -0700, Anitha Chrisant

RE: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-10-01 Thread Chrisanthus, Anitha
risanthus, Anitha > Cc: dri-devel@lists.freedesktop.org; Paauwe, Bob J > ; Dea, Edmund J ; > Vetter, Daniel > Subject: Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display > > On Mon, Aug 31, 2020 at 01:02:50PM -0700, Anitha Chrisanthus wrote: > > This is a basic KMS

Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-23 Thread Daniel Vetter
t; > Sent: Thursday, September 10, 2020 1:31 AM > > To: Chrisanthus, Anitha > > Cc: dri-devel@lists.freedesktop.org; Paauwe, Bob J > > ; Dea, Edmund J ; > > Vetter, Daniel > > Subject: Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display > > > > O

RE: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-22 Thread Chrisanthus, Anitha
> Sent: Thursday, September 10, 2020 1:31 AM > To: Chrisanthus, Anitha > Cc: dri-devel@lists.freedesktop.org; Paauwe, Bob J > ; Dea, Edmund J ; > Vetter, Daniel > Subject: Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display > > On Mon, Aug 31, 2020 at 01:02:50PM -

Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-12 Thread Sam Ravnborg
Hi Anitha. On Fri, Sep 11, 2020 at 08:54:41PM +, Chrisanthus, Anitha wrote: > Hi Neil, > Thanks for your review. Is a device tree binding document like this one > enough? Entries for kmb-drm are similar to this. > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings

RE: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-11 Thread Chrisanthus, Anitha
> -Original Message- > From: Neil Armstrong > Sent: Thursday, September 10, 2020 2:33 AM > To: Chrisanthus, Anitha ; dri- > de...@lists.freedesktop.org; Paauwe, Bob J ; > Dea, Edmund J > Cc: Vetter, Daniel > Subject: Re: [PATCH v7 2/4] drm/kmb: Add support for KeemB

Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-11 Thread Daniel Vetter
On Thu, Sep 10, 2020 at 08:33:43PM +0200, Sam Ravnborg wrote: > Hi Daniel. > > > > + } > > > + > > > + /* Initialize MIPI DSI */ > > > + ret = kmb_dsi_init(drm, adv_bridge); > > > > Split up isn't correct here, this won't compile since the dsi code isn't > > in this patch yet. So you need to have

Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-10 Thread Sam Ravnborg
Hi Daniel. > > + } > > + > > + /* Initialize MIPI DSI */ > > + ret = kmb_dsi_init(drm, adv_bridge); > > Split up isn't correct here, this won't compile since the dsi code isn't > in this patch yet. So you need to have this ordered the other way round. I have explicit asked for a simple fil

Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-10 Thread Neil Armstrong
On 31/08/2020 22:02, Anitha Chrisanthus wrote: > This is a basic KMS atomic modesetting display driver for KeemBay family of > SOCs. Driver has no 2D or 3D graphics.It calls into the ADV bridge > driver at the connector level. > > Single CRTC with LCD controller->mipi DSI-> ADV bridge > > Only 10

Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-10 Thread Daniel Vetter
On Mon, Aug 31, 2020 at 01:02:50PM -0700, Anitha Chrisanthus wrote: > This is a basic KMS atomic modesetting display driver for KeemBay family of > SOCs. Driver has no 2D or 3D graphics.It calls into the ADV bridge > driver at the connector level. > > Single CRTC with LCD controller->mipi DSI-> AD

Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-10 Thread Daniel Vetter
On Mon, Aug 31, 2020 at 01:02:50PM -0700, Anitha Chrisanthus wrote: > This is a basic KMS atomic modesetting display driver for KeemBay family of > SOCs. Driver has no 2D or 3D graphics.It calls into the ADV bridge > driver at the connector level. > > Single CRTC with LCD controller->mipi DSI-> AD

[PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-08-31 Thread Anitha Chrisanthus
This is a basic KMS atomic modesetting display driver for KeemBay family of SOCs. Driver has no 2D or 3D graphics.It calls into the ADV bridge driver at the connector level. Single CRTC with LCD controller->mipi DSI-> ADV bridge Only 1080p resolution and single plane is supported at this time. v