Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-12 Thread Finn Thain
On Thu, 11 May 2023, Thomas Zimmermann wrote: > But I'd really like to see most of these drivers being moved into > staging and deleted soon afterwards. Users will complain about those > drivers that are really still required. Those might be worth to spend > effort on. > That strategy is not

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-12 Thread Thomas Zimmermann
Hi Am 11.05.23 um 19:02 schrieb Helge Deller: On 5/11/23 16:27, Thomas Zimmermann wrote: But the work I do within fbdev is mostly for improving DRM. Sure. For the other issues in this file, I don't think that matroxfb should even be around any longer. Fbdev has been deprecated for a long ti

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-11 Thread Helge Deller
On 5/11/23 16:27, Thomas Zimmermann wrote: But the work I do within fbdev is mostly for improving DRM. Sure. For the other issues in this file, I don't think that matroxfb should even be around any longer. Fbdev has been deprecated for a long time. But a small number of drivers are still in u

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-11 Thread Helge Deller
On 5/11/23 15:10, Geert Uytterhoeven wrote: Hi Helge, On Thu, May 11, 2023 at 3:05 PM Helge Deller wrote: On 5/11/23 09:55, Thomas Zimmermann wrote: But the work I do within fbdev is mostly for improving DRM. Sure. For the other issues in this file, I don't think that matroxfb should even

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-11 Thread Thomas Zimmermann
Hi Am 11.05.23 um 15:05 schrieb Helge Deller: On 5/11/23 09:55, Thomas Zimmermann wrote: Hi Am 10.05.23 um 20:20 schrieb Sui Jingfeng: Hi, Thomas I love your patch, yet something to improve: On 2023/5/10 19:05, Thomas Zimmermann wrote: Fix coding style. No functional changes. Signed-off

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-11 Thread Geert Uytterhoeven
Hi Helge, On Thu, May 11, 2023 at 3:05 PM Helge Deller wrote: > On 5/11/23 09:55, Thomas Zimmermann wrote: > > But the work I do within fbdev is mostly for improving DRM. > > Sure. > > > For the > > other issues in this file, I don't think that matroxfb should even be > > around any longer. Fbdev

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-11 Thread Helge Deller
On 5/11/23 09:55, Thomas Zimmermann wrote: Hi Am 10.05.23 um 20:20 schrieb Sui Jingfeng: Hi, Thomas I love your patch, yet something to improve: On 2023/5/10 19:05, Thomas Zimmermann wrote: Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergma

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-11 Thread Sui Jingfeng
Hi On 2023/5/11 15:55, Thomas Zimmermann wrote: Hi Am 10.05.23 um 20:20 schrieb Sui Jingfeng: Hi, Thomas I love your patch, yet something to improve: On 2023/5/10 19:05, Thomas Zimmermann wrote: Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-11 Thread Thomas Zimmermann
Hi Am 10.05.23 um 20:20 schrieb Sui Jingfeng: Hi, Thomas I love your patch, yet something to improve: On 2023/5/10 19:05, Thomas Zimmermann wrote: Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergmann Reviewed-by: Sam Ravnborg Reviewed-by:

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-10 Thread Sui Jingfeng
Hi, Thomas I love your patch, yet something to improve: On 2023/5/10 19:05, Thomas Zimmermann wrote: Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergmann Reviewed-by: Sam Ravnborg Reviewed-by: Sui Jingfeng Tested-by: Sui Jingfeng --- dri

[PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-10 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergmann Reviewed-by: Sam Ravnborg Reviewed-by: Sui Jingfeng Tested-by: Sui Jingfeng --- drivers/video/fbdev/matrox/matroxfb_accel.c | 6 +++--- drivers/video/fbdev/matrox/matroxfb_base.h | 4 ++-- 2