Re: [PATCH v5 10/16] drm/vkms: Re-introduce line-per-line composition algorithm

2024-04-08 Thread Louis Chauvet
Le 27/03/24 - 14:29, Pekka Paalanen a écrit : > On Tue, 26 Mar 2024 16:57:02 +0100 > Louis Chauvet wrote: > > > [...] > > > > > > @@ -215,34 +188,146 @@ static void blend(struct vkms_writeback_job *wb, > > > > { > > > > struct vkms_plane_state **plane = crtc_state->active_planes; > > >

Re: [PATCH v5 10/16] drm/vkms: Re-introduce line-per-line composition algorithm

2024-03-27 Thread Pekka Paalanen
On Tue, 26 Mar 2024 16:57:02 +0100 Louis Chauvet wrote: > [...] > > > > @@ -215,34 +188,146 @@ static void blend(struct vkms_writeback_job *wb, > > > { > > > struct vkms_plane_state **plane = crtc_state->active_planes; > > > u32 n_active_planes = crtc_state->num_active_planes; > > > - int y

Re: [PATCH v5 10/16] drm/vkms: Re-introduce line-per-line composition algorithm

2024-03-26 Thread Louis Chauvet
[...] > > @@ -215,34 +188,146 @@ static void blend(struct vkms_writeback_job *wb, > > { > > struct vkms_plane_state **plane = crtc_state->active_planes; > > u32 n_active_planes = crtc_state->num_active_planes; > > - int y_pos, x_dst, x_limit; > > > > const struct pixel_argb_u16 ba

Re: [PATCH v5 10/16] drm/vkms: Re-introduce line-per-line composition algorithm

2024-03-26 Thread Louis Chauvet
Le 25/03/24 - 11:15, Maíra Canal a écrit : > On 3/13/24 14:45, Louis Chauvet wrote: > > Re-introduce a line-by-line composition algorithm for each pixel format. > > This allows more performance by not requiring an indirection per pixel > > read. This patch is focused on readability of the code. > >

Re: [PATCH v5 10/16] drm/vkms: Re-introduce line-per-line composition algorithm

2024-03-25 Thread Pekka Paalanen
On Wed, 13 Mar 2024 18:45:04 +0100 Louis Chauvet wrote: > Re-introduce a line-by-line composition algorithm for each pixel format. > This allows more performance by not requiring an indirection per pixel > read. This patch is focused on readability of the code. > > Line-by-line composition was i

Re: [PATCH v5 10/16] drm/vkms: Re-introduce line-per-line composition algorithm

2024-03-25 Thread Pekka Paalanen
On Mon, 25 Mar 2024 11:15:13 -0300 Maíra Canal wrote: > On 3/13/24 14:45, Louis Chauvet wrote: > > Re-introduce a line-by-line composition algorithm for each pixel format. > > This allows more performance by not requiring an indirection per pixel > > read. This patch is focused on readability of

Re: [PATCH v5 10/16] drm/vkms: Re-introduce line-per-line composition algorithm

2024-03-25 Thread Maíra Canal
On 3/13/24 14:45, Louis Chauvet wrote: Re-introduce a line-by-line composition algorithm for each pixel format. This allows more performance by not requiring an indirection per pixel read. This patch is focused on readability of the code. Line-by-line composition was introduced by [1] but rewrit

[PATCH v5 10/16] drm/vkms: Re-introduce line-per-line composition algorithm

2024-03-13 Thread Louis Chauvet
Re-introduce a line-by-line composition algorithm for each pixel format. This allows more performance by not requiring an indirection per pixel read. This patch is focused on readability of the code. Line-by-line composition was introduced by [1] but rewritten back to pixel-by-pixel algorithm in [