Re: [PATCH v4 7/9] drm: bridge: dw-hdmi: Add support for custom PHY configuration

2017-03-05 Thread Jose Abreu
Hi Laurent, On 02-03-2017 15:38, Laurent Pinchart wrote: > Hi Jose, > > On Thursday 02 Mar 2017 14:50:02 Jose Abreu wrote: >> On 02-03-2017 13:41, Laurent Pinchart wrote: Hmm, this is kind of confusing. Why do you need a phy_ops and then a separate configure_phy function? Can't we just

Re: [PATCH v4 7/9] drm: bridge: dw-hdmi: Add support for custom PHY configuration

2017-03-03 Thread Laurent Pinchart
Hi Jose, (CC'ing Archit) On Friday 03 Mar 2017 15:57:57 Jose Abreu wrote: > On 02-03-2017 15:38, Laurent Pinchart wrote: > > On Thursday 02 Mar 2017 14:50:02 Jose Abreu wrote: > >> On 02-03-2017 13:41, Laurent Pinchart wrote: > Hmm, this is kind of confusing. Why do you need a phy_ops and >

Re: [PATCH v4 7/9] drm: bridge: dw-hdmi: Add support for custom PHY configuration

2017-03-02 Thread Jose Abreu
Hi Laurent, On 02-03-2017 13:41, Laurent Pinchart wrote: > >> Hmm, this is kind of confusing. Why do you need a phy_ops and >> then a separate configure_phy function? Can't we just use phy_ops >> always? If its external phy then it would need to implement all >> phy_ops functions. > The phy_ops a

Re: [PATCH v4 7/9] drm: bridge: dw-hdmi: Add support for custom PHY configuration

2017-03-02 Thread Jose Abreu
Hi Laurent, On 01-03-2017 22:39, Laurent Pinchart wrote: > From: Kieran Bingham > > The DWC HDMI TX controller interfaces with a companion PHY. While > Synopsys provides multiple standard PHYs, SoC vendors can also integrate > a custom PHY. > > Modularize PHY configuration to support vendor PHYs

Re: [PATCH v4 7/9] drm: bridge: dw-hdmi: Add support for custom PHY configuration

2017-03-02 Thread Laurent Pinchart
Hi Jose, On Thursday 02 Mar 2017 14:50:02 Jose Abreu wrote: > On 02-03-2017 13:41, Laurent Pinchart wrote: > >> Hmm, this is kind of confusing. Why do you need a phy_ops and > >> then a separate configure_phy function? Can't we just use phy_ops > >> always? If its external phy then it would need t

Re: [PATCH v4 7/9] drm: bridge: dw-hdmi: Add support for custom PHY configuration

2017-03-02 Thread Laurent Pinchart
Hi Jose, On Thursday 02 Mar 2017 12:50:13 Jose Abreu wrote: > On 01-03-2017 22:39, Laurent Pinchart wrote: > > From: Kieran Bingham > > > > The DWC HDMI TX controller interfaces with a companion PHY. While > > Synopsys provides multiple standard PHYs, SoC vendors can also integrate > > a custom

[PATCH v4 7/9] drm: bridge: dw-hdmi: Add support for custom PHY configuration

2017-03-01 Thread Laurent Pinchart
From: Kieran Bingham The DWC HDMI TX controller interfaces with a companion PHY. While Synopsys provides multiple standard PHYs, SoC vendors can also integrate a custom PHY. Modularize PHY configuration to support vendor PHYs through platform data. The existing PHY configuration code was origina