Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-21 Thread Pekka Paalanen
On Fri, 18 Jun 2021 15:19:15 +0300 Laurent Pinchart wrote: > Hi Pekka, > > On Fri, Jun 18, 2021 at 02:32:00PM +0300, Pekka Paalanen wrote: > > On Fri, 18 Jun 2021 12:58:49 +0300 Laurent Pinchart wrote: > > > On Fri, Jun 18, 2021 at 11:55:38AM +0300, Pekka Paalanen wrote: > > > > On Thu, 17 J

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-18 Thread Laurent Pinchart
Hi Pekka, On Fri, Jun 18, 2021 at 02:32:00PM +0300, Pekka Paalanen wrote: > On Fri, 18 Jun 2021 12:58:49 +0300 Laurent Pinchart wrote: > > On Fri, Jun 18, 2021 at 11:55:38AM +0300, Pekka Paalanen wrote: > > > On Thu, 17 Jun 2021 16:37:14 +0300 Laurent Pinchart wrote: > > > > On Thu, Jun 17, 2021

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-18 Thread Pekka Paalanen
On Fri, 18 Jun 2021 12:58:49 +0300 Laurent Pinchart wrote: > Hi Pekka, > > On Fri, Jun 18, 2021 at 11:55:38AM +0300, Pekka Paalanen wrote: > > On Thu, 17 Jun 2021 16:37:14 +0300 Laurent Pinchart wrote: > > > On Thu, Jun 17, 2021 at 02:33:11PM +0300, Pekka Paalanen wrote: > > > > On Thu, 17 J

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-18 Thread Laurent Pinchart
Hi Pekka, On Fri, Jun 18, 2021 at 11:55:38AM +0300, Pekka Paalanen wrote: > On Thu, 17 Jun 2021 16:37:14 +0300 Laurent Pinchart wrote: > > On Thu, Jun 17, 2021 at 02:33:11PM +0300, Pekka Paalanen wrote: > > > On Thu, 17 Jun 2021 13:29:48 +0300 Laurent Pinchart wrote: > > > > On Thu, Jun 17, 2021

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-18 Thread Pekka Paalanen
On Thu, 17 Jun 2021 16:37:14 +0300 Laurent Pinchart wrote: > Hi Pekka, > > On Thu, Jun 17, 2021 at 02:33:11PM +0300, Pekka Paalanen wrote: > > On Thu, 17 Jun 2021 13:29:48 +0300 Laurent Pinchart wrote: > > > On Thu, Jun 17, 2021 at 10:27:01AM +0300, Pekka Paalanen wrote: > > > > On Thu, 17 J

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-17 Thread Laurent Pinchart
Hi Pekka, On Thu, Jun 17, 2021 at 02:33:11PM +0300, Pekka Paalanen wrote: > On Thu, 17 Jun 2021 13:29:48 +0300 Laurent Pinchart wrote: > > On Thu, Jun 17, 2021 at 10:27:01AM +0300, Pekka Paalanen wrote: > > > On Thu, 17 Jun 2021 00:05:24 +0300 Laurent Pinchart wrote: > > > > On Tue, Jun 15, 2021

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-17 Thread Pekka Paalanen
On Thu, 17 Jun 2021 13:29:48 +0300 Laurent Pinchart wrote: > Hi Pekka, > > On Thu, Jun 17, 2021 at 10:27:01AM +0300, Pekka Paalanen wrote: > > On Thu, 17 Jun 2021 00:05:24 +0300 Laurent Pinchart wrote: > > > On Tue, Jun 15, 2021 at 01:16:56PM +0300, Pekka Paalanen wrote: > > > > On Tue, 15 J

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-17 Thread Laurent Pinchart
Hi Pekka, On Thu, Jun 17, 2021 at 10:27:01AM +0300, Pekka Paalanen wrote: > On Thu, 17 Jun 2021 00:05:24 +0300 Laurent Pinchart wrote: > > On Tue, Jun 15, 2021 at 01:16:56PM +0300, Pekka Paalanen wrote: > > > On Tue, 15 Jun 2021 12:45:57 +0300 Laurent Pinchart wrote: > > > > On Tue, Jun 15, 2021

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-17 Thread Pekka Paalanen
On Thu, 17 Jun 2021 00:05:24 +0300 Laurent Pinchart wrote: > On Tue, Jun 15, 2021 at 01:16:56PM +0300, Pekka Paalanen wrote: > > On Tue, 15 Jun 2021 12:45:57 +0300 Laurent Pinchart wrote: > > > On Tue, Jun 15, 2021 at 07:15:18AM +, Simon Ser wrote: > > > > On Tuesday, June 15th, 2021 at 0

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-16 Thread Laurent Pinchart
On Tue, Jun 15, 2021 at 01:16:56PM +0300, Pekka Paalanen wrote: > On Tue, 15 Jun 2021 12:45:57 +0300 Laurent Pinchart wrote: > > On Tue, Jun 15, 2021 at 07:15:18AM +, Simon Ser wrote: > > > On Tuesday, June 15th, 2021 at 09:03, Pekka Paalanen wrote: > > > > > > > indeed it will, but what els

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-16 Thread Daniel Vetter
On Tue, Jun 15, 2021 at 2:09 PM Simon Ser wrote: > > On Tuesday, June 15th, 2021 at 12:16, Pekka Paalanen > wrote: > > > Good reminder about CRCs. CRCs have zero tolerance, so they are not > > useful for testing properties that have any leeway, are they? > > IIRC, IGT's alpha blending test curre

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-15 Thread Simon Ser
On Tuesday, June 15th, 2021 at 12:16, Pekka Paalanen wrote: > Good reminder about CRCs. CRCs have zero tolerance, so they are not > useful for testing properties that have any leeway, are they? IIRC, IGT's alpha blending test currently computes the CRC for all possible roundings, then checks th

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-15 Thread Pekka Paalanen
On Tue, 15 Jun 2021 12:45:57 +0300 Laurent Pinchart wrote: > On Tue, Jun 15, 2021 at 07:15:18AM +, Simon Ser wrote: > > On Tuesday, June 15th, 2021 at 09:03, Pekka Paalanen > > wrote: > > > > > indeed it will, but what else could one do to test userspace KMS > > > clients in generic CI w

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-15 Thread Laurent Pinchart
On Tue, Jun 15, 2021 at 07:15:18AM +, Simon Ser wrote: > On Tuesday, June 15th, 2021 at 09:03, Pekka Paalanen > wrote: > > > indeed it will, but what else could one do to test userspace KMS > > clients in generic CI where all you can have is virtual hardware? Maybe > > in the long run VKMS n

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-15 Thread Simon Ser
On Tuesday, June 15th, 2021 at 09:03, Pekka Paalanen wrote: > indeed it will, but what else could one do to test userspace KMS > clients in generic CI where all you can have is virtual hardware? Maybe > in the long run VKMS needs to loop back to a userspace daemon that > implements all the compl

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-15 Thread Pekka Paalanen
On Mon, 14 Jun 2021 19:33:47 +0300 Laurent Pinchart wrote: > On Mon, Jun 14, 2021 at 04:24:13PM +0100, Liviu Dudau wrote: > > On Mon, Jun 14, 2021 at 05:49:12PM +0300, Pekka Paalanen wrote: > > > On Fri, 11 Jun 2021 13:03:09 +0100 > > > Liviu Dudau wrote: > > > > > > > On Fri, Jun 11, 2021

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-14 Thread Laurent Pinchart
On Mon, Jun 14, 2021 at 04:24:13PM +0100, Liviu Dudau wrote: > On Mon, Jun 14, 2021 at 05:49:12PM +0300, Pekka Paalanen wrote: > > On Fri, 11 Jun 2021 13:03:09 +0100 > > Liviu Dudau wrote: > > > > > On Fri, Jun 11, 2021 at 08:14:59AM +, Simon Ser wrote: > > > > On Thursday, June 10th, 2021 at

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-14 Thread Laurent Pinchart
On Fri, Jun 11, 2021 at 02:34:18PM +0100, Liviu Dudau wrote: > On Fri, Jun 11, 2021 at 08:56:04AM -0400, Alyssa Rosenzweig wrote: > > > What I'm expected to see in the future is new functionality that gets > > > implemented by > > > one hardware vendor and the kernel developers trying to enable th

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-14 Thread Laurent Pinchart
On Fri, Jun 11, 2021 at 07:54:07AM +0200, Maxime Ripard wrote: > On Thu, Jun 10, 2021 at 11:00:05PM +0200, Daniel Vetter wrote: > > On Thu, Jun 10, 2021 at 7:47 PM Maxime Ripard wrote: > > > > > > New KMS properties come with a bunch of requirements to avoid each > > > driver from running their ow

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-14 Thread Liviu Dudau
On Mon, Jun 14, 2021 at 05:49:12PM +0300, Pekka Paalanen wrote: > On Fri, 11 Jun 2021 13:03:09 +0100 > Liviu Dudau wrote: > > > On Fri, Jun 11, 2021 at 08:14:59AM +, Simon Ser wrote: > > > On Thursday, June 10th, 2021 at 23:00, Daniel Vetter > > > wrote: > > > > > > > If there's a strong

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-14 Thread Pekka Paalanen
On Fri, 11 Jun 2021 13:03:09 +0100 Liviu Dudau wrote: > On Fri, Jun 11, 2021 at 08:14:59AM +, Simon Ser wrote: > > On Thursday, June 10th, 2021 at 23:00, Daniel Vetter > > wrote: > > > > > If there's a strong consensus that we really need this then I'm not > > > going to nack this, but t

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-14 Thread Pekka Paalanen
On Fri, 11 Jun 2021 07:54:07 +0200 Maxime Ripard wrote: > Hi, > > On Thu, Jun 10, 2021 at 11:00:05PM +0200, Daniel Vetter wrote: > > On Thu, Jun 10, 2021 at 7:47 PM Maxime Ripard wrote: > > > > > > New KMS properties come with a bunch of requirements to avoid each > > > driver from running th

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-11 Thread Daniel Vetter
On Fri, Jun 11, 2021 at 09:53:19AM +0300, Tomi Valkeinen wrote: > On 11/06/2021 08:54, Maxime Ripard wrote: > > Hi, > > > > On Thu, Jun 10, 2021 at 11:00:05PM +0200, Daniel Vetter wrote: > > > On Thu, Jun 10, 2021 at 7:47 PM Maxime Ripard wrote: > > > > > > > > New KMS properties come with a bun

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-11 Thread Liviu Dudau
On Fri, Jun 11, 2021 at 08:56:04AM -0400, Alyssa Rosenzweig wrote: > > What I'm expected to see in the future is new functionality that gets > > implemented by > > one hardware vendor and the kernel developers trying to enable that for > > userspace. It > > could be that the new property is gener

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-11 Thread Alyssa Rosenzweig
> What I'm expected to see in the future is new functionality that gets > implemented by > one hardware vendor and the kernel developers trying to enable that for > userspace. It > could be that the new property is generic, but there is no way of testing > that on > more than one implementation

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-11 Thread Liviu Dudau
On Fri, Jun 11, 2021 at 08:14:59AM +, Simon Ser wrote: > On Thursday, June 10th, 2021 at 23:00, Daniel Vetter > wrote: > > > If there's a strong consensus that we really need this then I'm not > > going to nack this, but this really needs a pile of acks from > > compositor folks that they're

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-11 Thread Simon Ser
On Thursday, June 10th, 2021 at 23:00, Daniel Vetter wrote: > If there's a strong consensus that we really need this then I'm not > going to nack this, but this really needs a pile of acks from > compositor folks that they're willing to live with the resulting > fallout this will likely bring. Y

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-10 Thread Tomi Valkeinen
On 11/06/2021 08:54, Maxime Ripard wrote: Hi, On Thu, Jun 10, 2021 at 11:00:05PM +0200, Daniel Vetter wrote: On Thu, Jun 10, 2021 at 7:47 PM Maxime Ripard wrote: New KMS properties come with a bunch of requirements to avoid each driver from running their own, inconsistent, set of properties,

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-10 Thread Maxime Ripard
Hi, On Thu, Jun 10, 2021 at 11:00:05PM +0200, Daniel Vetter wrote: > On Thu, Jun 10, 2021 at 7:47 PM Maxime Ripard wrote: > > > > New KMS properties come with a bunch of requirements to avoid each > > driver from running their own, inconsistent, set of properties, > > eventually leading to issues

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-10 Thread Daniel Vetter
On Thu, Jun 10, 2021 at 7:47 PM Maxime Ripard wrote: > > New KMS properties come with a bunch of requirements to avoid each > driver from running their own, inconsistent, set of properties, > eventually leading to issues like property conflicts, inconsistencies > between drivers and semantics, etc

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-10 Thread Rodrigo Vivi
On Thu, Jun 10, 2021 at 07:47:31PM +0200, Maxime Ripard wrote: > New KMS properties come with a bunch of requirements to avoid each > driver from running their own, inconsistent, set of properties, > eventually leading to issues like property conflicts, inconsistencies > between drivers and semanti

Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-10 Thread Liviu Dudau
Hi Maxime, On Thu, Jun 10, 2021 at 07:47:31PM +0200, Maxime Ripard wrote: > New KMS properties come with a bunch of requirements to avoid each > driver from running their own, inconsistent, set of properties, > eventually leading to issues like property conflicts, inconsistencies > between drivers

[PATCH v3] Documentation: gpu: Mention the requirements for new properties

2021-06-10 Thread Maxime Ripard
New KMS properties come with a bunch of requirements to avoid each driver from running their own, inconsistent, set of properties, eventually leading to issues like property conflicts, inconsistencies between drivers and semantics, etc. Let's document what we expect. Cc: Alexandre Belloni Cc: Al