Hi, On Thu, Jun 10, 2021 at 11:00:05PM +0200, Daniel Vetter wrote: > On Thu, Jun 10, 2021 at 7:47 PM Maxime Ripard <max...@cerno.tech> wrote: > > > > New KMS properties come with a bunch of requirements to avoid each > > driver from running their own, inconsistent, set of properties, > > eventually leading to issues like property conflicts, inconsistencies > > between drivers and semantics, etc. > > > > Let's document what we expect. > > > > Cc: Alexandre Belloni <alexandre.bell...@bootlin.com> > > Cc: Alexandre Torgue <alexandre.tor...@foss.st.com> > > Cc: Alex Deucher <alexander.deuc...@amd.com> > > Cc: Alison Wang <alison.w...@nxp.com> > > Cc: Alyssa Rosenzweig <alyssa.rosenzw...@collabora.com> > > Cc: Andrew Jeffery <and...@aj.id.au> > > Cc: Andrzej Hajda <a.ha...@samsung.com> > > Cc: Anitha Chrisanthus <anitha.chrisant...@intel.com> > > Cc: Benjamin Gaignard <benjamin.gaign...@linaro.org> > > Cc: Ben Skeggs <bske...@redhat.com> > > Cc: Boris Brezillon <bbrezil...@kernel.org> > > Cc: Brian Starkey <brian.star...@arm.com> > > Cc: Chen Feng <puck.c...@hisilicon.com> > > Cc: Chen-Yu Tsai <w...@csie.org> > > Cc: Christian Gmeiner <christian.gmei...@gmail.com> > > Cc: "Christian König" <christian.koe...@amd.com> > > Cc: Chun-Kuang Hu <chunkuang...@kernel.org> > > Cc: Edmund Dea <edmund.j....@intel.com> > > Cc: Eric Anholt <e...@anholt.net> > > Cc: Fabio Estevam <feste...@gmail.com> > > Cc: Gerd Hoffmann <kra...@redhat.com> > > Cc: Haneen Mohammed <hamohammed...@gmail.com> > > Cc: Hans de Goede <hdego...@redhat.com> > > Cc: "Heiko Stübner" <he...@sntech.de> > > Cc: Huang Rui <ray.hu...@amd.com> > > Cc: Hyun Kwon <hyun.k...@xilinx.com> > > Cc: Inki Dae <inki....@samsung.com> > > Cc: Jani Nikula <jani.nik...@linux.intel.com> > > Cc: Jernej Skrabec <jernej.skra...@siol.net> > > Cc: Jerome Brunet <jbru...@baylibre.com> > > Cc: Joel Stanley <j...@jms.id.au> > > Cc: John Stultz <john.stu...@linaro.org> > > Cc: Jonas Karlman <jo...@kwiboo.se> > > Cc: Jonathan Hunter <jonath...@nvidia.com> > > Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> > > Cc: Joonyoung Shim <jy0922.s...@samsung.com> > > Cc: Jyri Sarha <jyri.sa...@iki.fi> > > Cc: Kevin Hilman <khil...@baylibre.com> > > Cc: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > > Cc: Krzysztof Kozlowski <krzysztof.kozlow...@canonical.com> > > Cc: Kyungmin Park <kyungmin.p...@samsung.com> > > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > > Cc: Linus Walleij <linus.wall...@linaro.org> > > Cc: Liviu Dudau <liviu.du...@arm.com> > > Cc: Lucas Stach <l.st...@pengutronix.de> > > Cc: Ludovic Desroches <ludovic.desroc...@microchip.com> > > Cc: Marek Vasut <ma...@denx.de> > > Cc: Martin Blumenstingl <martin.blumensti...@googlemail.com> > > Cc: Matthias Brugger <matthias....@gmail.com> > > Cc: Maxime Coquelin <mcoquelin.st...@gmail.com> > > Cc: Maxime Ripard <mrip...@kernel.org> > > Cc: Melissa Wen <melissa....@gmail.com> > > Cc: Neil Armstrong <narmstr...@baylibre.com> > > Cc: Nicolas Ferre <nicolas.fe...@microchip.com> > > Cc: "Noralf Trønnes" <nor...@tronnes.org> > > Cc: NXP Linux Team <linux-...@nxp.com> > > Cc: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> > > Cc: Patrik Jakobsson <patrik.r.jakobs...@gmail.com> > > Cc: Paul Cercueil <p...@crapouillou.net> > > Cc: Pengutronix Kernel Team <ker...@pengutronix.de> > > Cc: Philippe Cornu <philippe.co...@foss.st.com> > > Cc: Philipp Zabel <p.za...@pengutronix.de> > > Cc: Qiang Yu <yuq...@gmail.com> > > Cc: Rob Clark <robdcl...@gmail.com> > > Cc: Robert Foss <robert.f...@linaro.org> > > Cc: Rob Herring <r...@kernel.org> > > Cc: Rodrigo Siqueira <rodrigosiqueiram...@gmail.com> > > Cc: Rodrigo Vivi <rodrigo.v...@intel.com> > > Cc: Roland Scheidegger <srol...@vmware.com> > > Cc: Russell King <li...@armlinux.org.uk> > > Cc: Sam Ravnborg <s...@ravnborg.org> > > Cc: Sandy Huang <h...@rock-chips.com> > > Cc: Sascha Hauer <s.ha...@pengutronix.de> > > Cc: Sean Paul <s...@poorly.run> > > Cc: Seung-Woo Kim <sw0312....@samsung.com> > > Cc: Shawn Guo <shawn...@kernel.org> > > Cc: Stefan Agner <ste...@agner.ch> > > Cc: Steven Price <steven.pr...@arm.com> > > Cc: Sumit Semwal <sumit.sem...@linaro.org> > > Cc: Thierry Reding <thierry.red...@gmail.com> > > Cc: Tian Tao <tiant...@hisilicon.com> > > Cc: Tomeu Vizoso <tomeu.viz...@collabora.com> > > Cc: Tomi Valkeinen <to...@kernel.org> > > Cc: VMware Graphics <linux-graphics-maintai...@vmware.com> > > Cc: Xinliang Liu <xinliang....@linaro.org> > > Cc: Xinwei Kong <kong.kongxin...@hisilicon.com> > > Cc: Yannick Fertre <yannick.fer...@foss.st.com> > > Cc: Zack Rusin <za...@vmware.com> > > Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> > > Signed-off-by: Maxime Ripard <max...@cerno.tech> > > > > --- > > > > Changes from v2: > > - Take into account the feedback from Laurent and Lidiu to no longer > > force generic properties, but prefix vendor-specific properties with > > the vendor name > > I'm pretty sure my r-b was without this ...
Yeah, sorry. I wanted to tell you on IRC that you wanted to have a second look, but I shouldn't have kept it and caught you by surprise indeed. > Why exactly do we need this? KMS is meant to be fairly generic (bugs > throw a wrench around here sometimes, and semantics can be tricky). If > we open up the door to yolo vendor properties in upstream, then that > goal is pretty much written off. And we've been there with vendor > properties, it's a giantic mess. > > Minimally drop my r-b, I'm definitely not in support of this idea. So the argument Lidiu and Laurent made was that in some cases, getting a generic property right with only a couple of users is hard. So they advocated for the right to keep non-generic properties. I can get the argument, and no-one else said that was wrong, so it felt like the consensus was there. > If there's a strong consensus that we really need this then I'm not > going to nack this, but this really needs a pile of acks from > compositor folks that they're willing to live with the resulting > fallout this will likely bring. Your cc list seems to have an absence > of compositor folks, but instead every driver maintainer. That's > backwards. We make uapi for userspace, not for kernel driver > maintainers! Right, but it's mostly about in-kernel rules though? And you're the one who mentionned CC'ing the driver maintainers in the first iteration? > ltdr; I'd go back to v2. And then cc compositor folks on this to get > their ack. So, Pekka, Simon, is there anyone else I should Cc? Thanks! Maxime
signature.asc
Description: PGP signature
