Re: [PATCH v2 4/9] drm/panel: Add driver for the LG Philips LB035Q02 panel

2019-08-11 Thread Sam Ravnborg
Hi Noralf. > >>> + /* register value */ > >>> + buffer[4] = 0x72; > >>> + buffer[5] = val >> 8; > >>> + buffer[6] = val; > >>> + value_xfer.tx_buf = buffer + 4; > >>> + spi_message_add_tail(&value_xfer, &msg); > >>> + > >>> + return spi_sync(lcd->spi, &msg); > >>> +} > >> > >> Just a note to Sam:

Re: [PATCH v2 4/9] drm/panel: Add driver for the LG Philips LB035Q02 panel

2019-08-11 Thread Noralf Trønnes
Den 11.08.2019 18.49, skrev Sam Ravnborg: > Hi Noralf. > >>> +static int lb035q02_write(struct lb035q02_device *lcd, u16 reg, u16 val) >>> +{ >>> + struct spi_message msg; >>> + struct spi_transfer index_xfer = { >>> + .len= 3, >>> + .cs_change = 1, >>> +

Re: [PATCH v2 4/9] drm/panel: Add driver for the LG Philips LB035Q02 panel

2019-08-11 Thread Sam Ravnborg
Hi Noralf. > > +static int lb035q02_write(struct lb035q02_device *lcd, u16 reg, u16 val) > > +{ > > + struct spi_message msg; > > + struct spi_transfer index_xfer = { > > + .len= 3, > > + .cs_change = 1, > > + }; > > + struct spi_transfer value_xfer = {

Re: [PATCH v2 4/9] drm/panel: Add driver for the LG Philips LB035Q02 panel

2019-08-11 Thread Noralf Trønnes
Hi Laurent, Den 11.08.2019 15.35, skrev Laurent Pinchart: > Hi Noralf, > > On Sun, Aug 11, 2019 at 03:19:13PM +0200, Noralf Trønnes wrote: >> Sam, >> >> Den 11.08.2019 01.10, skrev Laurent Pinchart: >>> This panel is used on the Gumstix Overo Palo35. >>> >>> The code is based on the omapdrm-speci

Re: [PATCH v2 4/9] drm/panel: Add driver for the LG Philips LB035Q02 panel

2019-08-11 Thread Laurent Pinchart
Hi Noralf, On Sun, Aug 11, 2019 at 03:19:13PM +0200, Noralf Trønnes wrote: > Sam, > > Den 11.08.2019 01.10, skrev Laurent Pinchart: > > This panel is used on the Gumstix Overo Palo35. > > > > The code is based on the omapdrm-specific panel-lgphilips-lb035q02 > > driver. > > > > Signed-off-by: L

Re: [PATCH v2 4/9] drm/panel: Add driver for the LG Philips LB035Q02 panel

2019-08-11 Thread Noralf Trønnes
Sam, Den 11.08.2019 01.10, skrev Laurent Pinchart: > This panel is used on the Gumstix Overo Palo35. > > The code is based on the omapdrm-specific panel-lgphilips-lb035q02 > driver. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Sam Ravnborg > --- > diff --git a/drivers/gpu/drm/panel/pa

[PATCH v2 4/9] drm/panel: Add driver for the LG Philips LB035Q02 panel

2019-08-10 Thread Laurent Pinchart
This panel is used on the Gumstix Overo Palo35. The code is based on the omapdrm-specific panel-lgphilips-lb035q02 driver. Signed-off-by: Laurent Pinchart Reviewed-by: Sam Ravnborg --- Changes since v1: - Comments updates - Store width_mm and height_mm in drm_display_mode - Use drm_panel_disab