Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-04-07 Thread Sui Jingfeng
On 2022/3/23 21:11, Rob Herring wrote: On Wed, Mar 23, 2022 at 12:12:43PM +0800, Sui Jingfeng wrote: On 2022/3/23 04:49, Rob Herring wrote: +/* + * mainly for dc in ls7a1000 which have builtin gpio emulated i2c + * + * @index : output channel index, 0 for DVO0, 1 for DVO1 + */ +struct lsdc_i2

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-03-24 Thread Rob Herring
On Thu, Mar 24, 2022 at 03:32:01PM +0800, Sui Jingfeng wrote: > > On 2022/3/23 04:49, Rob Herring wrote: > > > + } > > > + > > > + spin_lock_init(&li2c->reglock); > > > + > > > + snprintf(compat, sizeof(compat), "lsdc,i2c-gpio-%d", index); > > compatible values shouldn't have an index and you shou

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-03-24 Thread Rob Herring
On Thu, Mar 24, 2022 at 09:39:49AM +0800, Sui Jingfeng wrote: > > On 2022/3/23 04:49, Rob Herring wrote: > > On Tue, Mar 22, 2022 at 12:29:16AM +0800, Sui Jingfeng wrote: > > > From: suijingfeng > > > > > > There is a display controller in loongson's LS2K1000 SoC and LS7A1000 > > > bridge chip,

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-03-24 Thread Sui Jingfeng
On 2022/3/23 04:49, Rob Herring wrote: + } + + spin_lock_init(&li2c->reglock); + + snprintf(compat, sizeof(compat), "lsdc,i2c-gpio-%d", index); compatible values shouldn't have an index and you shouldn't need a index in DT. You need to iterate over child nodes with matching c

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-03-23 Thread Sui Jingfeng
On 2022/3/23 21:11, Rob Herring wrote: On Wed, Mar 23, 2022 at 12:12:43PM +0800, Sui Jingfeng wrote: On 2022/3/23 04:49, Rob Herring wrote: +/* + * mainly for dc in ls7a1000 which have builtin gpio emulated i2c + * + * @index : output channel index, 0 for DVO0, 1 for DVO1 + */ +struct lsdc_i2

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-03-23 Thread Sui Jingfeng
On 2022/3/23 04:49, Rob Herring wrote: On Tue, Mar 22, 2022 at 12:29:16AM +0800, Sui Jingfeng wrote: From: suijingfeng There is a display controller in loongson's LS2K1000 SoC and LS7A1000 bridge chip, the display controller is a PCI device in those chips. It has two display pipes but with o

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-03-23 Thread Rob Herring
On Wed, Mar 23, 2022 at 12:12:43PM +0800, Sui Jingfeng wrote: > > On 2022/3/23 04:49, Rob Herring wrote: > > > +/* > > > + * mainly for dc in ls7a1000 which have builtin gpio emulated i2c > > > + * > > > + * @index : output channel index, 0 for DVO0, 1 for DVO1 > > > + */ > > > +struct lsdc_i2c *l

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-03-23 Thread Sui Jingfeng
On 2022/3/23 04:49, Rob Herring wrote: + + if (state) { + val = readb(li2c->dir_reg); + val |= mask; + writeb(val, li2c->dir_reg); + } else { + val = readb(li2c->dir_reg); + val &= ~mask; + writeb(va

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-03-23 Thread Sui Jingfeng
On 2022/3/23 04:49, Rob Herring wrote: +/* + * ls7a_gpio_i2c_set - set the state of a gpio pin indicated by mask + * @mask: gpio pin mask + */ +static void ls7a_gpio_i2c_set(struct lsdc_i2c * const li2c, int mask, int state) +{ + unsigned long flags; + u8 val; + + spin_lock_i

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-03-22 Thread Sui Jingfeng
On 2022/3/23 04:49, Rob Herring wrote: This condition is never true. We're in the 'else' because !state. Thanks for your sharp eyes,  after the gpio emulate i2c driver works, i do not pay much attention to it and get hurry to do other things. I will fix this issue at next version and reply

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-03-22 Thread Sui Jingfeng
On 2022/3/23 04:49, Rob Herring wrote: +/* + * mainly for dc in ls7a1000 which have builtin gpio emulated i2c + * + * @index : output channel index, 0 for DVO0, 1 for DVO1 + */ +struct lsdc_i2c *lsdc_create_i2c_chan(struct device *dev, void *base, unsigned int index) +{ + char compat[32]

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-03-22 Thread Rob Herring
On Tue, Mar 22, 2022 at 12:29:16AM +0800, Sui Jingfeng wrote: > From: suijingfeng > > There is a display controller in loongson's LS2K1000 SoC and LS7A1000 > bridge chip, the display controller is a PCI device in those chips. It > has two display pipes but with only one hardware cursor. Each way

[PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-03-21 Thread Sui Jingfeng
From: suijingfeng There is a display controller in loongson's LS2K1000 SoC and LS7A1000 bridge chip, the display controller is a PCI device in those chips. It has two display pipes but with only one hardware cursor. Each way has a DVO interface which provide RGB888 signals, vertical & horizontal