Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-03 Thread Sam Ravnborg
Hi Neil, > > msscam is used to enable clocks both for the display driver and the > mipi-dsi part. > >>> > >>> If just clocks, then the msscam should be a clock provider possibly. > >>> If not, then the below looks right. > > > > I am feeling a little clueless here - sorry. > > > >

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-03 Thread Neil Armstrong
On 02/11/2020 19:04, Sam Ravnborg wrote: > Hi Neil. > >>> --- >>> .../bindings/display/intel,keembay-display.yaml| 75 >>> ++ >>> 1 file changed, 75 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/display/intel,keembay-

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-03 Thread Neil Armstrong
On 03/11/2020 03:02, Rob Herring wrote: > On Mon, Nov 2, 2020 at 10:38 AM Neil Armstrong > wrote: >> >> On 02/11/2020 16:16, Rob Herring wrote: >>> On Fri, Oct 30, 2020 at 4:15 PM Sam Ravnborg wrote: Hi Neil. On Fri, Oct 30, 2020 at 09:31:36AM +0100, Neil Armstrong wrote: >>>

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-02 Thread Rob Herring
On Mon, Nov 2, 2020 at 12:04 PM Sam Ravnborg wrote: > > Hi Neil. > > > > --- > > > .../bindings/display/intel,keembay-display.yaml| 75 > > > ++ > > > 1 file changed, 75 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindin

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-02 Thread Rob Herring
On Mon, Nov 2, 2020 at 10:38 AM Neil Armstrong wrote: > > On 02/11/2020 16:16, Rob Herring wrote: > > On Fri, Oct 30, 2020 at 4:15 PM Sam Ravnborg wrote: > >> > >> Hi Neil. > >> > >> On Fri, Oct 30, 2020 at 09:31:36AM +0100, Neil Armstrong wrote: > >>> Hi, > >>> > >>> On 29/10/2020 23:20, Sam Rav

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-02 Thread Sam Ravnborg
Hi Neil. > > --- > > .../bindings/display/intel,keembay-display.yaml| 75 > > ++ > > 1 file changed, 75 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/display/intel,keembay-display.yaml > > > > diff --git > >>

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-02 Thread Neil Armstrong
On 02/11/2020 16:16, Rob Herring wrote: > On Fri, Oct 30, 2020 at 4:15 PM Sam Ravnborg wrote: >> >> Hi Neil. >> >> On Fri, Oct 30, 2020 at 09:31:36AM +0100, Neil Armstrong wrote: >>> Hi, >>> >>> On 29/10/2020 23:20, Sam Ravnborg wrote: Hi Anitha. On Thu, Oct 29, 2020 at 02:27:52PM -

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-02 Thread Rob Herring
On Fri, Oct 30, 2020 at 4:15 PM Sam Ravnborg wrote: > > Hi Neil. > > On Fri, Oct 30, 2020 at 09:31:36AM +0100, Neil Armstrong wrote: > > Hi, > > > > On 29/10/2020 23:20, Sam Ravnborg wrote: > > > Hi Anitha. > > > > > > On Thu, Oct 29, 2020 at 02:27:52PM -0700, Anitha Chrisanthus wrote: > > >> This

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-10-30 Thread Sam Ravnborg
Hi Neil. On Fri, Oct 30, 2020 at 09:31:36AM +0100, Neil Armstrong wrote: > Hi, > > On 29/10/2020 23:20, Sam Ravnborg wrote: > > Hi Anitha. > > > > On Thu, Oct 29, 2020 at 02:27:52PM -0700, Anitha Chrisanthus wrote: > >> This patch adds bindings for Intel KeemBay Display > >> > >> v2: review chan

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-10-30 Thread Neil Armstrong
Hi, On 29/10/2020 23:20, Sam Ravnborg wrote: > Hi Anitha. > > On Thu, Oct 29, 2020 at 02:27:52PM -0700, Anitha Chrisanthus wrote: >> This patch adds bindings for Intel KeemBay Display >> >> v2: review changes from Rob Herring >> v3: review changes from Sam Ravnborg (removed mipi dsi entries, and

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-10-29 Thread Sam Ravnborg
Hi Anitha. On Thu, Oct 29, 2020 at 02:27:52PM -0700, Anitha Chrisanthus wrote: > This patch adds bindings for Intel KeemBay Display > > v2: review changes from Rob Herring > v3: review changes from Sam Ravnborg (removed mipi dsi entries, and > encoder entry, connect port to dsi) > MSSCAM

[PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-10-29 Thread Anitha Chrisanthus
This patch adds bindings for Intel KeemBay Display v2: review changes from Rob Herring v3: review changes from Sam Ravnborg (removed mipi dsi entries, and encoder entry, connect port to dsi) MSSCAM is part of the display submodule and its used to reset LCD and MIPI DSI clocks, so its b