Re: [PATCH v1 10/14] drm/msm/disp/dpu: add supports of DSC encoder v1.2 engine

2023-01-30 Thread Abhinav Kumar
On 1/30/2023 2:31 PM, Marijn Suijten wrote: Abhinav, On 2023-01-30 13:22:03, Abhinav Kumar wrote: Hi Marijn On 1/30/2023 12:16 PM, Marijn Suijten wrote: On 2023-01-24 15:52:46, Kuogee Hsieh wrote: If only replying to a small chunk somewhere in the middle of a diff and/or large review, p

Re: [PATCH v1 10/14] drm/msm/disp/dpu: add supports of DSC encoder v1.2 engine

2023-01-30 Thread Marijn Suijten
Abhinav, On 2023-01-30 13:22:03, Abhinav Kumar wrote: > Hi Marijn > > On 1/30/2023 12:16 PM, Marijn Suijten wrote: > > On 2023-01-24 15:52:46, Kuogee Hsieh wrote: > > > > > > > > If only replying to a small chunk somewhere in the middle of a diff > > and/or large review, please cut out unneces

Re: [PATCH v1 10/14] drm/msm/disp/dpu: add supports of DSC encoder v1.2 engine

2023-01-30 Thread Abhinav Kumar
Hi Marijn On 1/30/2023 12:16 PM, Marijn Suijten wrote: On 2023-01-24 15:52:46, Kuogee Hsieh wrote: If only replying to a small chunk somewhere in the middle of a diff and/or large review, please cut out unnecessary bits to make your reply easier to find :) + data = (dsc->flatness_min_

Re: [PATCH v1 10/14] drm/msm/disp/dpu: add supports of DSC encoder v1.2 engine

2023-01-30 Thread Marijn Suijten
On 2023-01-24 15:52:46, Kuogee Hsieh wrote: If only replying to a small chunk somewhere in the middle of a diff and/or large review, please cut out unnecessary bits to make your reply easier to find :) > >> + data = (dsc->flatness_min_qp & 0x1f); > >> + data |= (dsc->flatness_max_qp & 0x1f) <

Re: [PATCH v1 10/14] drm/msm/disp/dpu: add supports of DSC encoder v1.2 engine

2023-01-24 Thread Kuogee Hsieh
On 1/23/2023 12:11 PM, Marijn Suijten wrote: add support for* drm/msm/dpu* On 2023-01-23 10:24:30, Kuogee Hsieh wrote: DSC V1.2 encoder engine is newly added hardware module. This patch add support functions to configure and enable DSC V1.2 encoder engine. Signed-off-by: Kuogee Hsieh ---

Re: [PATCH v1 10/14] drm/msm/disp/dpu: add supports of DSC encoder v1.2 engine

2023-01-24 Thread Neil Armstrong
On 23/01/2023 19:24, Kuogee Hsieh wrote: DSC V1.2 encoder engine is newly added hardware module. This patch add support functions to configure and enable DSC V1.2 encoder engine. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/

Re: [PATCH v1 10/14] drm/msm/disp/dpu: add supports of DSC encoder v1.2 engine

2023-01-23 Thread Dmitry Baryshkov
On 23/01/2023 20:24, Kuogee Hsieh wrote: DSC V1.2 encoder engine is newly added hardware module. This patch add support functions to configure and enable DSC V1.2 encoder engine. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/

Re: [PATCH v1 10/14] drm/msm/disp/dpu: add supports of DSC encoder v1.2 engine

2023-01-23 Thread Marijn Suijten
add support for* drm/msm/dpu* On 2023-01-23 10:24:30, Kuogee Hsieh wrote: > DSC V1.2 encoder engine is newly added hardware module. This patch > add support functions to configure and enable DSC V1.2 encoder engine. > > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/Makefile

[PATCH v1 10/14] drm/msm/disp/dpu: add supports of DSC encoder v1.2 engine

2023-01-23 Thread Kuogee Hsieh
DSC V1.2 encoder engine is newly added hardware module. This patch add support functions to configure and enable DSC V1.2 encoder engine. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 2 +- drivers/gpu/d