>> +if (backlight_is_blank(bl) || (bl->props.brightness < 0x4))
> You could replace bl->props.brightness with backlight_get_brightness(bl)
> to avoid direct access to the properties.
Thanks. Changed in v2.
>> +/* turn the string off */
>> ret |= lm3630a_update(pchi
>> Use display_is_blank() to determine if the led strings should be turned
>
> Shouldn't this be backlight_is_blank()?
Yes, indeed. Thanks for pointing this out. Fixed in v2.
On Fri, May 05, 2023 at 08:57:52PM +0200, Maximilian Weigand wrote:
> From: Maximilian Weigand
>
> Use display_is_blank() to determine if the led strings should be turned
> off in the update_status() functions of both strings.
>
> Signed-off-by: Maximilian Weigand
> ---
> drivers/video/backlig
On Fri, May 05, 2023 at 08:57:52PM +0200, Maximilian Weigand wrote:
> From: Maximilian Weigand
>
> Use display_is_blank() to determine if the led strings should be turned
Shouldn't this be backlight_is_blank()?
> off in the update_status() functions of both strings.
Once the description is fix
From: Maximilian Weigand
Use display_is_blank() to determine if the led strings should be turned
off in the update_status() functions of both strings.
Signed-off-by: Maximilian Weigand
---
drivers/video/backlight/lm3630a_bl.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff
