Re: [PATCH v1] backlight: lm3630a: turn off both led strings when display is blank

[Maximilian Weigand]

>> +    if (backlight_is_blank(bl) || (bl->props.brightness < 0x4))
> You could replace bl->props.brightness with backlight_get_brightness(bl)
> to avoid direct access to the properties.

Thanks. Changed in v2.

>> +            /* turn the string off  */
>>              ret |= lm3630a_update(pchip, REG_CTRL, LM3630A_LEDA_ENABLE, 0);
>>      else
>>              ret |= lm3630a_update(pchip, REG_CTRL,
>> @@ -277,7 +279,9 @@ static int lm3630a_bank_b_update_status(struct 
>> backlight_device *bl)
>>      usleep_range(1000, 2000);
>>      /* minimum brightness is 0x04 */
>>      ret = lm3630a_write(pchip, REG_BRT_B, bl->props.brightness);
>> -    if (bl->props.brightness < 0x4)
>> +
>> +    if (backlight_is_blank(bl) || (bl->props.brightness < 0x4))

Thanks. Changed in v2.