Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 09:50:22PM +0200, Daniel Vetter wrote: > On Fri, Jun 14, 2013 at 4:42 PM, Russell King - ARM Linux > wrote: > > If you're happy with the patch I supplied, that's probably the minimal fix > > which should go to stable kernels (I'm using 3.9 here) - this also counts > > as a

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 04:23:22PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 3:03 PM, Russell King - ARM Linux > wrote: > > There's a bigger issue here - if it's possible for > > drm_crtc_helper_set_config() > > to be called with set->fb set but set->mode NULL, then we overwrite > > s

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 03:53:41PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: > > On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > > > The deeper I look, the more bugs there seem to be in this DRM stuff, > > > a

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Daniel Vetter
On Sat, Jun 15, 2013 at 12:15 AM, Russell King - ARM Linux wrote: > On Fri, Jun 14, 2013 at 09:50:22PM +0200, Daniel Vetter wrote: >> On Fri, Jun 14, 2013 at 4:42 PM, Russell King - ARM Linux >> wrote: >> > If you're happy with the patch I supplied, that's probably the minimal fix >> > which shou

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-14 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 09:50:22PM +0200, Daniel Vetter wrote: > On Fri, Jun 14, 2013 at 4:42 PM, Russell King - ARM Linux > wrote: > > If you're happy with the patch I supplied, that's probably the minimal fix > > which should go to stable kernels (I'm using 3.9 here) - this also counts > > as a

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-14 Thread Daniel Vetter
On Fri, Jun 14, 2013 at 4:42 PM, Russell King - ARM Linux wrote: > On Fri, Jun 14, 2013 at 04:23:22PM +0200, Daniel Vetter wrote: >> On Thu, Jun 13, 2013 at 3:03 PM, Russell King - ARM Linux >> wrote: >> > There's a bigger issue here - if it's possible for >> > drm_crtc_helper_set_config() >> >

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-14 Thread Daniel Vetter
On Thu, Jun 13, 2013 at 3:03 PM, Russell King - ARM Linux wrote: > On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: >> On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: >> > The deeper I look, the more bugs there seem to be in this DRM stuff, >> > a

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-14 Thread Daniel Vetter
On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: > On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > > The deeper I look, the more bugs there seem to be in this DRM stuff, > > and I'm continuing to look because I'm chasing a framebuffer refcount >

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-14 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 04:23:22PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 3:03 PM, Russell King - ARM Linux > wrote: > > There's a bigger issue here - if it's possible for > > drm_crtc_helper_set_config() > > to be called with set->fb set but set->mode NULL, then we overwrite > > s

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-14 Thread Daniel Vetter
On Sat, Jun 15, 2013 at 12:15 AM, Russell King - ARM Linux wrote: > On Fri, Jun 14, 2013 at 09:50:22PM +0200, Daniel Vetter wrote: >> On Fri, Jun 14, 2013 at 4:42 PM, Russell King - ARM Linux >> wrote: >> > If you're happy with the patch I supplied, that's probably the minimal fix >> > which shou

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-14 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 03:53:41PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: > > On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > > > The deeper I look, the more bugs there seem to be in this DRM stuff, > > > a

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-14 Thread Daniel Vetter
On Fri, Jun 14, 2013 at 4:42 PM, Russell King - ARM Linux wrote: > On Fri, Jun 14, 2013 at 04:23:22PM +0200, Daniel Vetter wrote: >> On Thu, Jun 13, 2013 at 3:03 PM, Russell King - ARM Linux >> wrote: >> > There's a bigger issue here - if it's possible for >> > drm_crtc_helper_set_config() >> >

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-14 Thread Daniel Vetter
On Thu, Jun 13, 2013 at 3:03 PM, Russell King - ARM Linux wrote: > On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: >> On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: >> > The deeper I look, the more bugs there seem to be in this DRM stuff, >> > a

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-14 Thread Daniel Vetter
On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: > On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > > The deeper I look, the more bugs there seem to be in this DRM stuff, > > and I'm continuing to look because I'm chasing a framebuffer refcount >

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-14 Thread Russell King - ARM Linux
On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: > On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > > The deeper I look, the more bugs there seem to be in this DRM stuff, > > and I'm continuing to look because I'm chasing a framebuffer refcount >

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-14 Thread Russell King - ARM Linux
On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > The deeper I look, the more bugs there seem to be in this DRM stuff, > and I'm continuing to look because I'm chasing a framebuffer refcount > bug. So, this refcount bug - I think I've just found it. This is the flow of r

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-14 Thread Russell King - ARM Linux
And another issue... What is drm_crtc_helper_set_mode() passed as the fb argument? Is it the old fb, or the new fb? bool drm_crtc_helper_set_mode(struct drm_crtc *crtc, struct drm_display_mode *mode, int x, int y,

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-13 Thread Daniel Vetter
On Thu, Jun 13, 2013 at 2:52 PM, Rob Clark wrote: > most of the embedded drivers should ignore the old_fb.. the API is a > bit odd but the purpose is to help drivers that need to pin/unpin the > gem objects backing the fb. The ones that do, do something like: > > foo_pin(new_fb); > foo_unpin(

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-13 Thread Russell King - ARM Linux
On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: > On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > > The deeper I look, the more bugs there seem to be in this DRM stuff, > > and I'm continuing to look because I'm chasing a framebuffer refcount >

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-13 Thread Russell King - ARM Linux
On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > The deeper I look, the more bugs there seem to be in this DRM stuff, > and I'm continuing to look because I'm chasing a framebuffer refcount > bug. So, this refcount bug - I think I've just found it. This is the flow of r

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-13 Thread Russell King - ARM Linux
And another issue... What is drm_crtc_helper_set_mode() passed as the fb argument? Is it the old fb, or the new fb? bool drm_crtc_helper_set_mode(struct drm_crtc *crtc, struct drm_display_mode *mode, int x, int y,

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-13 Thread Rob Clark
On Thu, Jun 13, 2013 at 7:19 AM, Russell King - ARM Linux wrote: > And another issue... > > What is drm_crtc_helper_set_mode() passed as the fb argument? Is it > the old fb, or the new fb? > > bool drm_crtc_helper_set_mode(struct drm_crtc *crtc, > struct drm_display_

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-13 Thread Daniel Vetter
On Thu, Jun 13, 2013 at 2:52 PM, Rob Clark wrote: > most of the embedded drivers should ignore the old_fb.. the API is a > bit odd but the purpose is to help drivers that need to pin/unpin the > gem objects backing the fb. The ones that do, do something like: > > foo_pin(new_fb); > foo_unpin(

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-13 Thread Rob Clark
On Thu, Jun 13, 2013 at 7:19 AM, Russell King - ARM Linux wrote: > And another issue... > > What is drm_crtc_helper_set_mode() passed as the fb argument? Is it > the old fb, or the new fb? > > bool drm_crtc_helper_set_mode(struct drm_crtc *crtc, > struct drm_display_

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-13 Thread Russell King - ARM Linux
And here's another one - look carefully at this path: buf = dev->driver->gem_prime_export(dev, obj, flags); if (IS_ERR(buf)) { /* normally the created dma-buf takes ownership of the ref, * but if that fails then drop

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
And here's another one - look carefully at this path: buf = dev->driver->gem_prime_export(dev, obj, flags); if (IS_ERR(buf)) { /* normally the created dma-buf takes ownership of the ref, * but if that fails then drop

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
On Wed, Jun 12, 2013 at 06:05:12PM +0100, Russell King - ARM Linux wrote: > On Wed, Jun 12, 2013 at 05:49:14PM +0100, Russell King - ARM Linux wrote: > > On Wed, Jun 12, 2013 at 09:56:22AM -0400, Rob Clark wrote: > > > On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux > > > wrote: > > > >

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
On Wed, Jun 12, 2013 at 05:49:14PM +0100, Russell King - ARM Linux wrote: > On Wed, Jun 12, 2013 at 09:56:22AM -0400, Rob Clark wrote: > > On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux > > wrote: > > > And having thought about this driver, DRM some more, I'm now of the > > > opinion th

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
On Wed, Jun 12, 2013 at 09:56:22AM -0400, Rob Clark wrote: > On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux > wrote: > > And having thought about this driver, DRM some more, I'm now of the > > opinion that DRM is not suitable for driving hardware where the GPU is > > an entirely separat

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
On Tue, Jun 11, 2013 at 09:48:57AM +1000, Dave Airlie wrote: > On Tue, Jun 11, 2013 at 9:36 AM, Russell King - ARM Linux > wrote: > > On Tue, Jun 11, 2013 at 09:24:16AM +1000, Dave Airlie wrote: > >> I'd like to see all the ARM based drivers based on CMA if it can meet > >> their requirements > >>

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
On Wed, Jun 12, 2013 at 06:05:12PM +0100, Russell King - ARM Linux wrote: > On Wed, Jun 12, 2013 at 05:49:14PM +0100, Russell King - ARM Linux wrote: > > On Wed, Jun 12, 2013 at 09:56:22AM -0400, Rob Clark wrote: > > > On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux > > > wrote: > > > >

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Rob Clark
On Wed, Jun 12, 2013 at 7:00 PM, Russell King - ARM Linux wrote: > And here's another one - look carefully at this path: > > buf = dev->driver->gem_prime_export(dev, obj, flags); > if (IS_ERR(buf)) { > /* normally the created dma-buf takes ow

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
On Wed, Jun 12, 2013 at 05:49:14PM +0100, Russell King - ARM Linux wrote: > On Wed, Jun 12, 2013 at 09:56:22AM -0400, Rob Clark wrote: > > On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux > > wrote: > > > And having thought about this driver, DRM some more, I'm now of the > > > opinion th

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
On Wed, Jun 12, 2013 at 09:56:22AM -0400, Rob Clark wrote: > On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux > wrote: > > And having thought about this driver, DRM some more, I'm now of the > > opinion that DRM is not suitable for driving hardware where the GPU is > > an entirely separat

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Rob Clark
On Wed, Jun 12, 2013 at 7:00 PM, Russell King - ARM Linux wrote: > And here's another one - look carefully at this path: > > buf = dev->driver->gem_prime_export(dev, obj, flags); > if (IS_ERR(buf)) { > /* normally the created dma-buf takes ow

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Rob Clark
On Wed, Jun 12, 2013 at 1:05 PM, Russell King - ARM Linux wrote: > On Wed, Jun 12, 2013 at 05:49:14PM +0100, Russell King - ARM Linux wrote: >> On Wed, Jun 12, 2013 at 09:56:22AM -0400, Rob Clark wrote: >> > On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux >> > wrote: >> > > And having t

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
On Tue, Jun 11, 2013 at 09:48:57AM +1000, Dave Airlie wrote: > On Tue, Jun 11, 2013 at 9:36 AM, Russell King - ARM Linux > wrote: > > On Tue, Jun 11, 2013 at 09:24:16AM +1000, Dave Airlie wrote: > >> I'd like to see all the ARM based drivers based on CMA if it can meet > >> their requirements > >>

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Rob Clark
On Wed, Jun 12, 2013 at 1:05 PM, Russell King - ARM Linux wrote: > On Wed, Jun 12, 2013 at 05:49:14PM +0100, Russell King - ARM Linux wrote: >> On Wed, Jun 12, 2013 at 09:56:22AM -0400, Rob Clark wrote: >> > On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux >> > wrote: >> > > And having t

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Rob Clark
On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux wrote: > On Tue, Jun 11, 2013 at 09:48:57AM +1000, Dave Airlie wrote: >> On Tue, Jun 11, 2013 at 9:36 AM, Russell King - ARM Linux >> wrote: >> > On Tue, Jun 11, 2013 at 09:24:16AM +1000, Dave Airlie wrote: >> >> I'd like to see all the AR

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Rob Clark
On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux wrote: > On Tue, Jun 11, 2013 at 09:48:57AM +1000, Dave Airlie wrote: >> On Tue, Jun 11, 2013 at 9:36 AM, Russell King - ARM Linux >> wrote: >> > On Tue, Jun 11, 2013 at 09:24:16AM +1000, Dave Airlie wrote: >> >> I'd like to see all the AR

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-11 Thread Ville Syrjälä
On Tue, Jun 11, 2013 at 12:01:59AM +0200, Daniel Vetter wrote: > On Mon, Jun 10, 2013 at 9:59 PM, Rob Clark wrote: > > On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux > > wrote: > >> On Mon, Jun 10, 2013 at 11:57:32AM -0400, Rob Clark wrote: > >>> On Sun, Jun 9, 2013 at 3:29 PM, Russell

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-11 Thread Dave Airlie
On Tue, Jun 11, 2013 at 9:36 AM, Russell King - ARM Linux wrote: > On Tue, Jun 11, 2013 at 09:24:16AM +1000, Dave Airlie wrote: >> I'd like to see all the ARM based drivers based on CMA if it can meet >> their requirements >> and using close to standard GEM/dma-buf interfaces. Otherwise it'll be >

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-11 Thread Daniel Vetter
On Mon, Jun 10, 2013 at 11:32:54PM +0100, Russell King - ARM Linux wrote: > On Tue, Jun 11, 2013 at 12:01:59AM +0200, Daniel Vetter wrote: > > On Mon, Jun 10, 2013 at 9:59 PM, Rob Clark wrote: > > > On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux > > > wrote: > > >> On Mon, Jun 10, 2013

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-11 Thread Dave Airlie
>> >> That makes the driver just be a dumb scanout only driver. Sorry, >> that *really* does not interest me one bit, because the CPU doing >> framebuffer accesses is pig slow. > > Well, yes that is basically what I am saying, unless we can find a > different way (dmabuf? if there is some way to p

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-11 Thread Ville Syrjälä
On Tue, Jun 11, 2013 at 12:01:59AM +0200, Daniel Vetter wrote: > On Mon, Jun 10, 2013 at 9:59 PM, Rob Clark wrote: > > On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux > > wrote: > >> On Mon, Jun 10, 2013 at 11:57:32AM -0400, Rob Clark wrote: > >>> On Sun, Jun 9, 2013 at 3:29 PM, Russell

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-11 Thread Russell King - ARM Linux
On Tue, Jun 11, 2013 at 09:48:57AM +1000, Dave Airlie wrote: > On Tue, Jun 11, 2013 at 9:36 AM, Russell King - ARM Linux > wrote: > > On Tue, Jun 11, 2013 at 09:24:16AM +1000, Dave Airlie wrote: > >> I'd like to see all the ARM based drivers based on CMA if it can meet > >> their requirements > >>

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-11 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 07:17:22PM -0400, Rob Clark wrote: > On Mon, Jun 10, 2013 at 6:56 PM, Russell King - ARM Linux > wrote: > > On Mon, Jun 10, 2013 at 06:49:06PM -0400, Rob Clark wrote: > >> I guess in the short term, the best I can think is keep those phys > >> ioctls as a small patch on top

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-11 Thread Russell King - ARM Linux
On Tue, Jun 11, 2013 at 09:24:16AM +1000, Dave Airlie wrote: > I'd like to see all the ARM based drivers based on CMA if it can meet > their requirements > and using close to standard GEM/dma-buf interfaces. Otherwise it'll be > come an unmaintainable > nightmare for everyone, but mostly for me. I

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-11 Thread Daniel Vetter
On Mon, Jun 10, 2013 at 11:32:54PM +0100, Russell King - ARM Linux wrote: > On Tue, Jun 11, 2013 at 12:01:59AM +0200, Daniel Vetter wrote: > > On Mon, Jun 10, 2013 at 9:59 PM, Rob Clark wrote: > > > On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux > > > wrote: > > >> On Mon, Jun 10, 2013

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-11 Thread Daniel Vetter
On Mon, Jun 10, 2013 at 9:59 PM, Rob Clark wrote: > On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux > wrote: >> On Mon, Jun 10, 2013 at 11:57:32AM -0400, Rob Clark wrote: >>> On Sun, Jun 9, 2013 at 3:29 PM, Russell King >>> wrote: >>> > This patch adds support for the pair of LCD contr

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Sebastian Hesselbarth
On 06/10/2013 11:48 PM, Russell King - ARM Linux wrote: > On Mon, Jun 10, 2013 at 01:10:18PM +0200, Sebastian Hesselbarth wrote: >> On 06/09/13 21:29, Russell King wrote: >>> +static const struct armada_output_type armada_drm_conn_slave = { >>> + .connector_type = DRM_MODE_CONNECTOR_HDMIA, >> >>

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 06:49:06PM -0400, Rob Clark wrote: > I guess in the short term, the best I can think is keep those phys > ioctls as a small patch on top of the upstream driver. It is ok to > leave place-holder ioctl #'s in the upstream driver so that the ioctl > #'s don't shift when you re

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Tue, Jun 11, 2013 at 12:01:59AM +0200, Daniel Vetter wrote: > On Mon, Jun 10, 2013 at 9:59 PM, Rob Clark wrote: > > On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux > > wrote: > >> On Mon, Jun 10, 2013 at 11:57:32AM -0400, Rob Clark wrote: > >>> On Sun, Jun 9, 2013 at 3:29 PM, Russell

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Tue, Jun 11, 2013 at 09:48:57AM +1000, Dave Airlie wrote: > On Tue, Jun 11, 2013 at 9:36 AM, Russell King - ARM Linux > wrote: > > On Tue, Jun 11, 2013 at 09:24:16AM +1000, Dave Airlie wrote: > >> I'd like to see all the ARM based drivers based on CMA if it can meet > >> their requirements > >>

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 07:17:22PM -0400, Rob Clark wrote: > On Mon, Jun 10, 2013 at 6:56 PM, Russell King - ARM Linux > wrote: > > On Mon, Jun 10, 2013 at 06:49:06PM -0400, Rob Clark wrote: > >> I guess in the short term, the best I can think is keep those phys > >> ioctls as a small patch on top

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Tue, Jun 11, 2013 at 09:24:16AM +1000, Dave Airlie wrote: > I'd like to see all the ARM based drivers based on CMA if it can meet > their requirements > and using close to standard GEM/dma-buf interfaces. Otherwise it'll be > come an unmaintainable > nightmare for everyone, but mostly for me. I

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 06:49:06PM -0400, Rob Clark wrote: > I guess in the short term, the best I can think is keep those phys > ioctls as a small patch on top of the upstream driver. It is ok to > leave place-holder ioctl #'s in the upstream driver so that the ioctl > #'s don't shift when you re

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 01:10:18PM +0200, Sebastian Hesselbarth wrote: > On 06/09/13 21:29, Russell King wrote: >> +/* >> + * The spec is unclear about the polarities of the syncs. >> + * We assume their non-inverted state is active high. >> + */ > > nit: "We confirmed their non-inv

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Tue, Jun 11, 2013 at 12:01:59AM +0200, Daniel Vetter wrote: > On Mon, Jun 10, 2013 at 9:59 PM, Rob Clark wrote: > > On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux > > wrote: > >> On Mon, Jun 10, 2013 at 11:57:32AM -0400, Rob Clark wrote: > >>> On Sun, Jun 9, 2013 at 3:29 PM, Russell

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Sebastian Hesselbarth
On 06/10/2013 11:48 PM, Russell King - ARM Linux wrote: On Mon, Jun 10, 2013 at 01:10:18PM +0200, Sebastian Hesselbarth wrote: On 06/09/13 21:29, Russell King wrote: +static const struct armada_output_type armada_drm_conn_slave = { + .connector_type = DRM_MODE_CONNECTOR_HDMIA, For a rew

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 01:10:18PM +0200, Sebastian Hesselbarth wrote: > On 06/09/13 21:29, Russell King wrote: >> +/* >> + * The spec is unclear about the polarities of the syncs. >> + * We assume their non-inverted state is active high. >> + */ > > nit: "We confirmed their non-inv

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 11:57:32AM -0400, Rob Clark wrote: > On Sun, Jun 9, 2013 at 3:29 PM, Russell King > wrote: > > +/* The mode_config.mutex will be held for this call */ > > +static int armada_drm_crtc_mode_set_base(struct drm_crtc *crtc, int x, int > > y, > > + struct drm_framebuffer

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 05:01:18PM -0400, Rob Clark wrote: > I would like to get at least some of the driver upstream. I'd hate > for it to have to live completely out of tree. I can think of a > couple possibilities. > > 1) the best would be, if there was some way for the drm driver to know > t

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 03:59:34PM -0400, Rob Clark wrote: > On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux > wrote: > > ARMADA_GEM_CREATE_PHYS is to deal with creating a gem buffer object for > > a chunk of physical memory allocated by other means (eg, the Vmeta stuff.) > > This allows

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 11:57:32AM -0400, Rob Clark wrote: > On Sun, Jun 9, 2013 at 3:29 PM, Russell King > wrote: > > This patch adds support for the pair of LCD controllers on the Marvell > > Armada 510 SoCs. This driver supports: > > - multiple contiguous scanout buffers for video and graphics

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 11:57:32AM -0400, Rob Clark wrote: > On Sun, Jun 9, 2013 at 3:29 PM, Russell King > wrote: > > +/* The mode_config.mutex will be held for this call */ > > +static int armada_drm_crtc_mode_set_base(struct drm_crtc *crtc, int x, int > > y, > > + struct drm_framebuffer

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 05:01:18PM -0400, Rob Clark wrote: > I would like to get at least some of the driver upstream. I'd hate > for it to have to live completely out of tree. I can think of a > couple possibilities. > > 1) the best would be, if there was some way for the drm driver to know > t

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 03:59:34PM -0400, Rob Clark wrote: > On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux > wrote: > > ARMADA_GEM_CREATE_PHYS is to deal with creating a gem buffer object for > > a chunk of physical memory allocated by other means (eg, the Vmeta stuff.) > > This allows

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Rob Clark
On Mon, Jun 10, 2013 at 7:38 PM, Russell King - ARM Linux wrote: > On Mon, Jun 10, 2013 at 07:17:22PM -0400, Rob Clark wrote: >> On Mon, Jun 10, 2013 at 6:56 PM, Russell King - ARM Linux >> wrote: >> > On Mon, Jun 10, 2013 at 06:49:06PM -0400, Rob Clark wrote: >> >> I guess in the short term, the

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Rob Clark
On Mon, Jun 10, 2013 at 7:24 PM, Dave Airlie wrote: >>> >>> That makes the driver just be a dumb scanout only driver. Sorry, >>> that *really* does not interest me one bit, because the CPU doing >>> framebuffer accesses is pig slow. >> >> Well, yes that is basically what I am saying, unless we ca

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Rob Clark
On Mon, Jun 10, 2013 at 6:56 PM, Russell King - ARM Linux wrote: > On Mon, Jun 10, 2013 at 06:49:06PM -0400, Rob Clark wrote: >> I guess in the short term, the best I can think is keep those phys >> ioctls as a small patch on top of the upstream driver. It is ok to >> leave place-holder ioctl #'s

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Rob Clark
On Mon, Jun 10, 2013 at 6:32 PM, Russell King - ARM Linux wrote: > On Tue, Jun 11, 2013 at 12:01:59AM +0200, Daniel Vetter wrote: >> On Mon, Jun 10, 2013 at 9:59 PM, Rob Clark wrote: >> > On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux >> > wrote: >> >> On Mon, Jun 10, 2013 at 11:57:32

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Rob Clark
On Mon, Jun 10, 2013 at 5:15 PM, Russell King - ARM Linux wrote: > On Mon, Jun 10, 2013 at 05:01:18PM -0400, Rob Clark wrote: >> I would like to get at least some of the driver upstream. I'd hate >> for it to have to live completely out of tree. I can think of a >> couple possibilities. >> >> 1)

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 11:57:32AM -0400, Rob Clark wrote: > On Sun, Jun 9, 2013 at 3:29 PM, Russell King > wrote: > > This patch adds support for the pair of LCD controllers on the Marvell > > Armada 510 SoCs. This driver supports: > > - multiple contiguous scanout buffers for video and graphics

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Rob Clark
On Mon, Jun 10, 2013 at 4:08 PM, Russell King - ARM Linux wrote: > On Mon, Jun 10, 2013 at 03:59:34PM -0400, Rob Clark wrote: >> On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux >> wrote: >> > ARMADA_GEM_CREATE_PHYS is to deal with creating a gem buffer object for >> > a chunk of physica

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Rob Clark
On Mon, Jun 10, 2013 at 7:38 PM, Russell King - ARM Linux wrote: > On Mon, Jun 10, 2013 at 07:17:22PM -0400, Rob Clark wrote: >> On Mon, Jun 10, 2013 at 6:56 PM, Russell King - ARM Linux >> wrote: >> > On Mon, Jun 10, 2013 at 06:49:06PM -0400, Rob Clark wrote: >> >> I guess in the short term, the

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Dave Airlie
On Tue, Jun 11, 2013 at 9:36 AM, Russell King - ARM Linux wrote: > On Tue, Jun 11, 2013 at 09:24:16AM +1000, Dave Airlie wrote: >> I'd like to see all the ARM based drivers based on CMA if it can meet >> their requirements >> and using close to standard GEM/dma-buf interfaces. Otherwise it'll be >

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Rob Clark
On Mon, Jun 10, 2013 at 7:24 PM, Dave Airlie wrote: >>> >>> That makes the driver just be a dumb scanout only driver. Sorry, >>> that *really* does not interest me one bit, because the CPU doing >>> framebuffer accesses is pig slow. >> >> Well, yes that is basically what I am saying, unless we ca

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Dave Airlie
>> >> That makes the driver just be a dumb scanout only driver. Sorry, >> that *really* does not interest me one bit, because the CPU doing >> framebuffer accesses is pig slow. > > Well, yes that is basically what I am saying, unless we can find a > different way (dmabuf? if there is some way to p

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Rob Clark
On Mon, Jun 10, 2013 at 6:56 PM, Russell King - ARM Linux wrote: > On Mon, Jun 10, 2013 at 06:49:06PM -0400, Rob Clark wrote: >> I guess in the short term, the best I can think is keep those phys >> ioctls as a small patch on top of the upstream driver. It is ok to >> leave place-holder ioctl #'s

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Rob Clark
On Mon, Jun 10, 2013 at 6:32 PM, Russell King - ARM Linux wrote: > On Tue, Jun 11, 2013 at 12:01:59AM +0200, Daniel Vetter wrote: >> On Mon, Jun 10, 2013 at 9:59 PM, Rob Clark wrote: >> > On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux >> > wrote: >> >> On Mon, Jun 10, 2013 at 11:57:32

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Rob Clark
On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux wrote: > On Mon, Jun 10, 2013 at 11:57:32AM -0400, Rob Clark wrote: >> On Sun, Jun 9, 2013 at 3:29 PM, Russell King >> wrote: >> > This patch adds support for the pair of LCD controllers on the Marvell >> > Armada 510 SoCs. This driver su

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Rob Clark
On Mon, Jun 10, 2013 at 5:15 PM, Russell King - ARM Linux wrote: > On Mon, Jun 10, 2013 at 05:01:18PM -0400, Rob Clark wrote: >> I would like to get at least some of the driver upstream. I'd hate >> for it to have to live completely out of tree. I can think of a >> couple possibilities. >> >> 1)

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Daniel Vetter
On Mon, Jun 10, 2013 at 9:59 PM, Rob Clark wrote: > On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux > wrote: >> On Mon, Jun 10, 2013 at 11:57:32AM -0400, Rob Clark wrote: >>> On Sun, Jun 9, 2013 at 3:29 PM, Russell King >>> wrote: >>> > This patch adds support for the pair of LCD contr

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Rob Clark
On Mon, Jun 10, 2013 at 4:08 PM, Russell King - ARM Linux wrote: > On Mon, Jun 10, 2013 at 03:59:34PM -0400, Rob Clark wrote: >> On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux >> wrote: >> > ARMADA_GEM_CREATE_PHYS is to deal with creating a gem buffer object for >> > a chunk of physica

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Sebastian Hesselbarth
On 06/09/13 21:29, Russell King wrote: > This patch adds support for the pair of LCD controllers on the Marvell > Armada 510 SoCs. This driver supports: > - multiple contiguous scanout buffers for video and graphics > - shm backed cacheable buffer objects for X pixmaps for Vivante GPU >acceler

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Rob Clark
On Mon, Jun 10, 2013 at 1:06 PM, Russell King - ARM Linux wrote: > On Mon, Jun 10, 2013 at 11:57:32AM -0400, Rob Clark wrote: >> On Sun, Jun 9, 2013 at 3:29 PM, Russell King >> wrote: >> > This patch adds support for the pair of LCD controllers on the Marvell >> > Armada 510 SoCs. This driver su

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Rob Clark
On Sun, Jun 9, 2013 at 3:29 PM, Russell King wrote: > This patch adds support for the pair of LCD controllers on the Marvell > Armada 510 SoCs. This driver supports: > - multiple contiguous scanout buffers for video and graphics > - shm backed cacheable buffer objects for X pixmaps for Vivante GP

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Rob Clark
On Sun, Jun 9, 2013 at 3:29 PM, Russell King wrote: > This patch adds support for the pair of LCD controllers on the Marvell > Armada 510 SoCs. This driver supports: > - multiple contiguous scanout buffers for video and graphics > - shm backed cacheable buffer objects for X pixmaps for Vivante GP

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-10 Thread Sebastian Hesselbarth
On 06/09/13 21:29, Russell King wrote: This patch adds support for the pair of LCD controllers on the Marvell Armada 510 SoCs. This driver supports: - multiple contiguous scanout buffers for video and graphics - shm backed cacheable buffer objects for X pixmaps for Vivante GPU acceleration -

[PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-09 Thread Russell King
This patch adds support for the pair of LCD controllers on the Marvell Armada 510 SoCs. This driver supports: - multiple contiguous scanout buffers for video and graphics - shm backed cacheable buffer objects for X pixmaps for Vivante GPU acceleration - dual lcd0 and lcd1 crt operation - video o