Re: [PATCH 2/2] drm/vc4: Ensure interrupts are disabled

2017-11-14 Thread Stefan Schake
On Tue, Nov 14, 2017 at 8:44 PM, Eric Anholt wrote: > Stefan Schake writes: > >> On Tue, Nov 14, 2017 at 1:18 AM, Eric Anholt wrote: >>> Stefan Schake writes: >>> The overflow mem work callback vc4_overflow_mem_work reenables its associated interrupt upon completion. To ensure all int

Re: [PATCH 2/2] drm/vc4: Ensure interrupts are disabled

2017-11-14 Thread Eric Anholt
Stefan Schake writes: > On Tue, Nov 14, 2017 at 1:18 AM, Eric Anholt wrote: >> Stefan Schake writes: >> >>> The overflow mem work callback vc4_overflow_mem_work reenables its >>> associated interrupt upon completion. To ensure all interrupts are disabled >>> when we return from vc4_irq_uninstal

Re: [PATCH 2/2] drm/vc4: Ensure interrupts are disabled

2017-11-14 Thread Stefan Schake
On Tue, Nov 14, 2017 at 1:18 AM, Eric Anholt wrote: > Stefan Schake writes: > >> The overflow mem work callback vc4_overflow_mem_work reenables its >> associated interrupt upon completion. To ensure all interrupts are disabled >> when we return from vc4_irq_uninstall, we need to disable it again

Re: [PATCH 2/2] drm/vc4: Ensure interrupts are disabled

2017-11-13 Thread Eric Anholt
Stefan Schake writes: > The overflow mem work callback vc4_overflow_mem_work reenables its > associated interrupt upon completion. To ensure all interrupts are disabled > when we return from vc4_irq_uninstall, we need to disable it again if > cancel_work_sync indicated pending work. Is there a r

[PATCH 2/2] drm/vc4: Ensure interrupts are disabled

2017-11-09 Thread Stefan Schake
The overflow mem work callback vc4_overflow_mem_work reenables its associated interrupt upon completion. To ensure all interrupts are disabled when we return from vc4_irq_uninstall, we need to disable it again if cancel_work_sync indicated pending work. Signed-off-by: Stefan Schake --- drivers/g