Re: [PATCH 2/2] drm/atomic: Make atomic iterators less surprising

2017-10-08 Thread Dmitry Osipenko
On 06.10.2017 12:07, Maarten Lankhorst wrote: > Op 27-09-17 om 14:53 schreef Dmitry Osipenko: >> On 27.09.2017 11:35, Maarten Lankhorst wrote: >>> Commit 669c9215afea ("drm/atomic: Make async plane update checks work as >>> intended, v2.") assumed incorrectly that if only 1 plane is matched in >>>

Re: [PATCH 2/2] drm/atomic: Make atomic iterators less surprising

2017-10-06 Thread Maarten Lankhorst
Op 27-09-17 om 14:53 schreef Dmitry Osipenko: > On 27.09.2017 11:35, Maarten Lankhorst wrote: >> Commit 669c9215afea ("drm/atomic: Make async plane update checks work as >> intended, v2.") assumed incorrectly that if only 1 plane is matched in >> the loop, the variables will be set to that plane. I

Re: [PATCH 2/2] drm/atomic: Make atomic iterators less surprising

2017-09-28 Thread Dmitry Osipenko
On 27.09.2017 11:35, Maarten Lankhorst wrote: > Commit 669c9215afea ("drm/atomic: Make async plane update checks work as > intended, v2.") assumed incorrectly that if only 1 plane is matched in > the loop, the variables will be set to that plane. In reality we reset > them to NULL every time a new

Re: [PATCH 2/2] drm/atomic: Make atomic iterators less surprising

2017-09-27 Thread Daniel Vetter
On Wed, Sep 27, 2017 at 10:35:32AM +0200, Maarten Lankhorst wrote: > Commit 669c9215afea ("drm/atomic: Make async plane update checks work as > intended, v2.") assumed incorrectly that if only 1 plane is matched in > the loop, the variables will be set to that plane. In reality we reset > them to N

[PATCH 2/2] drm/atomic: Make atomic iterators less surprising

2017-09-27 Thread Maarten Lankhorst
Commit 669c9215afea ("drm/atomic: Make async plane update checks work as intended, v2.") assumed incorrectly that if only 1 plane is matched in the loop, the variables will be set to that plane. In reality we reset them to NULL every time a new plane was iterated. This behavior is surprising, so fi