Re: [PATCH 1/3] drm: bridge: dw-hdmi: Define and use macros for PHY register addresses

2017-01-16 Thread Nickey.Yang
Hi Laurent, 在 2017年01月13日 21:46, Laurent Pinchart 写道: On Friday 13 Jan 2017 09:32:54 Nickey.Yang wrote: 在 2017年01月12日 23:26, Laurent Pinchart 写道: On Thursday 12 Jan 2017 09:45:31 Nickey.Yang wrote: 在 2017年01月12日 07:49, Laurent Pinchart 写道: Replace the hardcoded register address numerical va

Re: [PATCH 1/3] drm: bridge: dw-hdmi: Define and use macros for PHY register addresses

2017-01-13 Thread Laurent Pinchart
Hi Nickey, On Friday 13 Jan 2017 09:32:54 Nickey.Yang wrote: > 在 2017年01月12日 23:26, Laurent Pinchart 写道: > > On Thursday 12 Jan 2017 09:45:31 Nickey.Yang wrote: > >> 在 2017年01月12日 07:49, Laurent Pinchart 写道: > >>> Replace the hardcoded register address numerical values with macros to > >>> clarify

Re: [PATCH 1/3] drm: bridge: dw-hdmi: Define and use macros for PHY register addresses

2017-01-13 Thread Nickey.Yang
Hi Laurent, 在 2017年01月12日 23:26, Laurent Pinchart 写道: Hi Nickey, On Thursday 12 Jan 2017 09:45:31 Nickey.Yang wrote: 在 2017年01月12日 07:49, Laurent Pinchart 写道: Replace the hardcoded register address numerical values with macros to clarify the code. This change has been tested by comparing t

Re: [PATCH 1/3] drm: bridge: dw-hdmi: Define and use macros for PHY register addresses

2017-01-12 Thread Laurent Pinchart
Hi Nickey, On Thursday 12 Jan 2017 09:45:31 Nickey.Yang wrote: > 在 2017年01月12日 07:49, Laurent Pinchart 写道: > > Replace the hardcoded register address numerical values with macros to > > clarify the code. > > > > This change has been tested by comparing the assembly code before and > > after the c

Re: [PATCH 1/3] drm: bridge: dw-hdmi: Define and use macros for PHY register addresses

2017-01-12 Thread Nickey.Yang
Hi Laurent, 在 2017年01月12日 07:49, Laurent Pinchart 写道: Replace the hardcoded register address numerical values with macros to clarify the code. This change has been tested by comparing the assembly code before and after the change. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/bridge/

[PATCH 1/3] drm: bridge: dw-hdmi: Define and use macros for PHY register addresses

2017-01-11 Thread Laurent Pinchart
Replace the hardcoded register address numerical values with macros to clarify the code. This change has been tested by comparing the assembly code before and after the change. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/bridge/dw-hdmi.c | 35 - drivers/gpu/drm/bridg