[PATCH 1/3] drm/radeon/kms: use crtc-specific dpms functions in prepare and commit

2011-10-26 Thread Ilija Hadzic
On Wed, 26 Oct 2011, Michel [ISO-8859-1] D?nzer wrote: > On Die, 2011-10-25 at 22:40 -0400, Ilija Hadzic wrote: >> it's better that radeon_crtc_commit and radeon_crtc_prepare call >> crtc-specific dpms functions instead of hard-coding them to >> radeon_crtc_dpms. > > Is it really better? If it's

Re: [PATCH 1/3] drm/radeon/kms: use crtc-specific dpms functions in prepare and commit

2011-10-26 Thread Ilija Hadzic
On Wed, 26 Oct 2011, Michel [ISO-8859-1] D�nzer wrote: On Die, 2011-10-25 at 22:40 -0400, Ilija Hadzic wrote: it's better that radeon_crtc_commit and radeon_crtc_prepare call crtc-specific dpms functions instead of hard-coding them to radeon_crtc_dpms. Is it really better? If it's always ra

[PATCH 1/3] drm/radeon/kms: use crtc-specific dpms functions in prepare and commit

2011-10-26 Thread Michel Dänzer
On Die, 2011-10-25 at 22:40 -0400, Ilija Hadzic wrote: > it's better that radeon_crtc_commit and radeon_crtc_prepare call > crtc-specific dpms functions instead of hard-coding them to > radeon_crtc_dpms. Is it really better? If it's always radeon_crtc_dpms anyway, this obfuscates that fact (and i

Re: [PATCH 1/3] drm/radeon/kms: use crtc-specific dpms functions in prepare and commit

2011-10-26 Thread Michel Dänzer
On Die, 2011-10-25 at 22:40 -0400, Ilija Hadzic wrote: > it's better that radeon_crtc_commit and radeon_crtc_prepare call > crtc-specific dpms functions instead of hard-coding them to > radeon_crtc_dpms. Is it really better? If it's always radeon_crtc_dpms anyway, this obfuscates that fact (and i

[PATCH 1/3] drm/radeon/kms: use crtc-specific dpms functions in prepare and commit

2011-10-25 Thread Ilija Hadzic
it's better that radeon_crtc_commit and radeon_crtc_prepare call crtc-specific dpms functions instead of hard-coding them to radeon_crtc_dpms. Signed-off-by: Ilija Hadzic --- drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) dif

[PATCH 1/3] drm/radeon/kms: use crtc-specific dpms functions in prepare and commit

2011-10-25 Thread Ilija Hadzic
it's better that radeon_crtc_commit and radeon_crtc_prepare call crtc-specific dpms functions instead of hard-coding them to radeon_crtc_dpms. Signed-off-by: Ilija Hadzic --- drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) dif