On Fri Sep 5, 2025 at 8:50 PM JST, Alexandre Courbot wrote:
>> +
>> +Ok(GspCmdq {
>> +dev: dev.into(),
>> +msg_count: MSG_COUNT,
>> +seq: 0,
>> +gsp_mem,
>> +_nr_ptes: nr_ptes as u32,
>> +})
>> +}
>> +
>> +fn cpu_wp
Hi Alistair,
Here is a second pass on things not directly related to bindings.
One general comment is that we will want more documentation about how
the command queue operates; without it it is a bit difficult to
understand how things run and who can read or write what. I hope we can
improve the
On Thu Sep 4, 2025 at 3:57 PM JST, Alistair Popple wrote:
>> > +}
>> > +
>> > +// This next section contains constants and structures hand-coded from
>> > the GSP
>> > +// headers We could replace these with bindgen versions, but that's a bit
>> > of a
>> > +// pain because they basically end up
On 2025-09-04 at 14:12 +1000, Alexandre Courbot wrote...
> Hi Alistair,
>
> Making a pass about the bindings only - I will check the command-queue
> logic in another one.
>
> On Wed Aug 27, 2025 at 5:20 PM JST, Alistair Popple wrote:
> > This commit introduces core infrastructure for handling GS
Hi Alistair,
Making a pass about the bindings only - I will check the command-queue
logic in another one.
On Wed Aug 27, 2025 at 5:20 PM JST, Alistair Popple wrote:
> This commit introduces core infrastructure for handling GSP command and
> message queues in the nova-core driver. The command queu
On 2025-08-28 at 06:35 +1000, John Hubbard wrote...
> On 8/27/25 1:20 AM, Alistair Popple wrote:
> ...
>
> Hi Alistair,
>
> Not a real review yet, but one thing I noticed on a quick first pass:
>
> > +pub(crate) fn send_cmd_to_gsp(cmd: GspQueueCommand<'_>, bar: &Bar0) ->
> > Result {
> > +
On 8/27/25 1:20 AM, Alistair Popple wrote:
...
Hi Alistair,
Not a real review yet, but one thing I noticed on a quick first pass:
> +pub(crate) fn send_cmd_to_gsp(cmd: GspQueueCommand<'_>, bar: &Bar0) ->
> Result {
> +// Find the start of the message. We could also re-read the HW
>
This commit introduces core infrastructure for handling GSP command and
message queues in the nova-core driver. The command queue system enables
bidirectional communication between the host driver and GSP firmware
through a remote message passing interface.
The interface is based on passing serial
