Re: [PATCH] vt: Grab console_lock around con_is_bound in show_bind

2019-07-23 Thread Greg Kroah-Hartman
On Tue, Jul 23, 2019 at 09:38:20AM +0200, Daniel Vetter wrote: > Hi Greg, > > Do you plan to pick this up in your console/vt/whatever-fixes branch? Yes, now that the merge window is closed, I will be picking this up. thanks, greg k-h ___ dri-devel mai

Re: [PATCH] vt: Grab console_lock around con_is_bound in show_bind

2019-07-23 Thread Daniel Vetter
Hi Greg, Do you plan to pick this up in your console/vt/whatever-fixes branch? There's no reason for me to route this through drm-fixes. -Daniel On Thu, Jul 18, 2019 at 10:09:03AM +0200, Daniel Vetter wrote: > Not really harmful not to, but also not harm in grabbing the lock. And > this shuts up

Re: [PATCH] vt: Grab console_lock around con_is_bound in show_bind

2019-07-18 Thread Jens Remus
Am 18.07.2019 um 10:09 schrieb Daniel Vetter: Not really harmful not to, but also not harm in grabbing the lock. And this shuts up a new WARNING I introduced in commit ddde3c18b700 ("vt: More locking checks"). Reported-by: Jens Remus Cc: linux-ker...@vger.kernel.org Cc: dri-devel@lists.freedesk

Re: [PATCH] vt: Grab console_lock around con_is_bound in show_bind

2019-07-18 Thread Sam Ravnborg
Hi Daniel. Patch looks good. You can add my: Acked-by: Sam Ravnborg For good measure I checked all other users of con_is_bound() and they looked good from a locking perspective. Then I looked a bit more for missing locking and lost the overview. On Thu, Jul 18, 2019 at 10:09:03AM +0200, Daniel

[PATCH] vt: Grab console_lock around con_is_bound in show_bind

2019-07-18 Thread Daniel Vetter
Not really harmful not to, but also not harm in grabbing the lock. And this shuts up a new WARNING I introduced in commit ddde3c18b700 ("vt: More locking checks"). Reported-by: Jens Remus Cc: linux-ker...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-fb...@vger.kernel.org Cc: linu