Not really harmful not to, but also not harm in grabbing the lock. And this shuts up a new WARNING I introduced in commit ddde3c18b700 ("vt: More locking checks").
Reported-by: Jens Remus <jre...@linux.ibm.com> Cc: linux-ker...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-fb...@vger.kernel.org Cc: linux-s...@vger.kernel.org Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: Nicolas Pitre <nicolas.pi...@linaro.org> Cc: Martin Hostettler <textsh...@uchuujin.de> Cc: Adam Borowski <kilob...@angband.pl> Cc: Mikulas Patocka <mpato...@redhat.com> Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Sam Ravnborg <s...@ravnborg.org> --- drivers/tty/vt/vt.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index ec92f36ab5c4..34aa39d1aed9 100644 --- a/drivers/tty/vt/vt.c +++ b/drivers/tty/vt/vt.c @@ -3771,7 +3771,11 @@ static ssize_t show_bind(struct device *dev, struct device_attribute *attr, char *buf) { struct con_driver *con = dev_get_drvdata(dev); - int bind = con_is_bound(con->con); + int bind; + + console_lock(); + bind = con_is_bound(con->con); + console_unlock(); return snprintf(buf, PAGE_SIZE, "%i\n", bind); } -- 2.20.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel