[PATCH] drm: adv7511: really enable interrupts for EDID detection

2015-11-26 Thread Wolfram Sang
On Thu, Nov 26, 2015 at 01:43:33PM +0100, Lars-Peter Clausen wrote: > On 11/25/2015 09:27 AM, Wolfram Sang wrote: > > > >> I guess you mean that the GPIO callbacks include Runtime PM handling > >> however for irq_chip Runtime PM may not be hooked up so the GPIO block > >> is in such case is not po

[PATCH] drm: adv7511: really enable interrupts for EDID detection

2015-11-26 Thread Lars-Peter Clausen
On 11/25/2015 09:27 AM, Wolfram Sang wrote: > >> I guess you mean that the GPIO callbacks include Runtime PM handling >> however for irq_chip Runtime PM may not be hooked up so the GPIO block >> is in such case is not powered on / get clock enabled? > > Yes. There is another drawback when GPIOs a

[PATCH] drm: adv7511: really enable interrupts for EDID detection

2015-11-25 Thread Magnus Damm
Hi Wolfram, On Wed, Nov 25, 2015 at 3:48 PM, Wolfram Sang wrote: > >> > This has been tackled as well now. The clock for the GPIO controller was >> > off, so no interrupt was passed through. >> >> Thanks a lot for your efforts! When you have time, can you please show >> me the patch that fixes th

[PATCH] drm: adv7511: really enable interrupts for EDID detection

2015-11-25 Thread Magnus Damm
Hi Wolfram, On Wed, Nov 25, 2015 at 6:05 AM, Wolfram Sang wrote: > >> Note that I could not yet read EDID with Magnus' Koelsch. > > This has been tackled as well now. The clock for the GPIO controller was > off, so no interrupt was passed through. Thanks a lot for your efforts! When you have tim

[PATCH] drm: adv7511: really enable interrupts for EDID detection

2015-11-25 Thread Wolfram Sang
> I guess you mean that the GPIO callbacks include Runtime PM handling > however for irq_chip Runtime PM may not be hooked up so the GPIO block > is in such case is not powered on / get clock enabled? Yes. There is another drawback when GPIOs are not properly requested. It is still possible to re

[PATCH] drm: adv7511: really enable interrupts for EDID detection

2015-11-25 Thread Wolfram Sang
> > This has been tackled as well now. The clock for the GPIO controller was > > off, so no interrupt was passed through. > > Thanks a lot for your efforts! When you have time, can you please show > me the patch that fixes that GPIO interrupt problem? I'm asking > because I may have ran into a si

[PATCH] drm: adv7511: really enable interrupts for EDID detection

2015-11-24 Thread Wolfram Sang
> Note that I could not yet read EDID with Magnus' Koelsch. This has been tackled as well now. The clock for the GPIO controller was off, so no interrupt was passed through. -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-si

[PATCH] drm: adv7511: really enable interrupts for EDID detection

2015-11-24 Thread Wolfram Sang
From: Wolfram Sang The interrupts for EDID_READY or DDC_ERROR were never enabled in this driver, so reading EDID always timed out when the chip was powered down and interrupts were used. Fix this and remove clearing the interrupt flags, since they are cleared in POWER_DOWN mode anyhow (according