Re: [PATCH] drm/ttm: fixup ttm_bo_add_move_fence

2022-04-13 Thread Christian König
Am 13.04.22 um 10:44 schrieb Daniel Vetter: On Wed, Apr 13, 2022 at 09:21:33AM +0100, Matthew Auld wrote: It looks like we still need to call dma_fence_put() on the man->move, otherwise we just end up leaking it, leading to fireworks later. Closes: https://nam11.safelinks.protection.outlook

Re: [PATCH] drm/ttm: fixup ttm_bo_add_move_fence

2022-04-13 Thread Daniel Vetter
On Wed, Apr 13, 2022 at 10:43:02AM +0200, Christian König wrote: > Am 13.04.22 um 10:21 schrieb Matthew Auld: > > It looks like we still need to call dma_fence_put() on the man->move, > > otherwise we just end up leaking it, leading to fireworks later. > > > > Closes: > > https://nam11.safelinks.

Re: [PATCH] drm/ttm: fixup ttm_bo_add_move_fence

2022-04-13 Thread Daniel Vetter
On Wed, Apr 13, 2022 at 09:21:33AM +0100, Matthew Auld wrote: > It looks like we still need to call dma_fence_put() on the man->move, > otherwise we just end up leaking it, leading to fireworks later. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5689 > Fixes: 8bb31587820a ("drm/tt

Re: [PATCH] drm/ttm: fixup ttm_bo_add_move_fence

2022-04-13 Thread Christian König
Am 13.04.22 um 10:21 schrieb Matthew Auld: It looks like we still need to call dma_fence_put() on the man->move, otherwise we just end up leaking it, leading to fireworks later. Closes: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fdrm%2Fintel%2F-%2F

[PATCH] drm/ttm: fixup ttm_bo_add_move_fence

2022-04-13 Thread Matthew Auld
It looks like we still need to call dma_fence_put() on the man->move, otherwise we just end up leaking it, leading to fireworks later. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5689 Fixes: 8bb31587820a ("drm/ttm: remove bo->moving") Cc: Christian König Cc: Daniel Vetter Signed-of