Re: [PATCH] drm/rockchip: avoid 64-bit division

2024-11-29 Thread Maxime Ripard
On Mon, Nov 25, 2024 at 11:35:58AM +0100, Geert Uytterhoeven wrote: > Hi Maxime, > > On Fri, Nov 22, 2024 at 10:15 AM Maxime Ripard wrote: > > On Fri, Nov 22, 2024 at 09:36:16AM +0100, Geert Uytterhoeven wrote: > > > On Mon, Nov 4, 2024 at 6:30 PM Nathan Chancellor > > > wrote: > > > > On Fri,

Re: [PATCH] drm/rockchip: avoid 64-bit division

2024-11-25 Thread Geert Uytterhoeven
Hi Maxime, On Fri, Nov 22, 2024 at 10:15 AM Maxime Ripard wrote: > On Fri, Nov 22, 2024 at 09:36:16AM +0100, Geert Uytterhoeven wrote: > > On Mon, Nov 4, 2024 at 6:30 PM Nathan Chancellor wrote: > > > On Fri, Oct 18, 2024 at 03:10:10PM +, Arnd Bergmann wrote: > > > > From: Arnd Bergmann > >

Re: [PATCH] drm/rockchip: avoid 64-bit division

2024-11-22 Thread Geert Uytterhoeven
Hi Maxime, On Fri, Nov 22, 2024 at 10:15 AM Maxime Ripard wrote: > On Fri, Nov 22, 2024 at 09:36:16AM +0100, Geert Uytterhoeven wrote: > > On Mon, Nov 4, 2024 at 6:30 PM Nathan Chancellor wrote: > > > On Fri, Oct 18, 2024 at 03:10:10PM +, Arnd Bergmann wrote: > > > > From: Arnd Bergmann > >

Re: [PATCH] drm/rockchip: avoid 64-bit division

2024-11-22 Thread Maxime Ripard
On Fri, Nov 22, 2024 at 09:36:16AM +0100, Geert Uytterhoeven wrote: > On Mon, Nov 4, 2024 at 6:30 PM Nathan Chancellor wrote: > > On Fri, Oct 18, 2024 at 03:10:10PM +, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > Dividing a 64-bit integer prevents building this for 32-bit target

Re: [PATCH] drm/rockchip: avoid 64-bit division

2024-11-22 Thread Geert Uytterhoeven
On Mon, Nov 4, 2024 at 6:30 PM Nathan Chancellor wrote: > On Fri, Oct 18, 2024 at 03:10:10PM +, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > Dividing a 64-bit integer prevents building this for 32-bit targets: > > > > ERROR: modpost: "__aeabi_uldivmod" > > [drivers/gpu/drm/rockchip/r

Re: [PATCH] drm/rockchip: avoid 64-bit division

2024-11-04 Thread Nathan Chancellor
On Fri, Oct 18, 2024 at 03:10:10PM +, Arnd Bergmann wrote: > From: Arnd Bergmann > > Dividing a 64-bit integer prevents building this for 32-bit targets: > > ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/rockchip/rockchipdrm.ko] > undefined! > > As this function is not performance cr

Re: [PATCH] drm/rockchip: avoid 64-bit division

2024-10-18 Thread Dmitry Baryshkov
On Fri, Oct 18, 2024 at 03:10:10PM +, Arnd Bergmann wrote: > From: Arnd Bergmann > > Dividing a 64-bit integer prevents building this for 32-bit targets: > > ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/rockchip/rockchipdrm.ko] > undefined! > > As this function is not performance cr

[PATCH] drm/rockchip: avoid 64-bit division

2024-10-18 Thread Arnd Bergmann
From: Arnd Bergmann Dividing a 64-bit integer prevents building this for 32-bit targets: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/rockchip/rockchipdrm.ko] undefined! As this function is not performance criticial, just Use the div_u64() helper. Fixes: 128a9bf8ace2 ("drm/rockchip: Ad