On Fri, Oct 18, 2024 at 03:10:10PM +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <a...@arndb.de>
> 
> Dividing a 64-bit integer prevents building this for 32-bit targets:
> 
> ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/rockchip/rockchipdrm.ko] 
> undefined!
> 
> As this function is not performance criticial, just Use the div_u64() helper.
> 
> Fixes: 128a9bf8ace2 ("drm/rockchip: Add basic RK3588 HDMI output support")
> Signed-off-by: Arnd Bergmann <a...@arndb.de>

Reviewed-by: Nathan Chancellor <nat...@kernel.org>

Can someone please pick this up? It is still broken in next-20241104...

https://storage.tuxsuite.com/public/clangbuiltlinux/continuous-integration2/builds/2oNvJFRj8tkDieb6VfrMf4rh1Kn/build.log

> ---
>  drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c 
> b/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c
> index 9c796ee4c303..c8b362cc2b95 100644
> --- a/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c
> @@ -82,7 +82,7 @@ static void dw_hdmi_qp_rockchip_encoder_enable(struct 
> drm_encoder *encoder)
>                * comment in rk_hdptx_phy_power_on() from
>                * drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c
>                */
> -             phy_set_bus_width(hdmi->phy, rate / 100);
> +             phy_set_bus_width(hdmi->phy, div_u64(rate, 100));
>       }
>  }
>  
> -- 
> 2.39.5
> 

Reply via email to