Re: [PATCH] drm/qxl: unbind vgacon

2019-02-21 Thread kbuild test robot
Hi Gerd, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.0-rc4 next-20190221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ge

Re: [PATCH] drm/qxl: unbind vgacon

2019-02-21 Thread kbuild test robot
Hi Gerd, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.0-rc4 next-20190221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ge

Re: [PATCH] drm/qxl: unbind vgacon

2019-02-21 Thread Gerd Hoffmann
> > + /* unbind vgacon to make sure it doesn't touch our vga registers */ > > + console_lock(); > > + ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, true); > > + console_unlock(); > > Still seems very late, in i915 we kick out vgacon as pretty much the first > thing in driv

Re: [PATCH] drm/qxl: unbind vgacon

2019-02-21 Thread Daniel Vetter
On Wed, Feb 20, 2019 at 03:36:40PM +0100, Gerd Hoffmann wrote: > Problem: qxl switches from native mode back into vga compatibility mode > when it notices someone is accessing vga registers. And vgacon does > exactly that before fbcon takes over. > > Before qxl switched to the generic fbdev emul

[PATCH] drm/qxl: unbind vgacon

2019-02-20 Thread Gerd Hoffmann
Problem: qxl switches from native mode back into vga compatibility mode when it notices someone is accessing vga registers. And vgacon does exactly that before fbcon takes over. Before qxl switched to the generic fbdev emulation that didn't cause any problems. With the generic fbdev emulation t