Re: [PATCH] drm/qxl: unbind vgacon

[kbuild test robot]

Hi Gerd,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.0-rc4 next-20190221]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Gerd-Hoffmann/drm-qxl-unbind-vgacon/20190222-030117
config: x86_64-randconfig-m2-02211051 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   ld: drivers/gpu/drm/qxl/qxl_drv.o: in function `qxl_pci_probe':
>> drivers/gpu/drm/qxl/qxl_drv.c:94: undefined reference to `dummy_con'
>> ld: drivers/gpu/drm/qxl/qxl_drv.c:94: undefined reference to 
>> `do_take_over_console'

vim +94 drivers/gpu/drm/qxl/qxl_drv.c

    61  
    62  static int
    63  qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
    64  {
    65          struct qxl_device *qdev;
    66          int ret;
    67  
    68          if (pdev->revision < 4) {
    69                  DRM_ERROR("qxl too old, doesn't support 
client_monitors_config,"
    70                            " use xf86-video-qxl in user mode");
    71                  return -EINVAL; /* TODO: ENODEV ? */
    72          }
    73  
    74          qdev = kzalloc(sizeof(struct qxl_device), GFP_KERNEL);
    75          if (!qdev)
    76                  return -ENOMEM;
    77  
    78          ret = pci_enable_device(pdev);
    79          if (ret)
    80                  goto free_dev;
    81  
    82          ret = qxl_device_init(qdev, &qxl_driver, pdev);
    83          if (ret)
    84                  goto disable_pci;
    85  
    86          ret = qxl_modeset_init(qdev);
    87          if (ret)
    88                  goto unload;
    89  
    90          drm_kms_helper_poll_init(&qdev->ddev);
    91  
    92          /* unbind vgacon to make sure it doesn't touch our vga 
registers */
    93          console_lock();
  > 94          ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, 
true);
    95          console_unlock();
    96  
    97          /* Complete initialization. */
    98          ret = drm_dev_register(&qdev->ddev, ent->driver_data);
    99          if (ret)
   100                  goto modeset_cleanup;
   101  
   102          return 0;
   103  
   104  modeset_cleanup:
   105          qxl_modeset_fini(qdev);
   106  unload:
   107          qxl_device_fini(qdev);
   108  disable_pci:
   109          pci_disable_device(pdev);
   110  free_dev:
   111          kfree(qdev);
   112          return ret;
   113  }
   114  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

.config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel