Re: [PATCH] drm/nouveau: fix missing break in switch statement

2019-01-30 Thread Gustavo A. R. Silva
On 10/8/18 3:47 PM, Colin King wrote: > From: Colin Ian King > > The NOUVEAU_GETPARAM_PCI_DEVICE case is missing a break statement and falls > through to the following NOUVEAU_GETPARAM_BUS_TYPE case and may end up > re-assigning the getparam->value to an undesired value. Fix this by adding > in

Re: [PATCH] drm/nouveau: fix missing break in switch statement

2019-01-30 Thread Gustavo A. R. Silva
On 1/29/19 2:49 PM, Gustavo A. R. Silva wrote: > > > On 10/8/18 3:47 PM, Colin King wrote: >> From: Colin Ian King >> >> The NOUVEAU_GETPARAM_PCI_DEVICE case is missing a break statement and falls >> through to the following NOUVEAU_GETPARAM_BUS_TYPE case and may end up >> re-assigning the get

[PATCH] drm/nouveau: fix missing break in switch statement

2018-10-08 Thread Colin King
From: Colin Ian King The NOUVEAU_GETPARAM_PCI_DEVICE case is missing a break statement and falls through to the following NOUVEAU_GETPARAM_BUS_TYPE case and may end up re-assigning the getparam->value to an undesired value. Fix this by adding in the missing break. Detected by CoverityScan, CID#1