Re: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-06-30 Thread Rodrigo Vivi
On Fri, Apr 25, 2025 at 11:11:07PM +0800, Junxiao Chang wrote: > MEI GSC interrupt comes from i915. It has top half and bottom half. > Top half is called from i915 interrupt handler. It should be in > irq disabled context. > > With RT kernel, by default i915 IRQ handler is in threaded IRQ. MEI GSC

[PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-25 Thread Junxiao Chang
MEI GSC interrupt comes from i915. It has top half and bottom half. Top half is called from i915 interrupt handler. It should be in irq disabled context. With RT kernel, by default i915 IRQ handler is in threaded IRQ. MEI GSC top half might be in threaded IRQ context. generic_handle_irq_safe API c

Re: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-25 Thread Sebastian Andrzej Siewior
On 2025-04-25 20:04:43 [+0800], Junxiao Chang wrote: > --- a/drivers/gpu/drm/i915/gt/intel_gsc.c > +++ b/drivers/gpu/drm/i915/gt/intel_gsc.c > @@ -284,7 +284,8 @@ static void gsc_irq_handler(struct intel_gt *gt, unsigned > int intf_id) > if (gt->gsc.intf[intf_id].irq < 0) > ret

[PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-25 Thread Junxiao Chang
MEI GSC interrupt comes from i915. It has top half and bottom half. Top half is called from i915 interrupt handler. It should be in irq disabled context. With RT kernel, by default i915 IRQ handler is in threaded IRQ. MEI GSC top half might be in threaded IRQ context. generic_handle_irq_safe API c

RE: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-25 Thread Chang, Junxiao
On Fri, 25 Apr 2025, Jani Nikula wrote: >On Fri, 25 Apr 2025, Junxiao Chang wrote: >> MEI GSC interrupt comes from i915. It has top half and bottom half. >> >> -ret = generic_handle_irq(gt->gsc.intf[intf_id].irq); >> +/* It can be called in both irq context and in thread context */ > >Wha

Re: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-25 Thread Sebastian Andrzej Siewior
On 2025-04-25 14:04:54 [+0800], Junxiao Chang wrote: > MEI GSC interrupt comes from i915. It has top half and bottom half. > Top half is called from i915 interrupt handler. It should be in > irq disabled context. > > With RT kernel, by default i915 IRQ handler is in threaded IRQ. MEI GSC > top hal

Re: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-25 Thread Jani Nikula
On Fri, 25 Apr 2025, Junxiao Chang wrote: > MEI GSC interrupt comes from i915. It has top half and bottom half. > Top half is called from i915 interrupt handler. It should be in > irq disabled context. > > With RT kernel, by default i915 IRQ handler is in threaded IRQ. MEI GSC > top half might be

[PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-24 Thread Junxiao Chang
MEI GSC interrupt comes from i915. It has top half and bottom half. Top half is called from i915 interrupt handler. It should be in irq disabled context. With RT kernel, by default i915 IRQ handler is in threaded IRQ. MEI GSC top half might be in threaded IRQ context. generic_handle_irq_safe API c

Re: RE: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-24 Thread Sebastian Andrzej Siewior
On 2025-04-24 10:53:31 [+], Chang, Junxiao wrote: > >> This should have a Fixes when generic_handle_irq() was introduced. > > If PREEMPT_RT is disabled, original driver works fine. I prefer to not > add "Fixes:"? PREEMPT_RT is mainline. It deserves the same fixes as other parts of the kernel.

RE: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-24 Thread Chang, Junxiao
On Thu, 24 Apr 2025, Jani Nikula wrote: >On Thu, 24 Apr 2025, Sebastian Andrzej Siewior >wrote: >> On 2025-04-24 14:56:08 [+0800], Junxiao Chang wrote: >>> MEI GSC interrupt comes from i915. It has top half and bottom half. >>> Top half is called from i915 interrupt handler. It should be in irq >

Re: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-24 Thread Jani Nikula
On Thu, 24 Apr 2025, Sebastian Andrzej Siewior wrote: > On 2025-04-24 14:56:08 [+0800], Junxiao Chang wrote: >> MEI GSC interrupt comes from i915. It has top half and bottom half. >> Top half is called from i915 interrupt handler. It should be in >> irq disabled context. >> >> With RT kernel, by

Re: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-24 Thread Sebastian Andrzej Siewior
On 2025-04-24 14:56:08 [+0800], Junxiao Chang wrote: > MEI GSC interrupt comes from i915. It has top half and bottom half. > Top half is called from i915 interrupt handler. It should be in > irq disabled context. > > With RT kernel, by default i915 IRQ handler is in threaded IRQ. MEI GSC > top hal

[PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-23 Thread Junxiao Chang
MEI GSC interrupt comes from i915. It has top half and bottom half. Top half is called from i915 interrupt handler. It should be in irq disabled context. With RT kernel, by default i915 IRQ handler is in threaded IRQ. MEI GSC top half might be in threaded IRQ context. In this case, local IRQ shoul