Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-28 Thread Daniel Vetter
Hi Liviu, On Mon, Jan 28, 2019 at 3:03 PM Liviu Dudau wrote: > > On Tue, Jan 22, 2019 at 05:28:19PM +0100, Daniel Vetter wrote: > > On Tue, Jan 22, 2019 at 5:11 PM Sean Paul wrote: > > > On Tue, Jan 22, 2019 at 04:17:25PM +0100, Daniel Vetter wrote: > > > > On Tue, Jan 22, 2019 at 4:08 PM Brian

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-28 Thread Liviu Dudau
On Tue, Jan 22, 2019 at 05:28:19PM +0100, Daniel Vetter wrote: > On Tue, Jan 22, 2019 at 5:11 PM Sean Paul wrote: > > On Tue, Jan 22, 2019 at 04:17:25PM +0100, Daniel Vetter wrote: > > > On Tue, Jan 22, 2019 at 4:08 PM Brian Starkey > > > wrote: > > > > > > > > On Tue, Jan 22, 2019 at 03:03:59PM

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-23 Thread Daniel Vetter
On Wed, Jan 23, 2019 at 12:03:40PM +0200, Jani Nikula wrote: > On Tue, 22 Jan 2019, "Wentland, Harry" wrote: > > Would it make sense to append something like ", if such a test can be > > reasonably made using IGT for the target HW." to make it clear to > > contributors that in cases like the one d

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-23 Thread Daniel Vetter
On Wed, Jan 23, 2019 at 12:11:36PM +0200, Jani Nikula wrote: > On Wed, 23 Jan 2019, Daniel Stone wrote: > > If it helps, maybe we could draw up a list somewhere (README in igt? > > wiki?) of which tests seem to pass generically across a few drivers, > > which ones are expected to pass, which ones

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-23 Thread Daniel Vetter
On Wed, Jan 23, 2019 at 09:40:34AM +, Brian Starkey wrote: > On Tue, Jan 22, 2019 at 08:19:10PM +0100, Daniel Vetter wrote: > > On Tue, Jan 22, 2019 at 8:00 PM Wentland, Harry > > wrote: > > > On 2019-01-16 11:39 a.m., Daniel Vetter wrote: > > > > Compared to the RFC[1] no changes to the patc

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-23 Thread Jani Nikula
On Wed, 23 Jan 2019, Daniel Stone wrote: > If it helps, maybe we could draw up a list somewhere (README in igt? > wiki?) of which tests seem to pass generically across a few drivers, > which ones are expected to pass, which ones don't but really should, > etc. I'm currently running on imx-drm (com

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-23 Thread Daniel Stone
Hi, On Tue, 22 Jan 2019 at 19:42, Wentland, Harry wrote: > On 2019-01-22 2:19 p.m., Daniel Vetter wrote: > > I'd say we'll shrug these cases off as "can't be reasonable tested, > > won't have an igt". First driver team with hw that can be validated > > gets to fill the gaps :-) In practice still

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-23 Thread Jani Nikula
On Tue, 22 Jan 2019, "Wentland, Harry" wrote: > Would it make sense to append something like ", if such a test can be > reasonably made using IGT for the target HW." to make it clear to > contributors that in cases like the one discussed this is at the > reviewers discretion? I think the simplest

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-23 Thread Brian Starkey
On Tue, Jan 22, 2019 at 02:53:37PM -0500, Sean Paul wrote: > On Tue, Jan 22, 2019 at 07:42:30PM +, Wentland, Harry wrote: > > > > > > On 2019-01-22 2:19 p.m., Daniel Vetter wrote: > > > On Tue, Jan 22, 2019 at 8:00 PM Wentland, Harry > > > wrote: > > >> On 2019-01-16 11:39 a.m., Daniel Vett

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-23 Thread Brian Starkey
On Tue, Jan 22, 2019 at 08:19:10PM +0100, Daniel Vetter wrote: > On Tue, Jan 22, 2019 at 8:00 PM Wentland, Harry > wrote: > > On 2019-01-16 11:39 a.m., Daniel Vetter wrote: > > > Compared to the RFC[1] no changes to the patch itself, but igt moved > > > forward a lot: > > > > > > - gitlab CI buil

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-22 Thread Sean Paul
On Tue, Jan 22, 2019 at 07:42:30PM +, Wentland, Harry wrote: > > > On 2019-01-22 2:19 p.m., Daniel Vetter wrote: > > On Tue, Jan 22, 2019 at 8:00 PM Wentland, Harry > > wrote: > >> On 2019-01-16 11:39 a.m., Daniel Vetter wrote: > >>> Compared to the RFC[1] no changes to the patch itself, bu

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-22 Thread Wentland, Harry
On 2019-01-22 2:19 p.m., Daniel Vetter wrote: > On Tue, Jan 22, 2019 at 8:00 PM Wentland, Harry > wrote: >> On 2019-01-16 11:39 a.m., Daniel Vetter wrote: >>> Compared to the RFC[1] no changes to the patch itself, but igt moved >>> forward a lot: >>> >>> - gitlab CI builds with: reduced configs

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-22 Thread Daniel Vetter
On Tue, Jan 22, 2019 at 8:00 PM Wentland, Harry wrote: > On 2019-01-16 11:39 a.m., Daniel Vetter wrote: > > Compared to the RFC[1] no changes to the patch itself, but igt moved > > forward a lot: > > > > - gitlab CI builds with: reduced configs/libraries, arm cross build > > and a sysroot build

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-22 Thread Wentland, Harry
On 2019-01-16 11:39 a.m., Daniel Vetter wrote: > Compared to the RFC[1] no changes to the patch itself, but igt moved > forward a lot: > > - gitlab CI builds with: reduced configs/libraries, arm cross build > and a sysroot build (should address all the build/cross platform > concerns raised in

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-22 Thread Daniel Vetter
On Tue, Jan 22, 2019 at 5:11 PM Sean Paul wrote: > On Tue, Jan 22, 2019 at 04:17:25PM +0100, Daniel Vetter wrote: > > On Tue, Jan 22, 2019 at 4:08 PM Brian Starkey wrote: > > > > > > On Tue, Jan 22, 2019 at 03:03:59PM +0100, Daniel Vetter wrote: > > > > On Tue, Jan 22, 2019 at 2:27 PM Brian Stark

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-22 Thread Sean Paul
On Tue, Jan 22, 2019 at 04:17:25PM +0100, Daniel Vetter wrote: > On Tue, Jan 22, 2019 at 4:08 PM Brian Starkey wrote: > > > > On Tue, Jan 22, 2019 at 03:03:59PM +0100, Daniel Vetter wrote: > > > On Tue, Jan 22, 2019 at 2:27 PM Brian Starkey > > > wrote: > > /snip > > > > > > > > That seems a

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-22 Thread Daniel Vetter
On Tue, Jan 22, 2019 at 4:08 PM Brian Starkey wrote: > > On Tue, Jan 22, 2019 at 03:03:59PM +0100, Daniel Vetter wrote: > > On Tue, Jan 22, 2019 at 2:27 PM Brian Starkey wrote: > > [snip] > > > > > > > That doesn't really address my issue, but no matter. I guess I'm > > > having a hard time separ

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-22 Thread Brian Starkey
On Tue, Jan 22, 2019 at 03:03:59PM +0100, Daniel Vetter wrote: > On Tue, Jan 22, 2019 at 2:27 PM Brian Starkey wrote: [snip] > > > > That doesn't really address my issue, but no matter. I guess I'm > > having a hard time separating the existing igts from _new_ igts for > > new features; so sorry

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-22 Thread Daniel Vetter
On Tue, Jan 22, 2019 at 2:27 PM Brian Starkey wrote: > > Hi, > > On Tue, Jan 22, 2019 at 09:53:20AM +0100, Daniel Vetter wrote: > > On Mon, Jan 21, 2019 at 6:21 PM Daniel Vetter > > wrote: > > > > > > On Mon, Jan 21, 2019 at 12:54 PM Brian Starkey > > > wrote: > > > > > > > > Hi Daniel, > > >

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-22 Thread Brian Starkey
Hi, On Tue, Jan 22, 2019 at 09:53:20AM +0100, Daniel Vetter wrote: > On Mon, Jan 21, 2019 at 6:21 PM Daniel Vetter wrote: > > > > On Mon, Jan 21, 2019 at 12:54 PM Brian Starkey > > wrote: > > > > > > Hi Daniel, > > > > > > On Thu, Jan 17, 2019 at 12:52:16PM +0100, Daniel Vetter wrote: > > > > O

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-22 Thread Daniel Vetter
On Mon, Jan 21, 2019 at 6:21 PM Daniel Vetter wrote: > > On Mon, Jan 21, 2019 at 12:54 PM Brian Starkey wrote: > > > > Hi Daniel, > > > > On Thu, Jan 17, 2019 at 12:52:16PM +0100, Daniel Vetter wrote: > > > On Thu, Jan 17, 2019 at 12:38 PM Liviu Dudau wrote: > > > > > > > > On Wed, Jan 16, 2019

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-21 Thread Daniel Vetter
On Mon, Jan 21, 2019 at 12:54 PM Brian Starkey wrote: > > Hi Daniel, > > On Thu, Jan 17, 2019 at 12:52:16PM +0100, Daniel Vetter wrote: > > On Thu, Jan 17, 2019 at 12:38 PM Liviu Dudau wrote: > > > > > > On Wed, Jan 16, 2019 at 05:39:03PM +0100, Daniel Vetter wrote: > > > > Compared to the RFC[1]

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-21 Thread Brian Starkey
Hi Daniel, On Thu, Jan 17, 2019 at 12:52:16PM +0100, Daniel Vetter wrote: > On Thu, Jan 17, 2019 at 12:38 PM Liviu Dudau wrote: > > > > On Wed, Jan 16, 2019 at 05:39:03PM +0100, Daniel Vetter wrote: > > > Compared to the RFC[1] no changes to the patch itself, but igt moved > > > forward a lot: >

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-18 Thread Liviu Dudau
On Thu, Jan 17, 2019 at 04:59:49PM +0100, Daniel Vetter wrote: > On Thu, Jan 17, 2019 at 3:54 PM Liviu Dudau wrote: > > > > On Thu, Jan 17, 2019 at 01:32:15PM +0100, Daniel Vetter wrote: > > > On Thu, Jan 17, 2019 at 1:26 PM Liviu Dudau wrote: > > > > > > > > On Thu, Jan 17, 2019 at 12:52:16PM +0

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-17 Thread Daniel Vetter
On Thu, Jan 17, 2019 at 3:54 PM Liviu Dudau wrote: > > On Thu, Jan 17, 2019 at 01:32:15PM +0100, Daniel Vetter wrote: > > On Thu, Jan 17, 2019 at 1:26 PM Liviu Dudau wrote: > > > > > > On Thu, Jan 17, 2019 at 12:52:16PM +0100, Daniel Vetter wrote: > > > > On Thu, Jan 17, 2019 at 12:38 PM Liviu Du

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-17 Thread Liviu Dudau
On Thu, Jan 17, 2019 at 01:32:15PM +0100, Daniel Vetter wrote: > On Thu, Jan 17, 2019 at 1:26 PM Liviu Dudau wrote: > > > > On Thu, Jan 17, 2019 at 12:52:16PM +0100, Daniel Vetter wrote: > > > On Thu, Jan 17, 2019 at 12:38 PM Liviu Dudau wrote: > > > > > > > > On Wed, Jan 16, 2019 at 05:39:03PM +

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-17 Thread Daniel Vetter
On Thu, Jan 17, 2019 at 1:26 PM Liviu Dudau wrote: > > On Thu, Jan 17, 2019 at 12:52:16PM +0100, Daniel Vetter wrote: > > On Thu, Jan 17, 2019 at 12:38 PM Liviu Dudau wrote: > > > > > > On Wed, Jan 16, 2019 at 05:39:03PM +0100, Daniel Vetter wrote: > > > > Compared to the RFC[1] no changes to the

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-17 Thread Liviu Dudau
On Thu, Jan 17, 2019 at 12:52:16PM +0100, Daniel Vetter wrote: > On Thu, Jan 17, 2019 at 12:38 PM Liviu Dudau wrote: > > > > On Wed, Jan 16, 2019 at 05:39:03PM +0100, Daniel Vetter wrote: > > > Compared to the RFC[1] no changes to the patch itself, but igt moved > > > forward a lot: > > > > > > -

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-17 Thread Daniel Vetter
On Thu, Jan 17, 2019 at 12:38 PM Liviu Dudau wrote: > > On Wed, Jan 16, 2019 at 05:39:03PM +0100, Daniel Vetter wrote: > > Compared to the RFC[1] no changes to the patch itself, but igt moved > > forward a lot: > > > > - gitlab CI builds with: reduced configs/libraries, arm cross build > > and a

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-17 Thread Daniel Vetter
On Wed, Jan 16, 2019 at 11:41 PM Eric Anholt wrote: > > Daniel Vetter writes: > > > Compared to the RFC[1] no changes to the patch itself, but igt moved > > forward a lot: > > > > - gitlab CI builds with: reduced configs/libraries, arm cross build > > and a sysroot build (should address all the

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-17 Thread Liviu Dudau
On Wed, Jan 16, 2019 at 05:39:03PM +0100, Daniel Vetter wrote: > Compared to the RFC[1] no changes to the patch itself, but igt moved > forward a lot: > > - gitlab CI builds with: reduced configs/libraries, arm cross build > and a sysroot build (should address all the build/cross platform > co

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-17 Thread Petri Latvala
On Thu, Jan 17, 2019 at 01:01:00PM +0200, Arkadiusz Hiler wrote: > On Wed, Jan 16, 2019 at 05:39:03PM +0100, Daniel Vetter wrote: > > Compared to the RFC[1] no changes to the patch itself, but igt moved > > forward a lot: > > > > - gitlab CI builds with: reduced configs/libraries, arm cross build

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-17 Thread Arkadiusz Hiler
On Wed, Jan 16, 2019 at 05:39:03PM +0100, Daniel Vetter wrote: > Compared to the RFC[1] no changes to the patch itself, but igt moved > forward a lot: > > - gitlab CI builds with: reduced configs/libraries, arm cross build > and a sysroot build (should address all the build/cross platform > co

Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-16 Thread Eric Anholt
Daniel Vetter writes: > Compared to the RFC[1] no changes to the patch itself, but igt moved > forward a lot: > > - gitlab CI builds with: reduced configs/libraries, arm cross build > and a sysroot build (should address all the build/cross platform > concerns raised in the RFC discussions). >

[PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-16 Thread Daniel Vetter
Compared to the RFC[1] no changes to the patch itself, but igt moved forward a lot: - gitlab CI builds with: reduced configs/libraries, arm cross build and a sysroot build (should address all the build/cross platform concerns raised in the RFC discussions). - tests reorganized into subdirecto