Re: [PATCH] drm/bochs: Fix NULL dereference on atomic_disable helper

2019-03-11 Thread Daniel Vetter
On Mon, Mar 11, 2019 at 02:49:58PM -0300, Rodrigo Siqueira wrote: > On 03/11, Gerd Hoffmann wrote: > > Hi, > > > > > > IIRC the drm code checks for the atomic_enable callback presence to > > > > figure whenever it should take the atomic or legacy code paths. > > > > > > It should check for drm_

Re: [PATCH] drm/bochs: Fix NULL dereference on atomic_disable helper

2019-03-11 Thread Rodrigo Siqueira
On 03/11, Gerd Hoffmann wrote: > Hi, > > > > IIRC the drm code checks for the atomic_enable callback presence to > > > figure whenever it should take the atomic or legacy code paths. > > > > It should check for drm_driver->mode_config.funcs.atomic_commit for that, > > see drm_drv_uses_atomic_mo

Re: [PATCH] drm/bochs: Fix NULL dereference on atomic_disable helper

2019-03-11 Thread Gerd Hoffmann
Hi, > > IIRC the drm code checks for the atomic_enable callback presence to > > figure whenever it should take the atomic or legacy code paths. > > It should check for drm_driver->mode_config.funcs.atomic_commit for that, > see drm_drv_uses_atomic_modeset(). Anything else should be a bug. > >

Re: [PATCH] drm/bochs: Fix NULL dereference on atomic_disable helper

2019-03-11 Thread Daniel Vetter
On Mon, Mar 11, 2019 at 02:07:16PM +0100, Gerd Hoffmann wrote: > Hi, > > > > > static void bochs_crtc_atomic_flush(struct drm_crtc *crtc, > > > > struct drm_crtc_state > > > > *old_crtc_state) > > > > { > > > > @@ -66,6 +71,7 @@ static const struct drm_crtc

Re: [PATCH] drm/bochs: Fix NULL dereference on atomic_disable helper

2019-03-11 Thread Gerd Hoffmann
Hi, > > > static void bochs_crtc_atomic_flush(struct drm_crtc *crtc, > > > struct drm_crtc_state *old_crtc_state) > > > { > > > @@ -66,6 +71,7 @@ static const struct drm_crtc_funcs bochs_crtc_funcs = { > > > static const struct drm_crtc_helper_funcs bochs_helper_

Re: [PATCH] drm/bochs: Fix NULL dereference on atomic_disable helper

2019-03-11 Thread Rodrigo Siqueira
On 03/11, Gerd Hoffmann wrote: > On Sun, Mar 10, 2019 at 06:21:50PM -0300, Rodrigo Siqueira wrote: > > When the subtest basic-plain-flip from IGT project was executed on Bochs > > driver, the following bug appears: > > > > BUG: unable to handle kernel NULL pointer dereference at >

Re: [PATCH] drm/bochs: Fix NULL dereference on atomic_disable helper

2019-03-10 Thread Gerd Hoffmann
On Sun, Mar 10, 2019 at 06:21:50PM -0300, Rodrigo Siqueira wrote: > When the subtest basic-plain-flip from IGT project was executed on Bochs > driver, the following bug appears: > > BUG: unable to handle kernel NULL pointer dereference at > ? drm_atomic_helper_commit_modeset_dis

[PATCH] drm/bochs: Fix NULL dereference on atomic_disable helper

2019-03-10 Thread Rodrigo Siqueira
When the subtest basic-plain-flip from IGT project was executed on Bochs driver, the following bug appears: BUG: unable to handle kernel NULL pointer dereference at PGD 0 P4D 0 Oops: 0010 [#1] PREEMPT SMP PTI CPU: 0 PID: 423 Comm: kms_flip Not tainted 5.0.0-VM+ #102 Hardware name: