RE: New subsystem for acceleration devices

2022-08-10 Thread yuji2.ishikawa
> -Original Message- > From: Oded Gabbay > Sent: Wednesday, August 10, 2022 6:42 AM > To: Dave Airlie ; Greg Kroah-Hartman > ; ishikawa yuji(石川 悠司 ○RDC□AITC○ > EA開) ; Jiho Chu > Cc: dri-devel ; Arnd Bergmann > ; Linux-Kernel@Vger. Kernel. Org > ; Jason Gunthorpe > Subject: Re: New subsys

RE: [PATCH v2 2/5] soc: visconti: Add Toshiba Visconti image processing accelerator common source

2022-07-26 Thread yuji2.ishikawa
Hi Greg, Thank you for your comments. > -Original Message- > From: Greg KH > Sent: Monday, July 25, 2022 9:46 PM > To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開) > > Cc: Rob Herring ; Hans Verkuil ; > iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT) > ; Jonathan Corbet ; > Sumit Semwal ; Christian König > ; l

RE: [PATCH v2 5/5] Documentation: driver-api: visconti: add a description of DNN driver.

2022-07-25 Thread yuji2.ishikawa
Hi Jonathan Thank you for your comments > -Original Message- > From: Jonathan Corbet > Sent: Friday, July 22, 2022 10:33 PM > To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開) > ; Rob Herring ; Hans > Verkuil ; iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT) > ; Sumit Semwal > ; Christian König > Cc: linux-arm-

RE: [PATCH v2 4/5] MAINTAINERS: Add entries for Toshiba Visconti DNN image processing accelerator

2022-07-25 Thread yuji2.ishikawa
Sorry for this patch not being well formatted. I'll add change log and the signed-off-by tag. I should have checked patches with checkpatch.pl as well as testing sources with --file option. Regards, Yuji > -Original Message- > From: Greg KH > Sent: Monday, July 25, 2022 9:47 PM > To

RE: [PATCH v2 3/5] soc: visconti: Add Toshiba Visconti DNN image processing accelerator

2022-07-25 Thread yuji2.ishikawa
Hi Greg Thank you for your comments. > -Original Message- > From: Greg KH > Sent: Monday, July 25, 2022 9:51 PM > To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開) > > Cc: Rob Herring ; Hans Verkuil ; > iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT) > ; Jonathan Corbet ; > Sumit Semwal ; Christian König > ; li

RE: [PATCH v2 3/5] soc: visconti: Add Toshiba Visconti DNN image processing accelerator

2022-07-25 Thread yuji2.ishikawa
Hi Greg Thanks for your comments > -Original Message- > From: Greg KH > Sent: Monday, July 25, 2022 9:48 PM > To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開) > Hi > Cc: Rob Herring ; Hans Verkuil ; > iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT) > ; Jonathan Corbet ; > Sumit Semwal ; Christian König > ; linu

RE: [PATCH v2 0/5] Add Toshiba Visconti DNN image processing accelerator driver

2022-07-25 Thread yuji2.ishikawa
Hi Greg Thank you for your comments. > -Original Message- > From: Greg KH > Sent: Monday, July 25, 2022 9:47 PM > To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開) > > Cc: Rob Herring ; Hans Verkuil ; > iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT) > ; Jonathan Corbet ; > Sumit Semwal ; Christian König > ; li

RE: [PATCH 0/4] Add Toshiba Visconti DNN image processing accelerator driver

2022-07-11 Thread yuji2.ishikawa
Hi Hans, I'm going to submit DNN driver (with misc driver style) again. Updated version will include corrections suggested in reviews. For example: * apply checkpatch.pl --strict * uppercase letters in function name -> make them lowercase * use of integer types: uint32_t -> u32 ( _u32 in user API

RE: [PATCH 0/4] Add Toshiba Visconti DNN image processing accelerator driver

2022-07-05 Thread yuji2.ishikawa
Hi Hans, Thank you for your advice. I understand that V4L2 M2M driver is recommended for a group including Affine and Pyramid. As for DSPIF, our application SW engineer said that there is another version of firmware to handle neural network. Therefore, DSP can handle not only images, but also s

RE: [PATCH v2 3/4] soc: visconti: Add Toshiba Visconti AFFINE image processing accelerator

2022-05-31 Thread yuji2.ishikawa
Hi, Hans, With your advice for DNN accelerator, I prepared some description of AFFINE IPA and its usage. Handling memory blocks for Visconti5 accelerators (same description for DNN accelerator) Visconti5 Image-Processing-Accelerators do not have fine grained IOMMU, as CPU have. Therefore

RE: [PATCH 0/4] Add Toshiba Visconti DNN image processing accelerator driver

2022-05-31 Thread yuji2.ishikawa
Hi Hans, Thank you for your advice. I prepared some description of DNN accelerator and its usage. Handling memory blocks for Visconti5 accelerators Visconti5 Image-Processing-Accelerators do not have fine grained IOMMU, as CPU have. Therefore, memory region to be passed to the accelerators

RE: [PATCH 0/4] Add Toshiba Visconti DNN image processing accelerator driver

2022-05-20 Thread yuji2.ishikawa
Hi Hans, Thank you for your comment. I agree that this submission lacks documents sharing basic idea of the accelerators; what do they accept and what do they yield. Where can I put a new document? Can I put it as a comment in a source? Can I add a file under Documentation/misc-devices directory

RE: [PATCH v2 0/4] Add Toshiba Visconti AFFINE image processing accelerator driver

2022-04-27 Thread yuji2.ishikawa
Hi Laurent, Thank you for your comment. We had never imagined that affine driver can be a V4L2 driver. Affine is one of the accelerators in Visconti, and some accelerators receive/yield non-picture data. Also, as the original accelerator drivers were implemented for kernel 4.19.x, we were not a

RE: [PATCH 0/4] Add Toshiba Visconti AFFINE image processing accelerator driver

2022-04-27 Thread yuji2.ishikawa
Hi, I withdraw this series of patches. I'm going to submit updated version after applying checkpatch.pl with strict option. Best regards, Yuji > -Original Message- > From: Yuji Ishikawa > Sent: Tuesday, April 19, 2022 4:20 PM > To: iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT) > ; Sumit Semwal > ;