Hi Jonathan Thank you for your comments
> -----Original Message----- > From: Jonathan Corbet <cor...@lwn.net> > Sent: Friday, July 22, 2022 10:33 PM > To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開) > <yuji2.ishik...@toshiba.co.jp>; Rob Herring <robh...@kernel.org>; Hans > Verkuil <hverk...@xs4all.nl>; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) > <nobuhiro1.iwama...@toshiba.co.jp>; Sumit Semwal > <sumit.sem...@linaro.org>; Christian König <christian.koe...@amd.com> > Cc: linux-arm-ker...@lists.infradead.org; linux-ker...@vger.kernel.org; > linux-me...@vger.kernel.org; dri-devel@lists.freedesktop.org; > linaro-mm-...@lists.linaro.org; ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ > ＥＡ開) <yuji2.ishik...@toshiba.co.jp> > Subject: Re: [PATCH v2 5/5] Documentation: driver-api: visconti: add a > description of DNN driver. > > Yuji Ishikawa <yuji2.ishik...@toshiba.co.jp> writes: > > No changelog? > I'll add more detailed changelog. > > Signed-off-by: Yuji Ishikawa <yuji2.ishik...@toshiba.co.jp> > > --- > > v1 -> v2: > > - newly added documents > > --- > > Documentation/driver-api/visconti/common.rst | 115 ++++++ > > Documentation/driver-api/visconti/dnn.rst | 394 > +++++++++++++++++++ > > 2 files changed, 509 insertions(+) > > create mode 100644 Documentation/driver-api/visconti/common.rst > > create mode 100644 Documentation/driver-api/visconti/dnn.rst > > Two overall comments: > > - You've added new RST files without adding them to index.rst; that > will keep them from being part of the kernel docs build and will add > new warnings. I'll add index.rst to put these documents into the toc tree. > - Please avoid the use of flat-table and just use regular RST > ascii-art tables. Otherwise the result is nearly unreadable in the > plain-test format. All right, flat-table will be replaced with regular table. > Thanks, > > jon Regards, Yuji
