Re: [PATCH 1/2] drm/bridge/tc358775: Return before displaying inappropriate error message

2022-06-17 Thread Vinay Simha B N
Reviewed-by: Vinay Simha BN On Thu, Jun 16, 2022 at 3:55 AM Jiri Vanek wrote: > Function for reading from i2c device register displays error message even > if reading ends correctly. Add return to avoid falling through into > the fail label. > > Signed-off-by: Jiri Vanek >

Re: [PATCH 2/2] drm/bridge/tc358775: Fix DSI clock division for vsync delay calculation

2022-06-17 Thread Vinay Simha B N
Reviewed-by: Vinay Simha BN On Thu, Jun 16, 2022 at 3:55 AM Jiri Vanek wrote: > Use the same PCLK divide option (divide DSI clock to generate pixel clock) > which is set to LVDS Configuration Register (LVCFG) also for a VSync delay > calculation. Without this change an auxiliary varia

Re: [PATCH v2] drm/bridge/tc358775: Fix for dual-link LVDS

2022-01-07 Thread Vinay Simha B N
Reviewed-by: Vinay Simha BN Jiri Vanek, Could you please share the part number or datasheet of the dual-link LVDS display/panel used. On Fri, Jan 7, 2022 at 12:30 AM Jiri Vanek wrote: > Fixed wrong register shift for single/dual link LVDS output. > > Tested-by: Jiri Vanek > S

Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS

2022-01-05 Thread Vinay Simha B N
Robert, What is R-b tag? On Tue, Jan 4, 2022 at 7:21 PM Robert Foss wrote: > > Jiri: Are you able to test this patch? > > Vinay: Could you supply a R-b tag, if you feel that it is warranted? > > On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N wrote: > > > > Robert,

Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS

2022-01-05 Thread Vinay Simha B N
. Without this fix it > does not work at all. > > Ășt 4. 1. 2022 v 14:51 odesĂ­latel Robert Foss napsal: >> >> Jiri: Are you able to test this patch? >> >> Vinay: Could you supply a R-b tag, if you feel that it is warranted? >> >> On Tue, 14 Dec 2021 at 0

Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS

2021-12-14 Thread Vinay Simha B N
Robert, I do not have the hardware to test this feature. Sorry for the late response. On Thu, Nov 18, 2021 at 8:20 PM Robert Foss wrote: > + Zhen & Vinay > > This patch looks good in itself, but I would like to see a tested by > tag. At the very least testing for regression in single-link LVDS b

[PATCH v3] drm/bridge/tc358775: Fixes bus formats read

2021-01-18 Thread Vinay Simha BN
-by: Vinay Simha BN --- v1: * Laurent Pinchart review comments incorporated drm_bridge_state.output_bus_cfg.format instead of connector v2: * Laurent Pinchart review comments incorporated atomic_check removed ivideo data input and output formats added v3: * Laurent Pinchart rev

Re: [PATCH RESEND v2] drm/bridge/tc358775: Fixes bus formats read

2021-01-05 Thread Vinay Simha B N
Laurent, Please review the patch, so that we can push the input_format to the mainline, which completes the overall features handled wrt bridge. On Thu, Dec 17, 2020 at 10:39 AM Vinay Simha B N wrote: > Laurent, > > Please review the patch, so that we can push the input_form

Re: [PATCH RESEND v2] drm/bridge/tc358775: Fixes bus formats read

2020-12-17 Thread Vinay Simha B N
Laurent, Please review the patch, so that we can push the input_format to the mainline, which completes the overall features handled wrt bridge. On Sun, Nov 8, 2020 at 3:47 PM Sam Ravnborg wrote: > Hi Laurent, > > On Thu, Oct 22, 2020 at 12:15:47PM +0530, Vinay Simha

[PATCH RESEND v2] drm/bridge/tc358775: Fixes bus formats read

2020-10-22 Thread Vinay Simha BN
- atomic_check removed - video data input and output formats added - bus formats read from drm_bridge_state.output_bus_cfg.format and .atomic_get_input_bus_fmts() instead of connector Signed-off-by: Vinay Simha BN --- v1: * Laurent Pinchart review comments incorporated

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-09-09 Thread Vinay Simha B N
laurent, Please review or give some feedback. On Tue, Aug 25, 2020 at 7:57 PM Vinay Simha B N wrote: > laurent, > > Please review or give some feedback. > > On Thu, Aug 13, 2020 at 9:09 PM Vinay Simha B N > wrote: > > > > laurent, > > > > The cod

[PATCH] drm/bridge/tc358775: Fix semicolon

2020-08-28 Thread Vinay Simha BN
Remove unneded semicolon Reported-by: kernel test robot Signed-off-by: Vinay Simha BN --- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index d951cdc..2272adc 100644

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-26 Thread Vinay Simha B N
laurent, Please review or give some feedback. On Thu, Aug 13, 2020 at 9:09 PM Vinay Simha B N wrote: > > laurent, > > The code sequence was a problem. *num_inputs_fmts = > ARRAY_SIZE(tc_lvds_in_bus_fmts); should come first and then allocate > the kcalloc. > &

Re: [PATCH] drm/bridge/tc358775: Fix for PTR_ERR

2020-08-23 Thread Vinay Simha B N
Thanks Sam. On Sun, Aug 23, 2020 at 8:35 PM Sam Ravnborg wrote: > > On Sun, Aug 16, 2020 at 11:20:41AM +0530, Vinay Simha BN wrote: > > passing zero to 'PTR_ERR' > > > > Reported-by: kernel test robot > > Signed-off-by: Vinay Simha BN > > Appl

[PATCH] drm/bridge/tc358775: Fix for PTR_ERR

2020-08-17 Thread Vinay Simha BN
passing zero to 'PTR_ERR' Reported-by: kernel test robot Signed-off-by: Vinay Simha BN --- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 7da15cd..d951

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-17 Thread Vinay Simha B N
IZE(tc_lvds_in_bus_fmts); ++i) input_fmts[i] = tc_lvds_in_bus_fmts[i]; *num_inputs_fmts = ARRAY_SIZE(tc_lvds_in_bus_fmts); So, internally in the drm pipeline get set the input format based on the output formats? On Wed, Aug 12, 2020 at 10:45 PM Vinay Simha B N wr

[PATCH v2] drm/bridge/tc358775: Fixes bus formats read

2020-08-17 Thread Vinay Simha BN
- atomic_check removed - video data input and output formats added - bus formats read from drm_bridge_state.output_bus_cfg.format and .atomic_get_input_bus_fmts() instead of connector Signed-off-by: Vinay Simha BN --- v1: * Laurent Pinchart review comments incorporated

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-13 Thread Vinay Simha B N
t chosen? Since dsi->format = MIPI_DSI_FMT_RGB888 is used does it chooses MEDIA_BUS_FMT_RBG888_1X24 by the drm pipeline On Wed, Aug 12, 2020 at 6:48 PM Laurent Pinchart wrote: > > Hi Vinay, > > On Wed, Aug 12, 2020 at 06:07:52PM +0530, Vinay Simha B N wrote: > > On Wed, Aug

[PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-13 Thread Vinay Simha BN
- bus formats read from drm_bridge_state.output_bus_cfg.format and .atomic_get_input_bus_fmts() instead of connector Signed-off-by: Vinay Simha BN --- v1: * Laurent Pinchart review comments incorporated drm_bridge_state.output_bus_cfg.format instead of connector --- drivers/gpu/drm

Re: [PATCH v8 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

2020-08-13 Thread Vinay Simha B N
sam/laurent, [PATCH] drm/bridge/tc358775: Fixes bus formats read is on top of drm-misc-next. On Wed, Aug 12, 2020 at 7:50 AM Vinay Simha B N wrote: > > Sam, > > I will look into this and send the patch ASAP. > > On Wed, Aug 12, 2020 at 12:47 AM Sam Ravnborg wro

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-13 Thread Vinay Simha B N
IZE(tc_lvds_in_bus_fmts); ++i) input_fmts[i] = tc_lvds_in_bus_fmts[i]; *num_input_fmts = ARRAY_SIZE(tc_lvds_in_bus_fmts); On Wed, Aug 12, 2020 at 8:25 PM Vinay Simha B N wrote: > > laurent, > > Video data input format : RGB666 loosely packed 24 bits per pix

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-13 Thread Vinay Simha B N
laurent, please see the reply inline below. On Wed, Aug 12, 2020 at 3:24 PM Laurent Pinchart wrote: > > Hi Vinay, > > Thank you for the patch. > > On Wed, Aug 12, 2020 at 12:55:50PM +0530, Vinay Simha BN wrote: > > - bus formats read from drm_bridge_state.output_

Re: [PATCH v8 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

2020-08-12 Thread Vinay Simha B N
Sam, I will look into this and send the patch ASAP. On Wed, Aug 12, 2020 at 12:47 AM Sam Ravnborg wrote: > Hi Vinay. > > > > > > > If Laurent or others identify further things to improve we can take > > > it in-tree. > > > > Just one thing, please see below. > > > > > > > >> + d2l_write(t

Re: [PATCH v8 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

2020-08-12 Thread Vinay Simha B N
Sam, Thanks. On Mon, Aug 10, 2020 at 11:08 PM Sam Ravnborg wrote: > Hi Vinay. > > On Wed, Jul 29, 2020 at 06:01:21PM +0530, Vinay Simha B N wrote: > > Hi All, > > > > Please Review the patch > > > > On Fri, Jul 10, 2020 at 7:11 PM Vinay Simha BN > w

Re: [PATCH v8 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

2020-08-10 Thread Vinay Simha B N
Hi All, Please Review the patch On Wed, Jul 29, 2020 at 6:01 PM Vinay Simha B N wrote: > Hi All, > > Please Review the patch > > On Fri, Jul 10, 2020 at 7:11 PM Vinay Simha BN wrote: > >> This driver is tested with two panels individually with Apq8016-IFC6

Re: [PATCH v8 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

2020-08-10 Thread Vinay Simha B N
Hi All, Please Review the patch On Wed, Jul 29, 2020 at 6:01 PM Vinay Simha B N wrote: > Hi All, > > Please Review the patch > > On Fri, Jul 10, 2020 at 7:11 PM Vinay Simha BN wrote: > >> - license modified to (GPL-2.0-only OR BSD-2-Clause) >> - single-link and

Re: [PATCH v8 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

2020-07-30 Thread Vinay Simha B N
Hi All, Please Review the patch On Fri, Jul 10, 2020 at 7:11 PM Vinay Simha BN wrote: > - license modified to (GPL-2.0-only OR BSD-2-Clause) > - single-link and dual-link lvds description and > examples are added > - proper indentation > - VESA/JEIDA formats picked from

Re: [PATCH v8 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

2020-07-30 Thread Vinay Simha B N
Hi All, Please Review the patch On Fri, Jul 10, 2020 at 7:11 PM Vinay Simha BN wrote: > This driver is tested with two panels individually with Apq8016-IFC6309 > board > > https://www.inforcecomputing.com/products/single-board-computers-sbc/qualcomm-snapdragon-410-inforce-6309-mic

[PATCH v8 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

2020-07-14 Thread Vinay Simha BN
implemented - converted from .txt to .yaml Signed-off-by: Vinay Simha BN Reviewed-by: Sam Ravnborg Reviewed-by: Rob Herring --- v1: Initial version wast .txt file v2: From txt to yaml file format v3: * Andrzej Hajda review comments incorporated dual port lvds implemented * Laurent Pinchart

[PATCH v8 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

2020-07-14 Thread Vinay Simha BN
replaced u32 instead of uint32_t - updated alphabetic order of headers - added SPDX identifier license Signed-off-by: Vinay Simha BN --- v1: Initial version v2: * Andrzej Hajda review comments incorporated SPDX identifier development debug removed alphabetic order headers u32 instead of unit

Re: [PATCH v7 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

2020-07-08 Thread Vinay Simha B N
7, 2020 at 12:15 PM Andrzej Hajda wrote: > > On 04.07.2020 11:24, Vinay Simha BN wrote: > > This driver is tested with two panels individually with Apq8016-IFC6309 > board > > > https://protect2.fireeye.com/url?k=fe87a8ec-a3e0ecca-fe8623a3-0cc47a31384a-ffbc547df1141490

Re: [PATCH v6 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

2020-07-06 Thread Vinay Simha B N
sam, I will change to "GPL-2.0-only OR BSD-2-Clause", i thought running dt_binding_check is enough for .yaml. On Fri, Jul 3, 2020 at 8:36 PM Sam Ravnborg wrote: > > Hi Vinay. > > On Thu, Jul 02, 2020 at 06:06:33PM +0530, Vinay Simha BN wrote: > > S

[PATCH v7 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

2020-07-06 Thread Vinay Simha BN
ay_timings naming local variables - check for bus_formats unsupported - error handling enpoint data-lanes - Kconfig proper indentation - GENMASK and FIELD_PREP used - bus_formats handeld in mode_valid - MODE_CLOCK_HIGH handled properly - len initialized - static function for mode_valid Signed-off-by:

[PATCH v7 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

2020-07-06 Thread Vinay Simha BN
modified to (GPL-2.0-only OR BSD-2-Clause) Signed-off-by: Vinay Simha BN --- v1: Initial version wast .txt file v2: From txt to yaml file format v3: * Andrzej Hajda review comments incorporated dual port lvds implemented * Laurent Pinchart review comments incorporated dsi lanes property

[PATCH v6 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

2020-07-03 Thread Vinay Simha BN
Signed-off-by: Vinay Simha BN --- v1: Initial version wast .txt file v2: From txt to yaml file format v3: * Andrzej Hajda review comments incorporated dual port lvds implemented * Laurent Pinchart review comments incorporated dsi lanes property removed and it is dynamically picked

[PATCH v6 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

2020-07-03 Thread Vinay Simha BN
ta-mapping = "vesa-24" Signed-off-by: Vinay Simha BN --- v1: Initial version v2: * Andrzej Hajda review comments incorporated SPDX identifier development debug removed alphabetic order headers u32 instead of unit32_t magic numbers to macros for CLRSI and mux registers

Re: [PATCH v5 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

2020-07-02 Thread Vinay Simha B N
PM Sam Ravnborg wrote: > > Hi Vinay. > > On Wed, Jul 01, 2020 at 12:33:36PM +0530, Vinay Simha BN wrote: > > This driver is tested with two panels with Apq8016-IFC6309 board > > https://www.inforcecomputing.com/products/single-board-computers-sbc/qualcomm-snapdragon-41

[PATCH v5 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

2020-07-01 Thread Vinay Simha BN
= "vesa-24" Signed-off-by: Vinay Simha BN --- v1: Initial version wast .txt file v2: From txt to yaml file format v3: * Andrzej Hajda review comments incorporated dual port lvds implemented * Laurent Pinchart review comments incorporated dsi lanes property removed and it is dynamical

[PATCH v4 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

2020-07-01 Thread Vinay Simha BN
= "vesa-24" Signed-off-by: Vinay Simha BN --- v1: Initial version wast .txt file v2: From txt to yaml file format v3: * Andrzej Hajda review comments incorporated dual port lvds implemented * Laurent Pinchart review comments incorporated dsi lanes property removed and it is dynamical

[PATCH v5 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

2020-07-01 Thread Vinay Simha BN
Signed-off-by: Vinay Simha BN --- v1: Initial version v2: * Andrzej Hajda review comments incorporated SPDX identifier development debug removed alphabetic order headers u32 instead of unit32_t magic numbers to macros for CLRSI and mux registers ignored return value * Laurent

[PATCH v4 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

2020-07-01 Thread Vinay Simha BN
Signed-off-by: Vinay Simha BN --- v1: Initial version v2: * Andrzej Hajda review comments incorporated SPDX identifier development debug removed alphabetic order headers u32 instead of unit32_t magic numbers to macros for CLRSI and mux registers ignored return value * Laurent

Re: [PATCH v4] display/drm/bridge: TC358775 DSI/LVDS driver

2020-06-30 Thread Vinay Simha B N
Neil, yaml is the v3 version, there was no change , so i had not created v4 for yaml [PATCH v3 2/2] display/drm/bridge: TC358775 DSI/LVDS driver On Mon, Jun 29, 2020 at 2:08 PM Neil Armstrong wrote: > > Hi, > > On 21/06/2020 17:38, Vinay Simha BN wrote: > > Signed-off-

[PATCH v4] display/drm/bridge: TC358775 DSI/LVDS driver

2020-06-22 Thread Vinay Simha BN
Signed-off-by: Vinay Simha BN --- v1: Initial version v2: * Andrzej Hajda review comments incorporated SPDX identifier development debug removed alphabetic order headers u32 instead of unit32_t magic numbers to macros for CLRSI and mux registers ignored return value * Laurent

[PATCH v3 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

2020-06-18 Thread Vinay Simha BN
Signed-off-by: Vinay Simha BN --- v1: Initial version wast .txt file v2: From txt to yaml file format v3: * Andrzej Hajda review comments incorporated dual port lvds implemented * Laurent Pinchart review comments incorporated dsi lanes property removed and it is dynamically picked

[PATCH v3 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

2020-06-18 Thread Vinay Simha BN
Signed-off-by: Vinay Simha BN --- v1: Initial version v2: * Andrzej Hajda review comments incorporated SPDX identifier development debug removed alphabetic order headers u32 instead of unit32_t magic numbers to macros for CLRSI and mux registers ignored return value * Laurent

Re: [PATCH 1/2] dt-binding: Add DSI/LVDS tc358775 bridge bindings

2020-06-09 Thread Vinay Simha B N
;, 'panel-lvds'] is too long Please suggest how to add the references of panel/lvds.yaml or panel/panel-common.yaml and panel/advantech,idk-2121wr.yaml in my yaml file. On Tue, Mar 17, 2020 at 7:57 PM Sam Ravnborg wrote: > > Hi Vinay. > > On Tue, Mar 17, 2020 at 12:25:42PM

Re: [PATCH 3/3] drm/mipi: use dcs write for mipi_dsi_dcs_set_tear_scanline

2020-06-07 Thread Vinay Simha B N
hi emil, On Wed, May 13, 2020 at 3:17 PM Emil Velikov wrote: > > Hi Vinay, > > On Thu, 7 May 2020 at 17:18, Emil Velikov wrote: > > > > On Thu, 7 May 2020 at 13:29, Vinay Simha B N wrote: > > > > > > Emil, > > > > > > Reply in

Re: [PATCH 3/3] drm/mipi: use dcs write for mipi_dsi_dcs_set_tear_scanline

2020-05-08 Thread Vinay Simha B N
uish between the two writers? > > Cc: Robert Chiras > Cc: Vinay Simha BN > Cc: Jani Nikula > Cc: Thierry Reding > Fixes: e83950816367 ("drm/dsi: Implement set tear scanline") > Signed-off-by: Emil Velikov > --- > Robert, can you please test this against the o

Re: [PATCH 1/2] dt-binding: Add DSI/LVDS tc358775 bridge bindings

2020-03-17 Thread Vinay Simha B N
nvironment Documentation/devicetree/bindings/display/bridge/toshiba-tc358775.yaml is there any tool available similar to scripts/checkpatch.pl -f , for yaml files? On Sun, Mar 15, 2020 at 8:54 PM Vinay Simha B N wrote: > > rob, > > i do not get the error when running 'make dt_b

Re: [PATCH v1 12/36] dt-bindings: display: convert jdi,lt070me05000 to DT Schema

2020-03-17 Thread Vinay Simha B N
sam, Reviewed-by: Vinay Simha BN Thanks. On Sun, Mar 15, 2020 at 7:14 PM Sam Ravnborg wrote: > > Signed-off-by: Sam Ravnborg > Cc: Vinay Simha BN > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > .../display/panel/jdi,lt070me05000.txt| 31 - >

Re: [PATCH] display/bridge: dsi2lvds tc358775 driver

2020-03-15 Thread Vinay Simha B N
0>; }; }; }; }; On Thu, Mar 12, 2020 at 8:01 PM Laurent Pinchart wrote: > > Hi Vinay, > > On Wed, Mar 11, 2020 at 03:30:48PM +0530, Vinay Simha B N wrote: > > Laurent Pinchart, > > > > if we want to set to jeida-18 data mapping, > > do we

Re: [PATCH 1/2] dt-binding: Add DSI/LVDS tc358775 bridge bindings

2020-03-15 Thread Vinay Simha B N
ing wrote: > > On Wed, 11 Mar 2020 15:18:24 +0530, Vinay Simha BN wrote: > > Add yaml documentation for DSI/LVDS tc358775 bridge > > > > Signed-off-by: Vinay Simha BN > > > > --- > > v1: > > Initial version > > -

Re: [PATCH] display/bridge: dsi2lvds tc358775 driver

2020-03-12 Thread Vinay Simha B N
Laurent Pinchart, if we want to set to jeida-18 data mapping, do we need to set DATA3 with "Logic 0" LVI_L0 ? Please see reply inline. On Fri, Mar 6, 2020 at 7:02 PM Laurent Pinchart wrote: > > Hi Vinay, > > Thank you for the patch. > > On Fri, Mar 06, 2020 at 06:06

[PATCH 2/2] display/drm/bridge: tc358775 DSI/LVDS driver

2020-03-12 Thread Vinay Simha BN
dsi2lvds tc358775 bridge driver added Tested in apq8016, ifc6309 board and panel auo,b101xtn01 Signed-off-by: Vinay Simha BN --- v1: Initial version v2: * Andrzej Hajda review comments incorporated SPDX identifier development debug removed alphabetic order headers u32 instead of

[PATCH 1/2] dt-binding: Add DSI/LVDS tc358775 bridge bindings

2020-03-12 Thread Vinay Simha BN
Add yaml documentation for DSI/LVDS tc358775 bridge Signed-off-by: Vinay Simha BN --- v1: Initial version --- .../bindings/display/bridge/toshiba-tc358775.yaml | 174 + 1 file changed, 174 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge

Re: [PATCH] display/bridge: dsi2lvds tc358775 driver

2020-03-07 Thread Vinay Simha B N
hi andrzej, I had a doubt In the tc358764 driver,VP_CTRL, VP_CTRL_VSDELAY(15) is hardcoded to 15, but this has to be dynamic based on the resolution of panel used? Please see the reply inline. On Tue, Mar 3, 2020 at 8:39 PM Andrzej Hajda wrote: > > On 27.02.2020 15:03, Vinay Simha BN

[PATCH] display/bridge: dsi2lvds tc358775 driver

2020-02-28 Thread Vinay Simha BN
dsi2lvds tc358775 bridge driver added Tested in apq8016, ifc6309 board and panel auo,b101xtn01 Signed-off-by: Vinay Simha BN --- .../bindings/display/bridge/toshiba,tc358775.txt | 106 drivers/gpu/drm/bridge/Kconfig | 10 + drivers/gpu/drm/bridge/Makefile

Re: drm bridge control from another driver

2019-02-21 Thread Vinay Simha B N
mit/8ee2b9104fa56765320d4846086d91b8271f5609 please suggest. On Mon, Feb 18, 2019 at 8:49 PM Vinay Simha B N wrote: > added the temperature alert irq handler in adv driver , in the irq > calling schedule_work(&adv7511->hpd_work); , initially in the > adv7511_detect , if we set status = connector_status_disconn

Re: drm dsi2hdmi bridge - temperature sensor

2019-02-20 Thread Vinay Simha B N
rob, hpd works in kernel 5.0.0-rc6, i.e postboot if we connect hdmi display comes(apq8016). added the temperature alert_handler in adv7511_drv.c in adv7511_detect , i had set status = connector_status_disconnected; , since display should not come initially, but when irq calls schedule_work(&adv75

Re: drm bridge control from another driver

2019-02-19 Thread Vinay Simha B N
4, 2019 at 8:03 PM Andrzej Hajda wrote: > On 13.02.2019 15:31, Vinay Simha B N wrote: > > > > > > On Wed, Feb 13, 2019 at 7:44 PM Andrzej Hajda > <mailto:a.ha...@samsung.com>> wrote: > > > > On 13.02.2019 14:40, Vinay Simha B N wrote: > >

Re: drm dsi2hdmi bridge - temperature sensor

2019-02-15 Thread Vinay Simha B N via dri-devel
adv chip goes down and may not be operated later. > > Rob > > > > > > > BR, > > -R > > > > On Thu, Feb 14, 2019 at 7:32 AM Vinay Simha B N > wrote: > > > > > > rob, > > > > > > i am not getting much inputs in the

Re: drm bridge control from another driver

2019-02-14 Thread Vinay Simha B N via dri-devel
On Wed, Feb 13, 2019 at 7:44 PM Andrzej Hajda wrote: > On 13.02.2019 14:40, Vinay Simha B N wrote: > > Andrzej/Daniel, > > > > please suggest any input on the scenario for temperature control and > > dsi bridge enable/disable. > > > > On Mon,

Re: drm bridge control from another driver

2019-02-14 Thread Vinay Simha B N via dri-devel
Andrzej/Daniel, please suggest any input on the scenario for temperature control and dsi bridge enable/disable. On Mon, Feb 11, 2019 at 2:41 PM Vinay Simha B N wrote: > dsi2hdmi(adv7511) chip operating temperature range is -10 degC to +85 > degC. We want to enable/disable the bridge onl

Re: drm bridge control from another driver

2019-02-12 Thread Vinay Simha B N
/disable the bridge. Any suggestion what is the better way to handle this scenario? regards, vinaysimha On Mon, Feb 11, 2019 at 2:10 PM Daniel Vetter wrote: > On Mon, Feb 11, 2019 at 09:32:54AM +0100, Andrzej Hajda wrote: > > On 11.02.2019 07:52, Vinay Simha B N wrote: > > >

drm bridge control from another driver

2019-02-11 Thread Vinay Simha B N
hi, is it possible to control the drm bridge from another driver in irq handler(enable/disable the bridge)? is there a way to control the "dpms force off" and "dpms force on" in the interrupt handler? -- regards, vinaysimha ___ dri-devel mailing list

Re: [PATCH] drm/msm/hdmi: redefinitions of macros not required

2017-03-22 Thread Vinay Simha B N
hi, Could you please give some feedback or review comments for this patch On 3/14/17, Vinay Simha BN wrote: > 4 macros already defined in hdmi.h, > which is not required to redefine in hdmi_audio.c > > Signed-off-by: Vinay Simha BN > --- > drivers/gpu/drm/msm/hdm

[PATCH] drm/msm/hdmi: redefinitions of macros not required

2017-03-14 Thread Vinay Simha BN
4 macros already defined in hdmi.h, which is not required to redefine in hdmi_audio.c Signed-off-by: Vinay Simha BN --- drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c

[PATCH v10 3/3] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-09-15 Thread Vinay Simha
Hi Thierry, Could you please review the patch and integrate? On Fri, Aug 26, 2016 at 8:07 AM, Vinay Simha BN wrote: > Add support for the JDI LT070ME05000 WUXGA DSI panel used in > Nexus 7 2013 devices. > > Programming sequence for the panel is was originally found in the > andr

[PATCH v4] dt-bindings: Add jdi lt070me05000 panel bindings

2016-09-15 Thread Vinay Simha
Hi Tierry, Could you please review the patch and integrate? On Thu, Sep 8, 2016 at 10:44 AM, Vinay Simha BN wrote: > Add documentation for lt070me05000 panel > > Cc: Archit Taneja > Cc: John Stultz > Cc: Thierry Reding > Cc: Sumit Semwal > Signed-off-by: Vinay Simh

[PATCH v4] dt-bindings: Add jdi lt070me05000 panel bindings

2016-09-08 Thread Vinay Simha BN
Add documentation for lt070me05000 panel Cc: Archit Taneja Cc: John Stultz Cc: Thierry Reding Cc: Sumit Semwal Signed-off-by: Vinay Simha BN Acked-by: Rob Herring --- v2: * incorporated rob herring and thierry reviews gpio to gpios, gpio to regulator using fixed regulators and pwm

[PATCH 6/4] arm: dts: qcom: apq8064-nexus7: Add DSI and panel nodes

2016-09-08 Thread vinay simha
Regards, vinay simha On Thu, Sep 8, 2016 at 5:02 AM, John Stultz wrote: > Tagging on to Archit's patchset here. > > Add DSI and panel nodes to get graphics up and running > on the Nexus7. > > This still depends on the panel driver being present > (currently under rev

[RFC][PATCH 5/4] arm: dts: qcom: apq8064: Add dsi, gpu and iommu nodes

2016-09-08 Thread vinay simha
Regards, vinay simha On Thu, Sep 8, 2016 at 5:02 AM, John Stultz wrote: > > Sort of tagging on to Archit's patchset here. > > Adds the core gpu, and dsi nodes for the apq8064 needed > to get graphics working on the nexus7 and other devices. > > Feedback would be g

[PATCH v10 3/3] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-09-07 Thread Vinay Simha
thierry, please review. On Fri, Aug 26, 2016 at 8:07 AM, Vinay Simha BN wrote: > Add support for the JDI LT070ME05000 WUXGA DSI panel used in > Nexus 7 2013 devices. > > Programming sequence for the panel is was originally found in the > android-msm-flo-3.4-lollipop-rele

[PATCH v3 2/3] dt-bindings: Add jdi lt070me05000 panel bindings

2016-09-07 Thread Vinay Simha
thierry, please review. On Fri, Aug 26, 2016 at 8:07 AM, Vinay Simha BN wrote: > Add documentation for lt070me05000 panel > > Cc: Archit Taneja > Cc: John Stultz > Cc: Thierry Reding > Cc: Sumit Semwal > Signed-off-by: Vinay Simha BN > Acked-by: Rob Herring > &g

[PATCH v10 3/3] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-08-26 Thread Vinay Simha BN
rm/panel/panel-jdi-lt070me05000.c @@ -0,0 +1,532 @@ +/* + * Copyright (C) 2016 InforceComputing + * Author: Vinay Simha BN + * + * Copyright (C) 2016 Linaro Ltd + * Author: Sumit Semwal + * + * From internet archives, the panel for Nexus 7 2nd Gen, 2013 model is a + * JDI model LT070ME05000, a

[PATCH v3 2/3] dt-bindings: Add jdi lt070me05000 panel bindings

2016-08-26 Thread Vinay Simha BN
Add documentation for lt070me05000 panel Cc: Archit Taneja Cc: John Stultz Cc: Thierry Reding Cc: Sumit Semwal Signed-off-by: Vinay Simha BN Acked-by: Rob Herring --- v2: * incorporated rob herring and thierry reviews gpio to gpios, gpio to regulator using fixed regulators and pwm

[RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings

2016-08-24 Thread Vinay Simha
5PM +0530, Vinay Simha wrote: >> thierry, >> >> this is the reference pinouts of the panel >> http://www.tonylabs.com/wp-content/uploads/LT070ME05000-pinouts.jpg > > I can't open that file. > >> as you suggest , i will change the vcc-supply, >> >&

[RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings

2016-08-24 Thread Vinay Simha
rry Reding wrote: > On Sun, Jul 31, 2016 at 08:45:21PM +0530, Vinay Simha BN wrote: > [...] >> diff --git >> a/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt >> b/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt > [...] >> +-

[RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings

2016-08-24 Thread Vinay Simha
two(vddp-supply, dcdc_en-supply) remaining same. On Wed, Aug 24, 2016 at 5:15 PM, Thierry Reding wrote: > On Sun, Jul 31, 2016 at 08:45:21PM +0530, Vinay Simha BN wrote: >> Add documentation for lt070me05000 panel >> >> Cc: Archit Taneja >> Cc: John Stultz >>

[RESEND] [PATCH v9 4/4] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-31 Thread Vinay Simha BN
anel/panel-jdi-lt070me05000.c new file mode 100644 index 000..517fa89 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c @@ -0,0 +1,518 @@ +/* + * Copyright (C) 2016 InforceComputing + * Author: Vinay Simha BN + * + * Copyright (C) 2016 Linaro Ltd + * Author: Sumit Semwal +

[RESEND] [PATCH v3 3/4] drm/dsi: Implement dcs set/get display brightness

2016-07-31 Thread Vinay Simha BN
Provide a small convenience wrapper that set/get the display brightness value Cc: John Stultz Cc: Sumit Semwal Cc: Archit Taneja Cc: Rob Clark Cc: Jani Nikula Cc: Thierry Reding Cc: Emil Velikov Signed-off-by: Vinay Simha BN Reviewed-by: Emil Velikov --- v1: *tested in nexus7 2nd gen

[RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings

2016-07-31 Thread Vinay Simha BN
Add documentation for lt070me05000 panel Cc: Archit Taneja Cc: John Stultz Cc: Thierry Reding Cc: Sumit Semwal Signed-off-by: Vinay Simha BN Acked-by: Rob Herring --- v2: * incorporated rob herring and thierry reviews gpio to gpios, gpio to regulator using fixed regulators and pwm

[PATCH v3 1/2] drm/dsi: Implement dcs set/get display brightness

2016-07-19 Thread Vinay Simha
, Jul 19, 2016 at 3:00 PM, Sean Paul wrote: > On Mon, Jul 18, 2016 at 4:28 AM, Vinay Simha BN wrote: >> Provide a small convenience wrapper that set/get the >> display brightness value >> >> Cc: John Stultz >> Cc: Sumit Semwal >> Cc: Archit Taneja >

[PATCH v8 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-18 Thread Vinay Simha BN
..3af35ad --- /dev/null +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c @@ -0,0 +1,518 @@ +/* + * Copyright (C) 2016 InforceComputing + * Author: Vinay Simha BN + * + * Copyright (C) 2016 Linaro Ltd + * Author: Sumit Semwal + * + * From internet archives, the panel for Nexus 7 2nd G

[PATCH v3 1/2] drm/dsi: Implement dcs set/get display brightness

2016-07-18 Thread Vinay Simha BN
Provide a small convenience wrapper that set/get the display brightness value Cc: John Stultz Cc: Sumit Semwal Cc: Archit Taneja Cc: Rob Clark Cc: Jani Nikula Cc: Thierry Reding Cc: Emil Velikov Signed-off-by: Vinay Simha BN --- v1: *tested in nexus7 2nd gen. v2: * implemented jani

[PATCH v8 4/4] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-18 Thread Vinay Simha
On Fri, Jul 15, 2016 at 2:48 AM, Emil Velikov wrote: > On 13 July 2016 at 19:58, John Stultz wrote: > > On Wed, Jul 13, 2016 at 9:44 AM, Vinay Simha BN > wrote: > >> Add support for the JDI LT070ME05000 WUXGA DSI panel used in > >> Nexus 7 2013 devices. > >

[PATCH v2 3/4] drm/dsi: Implement dcs set/get display brightness

2016-07-18 Thread Vinay Simha
yes, it is wrong. it supposed to be if(err <= 0) { if(err == 0) will resend a modified version On Fri, Jul 15, 2016 at 2:50 AM, Emil Velikov wrote: > On 13 July 2016 at 17:44, Vinay Simha BN wrote: > > > +int mipi_dsi_dcs_get_display_brightness(struct mipi_

[PATCH v8 4/4] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-13 Thread Vinay Simha BN
/panel-jdi-lt070me05000.c @@ -0,0 +1,518 @@ +/* + * Copyright (C) 2016 InforceComputing + * Author: Vinay Simha BN + * + * Copyright (C) 2016 Linaro Ltd + * Author: Sumit Semwal + * + * From internet archives, the panel for Nexus 7 2nd Gen, 2013 model is a + * JDI model LT070ME05000, a

[PATCH v2 3/4] drm/dsi: Implement dcs set/get display brightness

2016-07-13 Thread Vinay Simha BN
Provide a small convenience wrapper that set/get the display brightness value Cc: John Stultz Cc: Sumit Semwal Cc: Archit Taneja Cc: Rob Clark Cc: Jani Nikula Cc: Thierry Reding Signed-off-by: Vinay Simha BN --- v1: *tested in nexus7 2nd gen. v2: * implemented jani review comments

[PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings

2016-07-13 Thread Vinay Simha BN
Add documentation for lt070me05000 panel Cc: Archit Taneja Cc: John Stultz Cc: Thierry Reding Cc: Sumit Semwal Signed-off-by: Vinay Simha BN Acked-by: Rob Herring --- v2: * incorporated rob herring and thierry reviews gpio to gpios, gpio to regulator using fixed regulators and pwm

[PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-11 Thread Vinay Simha
PM, Thierry Reding wrote: > On Sun, Jul 03, 2016 at 11:52:11PM +0100, Emil Velikov wrote: >> On 28 June 2016 at 16:59, Vinay Simha wrote: >> > hi, >> > >> > Any further comments or reviews? >> > >> You still haven't covered my earlier sugg

[PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-04 Thread Vinay Simha
On Mon, Jul 4, 2016 at 4:22 AM, Emil Velikov wrote: > On 28 June 2016 at 16:59, Vinay Simha wrote: >> hi, >> >> Any further comments or reviews? >> > You still haven't covered my earlier suggestions, as such I cannot > give you a r-b :-( They are not block

[PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-06-28 Thread Vinay Simha
hi, Any further comments or reviews? On Mon, Jun 20, 2016 at 11:23 AM, Vinay Simha BN wrote: > Add support for the JDI LT070ME05000 WUXGA DSI panel used in > Nexus 7 2013 devices. > > Programming sequence for the panel is was originally found in the > android-msm-flo-3.4-lollipop

[PATCH v2 1/2] drm/dsi: Implement dcs set/get display brightness

2016-06-28 Thread Vinay Simha
hi, Any further comments or reviews? On Mon, Jun 20, 2016 at 11:23 AM, Vinay Simha BN wrote: > Provide a small convenience wrapper that set/get the > display brightness value > > Cc: John Stultz > Cc: Sumit Semwal > Cc: Archit Taneja > Cc: Rob Clark > Cc: Jani Niku

[PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-06-20 Thread Vinay Simha BN
v/null +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c @@ -0,0 +1,495 @@ +/* + * Copyright (C) 2016 InforceComputing + * Author: Vinay Simha BN + * + * Copyright (C) 2016 Linaro Ltd + * Author: Sumit Semwal + * + * From internet archives, the panel for Nexus 7 2nd Gen, 2013 model is a + * JDI

[PATCH v2 1/2] drm/dsi: Implement dcs set/get display brightness

2016-06-20 Thread Vinay Simha BN
Provide a small convenience wrapper that set/get the display brightness value Cc: John Stultz Cc: Sumit Semwal Cc: Archit Taneja Cc: Rob Clark Cc: Jani Nikula Cc: Thierry Reding Signed-off-by: Vinay Simha BN --- v1: *tested in nexus7 2nd gen. v2: * implemented jani review comments

[PATCH v6 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-06-18 Thread Vinay Simha
On Sat, Jun 18, 2016 at 5:58 AM, Emil Velikov wrote: > Hi Vinay, > > On 17 June 2016 at 19:23, Vinay Simha BN wrote: > >> v6: >> * emil review comments incorporated >>PANEL_NUM_REGULATORS dropped, return ret added at necessary >>places, if ch

[PATCH v6 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-06-17 Thread Vinay Simha BN
panel-jdi-lt070me05000.c new file mode 100644 index 000..3213025 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c @@ -0,0 +1,494 @@ +/* + * Copyright (C) 2016 InforceComputing + * Author: Vinay Simha BN + * + * Copyright (C) 2016 Linaro Ltd + * Author: Sumit Semwal + * + *

[PATCH v2 1/2] drm/dsi: Implement dcs set/get display brightness

2016-06-17 Thread Vinay Simha BN
Provide a small convenience wrapper that set/get the display brightness value Cc: John Stultz Cc: Sumit Semwal Cc: Archit Taneja Cc: Rob Clark Cc: Jani Nikula Cc: Thierry Reding Signed-off-by: Vinay Simha BN --- v1: *tested in nexus7 2nd gen. v2: * implemented jani review comments

[PATCH v5 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-06-16 Thread Vinay Simha BN
Stultz [vinay simha bn: removed interface setting cmd mode, video mode panel setting selection] Cc: Rob Clark Signed-off-by: Vinay Simha BN --- v2: * incorporated code reviews from theiry, archit code style, alphabetical soring in Makefile, Kconfig, regulator_bulk, arrays of u8, generic

  1   2   >