On 2/26/2016 12:11 AM, Joseph Salisbury wrote:
> On 02/24/2016 10:53 PM, Jindal, Sonika wrote:
>> Hi Joe,
>>
>> Yes, first thing to try is to increase the tries.
> We testing with 300 retries, but the second monitor still did not show
> up. However, it did show
Hi Joe,
Yes, first thing to try is to increase the tries.
Can you please point me to the bug and provide more details like platform,
monitor, cable.
Are you referring to the same issue as Oleksandr reported where a single link
dvi/hdmi cable didnât work and dual link worked?
Regards,
Sonika
On 2/23/2016 8:38 PM, Ville Syrjälä wrote:
> On Mon, Feb 22, 2016 at 02:32:32PM +0200, Oleksandr Natalenko wrote:
>> Ville, Daniel,
>>
>> any additional info I could provide? I have to return dual-link DVI
>> cable back, so let me know if I could reveal more details if necessary.
> Unfortunatel
On 1/21/2016 8:59 AM, Nick Bowler wrote:
> On 1/20/16, Nick Bowler wrote:
>> Hi,
>>
>> On 2016-01-20, Jindal, Sonika wrote:
>>> Can you please check if you have following patch:
>>> "commit 3d8acd1f667b45c531401c8f0c2033072e32a05d
>>> Au
lug definitions"
Regards,
Sonika
On 1/20/2016 3:56 AM, Nick Bowler wrote:
> Hi,
>
> Upgrading from 4.3 to 4.4 breaks my HDMI output on my G45 machine.
>
> As soon as the intel driver is loaded, the monitor shuts off
> (standby mode). Inspecting /sys/class/drm/card0-HDMI-A-1/
perty function, which replaces the
> old blob for the property with the new one
> 4. Adds a pointer to hold blob for Gamma property in drm_crtc
>
> v2: Addressed all review comments from Sonika and Daniel Stone.
Instead you can mention the changes briefly.
>
> Signed-off-by: S
On 6/4/2015 7:12 PM, Kausal Malladi wrote:
> From: Kausal Malladi
>
> This patch adds a new structure in DRM layer for Gamma color correction.
> This structure will be used by all user space agents to configure
> appropriate Gamma precision and Gamma level.
>
> struct drm_intel_gamma {
>
g the patches using --in-reply-to tag.
Regards,
Sonika
-Original Message-
From: Malladi, Kausal
Sent: Thursday, June 4, 2015 7:13 PM
To: Roper, Matthew D; Barnes, Jesse; Lespiau, Damien; Jindal, Sonika; R,
Durgadoss; Purushothaman, Vijay A; intel-gfx at lists.freedesktop.org;
dri-dev
obj_holds_id, prop_holds_id);
> +
> + return ret;
> +}
> +
Split the patch to add drm specific changes in a separate patch. Also
you need to export this function.
Will review the rest of the file in some time.
Regards,
Sonika
> /**
>* drm_mode_connec
On 6/2/2015 1:22 AM, Kausal Malladi wrote:
> From: Kausal Malladi
>
> This patch adds a new structure in DRM layer for Gamma color correction.
> This structure will be used by all user space agents to configure
> appropriate Gamma precision and Gamma level.
>
> struct drm_intel_gamma {
>
On 6/2/2015 1:22 AM, Kausal Malladi wrote:
> From: Kausal Malladi
>
> This patch adds set property interface for Intel CRTC. This interface
> will be used to set color correction DRM properties.
>
> Signed-off-by: Shashank Sharma
> Signed-off-by: Kausal Malladi
> ---
> drivers/gpu/drm/i915/i
On 6/2/2015 1:22 AM, Kausal Malladi wrote:
> From: Kausal Malladi
>
> Color Manager is an extension in i915 driver to handle color correction
> and enhancements across various Intel platforms.
>
> This patch initializes color manager framework by :
> 1. Adding two new files, intel_color_manager(
Moving rotation property to "Drm" and removing from i915 and omap.
Also, adding description to the property
Cc: DRI Development
Suggested-by: Ville Syrjälä
Signed-off-by: Sonika Jindal
---
Documentation/DocBook/drm.tmpl | 41 ++--
1 file c
On 5/13/2015 9:57 AM, Jindal, Sonika wrote:
>
>
> On 5/12/2015 6:20 PM, Ville Syrjälä wrote:
>> On Wed, Apr 15, 2015 at 04:05:19PM +0530, Sonika Jindal wrote:
>>> Cc: dri-devel at lists.freedesktop.org
>>> Signed-off-by: Sonika Jindal
>>> ---
&
On 5/13/2015 9:57 AM, Jindal, Sonika wrote:
>
>
> On 5/12/2015 6:20 PM, Ville Syrjälä wrote:
>> On Wed, Apr 15, 2015 at 04:05:19PM +0530, Sonika Jindal wrote:
>>> Cc: dri-devel at lists.freedesktop.org
>>> Signed-off-by: Sonika Jindal
>>> ---
&
On 5/12/2015 6:20 PM, Ville Syrjälä wrote:
> On Wed, Apr 15, 2015 at 04:05:19PM +0530, Sonika Jindal wrote:
>> Cc: dri-devel at lists.freedesktop.org
>> Signed-off-by: Sonika Jindal
>> ---
>> Documentation/DocBook/drm.tmpl |7 +--
>> 1 file chan
Cc: dri-devel at lists.freedesktop.org
Signed-off-by: Sonika Jindal
---
Documentation/DocBook/drm.tmpl |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
index f4976cd..266d50a 100644
--- a/Documentation
Reviewed-by: Sonika Jindal
On 2/27/2015 4:41 PM, Jani Nikula wrote:
> Add a number of DPCD definitions from eDP 1.4.
>
> v2: s/DP_ALPM_LOCK_TIMEOUT_ERROR_STATUS/DP_ALPM_LOCK_TIMEOUT_ERROR/
> (Sonika)
>
> Signed-off-by: Jani Nikula
> ---
> include/
On Wednesday 25 February 2015 06:16 PM, Jani Nikula wrote:
> Signed-off-by: Jani Nikula
> ---
> include/drm/drm_dp_helper.h | 37 +
> 1 file changed, 37 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index cc96024e
cro above?
You can take a call.
> #define DP_MSTM_CTRL0x111 /* 1.2 */
> # define DP_MST_EN (1 << 0)
> # define DP_UP_REQ_EN (1 << 1)
> # define DP_UPSTREAM_IS_SRC (1 << 2)
>
> +#define DP_AUDIO_DELAY0 0x112 /* 1.2 */
> +#define DP_AUDIO_DELAY1 0x113
> +#define DP_AUDIO_DELAY2 0x114
> +
> #define DP_LINK_RATE_SET0x115 /* eDP 1.4 */
>
> +#define DP_UPSTREAM_DEVICE_DP_PWR_NEED 0x118 /* 1.2 */
> +# define DP_PWR_NOT_NEEDED (1 << 0)
> +
> #define DP_PSR_EN_CFG 0x170 /* XXX 1.2? */
> # define DP_PSR_ENABLE (1 << 0)
> # define DP_PSR_MAIN_LINK_ACTIVE(1 << 1)
Some cosmetic comments.
Reviewed-by: Sonika Jindal
On Wednesday 25 February 2015 06:16 PM, Jani Nikula wrote:
> Keep the DPCD macros ordered by address, and make indentation conform to
> the rest of the file.
>
> commit e045d20bef41707dbba676e58624b54f9f39e172
> Author: Sonika Jindal
> Date: Thu Feb 19 13:16:44 2015 +0530
&g
+
> #define DP_SIDEBAND_MSG_DOWN_REQ_BASE 0x1000 /* 1.2 MST */
> #define DP_SIDEBAND_MSG_UP_REP_BASE 0x1200 /* 1.2 MST */
> #define DP_SIDEBAND_MSG_DOWN_REP_BASE 0x1400 /* 1.2 MST */
Checked against edp1.3 spec.
Reviewed-by: Sonika Jindal
Adding dpcd macros related to edp1.4 and link rates
v2: Added DP_SUPPORTED_LINK_RATES macros
Cc: dri-devel at lists.freedesktop.org
Signed-off-by: Sonika Jindal
Reviewed-by: Todd Previte
---
include/drm/drm_dp_helper.h |8
1 file changed, 8 insertions(+)
diff --git a/include/drm
Adding dpcd macros related to edp1.4 and link rates
v2: Added DP_SUPPORTED_LINK_RATES macros
Signed-off-by: Sonika Jindal
---
include/drm/drm_dp_helper.h |8
1 file changed, 8 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 11f8c84
ginal Message-
From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com]
Sent: Wednesday, January 14, 2015 11:38 PM
To: Jindal, Sonika
Cc: intel-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/2] drm: Adding rotation to
drm_plane_helper_check_u
nal Message-
From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com]
Sent: Wednesday, January 14, 2015 5:14 PM
To: Jindal, Sonika
Cc: intel-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/2] drm: Adding rotation to
drm_plane_helper_check
Taking rotation into account while checking the plane
and adjusting the sizes accordingly.
v2: Adding parameter in the callers in the same patch(Matt)
Removing unnecessary code and allowing scaling(Ville)
Signed-off-by: Sonika Jindal
---
drivers/gpu/drm/drm_plane_helper.c | 44
On Tuesday 13 January 2015 07:02 PM, Ville Syrjälä wrote:
> On Tue, Jan 13, 2015 at 06:03:39PM +0530, Sonika Jindal wrote:
>> Taking rotation into account while checking the plane
>> and adjusting the sizes accordingly.
>>
>> Signed-off-by: Sonika Jindal
On Tuesday 13 January 2015 11:42 PM, Matt Roper wrote:
> On Tue, Jan 13, 2015 at 06:03:38PM +0530, Sonika Jindal wrote:
>> This adds another parameter rotation to drm_plane_helper_check_update.
>> This will enable this function to do to size updations based upon the
>&g
update the
destination size appropriately.
Please correct me if I am wrong.
-Original Message-
From: Jindal, Sonika
Sent: Wednesday, January 14, 2015 3:06 PM
To: 'Ville Syrjälä'
Cc: intel-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org
Subject: RE: [Intel-gfx]
test.
-Original Message-
From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com]
Sent: Wednesday, January 14, 2015 2:58 PM
To: Jindal, Sonika
Cc: intel-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/2] drm: Adding rotation to
drm_plane
Signed-off-by: Sonika Jindal
---
drivers/gpu/drm/i915/intel_display.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index f40288f..d19ed4b 100644
--- a/drivers/gpu/drm/i915/intel_display.c
Taking rotation into account while checking the plane
and adjusting the sizes accordingly.
Signed-off-by: Sonika Jindal
---
drivers/gpu/drm/drm_plane_helper.c | 79 ++--
include/drm/drm_plane_helper.h |3 +-
2 files changed, 77 insertions(+), 5
This adds another parameter rotation to drm_plane_helper_check_update.
This will enable this function to do to size updations based upon the rotation
if any.
Updated the calls to this function in i915 and drm. Rockchip driver also needs
to be updated.
Sonika Jindal (2):
drm: Adding rotation to
to add code to invalidate that cache. Simpler if drivers just
> take care of that themselves.
> -Daniel
For the edp revision, I am feeling that having a function which simply
reads DP_EDP_REV,
and returns it doesn't add much value.
So, I am thinking to put that part in driver itself. Please let me know
if you feel otherwise.
-Sonika
Thanks for your comments Thierry.
I agree to all your comments.
I will write a general function to return version and repost the patch
Thanks,
Sonika
On Wednesday 29 October 2014 07:12 PM, Thierry Reding wrote:
> On Wed, Oct 22, 2014 at 11:45:23AM +0530, sonika.jindal at intel.com wrote:
>
On 8/28/2014 11:36 AM, Jingoo Han wrote:
> On Thursday, August 28, 2014 1:33 PM, Sonika Sonika wrote:
>> On 8/28/2014 6:25 AM, Jingoo Han wrote:
>>> On Friday, August 08, 2014 7:54 PM, Sonika Jindal wrote:
>>>>
>>>> From: Sonika Jindal
>>>
On 8/28/2014 6:25 AM, Jingoo Han wrote:
> On Friday, August 08, 2014 7:54 PM, Sonika Jindal wrote:
>>
>> From: Sonika Jindal
>>
>> Rename the defines to have levels instead of values for vswing and
>> pre-emph levels as the values may differ in other scenarios
On 8/26/2014 4:58 PM, Thierry Reding wrote:
> On Fri, Aug 08, 2014 at 04:23:40PM +0530, sonika.jindal at intel.com wrote:
>> From: Sonika Jindal
>>
>> Adding new defines, older one will be removed in the last patch in the
>> series.
>> This is to rename the
Hi,
Did anybody get a chance to review the patches?
Adding respective owners for different drivers..
Thanks,
Sonika
-Original Message-
From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of
Jindal, Sonika
Sent: Tuesday, August 19, 2014 1:42 PM
To: intel-gfx at
Hi,
Did anybody get a chance to review other patches in this series?
I got r-b for 2 patches (patches with changes in drm and i915) from Damien.
Thanks,
Sonika
-Original Message-
From: Jindal, Sonika
Sent: Friday, August 8, 2014 4:24 PM
To: intel-gfx at lists.freedesktop.org
Cc: dri
On 8/5/2014 6:00 PM, Daniel Vetter wrote:
> On Tue, Aug 5, 2014 at 1:33 PM, Jindal, Sonika
> wrote:
>>
>>
>> On 8/5/2014 4:45 PM, Daniel Vetter wrote:
>>>
>>> On Tue, Aug 05, 2014 at 04:38:17PM +0530, sonika.jindal at intel.com wrote:
>>>>
On 8/5/2014 4:45 PM, Daniel Vetter wrote:
> On Tue, Aug 05, 2014 at 04:38:17PM +0530, sonika.jindal at intel.com wrote:
>> From: Sonika Jindal
>>
>> Renaming defines to have levels instead of nominal values.
>>
>> Signed-off-by: Sonika Jindal
>
> You can&
re.
> - Adjust the fb helper code accordingly.
> - Rip the omap restore rotation code in lastclose since the fb helper will
>now take care of this.
>
Ok, I will make this property a part of mode_config and will attach that
to drm_plane, and will post the remaining patches.
-Sonika
&g
On 7/4/2014 8:36 PM, Damien Lespiau wrote:
> On Fri, Jul 04, 2014 at 03:13:52PM +0530, sonika.jindal at intel.com wrote:
>> From: Sonika Jindal
>>
>> Enables 180 degree rotation for sprite and primary planes.
>> Updated the primary plane rotation support as per the ne
On 7/4/2014 8:28 PM, Damien Lespiau wrote:
> On Fri, Jul 04, 2014 at 03:14:02PM +0530, sonika.jindal at intel.com wrote:
>> +static int intel_primary_plane_set_property(struct drm_plane *plane,
>> +struct drm_property *prop,
>> +uint
Hi Thierry,
This patch was sent out by mistake.
I am sorry for the confusion.
I am working on further patchset based on these patches.
Regards,
Sonika
On 5/13/2014 1:16 PM, Thierry Reding wrote:
> On Fri, May 09, 2014 at 01:31:22PM +0530, sonika.jindal at intel.com wrote:
>> From: Vil
47 matches
Mail list logo
